[PATCH] D137838: [Support] Move TargetParsers to new component

zixuan-wu added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:10 +/// \file +/// This header is deprecated in favour of `llvm/Support/RISCVISAInfo.h`. +/// I think there is a typo that should be 'in favour of `llvm/TargetParser/RISCVISAIn

[clang] 9816c19 - [X86] Rename CMPCCXADD intrinsics.

Author: Freddy Ye Date: 2022-12-28T16:45:50+08:00 New Revision: 9816c1912d56668736a2bd95ce18b7fb41653b92 URL: https://github.com/llvm/llvm-project/commit/9816c1912d56668736a2bd95ce18b7fb41653b92 DIFF: https://github.com/llvm/llvm-project/commit/9816c1912d56668736a2bd95ce18b7fb41653b92.diff LOG

[PATCH] D140281: [X86] Rename CMPCCXADD intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9816c1912d56: [X86] Rename CMPCCXADD intrinsics. (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140281/new/ https://reviews.llvm.org/

[PATCH] D137838: [Support] Move TargetParsers to new component

pcwang-thead added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:10 +/// \file +/// This header is deprecated in favour of `llvm/Support/RISCVISAInfo.h`. +/// zixuan-wu wrote: > I think there is a typo that should be 'in favour of > `llvm

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

cpsauer added a comment. @nridge, yep, confirming: For Android, --target is being added explicitly as part of the command and we'll need to pass through explicit (but not implicit) --target flags to the system includes extractor to get the correct paths. CHANGES SINCE LAST ACTION https://rev

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein created this revision. nextsilicon-itay-bookstein added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: All. nextsilicon-itay-bookstein requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald ad

[PATCH] D140723: [clang][Interp] Only check constructors for global variables

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up to https://reviews.llvm.org/D13

[PATCH] D140724: [clang][Interp] Add back Run() call

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to run the functions we compiled immediat

[clang] 48655f7 - [clang][Interp][NFC] Fix typo in comment

Author: Timm Bäder Date: 2022-12-28T12:08:29+01:00 New Revision: 48655f72f9c09a6164109bff3197e07a3f3d8a52 URL: https://github.com/llvm/llvm-project/commit/48655f72f9c09a6164109bff3197e07a3f3d8a52 DIFF: https://github.com/llvm/llvm-project/commit/48655f72f9c09a6164109bff3197e07a3f3d8a52.diff LO

[PATCH] D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:35 struct DataflowAnalysisOptions { - /// Options for the built-in transfer

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1484 +LookupRequest ContainerLookup; +llvm::DenseMap RefIndexForContainer; Results.HasMore |= Index->refs(Req, [&](const Ref &R) { nridge wrote: > We can have multiple r

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders updated this revision to Diff 485482. tom-anders marked 8 inline comments as done. tom-anders added a comment. Rebase, fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137894/new/ https://reviews.llvm.org/D137894 Files:

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138028/new/ https://reviews.llvm.org/D138028 __

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders updated this revision to Diff 485483. tom-anders added a comment. s/llvm::Optional/std::optional/ for containerName field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137894/new/ https://reviews.llvm.org/D137894 Files: clang-tools-ex

[clang-tools-extra] 46575f6 - [clangd] Fix action `RemoveUsingNamespace` for inline namespace

Author: v1nh1shungry Date: 2022-12-28T13:34:43+01:00 New Revision: 46575f60380b18bf20c5f4cafc5fd06f561c4e7b URL: https://github.com/llvm/llvm-project/commit/46575f60380b18bf20c5f4cafc5fd06f561c4e7b DIFF: https://github.com/llvm/llvm-project/commit/46575f60380b18bf20c5f4cafc5fd06f561c4e7b.diff

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG46575f60380b: [clangd] Fix action `RemoveUsingNamespace` for inline namespace (authored by v1nh1shungry, committed by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485485. merrymeerkat added a comment. Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/ https://reviews.llvm.org/D140696 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +ASSERT

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:1551-1552 +const Value *FooVal = Env.getValue(*FooLoc); +// TODO: Initialise values inside unions, then change below to +// ASSERT_TRUE. +ASSERT

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added a comment. > Since (afaik) lambdas don't have these constructors, the input to > builtinTransferInitializer shouldn't come from a lambda. I thought they might because they need to store captured variables. But, godbolt doesn't show any custom constructors so seems they don't. I h

[PATCH] D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`.

ymandel updated this revision to Diff 485488. ymandel added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140703/new/ https://reviews.llvm.org/D140703 Files: clang/include/clang/Analysis/FlowSensitive/DataflowA

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining created this revision. SixWeining added reviewers: MaskRay, xen0n, xry111. Herald added subscribers: Enna1, StephenFan, hiraditya, dberris. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers:

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

dblaikie added a comment. In D139986#4017650 , @Mordante wrote: > In D139986#4017467 , @dblaikie > wrote: > >> In D139986#4008169 , @Mordante >> wrote: >> >>> In D139986

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

mceier added a comment. Checked the changes I'm suggesting and they fix the standalone build. Comment at: clang/lib/Basic/Targets/AArch64.cpp:650 + .Case(NAME, FMV_PRIORITY) +#include "../../../../llvm/include/llvm/TargetParser/AArch64TargetParser.def" + ; ---

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

ye-luo added a comment. Got tons of runtime failure target doesn't support jit UNREACHABLE executed at /gpfs/jlse-fs0/users/yeluo/opt/llvm-clang/llvm-project-nightly/openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h:543! on AMD GPU gfx908 when running miniqmc ctes

[PATCH] D140730: 59559 Explain code coverage with Lit in docs/SourceBasedCodeCoverage.rst

FlashSheridan created this revision. Herald added a project: All. FlashSheridan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation for code coverage in docs/SourceBasedCodeCoverage.rst omits a couple of crucial steps when us

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

ccotter added a comment. @Febbe - Really glad to see this phab up! Not having realized this phab was in progress, I implemented this a few months back (though, originally not as a clang-tidy tool and never published) and thought it'd be worth sharing notes. I recently turned my non-clang-tidy i

[clang] 2184fcf - [AArch64] Fix AArch64TargetParser.def includes for standalone builds.

Author: Pavel Iliin Date: 2022-12-28T17:38:35Z New Revision: 2184fcf17ee00a939b3bde98a28ef586c67d6b1a URL: https://github.com/llvm/llvm-project/commit/2184fcf17ee00a939b3bde98a28ef586c67d6b1a DIFF: https://github.com/llvm/llvm-project/commit/2184fcf17ee00a939b3bde98a28ef586c67d6b1a.diff LOG: [

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4018490 , @mceier wrote: > Checked the changes I'm suggesting and they fix the standalone build. Thanks! Fix committed 2184fcf17ee00a939b3bde98a28ef586c67d6b1a

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

browneee added a comment. In D140690#4018043 , @SixWeining wrote: > We notice that DFSan is a work in progress > , > currently under development for x86_64 Linux. So maybe we can defer

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added a comment. another thought: please verify that `createStorageLoction` and `createValue` can correctly handle union types. Otherwise, you'll likely end up with other (surprising) crashes in the system. E.g. https://github.com/llvm/llvm-project/blob/781eabeb40b8e47e3a46b0b927784e63f

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Most targets reject `-p` now. It's unnecessary to have another z/OS specific diagnostic. So this patch can be abandoned. % fclang -p a.cc clang-16: error: unsupported option '-

[PATCH] D113638: [xray] Add support for hexagon architecture

MaskRay added a comment. Herald added a subscriber: Enna1. Herald added a project: All. `recordSled(CurSled, MI, Kind, 0);` is not intended. All new ports should use version 2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://revi

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

ego added a comment. See my comment below where I can trigger an MC-layer assertion when using "vaeskf1 v0, ...". Comment at: llvm/test/MC/RISCV/rvv/rv64zvkns.s:1-9 +# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+zve32x --mattr=+experimental-zvkns %s \ +# RUN:

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:97 bool HasRV32 = false; + bool HasStdExtZvkb = false; + bool HasStdExtZvkg = false; This needs to be rebased, it's all autogenerated by tablegen now. Repository: rG L

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Comment at: llvm/test/MC/RISCV/rvv/rv64zvkns.s:59 + +vaeskf1.vi v10, v9, 1 +# CHECK-INST: vaeskf1.vi v10, v9, 1 ego wrote: > If I replaces "v10" with "v0", the test fails with an assertion failure. My > own patch uses a slight

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

MaskRay added a comment. In D140690#4018617 , @browneee wrote: > In D140690#4018043 , @SixWeining > wrote: > >> We notice that DFSan is a work in progress >>

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. All good now! The latest revision of this patch doesn't seem to break anything, unless I ran our tests wrong. From my perspective this is OK to reland now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https:

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

browneee created this revision. browneee added a reviewer: MaskRay. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. browneee requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Following suggestio

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

browneee updated this revision to Diff 485547. browneee added a comment. Fix updated line numbers in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743 Files: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743 _

[PATCH] D137838: [Support] Move TargetParsers to new component

vitalybuka added a comment. This bot is broken after the patch https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___

[clang] 14b42f2 - [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

Author: Brad Smith Date: 2022-12-28T17:57:14-05:00 New Revision: 14b42f21a25ccc3c5ce8c1fd2bdf44b018088a42 URL: https://github.com/llvm/llvm-project/commit/14b42f21a25ccc3c5ce8c1fd2bdf44b018088a42 DIFF: https://github.com/llvm/llvm-project/commit/14b42f21a25ccc3c5ce8c1fd2bdf44b018088a42.diff LO

[PATCH] D140657: [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG14b42f21a25c: [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault… (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

myhsu requested changes to this revision. myhsu added a comment. This revision now requires changes to proceed. In D140695#4018127 , @0x59616e wrote: > FYI the pre-merge checks seem to have some issues. Here is the output: > > Command Output (stderr): >

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

browneee updated this revision to Diff 485552. browneee added a comment. Fix other line number. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

arsenm resigned from this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added subscribers: kosarev, MaskRay. Herald added a project: All. This should be abandoned, the flag is gone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D140462: [clangd] Add schema for `.clangd` config

sammccall added a comment. The difficulty in testing is that: - JSON-schema is totally unknown in llvm-project, so there are no tools but also no expectation that contributors understand it - llvm-project doesn't like dependencies, particularly those that aren't in C++ or python - having done s

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. In D136554#4018870 , @rupprecht wrote: > All good now! The latest revision of this patch doesn't seem to break > anything, unless I ran our tests wrong. From my perspective this is OK to > reland now. ... and yep, I was holdi

[PATCH] D140692: [RISCV] Add Svpbmt extension support.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140692/new/ https://reviews.llvm.org/D140692 ___

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining planned changes to this revision. SixWeining added a comment. D140725 is abandoned. Let me defer this change until we support 64bit PC-relative relocation for `SymA - SymB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a comment. In D140462#4018983 , @sammccall wrote: > I tried 3 consumers (`ajv-cli`, `yaml-language-server`, and `yajsv`) and > **hit different blocking bugs in all of them** when using obvious, > spec-compliant approaches to writing schemas

[PATCH] D140462: [clangd] Add schema for `.clangd` config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/schema/config.json:20 + "properties": { +"If": { + "description": "Conditions in the If block restrict when a fragment applies.", nridge wrote: > sammccall wrote: > > disabling `addi

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. I'm not sure what to make of the new failure when I try it out this time. Given a source like this: #include struct Options { std::function identity = [](bool x) -> bool { return x; }; }; struct Wrapper { explicit Wrapper(const Options& options =

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added a comment. How come the Clang M68k backend defaults to 68000? GCC defaults to 68020 for all targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485582. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 Files: clang/lib/Basic/Targets/M68k.cpp clang/test/Preprocessor/predefined-arch-macros.c Index: clang/test/Pr

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

This revision was automatically updated to reflect the committed changes. Closed by commit rG1972fb23cb36: [Clang][RISCV] Use poison instead of undef (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140687/new/ https://reviews.llvm

[clang] bd9c0f0 - [RISCV] Add Svpbmt extension support.

Author: Yeting Kuo Date: 2022-12-28T23:57:54-08:00 New Revision: bd9c0f082b20d96ced1e5f5ddc1506afffc0f8d3 URL: https://github.com/llvm/llvm-project/commit/bd9c0f082b20d96ced1e5f5ddc1506afffc0f8d3 DIFF: https://github.com/llvm/llvm-project/commit/bd9c0f082b20d96ced1e5f5ddc1506afffc0f8d3.diff LO

[PATCH] D140692: [RISCV] Add Svpbmt extension support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd9c0f082b20: [RISCV] Add Svpbmt extension support. (authored by fakepaper56). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht