[clang] 125ccd3 - [ASTMatchers] Add isInAnonymousNamespace narrowing matcher

Author: Carlos Galvez Date: 2022-12-23T07:39:03Z New Revision: 125ccd3751472a0c709498f83671577ffed394a6 URL: https://github.com/llvm/llvm-project/commit/125ccd3751472a0c709498f83671577ffed394a6 DIFF: https://github.com/llvm/llvm-project/commit/125ccd3751472a0c709498f83671577ffed394a6.diff LOG:

[PATCH] D140328: [ASTMatchers] Add isInAnonymousNamespace narrowing matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG125ccd375147: [ASTMatchers] Add isInAnonymousNamespace narrowing matcher (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140328/ne

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

hokein added a comment. In D140587#4014437 , @shafik wrote: > Thank you for the fix, can you explain the failure case in more detail and > why checking that `RD` is defined is the correct fix. The `RD->isAggregate()` needs to access the member of `data(

[clang-tools-extra] e82dd5b - [clang-tidy][NFC] Remove custom isInAnonymousNamespace matchers

Author: Carlos Galvez Date: 2022-12-23T08:54:48Z New Revision: e82dd5b37c7d6ccd67c5118fe7400c6006e67d73 URL: https://github.com/llvm/llvm-project/commit/e82dd5b37c7d6ccd67c5118fe7400c6006e67d73 DIFF: https://github.com/llvm/llvm-project/commit/e82dd5b37c7d6ccd67c5118fe7400c6006e67d73.diff LOG:

[PATCH] D139211: [clang-format] Properly handle the C11 _Generic keyword.

rymiel updated this revision to Diff 485062. rymiel marked an inline comment as done. rymiel retitled this revision from "[WIP][clang-format] Properly handle the C11 _Generic keyword." to "[clang-format] Properly handle the C11 _Generic keyword.". rymiel added a comment. This revision is now acce

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

sameerds added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-features.cl:7 +// RUN: %clang_cc1 -triple amdgcn -S -emit-llvm -o - %s | FileCheck --check-prefix=NOCPU %s +// RUN: %clang_cc1 -triple amdgcn -target-feature +wavefrontsize32 -S -emit-llvm -o - %s | Fil

[PATCH] D140614: [C++20] Check the dependency of declaration contexts before pumping diagnostics

lime created this revision. lime added reviewers: cor3ntin, shafik, erichkeane, aaron.ballman, ychen, clang-language-wg. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. Unevaluated lambdas can cause the inst

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 485067. cor3ntin added a comment. I hope we will get there... It further reduces to consteval void immediate(){}; struct h { int g = 0; int blah = (immediate(), g); }; struct k { h j{}; }_; The issue was that nested expressions are

[PATCH] D140462: [clangd] Add schema for `.clangd` config

sammccall added a comment. I think there's a clear benefit, but my feeling is it's outweighed by the costs, which are fairly high given lack of any automation/tests. If clangd contributors should maintain this, how should contributors/reviewers know whether changes are correct? If they needn't m

[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a comment. In D140462#4014944 , @sammccall wrote: > given lack of any automation/tests That's a fair point, it would definitely help validate the correctness of the schema if we had tests in the form of example config files that pass or fai

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito updated this revision to Diff 485072. ManuelJBrito added a comment. Fix demangle test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140538/new/ https://reviews.llvm.org/D140538 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

ilya-biryukov added subscribers: ayzhao, ilya-biryukov. ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6177 // constructors. For example, conversion function. if (const auto *RD = dyn_cast(DestType->getAs()->getDecl());

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM to unbreak clangd, this seems to pop up a lot for Chrome developers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140587/new/

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

abidmalikwaterloo added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105584/new/ https://reviews.llvm.org/D105584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D140617: [clangd] Fix a clangd crash when indexing the standard library.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Setup a current workin

[clang] e0fa7c7 - Remove empty header file.

Author: Dani Ferreira Franco Moura Date: 2022-12-23T11:34:50Z New Revision: e0fa7c730d01fafd877863a145462cf1e0d5fd5b URL: https://github.com/llvm/llvm-project/commit/e0fa7c730d01fafd877863a145462cf1e0d5fd5b DIFF: https://github.com/llvm/llvm-project/commit/e0fa7c730d01fafd877863a145462cf1e0d5fd

[PATCH] D140483: Remove empty header file.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0fa7c730d01: Remove empty header file. (authored by merrymeerkat). Changed prior to commit: https://reviews.llvm.org/D140483?vs=484578&id=485075#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

hokein updated this revision to Diff 485076. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140587/new/ https://reviews.llvm.org/D140587 Files: clang/lib/Sema/SemaI

[clang] 32d7aae - [clang] Fix a clang crash on invalid code in C++20 mode.

Author: Haojian Wu Date: 2022-12-23T12:40:39+01:00 New Revision: 32d7aae04fdb58e65a952f281ff2f2c3f396d98f URL: https://github.com/llvm/llvm-project/commit/32d7aae04fdb58e65a952f281ff2f2c3f396d98f DIFF: https://github.com/llvm/llvm-project/commit/32d7aae04fdb58e65a952f281ff2f2c3f396d98f.diff LO

[PATCH] D140587: [clang] Fix a clang crash on invalid code in C++20 mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32d7aae04fdb: [clang] Fix a clang crash on invalid code in C++20 mode. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D140614: [C++20] Check the dependency of declaration contexts before pumping diagnostics

lime added a comment. I submitted it a little early. The correct fix may be letting the declaration be dependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140614/new/ https://reviews.llvm.org/D140614 _

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

KKoovalsky created this revision. Herald added subscribers: kadircet, arphaman, mgrang. Herald added a project: All. KKoovalsky requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. This is mainly insipred by ExtractVari

[PATCH] D140620: [clang] Migrate away from a deprecated Clang CFG factory function

gribozavr created this revision. gribozavr added a reviewer: merrymeerkat. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. gribozavr requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscribe

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

hokein added a comment. FYI, this patch triggers a crash in chromium, see https://github.com/llvm/llvm-project/issues/59675 for details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 __

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/amdgpu-features.cl:7 +// RUN: %clang_cc1 -triple amdgcn -S -emit-llvm -o - %s | FileCheck --check-prefix=NOCPU %s +// RUN: %clang_cc1 -triple amdgcn -target-feature +wavefrontsize32 -S -emit-llvm -o - %s | FileC

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm planned changes to this revision. arsenm added a comment. This doesn't work correctly for unspecified wavesize for non-wave32 targets CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 ___ cfe-comm

[clang-tools-extra] 3a39b0a - [clang] Migrate away from a deprecated Clang CFG factory function

Author: Dmitri Gribenko Date: 2022-12-23T14:36:52+01:00 New Revision: 3a39b0ac1a72a2fb554e2ccc286003da5166faeb URL: https://github.com/llvm/llvm-project/commit/3a39b0ac1a72a2fb554e2ccc286003da5166faeb DIFF: https://github.com/llvm/llvm-project/commit/3a39b0ac1a72a2fb554e2ccc286003da5166faeb.dif

[PATCH] D140620: [clang] Migrate away from a deprecated Clang CFG factory function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a39b0ac1a72: [clang] Migrate away from a deprecated Clang CFG factory function (authored by gribozavr). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D140625: [clang] Remove deprecated ControlFlowContext::build()

gribozavr created this revision. gribozavr added a reviewer: merrymeerkat. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// cla

[PATCH] D140626: [clang][nullability] Remove old overload for getNullability()

merrymeerkat created this revision. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140626 Files: clang/include/clang/AST/Type.h

[clang] d273863 - [clang] Remove deprecated ControlFlowContext::build()

Author: Dmitri Gribenko Date: 2022-12-23T15:06:59+01:00 New Revision: d27386384a2a414bcd7c7a18491db32f4ca86881 URL: https://github.com/llvm/llvm-project/commit/d27386384a2a414bcd7c7a18491db32f4ca86881 DIFF: https://github.com/llvm/llvm-project/commit/d27386384a2a414bcd7c7a18491db32f4ca86881.dif

[PATCH] D140625: [clang] Remove deprecated ControlFlowContext::build()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd27386384a2a: [clang] Remove deprecated ControlFlowContext::build() (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 0026874 - fix warn-xparser test

Author: Mikhail Goncharov Date: 2022-12-23T15:34:06+01:00 New Revision: 0026874c8bd0616b520779b9fcfdb05e53ea4dca URL: https://github.com/llvm/llvm-project/commit/0026874c8bd0616b520779b9fcfdb05e53ea4dca DIFF: https://github.com/llvm/llvm-project/commit/0026874c8bd0616b520779b9fcfdb05e53ea4dca.d

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm updated this revision to Diff 485110. arsenm added a comment. Fix unknown target handling, diagnose some more of the errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

pscoro created this revision. Herald added a project: All. pscoro requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140628 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D140626: [clang][nullability] Remove old overload for getNullability()

This revision was automatically updated to reflect the committed changes. Closed by commit rGfbee2dd9a4ba: [clang][nullability] Remove old overload for getNullability() (authored by merrymeerkat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140626/

[clang] fbee2dd - [clang][nullability] Remove old overload for getNullability()

Author: Dani Ferreira Franco Moura Date: 2022-12-23T16:50:58Z New Revision: fbee2dd9a4ba226590d16546728e436ad9e5ed6c URL: https://github.com/llvm/llvm-project/commit/fbee2dd9a4ba226590d16546728e436ad9e5ed6c DIFF: https://github.com/llvm/llvm-project/commit/fbee2dd9a4ba226590d16546728e436ad9e5ed

[PATCH] D131963: [libc++] Add custom clang-tidy checks

Mordante added inline comments. Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:15 // TODO: run clang-tidy with modules enabled once they are supported +// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=%{test-tools}/clang_tidy_check

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5)

nlopes added a comment. In D134410#3983684 , @nikic wrote: > The other problem I see here is that we still need to do something about the > memcpy -> load/store fold. As soon as we have poison from uninit values > (either directly or via `!uninit_is_poi

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140544/new/ https://reviews.llvm.org/D140544 _

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm created this revision. arsenm added a reviewer: fhahn. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. I realized the handling of copysign made no sense at all. Only the type of the first operand should really matter, and it shou

[PATCH] D78441: Delete NaCl support

MaskRay added a comment. Herald added subscribers: llvm-commits, StephenFan, pengfei. Herald added projects: LLVM, All. @dschuff Is NaCL dead in 2022 ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78441/new/ https://reviews.llvm.org/D78

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485180. owenpan added a comment. This revision is now accepted and ready to land. - Adds support for C#, Java, and JavaScript using `_`. - Adds support for only formatting affected ranges. - Simplifies ``IntegerLiteralSeparatorFixer::format()``. - Adds more as

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will add more unit tests and perhaps move them to their own file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits ma

[clang] 073cc29 - [X86][Reduce] Preserve fast math flags when change it. NFCI

Author: Phoebe Wang Date: 2022-12-24T11:41:17+08:00 New Revision: 073cc29e04b756cb4997bf3538c733c0938cd4ae URL: https://github.com/llvm/llvm-project/commit/073cc29e04b756cb4997bf3538c733c0938cd4ae DIFF: https://github.com/llvm/llvm-project/commit/073cc29e04b756cb4997bf3538c733c0938cd4ae.diff L

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG073cc29e04b7: [X86][Reduce] Preserve fast math flags when change i