[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. In D137517#4012307 , @craig.topper wrote: > In D137517#4012298 , @pcwang-thead > wrote: > >> In D137517#4009175 , @fpetrogalli >> wrote: >

[PATCH] D140462: [clangd] Add schema for `.clangd` config

nridge added a subscriber: sammccall. nridge added a comment. Thanks, this is pretty neat! cc @sammccall as a heads up, just to make sure you're cool with having this in-tree Comment at: clang-tools-extra/clangd/schema/config.json:48 + "description": "Directory to se

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe created this revision. Herald added a subscriber: pengfei. Herald added a project: All. FreddyYe requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140531 Files: clan

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 484758. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td clang/inclu

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484759. FreddyYe added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/ReleaseNotes.rst clang/lib/Headers/avx512vl

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlbwintrin.h:2806-2814 +/* Vector-reduction arithmetic accepts vectors as inputs and produces scalars as + * outputs. This class of vector operation forms the basis of many scientific + * computations. In vector-

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:1 +// RUN: %clang_cc1 -ffreestanding %s -O0 -triple=x86_64-apple-darwin -target-feature +avx512bw -target-feature +avx512vl -emit-llvm -o - -Wall -Werror | FileCheck %s + ---

[PATCH] D140532: .clang-tidy: disable misc-use-anonymous-namespace check.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a reviewer: njames93. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: llvm-commits, aheejin. Herald added a project: LLVM. The check gives warnings on static functions, t

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceIntrin.c:1 +// RUN: %clang_cc1 -ffreestanding %s -O0 -triple=x86_64-apple-darwin -target-feature +avx512bw -target-feature +avx512vl -emit-llvm -o - -Wall -Werror | FileCheck %s + ---

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484764. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe added inline comments. Comment at: clang/test/CodeGen/X86/avx512vlbw-reduceMinMaxIntrin.c:1 +// RUN: %clang_cc1 -ffreestanding %s -O0 -triple=x86_64-apple-darwin -target-feature +avx512bw -target-feature +avx512vl -emit-llvm -o - -Wall -Werror | FileCheck %s +

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Please wait some days for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 _

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke updated this revision to Diff 484765. Sockke added a comment. Improved the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/te

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

owenpan added a comment. In D139801#3991108 , @MyDeveloperDay wrote: > I also appreciate the concessions made by others to allow clang-format to > alter code as this has opened the doors in my view to 1 or 2 other great code > modification changes. +1

[clang] 4cafc37 - [clang-format] Add 'friend' to QualifierOrder

Author: Micah Weston Date: 2022-12-22T02:02:09-08:00 New Revision: 4cafc3727b35151e8f676adab11524bb21140939 URL: https://github.com/llvm/llvm-project/commit/4cafc3727b35151e8f676adab11524bb21140939 DIFF: https://github.com/llvm/llvm-project/commit/4cafc3727b35151e8f676adab11524bb21140939.diff

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cafc3727b35: [clang-format] Add 'friend' to QualifierOrder (authored by red1bluelost, committed by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:918 return false; + if (!Ptr.isRoot()) +Ptr.initialize(); shafik wrote: > tbaeder wrote: > > shafik wrote: > > > Can you explain what is going on here? Why do we need to initialize

[clang] 0dc4dfa - [clang-format] Add InsertBraces to operator== in Format.h

Author: Owen Pan Date: 2022-12-22T02:28:25-08:00 New Revision: 0dc4dfabd748ba3bc4d968a88104c686c388f177 URL: https://github.com/llvm/llvm-project/commit/0dc4dfabd748ba3bc4d968a88104c686c388f177 DIFF: https://github.com/llvm/llvm-project/commit/0dc4dfabd748ba3bc4d968a88104c686c388f177.diff LOG:

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

skan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:806 - Lift _BitInt() supported max width from 128 to 8388608. +- Support *_reduce_*_ep[i|u]8/16 series intrinsics. This is not clear to me, try sth like "mm*_reduce_(add|and|max)_epi" and put

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito created this revision. ManuelJBrito added a reviewer: nlopes. ManuelJBrito added a project: clang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a project: libc++abi. Herald added a revie

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

nlopes accepted this revision. nlopes added a comment. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140538/new/ https://reviews.llvm.org/D140538 ___ cfe-commits mailing list cfe-commits

[PATCH] D140531: [X86] Add reduce_*_ep[i|u]8/16 series intrinsics.

FreddyYe updated this revision to Diff 484784. FreddyYe marked 3 inline comments as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140531/new/ https://reviews.llvm.org/D140531 Files: clang/docs/Re

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closes https://g

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan planned changes to this revision. owenpan added a comment. Will add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits mailing

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl. shchenz added a project: LLVM. Herald added a project: All. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D140423: [WIP][clang] Add PrintingPolicy callback for identifying default template arguments

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 added a comment. Michael137 updated this revision to Diff 484341. Michael137 added a reviewer: labath. Michael137 edited the summary of this revision. Michael137 added a reviewer

[clang] aeb8f91 - [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

Author: gonglingqin Date: 2022-12-22T18:56:34+08:00 New Revision: aeb8f911b1695778aa518db4bed471e8447dc57f URL: https://github.com/llvm/llvm-project/commit/aeb8f911b1695778aa518db4bed471e8447dc57f DIFF: https://github.com/llvm/llvm-project/commit/aeb8f911b1695778aa518db4bed471e8447dc57f.diff L

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeb8f911b169: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] e726703 - [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

Author: gonglingqin Date: 2022-12-22T19:21:22+08:00 New Revision: e726703c27c417ffb5917eca4760ea3c4f4a62d5 URL: https://github.com/llvm/llvm-project/commit/e726703c27c417ffb5917eca4760ea3c4f4a62d5 DIFF: https://github.com/llvm/llvm-project/commit/e726703c27c417ffb5917eca4760ea3c4f4a62d5.diff L

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

This revision was automatically updated to reflect the committed changes. Closed by commit rGe726703c27c4: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w (authored by gonglingqin). Changed prior to commit: https://reviews.llvm.org/D139987?vs=484466&id=484792#toc Reposit

[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

arsenm closed this revision. arsenm added a comment. 4086ea331cad827d74542e52a86b7d7933376e7b CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138392/new/ https://reviews.llvm.org/D138392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484795. fpetrogalli added a comment. I added some fixes to make it work when building with modules (`-DLLVM_ENABLE_MODULES=On`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.ll

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. In D137517#4012449 , @pcwang-thead wrote: > In D137517#4012307 , @craig.topper > wrote: > >> In D137517#4012298 , @pcwang-thead >> wrote: >

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. > @pcwang-thead, may I ask you to own these further optimisations of the > generative process, and submit a patch for it after the current patch lands? > I'd happily review it! > > The reason I am asking this is because the current patch is mostly dealing > with ma

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4012283 , @hctim wrote: > I'm not sure "MSan didn't handle correctly SmallVector" is the case. Given > your diagnosis of 3-elements-vs-2, I'm guessing the root cause is that > `clang/lib/Sema/SemaDecl.cpp:11369` is wro

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140547 Files: clang/lib/Sema/SemaTemplateInstantiate

[PATCH] D140532: .clang-tidy: disable misc-use-anonymous-namespace check.

sammccall added a comment. Yeah, good call. Do you mind if I first use this as a trigger to start a thread about this style rule on discourse, though? I've been meaning to, it came up in a review recently. I think there's a fair chance of changing the policy from "require static" to "allow eit

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 484801. owenpan added a comment. Fixes a couple of bugs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Fo

[PATCH] D138394: HIP: Directly call fma builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138394/new/ https://reviews.llvm.org/D138394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 484802. cor3ntin added a comment. Thanks @rupprecht As all good bugs, this was very confusing up until the moment it became obvious. I did not make the initializer a full expression during parsing, (but on use), as I thought that was unecessary. But then i

[PATCH] D139784: [Doc] Refactor descriptions of `min-legal-vector-width`

pengfei updated this revision to Diff 484805. pengfei added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move doc to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139784/new/ https://reviews.llvm.org/D

[PATCH] D139701: [Clang] Emit "min-legal-vector-width" attribute for X86 only

pengfei added inline comments. Comment at: llvm/docs/LangRef.rst:2235-2241 -``"min-legal-vector-width"=""`` -This attribute indicates the minimum legal vector width required by the -calling convension. It is the maximum width of vector arguments and -returnings in the

[PATCH] D139784: [Doc] Refactor descriptions of `min-legal-vector-width`

pengfei added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:502-504 + // This attribute is intended for X86 backend use only. The "min legal" in the + // name means the minimum width in bits that vector types have must be treated + // as legal types by c

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

MyDeveloperDay added a comment. does it have any unit tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] 9e03115 - clang/HIP: Fix missing test for __frsqrt_rn

Author: Matt Arsenault Date: 2022-12-22T08:43:15-05:00 New Revision: 9e0311561c8ed4df2d67a5a1fba16a148683c3c9 URL: https://github.com/llvm/llvm-project/commit/9e0311561c8ed4df2d67a5a1fba16a148683c3c9 DIFF: https://github.com/llvm/llvm-project/commit/9e0311561c8ed4df2d67a5a1fba16a148683c3c9.diff

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code Also add Octal? ==

[PATCH] D140462: [clangd] Add schema for `.clangd` config

sammccall added a comment. In D140462#4012451 , @nridge wrote: > Thanks, this is pretty neat! > > cc @sammccall as a heads up, just to make sure you're cool with having this > in-tree This has been discussed before, unfortunately while I *thought* it wa

[clang] 0e8d4a6 - [clang][dataflow] Simplify handling of nullopt-optionals.

Author: Yitzhak Mandelbaum Date: 2022-12-22T14:19:49Z New Revision: 0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb URL: https://github.com/llvm/llvm-project/commit/0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb DIFF: https://github.com/llvm/llvm-project/commit/0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb.diff

[PATCH] D140506: [clang][dataflow] Simplify handling of nullopt-optionals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e8d4a6df959: [clang][dataflow] Simplify handling of nullopt-optionals. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D140551: [include-cleaner] Don't count references to operators as uses

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Fixes https://github.com/llvm/llvm-project/issues/59655 Repository: rG LLVM G

[clang] f3700bd - [clang][dataflow] Account for global variables in constructor initializers.

Author: Yitzhak Mandelbaum Date: 2022-12-22T14:20:50Z New Revision: f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59 URL: https://github.com/llvm/llvm-project/commit/f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59 DIFF: https://github.com/llvm/llvm-project/commit/f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59.diff

[PATCH] D140501: [clang][dataflow] Account for global variables in constructor initializers.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3700bdb7f00: [clang][dataflow] Account for global variables in constructor initializers. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] 38404df - [clang][dataflow] Fix bug in handling of `return` statements.

Author: Yitzhak Mandelbaum Date: 2022-12-22T14:42:17Z New Revision: 38404df9d879483784a7024b2b4a366388d6d476 URL: https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476 DIFF: https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476.diff

[PATCH] D140430: [clang][dataflow] Fix bug in handling of `return` statements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38404df9d879: [clang][dataflow] Fix bug in handling of `return` statements. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D140551: [include-cleaner] Don't count references to operators as uses

sammccall added a comment. Yeah, I think this makes sense. I think this sort of thing should ideally be captured in the include-cleaner design doc if there was one. (Doesn't make sense to create one just for this issue, but it seems like a doc that should exist). Comment at:

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ManuelJBrito added a comment. A 2022-12-22 10:51, Nuno Lopes via Phabricator escreveu: > nlopes accepted this revision. > nlopes added a comment. > > LGTM, thank you! > > Repository: > > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > > https://reviews.llvm.org/D140538/new/ > > https:

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

lime created this revision. lime added reviewers: cor3ntin, shafik, erichkeane, aaron.ballman, clang-language-wg. lime added a project: clang. Herald added a project: All. lime requested review of this revision. Herald added a subscriber: cfe-commits. During template instantiation, the instantiat

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 484826. pengfei added a comment. Add test case to check FastMathFlagGuard works. > Tests don't exist for users, they exist for compiler developers... > I agree with @arsenm. At least for clang irgen, we should have good test > coverage. You are right. Added

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added a comment. In D140467#4013107 , @pengfei wrote: > Add test case to check FastMathFlagGuard works. > > Not to mention above cases. So it doesn't sound feasible to me. Testing is always feasible. You could even just generate all the combinatio

[PATCH] D123032: [clang][dataflow] Exclude protobuf types from modeling in the environment.

ymandel updated this revision to Diff 484830. ymandel added a comment. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Reviving this patch, addressing some of the earlier concerns. However, I may have a better solution which makes this patch irrelevant. So, still WIP. Reposito

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei updated this revision to Diff 484838. pengfei marked 2 inline comments as done. pengfei added a comment. Address review comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140467/new/ https://reviews.llvm.org/D140467 Files: c

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

pengfei added inline comments. Comment at: clang/test/CodeGen/builtins-x86-reduce.c:8 +} + +// CHECK: fadd arsenm wrote: > Should test the builtins from both sets Do you mean this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

aykevl added a comment. I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is inherently specific to that particular chip anyway so compatibility is not an issue. In fact, having two flags may even introd

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 484841. owenpan added a comment. Fixed another bug and added some unit tests. Also updated ReleaseNotes.rst and addressed some review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files: cla

[PATCH] D140547: Perform access checking to private members in simple requirement.

shafik added a comment. Thank you for the fix, can you elaborate on the motivation for this change, it looks like setting `setNamingClass` allows for improved diagnostics but I would like it explained better in the PR description. Comment at: clang/lib/Sema/SemaTemplateInstan

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan marked an inline comment as done. owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code H

[PATCH] D140544: [DebugInfo] make DW_LANG_C11 respect -gstrict-dwarf

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:582 } else if (LO.C11) { -LangTag = llvm::dwarf::DW_LANG_C11; +if (CGO.DebugStrictDwarf && CGO.DwarfVersion < 5) + LangTag = llvm::dwarf::DW_LANG_C; Generally, I think,

[PATCH] D140554: [C++20] Determine the dependency of unevaluated lambdas more accurately

shafik added a comment. I am not sure if this is moving in the right direction or not, I will wait for @cor3ntin to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140554/new/ https://reviews.llvm.org/D140554 _

[clang] 63aa57d - Small fixes to creduce-clang-crash.py script.

Author: Amy Huang Date: 2022-12-22T16:33:28Z New Revision: 63aa57dc57e1d47479025f65a89a5a9da974800f URL: https://github.com/llvm/llvm-project/commit/63aa57dc57e1d47479025f65a89a5a9da974800f DIFF: https://github.com/llvm/llvm-project/commit/63aa57dc57e1d47479025f65a89a5a9da974800f.diff LOG: Sma

[PATCH] D140467: [X86][Reduce] Preserve fast math flags when change it. NFCI

arsenm added inline comments. Comment at: clang/test/CodeGen/builtins-x86-reduce.c:8 +} + +// CHECK: fadd pengfei wrote: > arsenm wrote: > > Should test the builtins from both sets > Do you mean this? Almost. You added the guard to 4 switch cases, so I would expe

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

balazske added a comment. This crash is produced if the test is run without the fix: [ RUN ] ParameterizedTests/ASTImporterOptionSpecificTestBase.ImportInjectedClassNameType/0 ASTTests: llvm-project/clang/lib/AST/ASTContext.cpp:4678: clang::QualType clang::ASTContext::getTypedefType(co

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Glad the test case made sense to you, it was convoluted to me :) Still seeing one more error, and it's not modules-related so I might be able to get it reduced today. Generally, it looks like this: struct Inner { Foo& foo; const std::unique_ptr<...> x = blah

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 484882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/AST/Type.h clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions

[PATCH] D140565: [Clang][CMake] Set up distribution target for Clang-BOLT

Amir created this revision. Amir added a reviewer: phosek. Herald added a subscriber: wenlei. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Provide a way to install usable BOLT-optimized Clang (clang + re

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

jansvoboda11 added a comment. Why is it necessary to add new command-line flags for this? Can't the input and output be inherited from the specified Clang command line? Would such command line make sense? Comment at: clang/test/ClangScanDeps/P1689.cppm:9 +// +// Check the sep

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. I agree, it's probably best to temporarily revert this until Joao has time to address the issues you mentioned. The Linux kernel doesn't use `-mibt-seal` yet, so dropping the featu

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

njames93 added a comment. In D138655#4012557 , @Sockke wrote: > Improved the test file. Just a general workflow comment, can you please mark comments as done when they are addressed, or, if you feel the comment in unjustified, explain why. CHANGES SIN

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ben.boeckel added inline comments. Comment at: clang/test/ClangScanDeps/P1689.cppm:9 +// +// Check the seperated dependency format. +// RUN: clang-scan-deps -format=p1689 --p1689-targeted-file-name=%t/M.cppm --p1689-targeted-output=%t/M.o \ jansvoboda11 wrote: >

[clang] c348abc - Revert D138179 "MIPS: fix build from IR files, nan2008 and FpAbi"

Author: Fangrui Song Date: 2022-12-22T11:48:55-08:00 New Revision: c348abce68ac422bf3842de3943ca7463e3a814f URL: https://github.com/llvm/llvm-project/commit/c348abce68ac422bf3842de3943ca7463e3a814f DIFF: https://github.com/llvm/llvm-project/commit/c348abce68ac422bf3842de3943ca7463e3a814f.diff

[PATCH] D137838: [Support] Move TargetParsers to new component

paulkirth added a comment. Hi, we're seeing some build failures after this change. Seems like the TargetParser isn't getting added to LLVMExports correctly. Can you take a look and address these? Failing bot https://ci.chromium.org/ui/p/fuchsia/builders/prod/llvm-linux-x64/b8794232527428765009

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

nickdesaulniers added a comment. Herald added a project: All. The linux kernel uses a build time invocation of the compiler for feature detection of the `-mabi=lp64` command line flag, which clang-16 currently doesn't support. Looking at https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html,

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

This revision was automatically updated to reflect the committed changes. Closed by commit rG69243cdb926b: Remove incorrectly implemented -mibt-seal (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140363/new/ https://reviews.llv

[clang] 69243cd - Remove incorrectly implemented -mibt-seal

Author: Fangrui Song Date: 2022-12-22T12:32:59-08:00 New Revision: 69243cdb926b1057c54522df305ffc195b2863ec URL: https://github.com/llvm/llvm-project/commit/69243cdb926b1057c54522df305ffc195b2863ec DIFF: https://github.com/llvm/llvm-project/commit/69243cdb926b1057c54522df305ffc195b2863ec.diff

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I'll reject [-\Xparser for a while as well. This is a valid amendment to D139717 , so I don't think it needs more approval. Repository: rG LLVM Github

[clang] 46cd312 - [Driver] Revert D139717 and add -Xparser/-Xcompiler instead

Author: Fangrui Song Date: 2022-12-22T12:51:20-08:00 New Revision: 46cd3127fe54ab51f813492017c5acdbeb1baf26 URL: https://github.com/llvm/llvm-project/commit/46cd3127fe54ab51f813492017c5acdbeb1baf26 DIFF: https://github.com/llvm/llvm-project/commit/46cd3127fe54ab51f813492017c5acdbeb1baf26.diff

[PATCH] D140224: [Driver] Revert D139717 and add -Xparser instead

This revision was automatically updated to reflect the committed changes. Closed by commit rG46cd3127fe54: [Driver] Revert D139717 and add -Xparser/-Xcompiler instead (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D140224?vs=483565&id=484938#toc Repository: rG LLVM

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void created this revision. void added reviewers: aaron.ballman, rjmccall, rsmith, dblaikie. Herald added subscribers: arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan updated this revision to Diff 484945. scchan added a comment. Remove unused bitcode files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140315/new/ https://reviews.llvm.org/D140315 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/tes

[PATCH] D140315: [AMDGCN] Update search path for device libraries

scchan added a comment. In D140315#4011440 , @yaxunl wrote: > files under > clang/test/Driver/Inputs/rocm_resource_dir/lib/amdgcn/bitcode-no-abi-ver seem > not used. removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D137838: [Support] Move TargetParsers to new component

paulkirth added a comment. Sorry for the noise, I missed that that bot is setting a CMake flag that affects LLVM_EXPORTS. Please disregard my earlier message. I just need to update the CMake invocation to fix this, so I don't think there is anything required on your end. Repository: rG LLVM

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay updated this revision to Diff 484955. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a reviewer: bollu. Herald added subscribers: yota9, ayermolo, StephenFan. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksf

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

MaskRay added a comment. Created D140585 to update `llvm/docs/CodingStandards.rst`. Changed the summary to mention https://discourse.llvm.org/t/top-level-clang-tidy-options-and-variablename-suggestion-on-codingstandards/58783 Repository: rG LLVM Github Mono

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest, IntegerLiteralSeparator) { + FormatStyle Style = getLLVMStyle(); --

[PATCH] D108265: .clang-tidy: Push variable related readability-identifier-naming options down to projects

Amir accepted this revision. Amir added a comment. This revision is now accepted and ready to land. LGTM for BOLT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108265/new/ https://reviews.llvm.org/D108265 __

[clang] 9b050e5 - [clang] Remove redundant initialization of std::optional (NFC)

Author: Kazu Hirata Date: 2022-12-22T13:46:26-08:00 New Revision: 9b050e5011e92be1b953cc1cc1406cfbcb43fb90 URL: https://github.com/llvm/llvm-project/commit/9b050e5011e92be1b953cc1cc1406cfbcb43fb90 DIFF: https://github.com/llvm/llvm-project/commit/9b050e5011e92be1b953cc1cc1406cfbcb43fb90.diff L

[PATCH] D140363: Remove incorrectly implemented -mibt-seal

joaomoreira added a comment. FWIIW, agreed on removing this until we figure out how to make it work properly. Thanks for the patch @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140363/new/ https://reviews.llvm.org/D140363 __

  1   2   >