[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. In D137517#4009328 , @jrtc27 wrote: > Hm, this means that llvm/lib/Target/$TARGET/$TARGET.td needs to remain > working (or at least mostly working, things like ISel patterns can fail to > type check) in order for Clang to bu

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484664. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Remove all `auto` types in the emitter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:52 + for (auto &Def : Map) { +const auto &Record = Def.second; +if (Record->isSubClassOf("RISCVProcessorModelTUNE_PROC")) barannikov88 wrote: > fpetrogalli wrote

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484665. zahiraam marked an inline comment as done. Herald added a subscriber: aheejin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > zahiraam wrote: > > >

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 484671. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase, drop callbrpad inst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 484672. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/lib/Code

[PATCH] D140501: [clang][dataflow] Account for global variables in constructor initializers.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, the analysis modeled global v

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 484678. nickdesaulniers added a comment. - add clang release notes from D138078 and new one for new feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/

[PATCH] D140501: [clang][dataflow] Account for global variables in constructor initializers.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp:112 + const auto *Var = selectFirst("global", Results); + ASSERT_TRUE(Fun != nul

[PATCH] D140486: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:86 +auto Task = [ +// Captured by value +LO(*CI.getLangOpt

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added a comment. Ready for review: 1. https://reviews.llvm.org/D135997 2. https://reviews.llvm.org/D140166 3. https://reviews.llvm.org/D139861 4. https://reviews.llvm.org/D139872 5. https://reviews.llvm.org/D139883 6. https://reviews.llvm.org/D139970 7. https://reviews.llvm.org/D1

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4010987 , @dblaikie wrote: > This has introduced a circular dependency due to the forwarding header > (forwarding header depends on new lib, new lib depends on support, where the > forwarding header is). Generally this

[clang-tools-extra] b494f67 - [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

Author: Sam McCall Date: 2022-12-21T23:35:48+01:00 New Revision: b494f67f67968c50289148fb423a108607be83e9 URL: https://github.com/llvm/llvm-project/commit/b494f67f67968c50289148fb423a108607be83e9 DIFF: https://github.com/llvm/llvm-project/commit/b494f67f67968c50289148fb423a108607be83e9.diff LO

[PATCH] D140486: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGb494f67f6796: [clangd] Fix crashing race in ClangdServer shutdown with stdlib indexing (authored by sammc

[PATCH] D140506: [clang][dataflow] Simplify handling of nullopt-optionals.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, in the case of an optional co

[clang] 437346a - clang: Add __builtin_elementwise canonicalize and copysign

Author: Matt Arsenault Date: 2022-12-21T18:01:42-05:00 New Revision: 437346abe18ec4fc982ae36f6821487dafc1a06e URL: https://github.com/llvm/llvm-project/commit/437346abe18ec4fc982ae36f6821487dafc1a06e DIFF: https://github.com/llvm/llvm-project/commit/437346abe18ec4fc982ae36f6821487dafc1a06e.diff

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

arsenm closed this revision. arsenm added a comment. 437346abe18ec4fc982ae36f6821487dafc1a06e Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. clang would improperly disallow GNU attributes before C++ standard attributes when

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 484694. paulkirth retitled this revision from "[codegen] Display stack layouts in console" to "[codegen] Add a remarks based Stack Layout Analysis pass". paulkirth edited the summary of this revision. paulkirth added a comment. Herald added subscribers: pcwa

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers created this revision. Herald added a reviewer: NoQ. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that we support outputs from asm goto along indirect edges, we can remove/

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 484699. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - reference 3a604fdbcd5f in commit message as well Repository: rG LLVM Github Mono

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4011437 , @hctim wrote: > 2. Build a sanitizer libcxx. > > $ cd /tmp/2 > $ cmake \ > -DCMAKE_C_COMPILER=/tmp/1/bin/clang \ > -DCMAKE_CXX_COMPILER=/tmp/1/bin/clang++ \ > -GNinja \ > -DLLVM_USE_SANITIZER=Memory

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140433/new/ https://reviews.llvm.org/D140433 ___

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

ChuanqiXu added a comment. @Bigcheese @jansvoboda11 gentle ping~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir updated this revision to Diff 484727. Amir added a comment. Convert perf profile using perf2bolt (aggregate-only mode) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/lib/AST/Interp/Interp.cpp:1 //===--- Interpcpp - Interpreter for the constexpr VM --*- C++ -*-===// // One more time :-) CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D137415: [clang][Interp] Implement switch statements

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:405 + const Expr *Cond = S->getCond(); + PrimType CondT = this->classifyPrim(Cond->getType()); + The condition could be a class type w/ a conversion operator, this does not seem

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. I've managed to reproduce "MemorySanitizer: use-of-uninitialized-value" error locally, thank you @hctim for help! If I understand it right, it seems **MSan didn't handle correctly SmallVector** - a variable-sized array with some number of elements in-place and heap alloc

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

rtrieu added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred() && "Substitution failures must be handled " -

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4012276 , @ilinpv wrote: > I've managed to reproduce "MemorySanitizer: use-of-uninitialized-value" error > locally, thank you @hctim for help! > If I understand it right, it seems **MSan didn't handle correctly > SmallV

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

MaskRay added a comment. In D127812#4011437 , @hctim wrote: > LDFLAGS="$LDFLAGS -Wl,--rpath=/tmp/2/lib" # < use the instrumented libcxx > from step 2 I think -Wl,-rpath and -isystem are somewhat different. sanitizer_ldflags="-Wl,--rpath=$libcxx_o

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. In D137517#4009175 , @fpetrogalli wrote: > @pcwang-thead, I addressed some of your comments. > > The value of `EnumFeatures` is now computed dynamicaly from the > `Features` field of the `Processor` class. Thanks! That soun

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added a comment. In D137517#4012298 , @pcwang-thead wrote: > In D137517#4009175 , @fpetrogalli > wrote: > >> @pcwang-thead, I addressed some of your comments. >> >> The value of `EnumFeatures` is no

[clang] 8c0aa53 - Fix out-of-bound access in TransformNestedRequirement.

Author: Utkarsh Saxena Date: 2022-12-22T05:20:31+01:00 New Revision: 8c0aa53b07caa604d58a0d83dc571d8fcb004972 URL: https://github.com/llvm/llvm-project/commit/8c0aa53b07caa604d58a0d83dc571d8fcb004972 DIFF: https://github.com/llvm/llvm-project/commit/8c0aa53b07caa604d58a0d83dc571d8fcb004972.diff

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred(

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011 __

[clang] 5370255 - [RISCV] Merge Masked and unMasked RVV manual codegen

Author: Piyou Chen Date: 2022-12-21T20:28:12-08:00 New Revision: 5370255ff18ac101a73685b77615148142ee7552 URL: https://github.com/llvm/llvm-project/commit/5370255ff18ac101a73685b77615148142ee7552 DIFF: https://github.com/llvm/llvm-project/commit/5370255ff18ac101a73685b77615148142ee7552.diff LO

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5370255ff18a: [RISCV] Merge Masked and unMasked RVV manual codegen (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +assert(!Trap.hasErrorOccurred() && "Substitution failures must be handled " -

[clang] 3b186db - [clang][C++20] Add test for crash in NestedRequirement.

Author: Utkarsh Saxena Date: 2022-12-22T06:52:44+01:00 New Revision: 3b186db5a97c8392bdbb0446e84353497870551e URL: https://github.com/llvm/llvm-project/commit/3b186db5a97c8392bdbb0446e84353497870551e DIFF: https://github.com/llvm/llvm-project/commit/3b186db5a97c8392bdbb0446e84353497870551e.diff

[PATCH] D140527: [LoongArch] Add intrinsics for CACOP instruction

XiaodongLoong created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. XiaodongLoong requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The CACOP instruction is mainly used for cache initializ

<    1   2