[PATCH] D138300: [clangd] Support type hints for `decltype(expr)`

nridge added a comment. Sorry for being a slow reviewer. I think showing type hints for `decltype(expr)` would be a nice enhancement. @v1nh1shungry, are you interested in working further on this? One high-level thought I had is: what if we attached the type hint to the closing `)` of the declt

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

kito-cheng added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:100 + bool MU = false; + bool MA = false; + bool IntrinsicWithoutMU = false; Maybe use enum value for tail/mask policy? *U and *A are mutually exclusive, so I fee

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 483443. ChuanqiXu added a comment. - when `-fmodule-output` and `-o` are both specified, generate the module file into the directory of the output file and name the module file with the name of the input file with module file's suffixes. (Previously, the n

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 483446. balazske added a comment. Updated test in errno-noopen.c. The functions feof and ferror reset errno, the previous test was incorrect in this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135247/ne

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139507/new/ https://reviews.llvm.org/D139507 ___ c

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

ego added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:827 +{{"zvkb"}, {ImpliedExtsZve64x}}, +{{"zvkg"}, {ImpliedExtsZve32x}}, +{{"zvknha"}, {ImpliedExtsZve32x}}, craig.topper wrote: > ego wrote: > > What is the reasoning between 32

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + dblaikie wrote: > ChuanqiXu

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 483449. ChuanqiXu added a comment. Update since the dependent one changed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp c

[PATCH] D139006: [UpdateTestChecks] Match define for labels

nikic added a comment. In D139006#384 , @jdoerfert wrote: > Why not just `--function-define` as a way to enable the `define` but not the > `captures`, if that is really something necessary. > It is unclear to me why `function-signature` is not suffic

[PATCH] D140191: [CodeComplete] Offer completions for headers with extension .hxx in include directives

nridge created this revision. nridge added reviewers: kadircet, sammccall. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/1379 Repository:

[PATCH] D140191: [CodeComplete] Offer completions for headers with extension .hxx in include directives

nridge added a comment. Precedent for treating `.hxx` as a supported header extension: https://reviews.llvm.org/D81366 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140191/new/ https://reviews.llvm.org/D140191

[clang-tools-extra] b1df3a2 - [Support] llvm::Optional => std::optional

Author: Fangrui Song Date: 2022-12-16T08:49:10Z New Revision: b1df3a2c0b6a42570042934cb79ca0e4359f863b URL: https://github.com/llvm/llvm-project/commit/b1df3a2c0b6a42570042934cb79ca0e4359f863b DIFF: https://github.com/llvm/llvm-project/commit/b1df3a2c0b6a42570042934cb79ca0e4359f863b.diff LOG:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

MoritzS added a comment. In D122215#3998105 , @pmatos wrote: > In D122215#3991648 , @MoritzS wrote: > >> Thanks for the patch! I just tried it out and I think this enables many >> interesting use cases for WebAss

[clang] 31f4859 - [Clang] Allow additional mathematical symbols in identifiers.

Author: Corentin Jabot Date: 2022-12-16T10:20:49+01:00 New Revision: 31f4859c3e4d261d4a45118bb77d453138a6f7a9 URL: https://github.com/llvm/llvm-project/commit/31f4859c3e4d261d4a45118bb77d453138a6f7a9 DIFF: https://github.com/llvm/llvm-project/commit/31f4859c3e4d261d4a45118bb77d453138a6f7a9.diff

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31f4859c3e4d: [Clang] Allow additional mathematical symbols in identifiers. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

hokein updated this revision to Diff 483453. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140095/new/ https://reviews.llvm.org/D140095 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp clang-too

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:70 QualType Type = E->getBase()->IgnoreImpCasts()->getType(); report(E->getMemberLoc(), resolveType(Type)); return true; ---

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#4000363 , @rupprecht wrote: > I applied this version of the patch and the crash is now gone 🎉 > > However, now I get this inexplicable error -- I'm not entirely sure it's > related, maybe I'm holding it wrong: > > I

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:469 // Also grab prefixes for each option, these are not fully exposed. -const char *const *Prefixes[DriverID::LastOption] = {nullptr}; -#define PREFIX(NAME, VALUE) static const char

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

kadircet added a comment. In D134130#3992215 , @tom-anders wrote: > Thanks for the detailed feedback! Unfortunately, I’m sick right now, so I > probably won’t be able to give a detailed answer until after Christmas. Sorry to hear that. I hope you get b

[PATCH] D140194: [clang-tidy] Fix crash in bugprone-suspicious-realloc-usage.

balazske created this revision. Herald added subscribers: carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D139998: [clangd] Remove ReferenceFinder::Reference::Target

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:871 for (const NamedDecl *ND : Targets) { const Decl *CD = ND->getCanonicalDecl(); + TargetD

[PATCH] D140191: [CodeComplete] Offer completions for headers with extension .hxx in include directives

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:10020 // Only files that really look like headers. (Except in special dirs). // Header extension

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat updated this revision to Diff 483460. merrymeerkat added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140104/new/ https://reviews.llvm.org/D140104 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

jmmartinez created this revision. Herald added a project: All. jmmartinez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140195 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

jmmartinez updated this revision to Diff 483468. jmmartinez added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140195/new/ https://reviews.llvm.org/D140195 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenObj

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:70 QualType Type = E->getBase()->IgnoreImpCasts()->getType(); report(E->getMemberLoc(), resolveType(Type)); return true; hokein wrote: > sammccall wrote:

[clang] 8dcb629 - [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

Author: Daniel Grumberg Date: 2022-12-16T11:01:03Z New Revision: 8dcb629aa4ccfdd18fb700cabb45fd74fcd291c8 URL: https://github.com/llvm/llvm-project/commit/8dcb629aa4ccfdd18fb700cabb45fd74fcd291c8 DIFF: https://github.com/llvm/llvm-project/commit/8dcb629aa4ccfdd18fb700cabb45fd74fcd291c8.diff LO

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dcb629aa4cc: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140010/new/ http

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? - // CHECKCXX98: @_ZN11rdar93574

[clang] 0da4cec - [clang][dataflow] Remove unused argument in getNullability

Author: Dani Ferreira Franco Moura Date: 2022-12-16T12:22:23+01:00 New Revision: 0da4cecfb6ad14ee0f0f9fa904e685fd6b64be60 URL: https://github.com/llvm/llvm-project/commit/0da4cecfb6ad14ee0f0f9fa904e685fd6b64be60 DIFF: https://github.com/llvm/llvm-project/commit/0da4cecfb6ad14ee0f0f9fa904e685fd6

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0da4cecfb6ad: [clang][dataflow] Remove unused argument in getNullability (authored by merrymeerkat, committed by gribozavr). Repository: rG LLVM G

[clang] 231992d - [clang] silence unused variable warning

Author: Krasimir Georgiev Date: 2022-12-16T11:22:46Z New Revision: 231992d9b88fe4e0b4aa0f55ed64d7ba88b231ce URL: https://github.com/llvm/llvm-project/commit/231992d9b88fe4e0b4aa0f55ed64d7ba88b231ce DIFF: https://github.com/llvm/llvm-project/commit/231992d9b88fe4e0b4aa0f55ed64d7ba88b231ce.diff

[clang] c4c2352 - [ASTContext] Avoid duplicating address space map. NFCI

Author: Alex Richardson Date: 2022-12-16T11:28:19Z New Revision: c4c23527d6c919bfd781fae0f7a82b9271b6429e URL: https://github.com/llvm/llvm-project/commit/c4c23527d6c919bfd781fae0f7a82b9271b6429e DIFF: https://github.com/llvm/llvm-project/commit/c4c23527d6c919bfd781fae0f7a82b9271b6429e.diff LO

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4c23527d6c9: [ASTContext] Avoid duplicating address space map. NFCI (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 updated this revision to Diff 483476. Michael137 marked an inline comment as done. Michael137 added a comment. - Add comment re. ABI break Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986 Files:

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 updated this revision to Diff 483477. Michael137 added a comment. - Split out LLVM changes into separate commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139989/new/ https://reviews.llvm.org/D139989 Files: clang/lib/CodeGen/CGDebu

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 updated this revision to Diff 483478. Michael137 added a comment. - Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986 Files: clang/lib/AST/TypePrinter.cpp clang/test/CXX/te

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

sammccall added a comment. Mostly comment nits and was ready to approve, but I think I found a bug (getAs) Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:46 + Base = Base->getPointeeType(); +if (const auto *TT = Base->getAs()) + return TT->getDecl()

[clang] 98afcba - [clang][AST][NFC] Expose clang::isSubstitutedDefaultArgument to clang/AST consumers

Author: Michael Buch Date: 2022-12-16T11:38:50Z New Revision: 98afcbab66505661045dccb85ee9acdbf9410047 URL: https://github.com/llvm/llvm-project/commit/98afcbab66505661045dccb85ee9acdbf9410047 DIFF: https://github.com/llvm/llvm-project/commit/98afcbab66505661045dccb85ee9acdbf9410047.diff LOG:

[clang] 1706f34 - [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Author: Michael Buch Date: 2022-12-16T11:38:51Z New Revision: 1706f34d604ec304af58a7b95dbc127bd77e17fa URL: https://github.com/llvm/llvm-project/commit/1706f34d604ec304af58a7b95dbc127bd77e17fa DIFF: https://github.com/llvm/llvm-project/commit/1706f34d604ec304af58a7b95dbc127bd77e17fa.diff LOG:

[clang] 8d3843b - [clang][DebugInfo] Simplify logic to determine DW_AT_default_value for template parameters

Author: Michael Buch Date: 2022-12-16T11:38:52Z New Revision: 8d3843badb8a32a56531e383a2a9eb5b07ae8b0d URL: https://github.com/llvm/llvm-project/commit/8d3843badb8a32a56531e383a2a9eb5b07ae8b0d DIFF: https://github.com/llvm/llvm-project/commit/8d3843badb8a32a56531e383a2a9eb5b07ae8b0d.diff LOG:

[clang] 2c22cfd - [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Author: Michael Buch Date: 2022-12-16T11:38:54Z New Revision: 2c22cfd4c95606adec311dece051e95e86e3f0f3 URL: https://github.com/llvm/llvm-project/commit/2c22cfd4c95606adec311dece051e95e86e3f0f3 DIFF: https://github.com/llvm/llvm-project/commit/2c22cfd4c95606adec311dece051e95e86e3f0f3.diff LOG:

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1706f34d604e: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types (authored by Michael137). Repository: rG LLVM Github Mo

[PATCH] D139988: [clang][DebugInfo] Simplify logic to determine DW_AT_default_value for template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d3843badb8a: [clang][DebugInfo] Simplify logic to determine DW_AT_default_value for template… (authored by Michael137). Repository: rG LLVM Githu

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dff41c320fc: [llvm][DebugInfo] Add IsDefault parameter to DIBuilder… (authored by Michael137). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 added a comment. committed in `98afcbab66505661045dccb85ee9acdbf9410047` Missed phab link in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139985/new/ https://reviews.llvm.org/D139985 _

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. The most recent update is all the fixes needed after the builds @MaskRay asked me for. I think this is ready to land on Monday? @thakis there will be GN fallout from this change. I do not intend to update GN in this patchset, but wanted to give you a heads-up. Reposito

[PATCH] D137838: [Support] Move TargetParsers to new component

fpetrogalli accepted this revision. fpetrogalli added a comment. In D137838#4000959 , @lenary wrote: > [...] I think this is ready to land on Monday? SGTM - thank you again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D139006: [UpdateTestChecks] Match define for labels

sebastian-ne added a comment. > I believe the motivation here is the default behavior Correct, update_test_checks produces a broken test for some input and I think this is a bug that we should fix. Sorry for the test churn and thanks for the revert (I only got to work a few hours after nikic a

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

hokein updated this revision to Diff 483493. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140095/new/ https://reviews.llvm.org/D140095 Files: clang-tools-extra/i

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:70 QualType Type = E->getBase()->IgnoreImpCasts()->getType(); report(E->getMemberLoc(), resolveType(Type)); return true; sammccall wrote: > hokein wrote: >

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. Gently ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139704/new/ https://reviews.llvm.org/D139704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D139006: [UpdateTestChecks] Match define for labels

spatel added a comment. In D139006#4000992 , @sebastian-ne wrote: > Adding `--function-signature` by default sounds like a good idea to me. > Is there any reason why we wouldn’t want to enable this by default (for new > tests)? No objection from me for

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

eandrews added a comment. I came across a strange error when capturing arguments in a lambda inside another lambda. I filed an issue here - https://github.com/llvm/llvm-project/issues/59549 Short reproducer: void foo () { constexpr int i = 2; [&]() { [=]() [[clang::annotate_

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Thanks for the changes and your work here. In D131915#3994160 , @TIFitis wrote: > Added custom printer & parser for ma

[PATCH] D140075: [libclang] Expose using shadow types and declarations in libclang.

emilio updated this revision to Diff 483499. emilio added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140075/new/ https://reviews.llvm.org/D140075 Files: clang/include/clang-c/Index.h clang/lib/Sema/SemaCodeComplete.cpp

[clang] 95c1a17 - [clang-format] add config parse test for short lambda

Author: Backl1ght Date: 2022-12-16T21:36:07+08:00 New Revision: 95c1a17433b972e8345b672f69005204dab0916d URL: https://github.com/llvm/llvm-project/commit/95c1a17433b972e8345b672f69005204dab0916d DIFF: https://github.com/llvm/llvm-project/commit/95c1a17433b972e8345b672f69005204dab0916d.diff LOG

[PATCH] D140105: [clang-format] add missing config parse test for short lambda

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95c1a17433b9: [clang-format] add config parse test for short lambda (authored by Backl1ght). Changed prior to commit: https://reviews.llvm.org/D14

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:45 +if (Base->isPointerType()) + Base = Base->getPointeeType(); +// Unwrap the su

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9072 auto GetNullability = [&Ctx](QualType Ty) { +Optional Kind = Ty->getNullability(); This now gives a warning `clang/lib/Sema/SemaExpr.cpp:9072:27: warning: lambda capture 'Ct

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 updated this revision to Diff 483507. jhuber6 added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140158/new/ https://reviews.llvm.org/D140158 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Cuda.cp

[PATCH] D140211: [clang][dataflow] Remove unused lambda capture

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 added a comment. Missed couple of test cases in libcxx About to fix those Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139986/new/ https://reviews.llvm.org/D139986 ___ cfe-commits mailing lis

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9072 auto GetNullability = [&Ctx](QualType Ty) { +Optional Kind = Ty->getNullability(); barannikov88 wrote: > This now gives a warning > `clang/lib/Sema/SemaExpr.cpp:9072:27: war

[PATCH] D139604: [PATCH] Github Issue: Create a check that warns about using %p printf specifier #43453

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I appreciate that you are interested in tackling this. I do think it's a low-hanging fruit, so it's a good choice! However, there are a couple of things we need to improve before

[PATCH] D139006: [UpdateTestChecks] Match define for labels

arichardson added a comment. I like the idea of defaulting to --function-signature for new tests a lot, so I've implemented that in D140212 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139006/new/ https://review

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev reopened this revision. dzhidzhoev added a comment. This revision is now accepted and ready to land. In D139741#4000201 , @rupprecht wrote: > I'm not sure what the libcxx failure was that caused you to revert this, but > we also saw a clang cr

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 483519. dzhidzhoev added a comment. Ignore union fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h clang/lib/AST/De

[PATCH] D140211: [clang][dataflow] Remove unused lambda capture

krasimir added a comment. I'll submit this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140211/new/ https://reviews.llvm.org/D140211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] f86cdb4 - [clang][dataflow] Remove unused lambda capture

Author: Dani Ferreira Franco Moura Date: 2022-12-16T15:39:31+01:00 New Revision: f86cdb4853618603b8889dfeb932fd4ef8efd010 URL: https://github.com/llvm/llvm-project/commit/f86cdb4853618603b8889dfeb932fd4ef8efd010 DIFF: https://github.com/llvm/llvm-project/commit/f86cdb4853618603b8889dfeb932fd4ef

[PATCH] D140211: [clang][dataflow] Remove unused lambda capture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf86cdb485361: [clang][dataflow] Remove unused lambda capture (authored by merrymeerkat, committed by krasimir). Repository: rG LLVM Github Monorep

[clang] 82b51a1 - [AArch64] Support SLC in ACLE prefetch intrinsics

Author: Archibald Elliott Date: 2022-12-16T14:42:27Z New Revision: 82b51a14280414a53413ed62c001d2c589c649c3 URL: https://github.com/llvm/llvm-project/commit/82b51a14280414a53413ed62c001d2c589c649c3 DIFF: https://github.com/llvm/llvm-project/commit/82b51a14280414a53413ed62c001d2c589c649c3.diff

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked 2 inline comments as done. Closed by commit rG82b51a142804: [AArch64] Support SLC in ACLE prefetch intrinsics (authored by lenary). Repository: rG LLVM

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

stefanp added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9072 auto GetNullability = [&Ctx](QualType Ty) { +Optional Kind = Ty->getNullability(); merrymeerkat wrote: > barannikov88 wrote: > > This now gives a warning > > `clang/lib/Sema/Sema

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3999681 , @efriedma wrote: > Not sure exactly what code that generates in its current form, but that's > roughly the right idea, yes. Thanks. This is the IR I am getting for this simple case. I think there is still

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Tests where the RUN-

[PATCH] D140218: [update_cc_test_checks] Default to --function-signature for new tests

arichardson created this revision. arichardson added reviewers: nikic, lebedev.ri, jdoerfert, spatel, sebastian-ne. Herald added a project: All. arichardson requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This is

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

kmclaughlin added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve2-intrinsics-fp-int-binary-logarithm.ll:31 +; CHECK-NEXT: ret + %out = call @llvm.aarch64.sve.flogb.nxv2f64( %a, + %pg,

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

tahonermann added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5545 +if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) + TempPath = FinalOutput->getValue(); +else + TempPath = BaseInput; + ChuanqiXu wrote: > dblaiki

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. In D124351#4001050 , @eandrews wrote: > I came across a strange error when capturing arguments in a lambda inside > another lambda. I filed an issue here - > https://github.com/llvm/llvm-project/issues/59549 > > Short reproduce

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 483545. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addresed reviewer comments. Added second map clause to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131915/new/ https://reviews.

[PATCH] D140217: [lit] Script to automate use of %(line-n). Use in CodeComplete tests.

sammccall updated this revision to Diff 483547. sammccall edited the summary of this revision. sammccall added a comment. add bug link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140217/new/ https://reviews.llvm.org/D140217 Files: clang/test/C

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch contains several related changes: 1. We move to using TARGET_BUILTIN for

[clang] 7f8bd8a - Revert "[Driver] Remove Joined -X"

Author: Roy Sundahl Date: 2022-12-16T08:08:44-08:00 New Revision: 7f8bd8ac0658b5e75049fd5c04fcf8c31352f397 URL: https://github.com/llvm/llvm-project/commit/7f8bd8ac0658b5e75049fd5c04fcf8c31352f397 DIFF: https://github.com/llvm/llvm-project/commit/7f8bd8ac0658b5e75049fd5c04fcf8c31352f397.diff L

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f8bd8ac0658: Revert "[Driver] Remove Joined -X" (authored by rsundahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

tberghammer updated this revision to Diff 483553. tberghammer added a comment. Add wstring_view test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/readability/Redun

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 3 inline comments as done. TIFitis added a comment. > Can you add this as a test? AFAIS, the tests attached to this patch do not > seem to be exercising the `VariadicofVariadic` requirement. An explanation > with an example would be great. `VariadicOfVariadic` gives us a `SmallVe

[clang] cfd594f - [SROA] `isVectorPromotionViable()`: memory intrinsics operate on vectors of bytes (take 3)

Author: Roman Lebedev Date: 2022-12-16T19:27:38+03:00 New Revision: cfd594f8bb5e779c81171e7c1e61ae8436efabd3 URL: https://github.com/llvm/llvm-project/commit/cfd594f8bb5e779c81171e7c1e61ae8436efabd3 DIFF: https://github.com/llvm/llvm-project/commit/cfd594f8bb5e779c81171e7c1e61ae8436efabd3.diff

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

xazax.hun added a comment. I don't mind committing these patches, I have a high confidence in you going back and addressing feedback post-commit if something is coming up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137348/new/ https://reviews.llvm.org/D137348 __

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

ego added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:827 +{{"zvkg"}, {ImpliedExtsZve32x}}, +{{"zvknha"}, {ImpliedExtsZve32x}}, +{{"zvknhb"}, {ImpliedExtsZve64x}}, ego wrote: > How does this work? This doesn't seem to be enough, > "

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3998077 , @manojgupta wrote: > Xlinker still works. Xcompiler is failing. > > A google search will show that Xcompiler is a wide-spread option used by many > packages. Whether or not GCC supports it is not relevant. P

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3999098 , @rsundahl wrote: > Added the test warn-not-error-Xfoo `-Xfoo` leads to a warning (expected) which is weird. Can you change it to a form which actually reflects how `-X` is used? (aka `-Xparser`) I am not su

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#4001685 , @MaskRay wrote: > In D139717#3998077 , @manojgupta > wrote: > >> Xlinker still works. Xcompiler is failing. >> >> A google search will show that Xcompiler is a wide-sp

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#4001688 , @davide wrote: > In D139717#4001685 , @MaskRay wrote: > >> In D139717#3998077 , @manojgupta >> wrote: >> >>> Xlinker still w

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#4001702 , @MaskRay wrote: > In D139717#4001688 , @davide wrote: > >> In D139717#4001685 , @MaskRay >> wrote: >> >>> In D139717#3998077

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#4001704 , @davide wrote: > In D139717#4001702 , @MaskRay wrote: > >> In D139717#4001688 , @davide wrote: >> >>> In D139717#4001685

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137348/new/ https://reviews.llvm.org/D137348 ___ cfe-commits mailing list cfe-commits

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138253/new/ https://reviews.llvm.org/D138253 ___ cfe-commits mailing list cfe-commits

  1   2   3   >