[PATCH] D140044: [CodeComplete] Complete members of dependent `auto` variables

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeCompletion/member-access.cpp:121 // CHECK-DEP-CHAIN: baseTemplateField : [#T#]baseTemplateField -// RUN: %clang_cc1 -fsyntax-only -code-comple

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3988902 , @manojgupta wrote: > We use -Xcompiler and -Xlinker which are passed in programs and they raise > error now. Sorry, I do not understand. `clang -Xlinker --verbose a.c` works well. `-Xcompiler` is invalid i

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3991765 , @rsundahl wrote: > In D139717#3987963 , @MaskRay wrote: > >>> This change is breaking internal builds. We use the -Xfoo pattern but can >>> now no longer manage wheth

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

MaskRay added a comment. Thanks for doing this! Comment at: clang/lib/Driver/ToolChain.cpp:553 + // armeb (big endian) is left out here on purpose so that we don't try to use + // little endian libraries in that case. The comments can be combined. First sta

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added a comment. (On a trip so I will be slow.) I wish that some mips experts like @atanasyan can some proper checks but this patch seems fine. Landing in one minute after testing finishes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138

[clang] 9739bb8 - MIPS: fix build from IR files, nan2008 and FpAbi

Author: YunQiang Su Date: 2022-12-15T09:04:36Z New Revision: 9739bb81aed490bfcbcbbac6970da8fb7232fd34 URL: https://github.com/llvm/llvm-project/commit/9739bb81aed490bfcbcbbac6970da8fb7232fd34 DIFF: https://github.com/llvm/llvm-project/commit/9739bb81aed490bfcbcbbac6970da8fb7232fd34.diff LOG: M

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9739bb81aed4: MIPS: fix build from IR files, nan2008 and FpAbi (authored by wzssyqa, committed by MaskRay). Repository: rG LLVM Github Monorepo C

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

GGanesh updated this revision to Diff 483092. GGanesh added a comment. Update to use 'no' processor model. Fixed the below tests tools/llvm-mca/X86/cpus.s tools/llvm-mca/X86/read-after-ld-1.s tools/llvm-mca/X86/register-file-statistics.s tools/llvm-mca/X86/scheduler-queue-usage.s Addressed commen

[clang-tools-extra] 8b61376 - YAMLParser: llvm::Optional => std::optional

Author: Fangrui Song Date: 2022-12-15T09:34:31Z New Revision: 8b61376dfa1d67ef2776bcb4a5f92095132ce2fa URL: https://github.com/llvm/llvm-project/commit/8b61376dfa1d67ef2776bcb4a5f92095132ce2fa DIFF: https://github.com/llvm/llvm-project/commit/8b61376dfa1d67ef2776bcb4a5f92095132ce2fa.diff LOG:

[PATCH] D140090: [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC]

ManuelJBrito created this revision. ManuelJBrito added reviewers: peterwaller-arm, paulwalker-arm, david-arm. Herald added subscribers: ctetreau, arphaman, kristof.beyls. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske marked 3 inline comments as done. balazske added a comment. In D135247#3993351 , @NoQ wrote: > Also, similarly to `getenv()`, in these cases domain-specific knowledge may > help suppress some unwanted reports. Eg., if a file has been opened > s

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 483106. balazske marked an inline comment as done. balazske edited the summary of this revision. balazske added a comment. Rebase to current main, fix of comment issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. (per previous comment, mostly looks good though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139507/new/ https://reviews.llvm.org/D139

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { zixuw wrote: > dang wrote: > > zixuw wrote: > > > Aren't

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. Thanks @GGanesh - LGTM with one minor - the orphan ZNVER4 checks from the llvm-mca tests need removing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D140044: [CodeComplete] Complete members of dependent `auto` variables

ilya-biryukov added inline comments. Comment at: clang/test/CodeCompletion/member-access.cpp:121 // CHECK-DEP-CHAIN: baseTemplateField : [#T#]baseTemplateField -// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:111:41 %s -o - | FileCheck -check-prefix=CHECK-DEP-CHAIN %s +

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett updated this revision to Diff 483112. DavidSpickett added a comment. Expand the comment and show an example of changed triples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011 Files: clang

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

GGanesh added a comment. In D139073#3997418 , @RKSimon wrote: > Thanks @GGanesh - LGTM with one minor - the orphan ZNVER4 checks from the > llvm-mca tests need removing Thank you! I left them intentionally as this is a stop-gap patch. Agreed! Will rem

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry updated this revision to Diff 483114. v1nh1shungry added a comment. apply review's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 Files: clang-tools-extra/clangd/refactor/tweak

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

fsb4000 added a subscriber: CaseyCarter. fsb4000 added a comment. @CaseyCarter created https://github.com/microsoft/STL/pull/3285 So MSVC STL don't use with Clang now. It should fix the issues too because Clang overrides (and doesn't override) CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D140090: [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG84b4ff24e94b: [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC] (authored by ManuelJBrito). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 84b4ff2 - [Clang][CodeGen] Use poison instead of undef in CodeGen for ARM Builtins [NFC]

Author: Manuel Brito Date: 2022-12-15T12:00:53Z New Revision: 84b4ff24e94bee91ff35f7f29bd748e0432e52ac URL: https://github.com/llvm/llvm-project/commit/84b4ff24e94bee91ff35f7f29bd748e0432e52ac DIFF: https://github.com/llvm/llvm-project/commit/84b4ff24e94bee91ff35f7f29bd748e0432e52ac.diff LOG:

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 483121. dzhidzhoev added a comment. clang-format'ed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.c

[clang] 731abdf - [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

Author: Vladislav Dzhidzhoev Date: 2022-12-15T15:10:41+03:00 New Revision: 731abdfdcc33d813e6c3b4b89eff307aa5c18083 URL: https://github.com/llvm/llvm-project/commit/731abdfdcc33d813e6c3b4b89eff307aa5c18083 DIFF: https://github.com/llvm/llvm-project/commit/731abdfdcc33d813e6c3b4b89eff307aa5c1808

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG731abdfdcc33: [clang][CodeGen] Use base subobject type layout for potentially-overlapping… (authored by dzhidzhoev). Repository: rG LLVM Github Mo

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3996643 , @rupprecht wrote: > Here's a well-formed reproducer: Thanks a lot. We were transforming the initializer in a context where the this pointer was not set up properly, so if it was referring to this, explicitl

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 483133. cor3ntin added a comment. Properly transform the this pointer in member initializers that need to be rewritten. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D1365

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

manas updated this revision to Diff 483135. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140086/new/ https://reviews.llvm.org/D140086 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[clang] 7b36538 - [clang-format] make doc for SLS_Inline more clearly

Author: Backl1ght Date: 2022-12-15T20:51:53+08:00 New Revision: 7b36538156b7742627b422c0e6a3a18ec13b99b3 URL: https://github.com/llvm/llvm-project/commit/7b36538156b7742627b422c0e6a3a18ec13b99b3 DIFF: https://github.com/llvm/llvm-project/commit/7b36538156b7742627b422c0e6a3a18ec13b99b3.diff LOG

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b36538156b7: [clang-format] make doc for SLS_Inline more clearly (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, clang-tools-extra. Fixes https://github.com/llvm/llvm-project/issues/59533 Repository: rG

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

GGanesh updated this revision to Diff 483141. GGanesh added a comment. Fixed the tests tools/llvm-mca/X86/cpus.s tools/llvm-mca/X86/read-after-ld-1.s tools/llvm-mca/X86/register-file-statistics.s tools/llvm-mca/X86/scheduler-queue-usage.s Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

Michael137 added inline comments. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by dblaikie wrote: > aprantl wrote: > > It looks lik

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. I don't think the comments require another round of review. Thanks for fixing this. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:23-29 +static constexpr llvm::St

[PATCH] D138668: Correct typos

Sprite added a comment. @jpienaar Sorry, this is my first time using this platform. I just tried running `arc land --revision D138668` and it is trying to push my local commit (I have rebased manually) to the `main` branch on `https://github.com/llvm/llvm-project.git`, and apparently I don't ha

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2095-2097 +NamedDecl const *ND = Args.TList->getParam(i); +defaultParameter = TemplateUtils::isSubstitutedDefaultArgument( +CGM.getContext(), TA, ND, Args.Args, Args.TList-

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon accepted this revision. RKSimon added a comment. cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139073/new/ https://reviews.llvm.org/D139073 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 updated this revision to Diff 483146. qiongsiwu1 added a comment. Addressing review comments. Thanks for the review @nemanjai !! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140080/new/ https://reviews.llvm.org/D140080 Files: clang/l

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. In D128372#3991516 , @MyDeveloperDay wrote: > Ironically as an aside... looking back at the review because of the discource > article. > > The whole reason why I added the [[nodiscard]] checker to clang-tidy 4 years > ago was to c

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

nikic added a comment. In D125291#3548671 , @jyknight wrote: > So, I've been spending some significant time looking into this. I found that > I couldn't really review this change for correctness, because I find it > basically impossible to figure out wh

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

Michael137 updated this revision to Diff 483155. Michael137 added a comment. - Hoist common code out of switch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139988/new/ https://reviews.llvm.org/D139988 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

Michael137 updated this revision to Diff 483156. Michael137 added a comment. - Remove now redundant `isSubstitutedDefaultArgument` call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139989/new/ https://reviews.llvm.org/D139989 Files: clang/lib/C

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

merrymeerkat created this revision. Herald added subscribers: martong, kadircet, arphaman, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This change will allow users t

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 483167. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/AST/Type.h clang/include/clang/Basic/FPOptions.

[PATCH] D140095: [include-cleaner] Fix the member-expr-access usage for sugar type.

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:50 + return UT->getFoundDecl(); +if (const auto *TST = Type->getAs()) + return resolveTemplateName(TST->getTemplateName()); Resolving a template type to o

[clang] 948bb35 - [PPC] Convert tests to check 'target='

Author: Paul Robinson Date: 2022-12-15T07:01:14-08:00 New Revision: 948bb35d747419651fa5bcf86d5b6563bbb56119 URL: https://github.com/llvm/llvm-project/commit/948bb35d747419651fa5bcf86d5b6563bbb56119 DIFF: https://github.com/llvm/llvm-project/commit/948bb35d747419651fa5bcf86d5b6563bbb56119.diff

[PATCH] D138954: [PPC] Convert tests to check 'target='

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG948bb35d7474: [PPC] Convert tests to check 'target=' (authored by probinson). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D140084: [llvm][test] Split DW_AT_default_value check out of clang/test/

Michael137 added a comment. In D140084#3997123 , @dblaikie wrote: > Sorry, should've caught this in review. The clang change needs test coverage > in clang, but should verify the emitted it, rather than going all the way > down to object code. > > The l

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 483171. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Change CBV implementation to template using ConstantBuffer = T; Added new internal attribute HLSLConstantBufferView to mark CBV with AttributedType. Repository: rG LLVM Gith

[PATCH] D140105: [clang-format] add missing config parse test for short lambda

Backl1ght created this revision. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140105 Files:

[clang] 33e3edd - [CodeComplete] Complete members of dependent `auto` variables

Author: Sam McCall Date: 2022-12-15T16:10:19+01:00 New Revision: 33e3edde44952ed2be44ad00e6cb73208580bb85 URL: https://github.com/llvm/llvm-project/commit/33e3edde44952ed2be44ad00e6cb73208580bb85 DIFF: https://github.com/llvm/llvm-project/commit/33e3edde44952ed2be44ad00e6cb73208580bb85.diff LO

[PATCH] D140044: [CodeComplete] Complete members of dependent `auto` variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33e3edde4495: [CodeComplete] Complete members of dependent `auto` variables (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES

[clang] 19d300f - Revert "[clang][CodeGen] Use base subobject type layout for potentially-overlapping fields"

Author: Vladislav Dzhidzhoev Date: 2022-12-15T18:12:26+03:00 New Revision: 19d300fb4150b94f6dc7d8d230553d36349a3002 URL: https://github.com/llvm/llvm-project/commit/19d300fb4150b94f6dc7d8d230553d36349a3002 DIFF: https://github.com/llvm/llvm-project/commit/19d300fb4150b94f6dc7d8d230553d36349a300

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

qiongsiwu1 added a comment. The pre-commit CI crashes do not seem to relate to this patch. I will land it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140080/new/ https://reviews.llvm.org/D140080 ___

[clang] 5d22d1f - [clang][dataflow] Improve optional model's support for ignoring smart pointers.

Author: Yitzhak Mandelbaum Date: 2022-12-15T15:39:52Z New Revision: 5d22d1f54836263ead1971ef8128f5128290dfa7 URL: https://github.com/llvm/llvm-project/commit/5d22d1f54836263ead1971ef8128f5128290dfa7 DIFF: https://github.com/llvm/llvm-project/commit/5d22d1f54836263ead1971ef8128f5128290dfa7.diff

[PATCH] D140020: [clang][dataflow] Improve optional model's support for ignoring smart pointers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d22d1f54836: [clang][dataflow] Improve optional model's support for ignoring smart pointers. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 98550df - [clang-tidy] Add configuration option to bugprone-unchecked-optional-access check.

Author: Yitzhak Mandelbaum Date: 2022-12-15T15:43:21Z New Revision: 98550df7b7bbce0e38a1ec558287d759163c64ba URL: https://github.com/llvm/llvm-project/commit/98550df7b7bbce0e38a1ec558287d759163c64ba DIFF: https://github.com/llvm/llvm-project/commit/98550df7b7bbce0e38a1ec558287d759163c64ba.diff

[PATCH] D140021: [clang-tidy] Add configuration option to bugprone-unchecked-optional-access check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98550df7b7bb: [clang-tidy] Add configuration option to bugprone-unchecked-optional-access… (authored by ymandel). Repository: rG LLVM Github Monor

[clang] de8deb5 - [clang][PPC] Supporting -mcpu=405

Author: Qiongsi Wu Date: 2022-12-15T10:55:26-05:00 New Revision: de8deb5189c948db89c753ff2dff65b8e7840e8b URL: https://github.com/llvm/llvm-project/commit/de8deb5189c948db89c753ff2dff65b8e7840e8b DIFF: https://github.com/llvm/llvm-project/commit/de8deb5189c948db89c753ff2dff65b8e7840e8b.diff LO

[PATCH] D140080: [clang][PPC] Supporting -mcpu=405

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde8deb5189c9: [clang][PPC] Supporting -mcpu=405 (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. Xlinker still works. Xcompiler is failing. A google search will show that Xcompiler is a wide-spread option used by many packages. Whether or not GCC supports it is not relevant. Please do not remove options just because you do not use them. Repository: rG LLVM G

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 483203. pmatos added a comment. Force mem2reg on all optimization levels to avoid allocas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/clang

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#3991648 , @MoritzS wrote: > Thanks for the patch! I just tried it out and I think this enables many > interesting use cases for WebAssembly when using C/C++. > > Currently the lowering to wasm does not work when using e

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 483205. dgoldman added a comment. Don't pass ASTSignals through ParsedAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-extra/clangd/ASTSignal

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

compnerd added a comment. Thanks @fsb4000 (and @CaseyCarter)! I think that due to the shipped version, it makes sense to do this still. Using standard semantics in general I think is preferable, since nothing prevents another compiler implementation to still do something similar. CHANGES SI

[PATCH] D139986: [WIP][clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 updated this revision to Diff 483168. Michael137 added a comment. Michael137 updated this revision to Diff 483184. Michael137 published this revision for review. Michael137 added a subscr

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 483213. balazske added a comment. Removed change of errno state from StreamChecker. Added cases for zero buffer size in `fread` and `fwrite`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135247/new/ https://r

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Michael137 added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? - // CHECKCXX98: @_ZN11rdar93574002ggE ={{.*}} constant [49 x i8] c"{vector

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#3997193 , @MaskRay wrote: > In D139717#3991765 , @rsundahl > wrote: > >> In D139717#3987963 , @MaskRay >> wrote: >> This change i

[PATCH] D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert().

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140068/new/ https://reviews.llvm.org/D140068 __

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Rebase to trigger pre-merge checks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140085/new/ https://reviews.llvm.org/D140085

[clang-tools-extra] 40cc041 - [clang-tools-extra] Convert tests to check 'target=...'

Author: Paul Robinson Date: 2022-12-15T09:51:06-08:00 New Revision: 40cc041d4eec7306a67bfdbfeaa8796b8d856b60 URL: https://github.com/llvm/llvm-project/commit/40cc041d4eec7306a67bfdbfeaa8796b8d856b60 DIFF: https://github.com/llvm/llvm-project/commit/40cc041d4eec7306a67bfdbfeaa8796b8d856b60.diff

[clang] 80f2f1e - [NFC] Rename Function::insertBasicBlockAt() to Function::insert().

Author: Vasileios Porpodas Date: 2022-12-15T10:03:37-08:00 New Revision: 80f2f1eabc491cde39d543e4ebda93e2d2974d1f URL: https://github.com/llvm/llvm-project/commit/80f2f1eabc491cde39d543e4ebda93e2d2974d1f DIFF: https://github.com/llvm/llvm-project/commit/80f2f1eabc491cde39d543e4ebda93e2d2974d1f.

[PATCH] D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert().

This revision was automatically updated to reflect the committed changes. Closed by commit rG80f2f1eabc49: [NFC] Rename Function::insertBasicBlockAt() to Function::insert(). (authored by vporpo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140068/n

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

vporpo updated this revision to Diff 483222. vporpo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140085/new/ https://reviews.llvm.org/D140085 Files: clang/lib/CodeGen/CGCleanup.cpp llvm/docs/ProgrammersManual.rst llv

[PATCH] D136176: Implement support for option 'fexcess-precision'.

andrew.w.kaylor added inline comments. Comment at: clang/test/CodeGen/X86/fexcess-precision.c:89 +// CHECK-EXT-NEXT:[[EXT1:%.*]] = fpext half [[TMP1]] to float +// CHECK-EXT-NEXT:[[MUL:%.*]] = fmul float [[EXT]], [[EXT1]] +// CHECK-EXT-NEXT:[[TMP2:%.*]] = load half, p

[PATCH] D140086: [analyzer][solver] Improve reasoning for not equal to operator

steakhal added a comment. Thanks for going the extra mile to address this last thing. I really appreciate it. I've got only a few minor comments and suggestions. I'd recommend spell-checking the comments and the summary of this revision. See my technical comments inline. The test coverage looks

[PATCH] D140125: [clang] splits diagnostic message into summary and reason

cjdb created this revision. cjdb added reviewers: dblaikie, erichkeane. Herald added subscribers: kadircet, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added projects: clang, libc++abi, clang-tools-extra. Herald added subscribers: cfe-commits, libcxx-commit

[PATCH] D140105: [clang-format] add missing config parse test for short lambda

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/ConfigParseTest.cpp:545 + AllowShortLambdasOnASingleLine, FormatStyle::SLS_All); + CHECK_PARSE("A

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

hubert.reinterpretcast added a comment. In D139586#3987252 , @royjacobson wrote: > The (non-wording) paper makes a pretty convincing case to just apply this > retroactively to any C++11 code > (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

aprantl added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? - // CHECKCXX98: @_ZN11rdar93574002ggE ={{.*}} constant [49 x i8] c"{vector >=[

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

zixuw accepted this revision. zixuw added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

samitolvanen accepted this revision. samitolvanen added a comment. This revision is now accepted and ready to land. In D140035#3996066 , @joaomoreira wrote: > Regarding not being able to reproduce this in kernel -- never mind... I was > misled by setup

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

aprantl added inline comments. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by Michael137 wrote: > dblaikie wrote: > > aprantl wrot

[clang] 678ded0 - [clang] Support for read-only types

Author: MalavikaSamak Date: 2022-12-15T12:09:01-08:00 New Revision: 678ded017f21b22da3ab20ffafe2bc2dc4457493 URL: https://github.com/llvm/llvm-project/commit/678ded017f21b22da3ab20ffafe2bc2dc4457493 DIFF: https://github.com/llvm/llvm-project/commit/678ded017f21b22da3ab20ffafe2bc2dc4457493.diff

[PATCH] D135851: [clang] Support for read-only types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG678ded017f21: [clang] Support for read-only types (authored by malavikasamak). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

gribozavr2 added inline comments. Comment at: clang/include/clang/AST/Type.h:2550 /// be lost by canonicalization and desugaring. - Optional getNullability(const ASTContext &context) const; + Optional getNullability() const; Could you add a temporary depre

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl updated this revision to Diff 483297. rsundahl added a comment. Added the test warn-not-error-Xfoo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 Files: clang/include/clang/Driver/Options.td

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl added a comment. I added a test so we can catch any regression. If we choose to deprecate then we can modify the test to watch for the "is deprecated" message that should be asserted for "some time" appropriate. Thank you all for your input. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

dblaikie accepted this revision. dblaikie added a comment. Looks good to me, thanks! Patch description might need a tweak, this bit: > Type template parameters where the type is itself a template instantiation > (e.g., `template>`) The quoted example is impossible (infinitely recursive) & the

[clang] e0f2150 - [clang] Convert tests to check 'target=...'

Author: Paul Robinson Date: 2022-12-15T12:26:33-08:00 New Revision: e0f2150e99e5e429c33047f25e3da2ab146d0f57 URL: https://github.com/llvm/llvm-project/commit/e0f2150e99e5e429c33047f25e3da2ab146d0f57 DIFF: https://github.com/llvm/llvm-project/commit/e0f2150e99e5e429c33047f25e3da2ab146d0f57.diff

[clang] 32b38d2 - [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

Author: Vasileios Porpodas Date: 2022-12-15T12:27:45-08:00 New Revision: 32b38d248fd3c75abc5c86ab6677b6cb08a703cc URL: https://github.com/llvm/llvm-project/commit/32b38d248fd3c75abc5c86ab6677b6cb08a703cc DIFF: https://github.com/llvm/llvm-project/commit/32b38d248fd3c75abc5c86ab6677b6cb08a703cc.

[PATCH] D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32b38d248fd3: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be… (authored by vporpo). Repository: rG LLVM Github Monorepo

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

dblaikie accepted this revision. dblaikie added a comment. Looks good to me - we'd usually split the LLVM part from the Clang part, but I don't think we have fine grained unit tests for DIBuilder (could you check - if we do, then the LLVM part should go separately, with unit test coverage, then

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we wa

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

dblaikie added inline comments. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by aprantl wrote: > Michael137 wrote: > > dblaikie wro

[PATCH] D140155: [OpenMP] Allow host call to nohost function with host variant

doru1004 created this revision. doru1004 added reviewers: carlo.bertolli, ronl, gregrodgers, jdoerfert, jhuber6, ABataev. doru1004 added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. doru1004 requested review of this revision. Herald added subscribers:

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

aprantl added inline comments. Comment at: clang/test/CodeGenObjCXX/encode.mm:93-94 // FIXME: This difference is due to D76801. It was probably an unintentional change. Maybe we want to undo it? - // CHECKCXX98: @_ZN11rdar93574002ggE ={{.*}} constant [49 x i8] c"{vector >=[

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, JonChesterfield. Herald added subscribers: mattd, gchakrabarti, carlosgalvezp, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald adde

[PATCH] D140159: [clang][nfc] Fixes for D129531

ayzhao created this revision. ayzhao added a reviewer: shafik. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Additional fixes for review comments made in https://reviews.llvm.org/D129531 after the patch

  1   2   >