[PATCH] D139998: [clangd] Remove ReferenceFinder::Reference::Target

nridge created this revision. nridge added reviewers: tom-anders, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. No one w

[PATCH] D119077: clangd SemanticHighlighting: added support for highlighting overloaded operators

nridge abandoned this revision. nridge added a comment. Abandoning in favour of D136594 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 ___ cfe-commits mailing list

[libunwind] 356bbbb - [libunwind] Use .irp directives. NFC

Author: Fangrui Song Date: 2022-12-14T08:24:22Z New Revision: 356da9d00d734b8fbfc1492f584b25b4b6f0 URL: https://github.com/llvm/llvm-project/commit/356da9d00d734b8fbfc1492f584b25b4b6f0 DIFF: https://github.com/llvm/llvm-project/commit/356da9d00d734b8fbfc1492f584b25b4b6f0.diff LOG:

[PATCH] D139999: [clang-format][NFC] Don't run any passes if Environment::make fails

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 482732. TIFitis added a comment. Added custom printer & parser for map clause. Updated ops.mlir test to address reviewer comments. Custom Printer example: OMP: !$omp target exit data map(from: a,b) map(release: c) map(delete: d) map(always, from: e) Custom

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1426 + LookupRequest ContainerLookup; + llvm::DenseMap RefIndexForContainer; Index->relations(OverriddenBy, [&](const SymbolID &Subject, Unlike the QueryIndex case, I th

[clang] c86a878 - [RISCV] Add Syntacore SCR1 CPU model

Author: Dmitrii Petrov Date: 2022-12-14T11:45:44+03:00 New Revision: c86a878e8995d54a5b950098e81f0d3bf153aded URL: https://github.com/llvm/llvm-project/commit/c86a878e8995d54a5b950098e81f0d3bf153aded DIFF: https://github.com/llvm/llvm-project/commit/c86a878e8995d54a5b950098e81f0d3bf153aded.diff

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc86a878e8995: [RISCV] Add Syntacore SCR1 CPU model (authored by dnpetrov-sc, committed by anton-afanasyev). Repository: rG LLVM Github Monorepo C

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 10 inline comments as done. TIFitis added inline comments. Comment at: mlir/test/Dialect/OpenMP/ops.mlir:389 +// CHECK: omp.target_data +"omp.target_data"(%if_cond, %device, %data1, %data2) ({ + clementval wrote: > Can you switch to

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3993791 , @rupprecht wrote: > Looks like the latest reland still has some issue remaining. With asserts > enabled, I get: `assert.h assertion failed at > clang/include/clang/AST/Type.h:752 in const ExtQualsTypeCommon

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0660691f74: [clang][analyzer] No new nodes when bug is detected in… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] da06606 - [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

Author: Balázs Kéri Date: 2022-12-14T09:51:43+01:00 New Revision: da0660691f74b0350dee8e15f4ac942457e397e4 URL: https://github.com/llvm/llvm-project/commit/da0660691f74b0350dee8e15f4ac942457e397e4 DIFF: https://github.com/llvm/llvm-project/commit/da0660691f74b0350dee8e15f4ac942457e397e4.diff L

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 482738. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Address comments: - if `-o` is not provided, emit the module file to the working directory instead of the directory of the input file. CHANGES SINCE LAST ACTION https://r

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5541-5542 + // + // FIXME: Do we need to handle the case that the calculated output is + // conflicting with the specified output file or the input file? + if (!AtTopLevel && isa(JA) &&

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 482739. ChuanqiXu added a comment. Update since the dependent one changed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp c

[clang] 339a768 - Revert "Implement CWG2631"

Author: Krasimir Georgiev Date: 2022-12-14T09:10:22Z New Revision: 339a7687e1c036a5f91c9d5391523b93e2e76cd3 URL: https://github.com/llvm/llvm-project/commit/339a7687e1c036a5f91c9d5391523b93e2e76cd3 DIFF: https://github.com/llvm/llvm-project/commit/339a7687e1c036a5f91c9d5391523b93e2e76cd3.diff

[PATCH] D140000: [clangd] Compute the unused includes in the check mode.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[clang-tools-extra] 6f0b149 - [clangd] Correct the local variable names to match the code style, NFC

Author: Haojian Wu Date: 2022-12-14T10:45:20+01:00 New Revision: 6f0b149f40bb1ae8da4e4584a30c405f92bd27a4 URL: https://github.com/llvm/llvm-project/commit/6f0b149f40bb1ae8da4e4584a30c405f92bd27a4 DIFF: https://github.com/llvm/llvm-project/commit/6f0b149f40bb1ae8da4e4584a30c405f92bd27a4.diff LO

[PATCH] D139715: [include-cleaner] Print the line number of removal #includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4702d8d9cf80: [include-cleaner] Print the line number of removal #includes. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139715/new/

[clang-tools-extra] 4702d8d - [include-cleaner] Print the line number of removal #includes.

Author: Haojian Wu Date: 2022-12-14T10:52:13+01:00 New Revision: 4702d8d9cf80d6f80e68d20b3ff5c0bf8a43e000 URL: https://github.com/llvm/llvm-project/commit/4702d8d9cf80d6f80e68d20b3ff5c0bf8a43e000 DIFF: https://github.com/llvm/llvm-project/commit/4702d8d9cf80d6f80e68d20b3ff5c0bf8a43e000.diff LO

[PATCH] D140002: [C++20] [Modules] Merging of lambda types in deserialization

ChuanqiXu created this revision. ChuanqiXu added reviewers: ilya-biryukov, rsmith, dblaikie, iains, erichkeane, tahonermann. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D140002: [C++20] [Modules] Merging of lambda types in deserialization

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:2161-2198 + /// FIXME: The `DeclContext::noload_lookup()` wouldn't load local lexical + /// lookups since unnamed declarations are skipped. We can find this in + /// `DeclContext::buildLooku

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

eklepilkina added a comment. @lewis-revill could you please provide the case where the LTO linker would not receive any information about target features? We met similar problems, it appears on runtime functions in our cases. I made a small fix for this problem https://reviews.llvm.org/D139704.

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 482778. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Anonymous enums that are typedef'd should take on the name of the typedef.

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett created this revision. Herald added subscribers: Enna1, kristof.beyls, dberris. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, MaskRay. Herald added projects: clang, Sanitizers, LLVM. The

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett added reviewers: MaskRay, phosek. DavidSpickett added a comment. Herald added a subscriber: StephenFan. The first attempt at this was https://reviews.llvm.org/D110142. The key difference is that... > It also seems like armhf-unknown-linux-gnueabihf duplicates the hf bit > (there's

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

Backl1ght added a comment. In D139937#3994044 , @HazardyKnusperkeks wrote: > In D139937#3993641 , @Backl1ght > wrote: > >> In D139937#3992987 , >> @HazardyKnusperkeks w

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett updated this revision to Diff 482811. DavidSpickett added a comment. - `-target` changed to `--target=` in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011 Files: clang/lib/Driver/Too

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett added a comment. I haven't tested this on a BSD myself. I don't see a major reason it wouldn't work but if you think it's going to have issues I can do that testing and/or restrict this change to Linux only initially. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

UnionType added a comment. @v.g.vassilev Thanks for your reply, the patch is clean and clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits m

[clang] d8f91f2 - [CodeGenCUDASPIRV] Convert tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2022-12-14T13:36:07+01:00 New Revision: d8f91f2c1d0955da5d30ca297f2979bf6c01d8a3 URL: https://github.com/llvm/llvm-project/commit/d8f91f2c1d0955da5d30ca297f2979bf6c01d8a3 DIFF: https://github.com/llvm/llvm-project/commit/d8f91f2c1d0955da5d30ca297f2979bf6c01d8a3.diff

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

Backl1ght added a comment. In D139937#3994044 , @HazardyKnusperkeks wrote: > In D139937#3993641 , @Backl1ght > wrote: > >> In D139937#3992987 , >> @HazardyKnusperkeks w

[PATCH] D138499: [clangd] Extract Function: add hoisting support

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138499/new/ https://reviews.llvm.org/D138499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D137875: clang/AMDGPU: Drop volatile from builtin_atomic* pointers

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137875/new/ https://reviews.llvm.org/D137875 ___ cfe-commits maili

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

hokein added a comment. I haven't read all code yet, left a few initial comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:85 +/// Represents properties of a symbol provider. +enum class Hint : uint8_t { + None = 0x00, IIUC, we're u

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille updated this revision to Diff 482825. serge-sans-paille added a comment. Make `Prefixes` an array of StringRef too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/

[PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

serge-sans-paille marked 4 inline comments as done. serge-sans-paille added a comment. New version passes `ninja check` with clang, clang-tools-extra and lld. Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39 ento::CallDescription::CallDescription(CallDescriptio

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

hans added a comment. Could we add a release note and/or update to the clang manual explaining the new behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 __

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

tberghammer created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. tberghammer requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previously we wer

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Please rebase if still relevant CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80416/new/ https://reviews.llvm.org/D80416 ___ cfe

[PATCH] D88978: [WIP] Attach debug intrinsics to allocas, and use correct address space

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a subscriber: arichardson. Please rebase if still relevant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88978/new/ https

[PATCH] D140020: [clang][dataflow] Improve optional model's support for ignoring smart pointers.

ymandel created this revision. ymandel added a reviewer: xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The optional model has an option to ignore optionals

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think given that it confused you I'm fine with this change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 __

[PATCH] D140021: [clang-tidy] Add configuration option to bugprone-unchecked-optional-access check.

ymandel created this revision. ymandel added a reviewer: xazax.hun. Herald added subscribers: carlosgalvezp, rnkovacs. Herald added a reviewer: njames93. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. The underlying model already

[PATCH] D140021: [clang-tidy] Add configuration option to bugprone-unchecked-optional-access check.

ymandel updated this revision to Diff 482833. ymandel added a comment. simplify new test file to only include relevant cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140021/new/ https://reviews.llvm.org/D140021 Files: clang-tools-extra/clan

[PATCH] D140021: [clang-tidy] Add configuration option to bugprone-unchecked-optional-access check.

ymandel updated this revision to Diff 482834. ymandel added a comment. comment tweaks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140021/new/ https://reviews.llvm.org/D140021 Files: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccess

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

carlosgalvezp added a comment. Please document the changes in the Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 ___ cfe-commits mailing list cf

[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

arsenm updated this revision to Diff 482839. arsenm added a comment. Don't handle null and add nonnull attributes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138392/new/ https://reviews.llvm.org/D138392 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/__clang_hip_ma

[clang] 2eac70c - [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture

Author: Alexey Baturo Date: 2022-12-14T17:29:05+03:00 New Revision: 2eac70c1084cca6a1fa067c95ba7db2c9c00f103 URL: https://github.com/llvm/llvm-project/commit/2eac70c1084cca6a1fa067c95ba7db2c9c00f103 DIFF: https://github.com/llvm/llvm-project/commit/2eac70c1084cca6a1fa067c95ba7db2c9c00f103.diff

[PATCH] D131345: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eac70c1084c: [RISC-V][HWASAN] Enable HWASAN for RISC-V architecture (authored by smd). Changed prior to commit: https://reviews.llvm.org/D131345?vs=450579&id=482841#toc Repository: rG LLVM Github Mo

[PATCH] D138668: Correct typos

jpienaar added a comment. Do you need help in landing change? Or waiting for all reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138668/new/ https://reviews.llvm.org/D138668 ___ cfe-commits mail

[PATCH] D139966: [clang-tidy] Use Python3 for add_new_check.py and rename_check.py

Eugene.Zelenko accepted this revision. Eugene.Zelenko added a comment. This revision is now accepted and ready to land. Looks OK for me, but will be good idea to wait for couple of days for other eyes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a subscriber: wdng. I think the __builtin_isfpclass part should be a separate patch from the rest of the functions. Also needs sema tests for the handling of the immediat

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov accepted this revision as: ilya-biryukov. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Thanks a lot for driving this to conclusion! Please note that there is one small NIT you may want to fix before landing this. UB definitely explains why we

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#3991648 , @MoritzS wrote: > Thanks for the patch! I just tried it out and I think this enables many > interesting use cases for WebAssembly when using C/C++. > > Currently the lowering to wasm does not work when using e

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. ahhh, ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 482862. ayzhao marked an inline comment as done. ayzhao added a comment. use getFailureKind() + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/d

[clang] 40c5215 - [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

Author: Alan Zhao Date: 2022-12-14T07:54:15-08:00 New Revision: 40c52159d3ee337dbed14e4c73b5616ea354c337 URL: https://github.com/llvm/llvm-project/commit/40c52159d3ee337dbed14e4c73b5616ea354c337 DIFF: https://github.com/llvm/llvm-project/commit/40c52159d3ee337dbed14e4c73b5616ea354c337.diff LOG

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40c52159d3ee: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a… (authored by ayzhao). Repository: rG LLVM Github Monorepo

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ymandel added a comment. In D139737#3993813 , @NoQ wrote: > In D139737#3991699 , @ymandel wrote: > >> 2. We (google) have a tool for changing the type of a variable which takes >> into account all cascading chang

[PATCH] D139921: [include-cleaner] Ranking of providers based on hints

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:84 +/// Represents properties of a symbol provider. +enum class Hint : uint8_t { along with `SymbolLocation`, I think mixing our fundamental types and analysis

[clang] e20cc31 - [Clang] Convert test to opaque pointers (NFC)

Author: Nikita Popov Date: 2022-12-14T17:03:27+01:00 New Revision: e20cc31ae4fd32c131adc46e92862225a7a8e931 URL: https://github.com/llvm/llvm-project/commit/e20cc31ae4fd32c131adc46e92862225a7a8e931 DIFF: https://github.com/llvm/llvm-project/commit/e20cc31ae4fd32c131adc46e92862225a7a8e931.diff

[PATCH] D140029: [CodeComplete] Provide designated-init completions in (const) reference context

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140029 Files: cl

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

probinson added a comment. See D139967 for why `UNSUPPORTED: powerpc` didn't work. That patch will put it back, and also update the lit config so the check will work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.AllowShortCaseLabelsOnASingleLine = false; + LLVMStyle.AllowShortCompoundRequirementOnASingleLine = true; LLVMStyle.AllowShortEnumsOnASingleLine = true; HazardyKnu

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

tblah added a comment. In D138675#3995282 , @probinson wrote: > See D139967 for why `UNSUPPORTED: powerpc` > didn't work. That patch will put it back, and also update the lit config so > the check will work now. Thank

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

tberghammer updated this revision to Diff 482870. tberghammer added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/readability/Redundant

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

tberghammer updated this revision to Diff 482871. tberghammer added a comment. Fix formatting type in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140018/new/ https://reviews.llvm.org/D140018 Files: clang-tools-extra/clang-tidy/re

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

amyk added a comment. In D138675#3995282 , @probinson wrote: > See D139967 for why `UNSUPPORTED: powerpc` > didn't work. That patch will put it back, and also update the lit config so > the check will work now. Thank

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

dzhidzhoev updated this revision to Diff 482874. dzhidzhoev added a comment. Addressed @efriedma comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139741/new/ https://reviews.llvm.org/D139741 Files: clang/include/clang/AST/Decl.h clang/l

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos added a comment. In D122215#3995105 , @pmatos wrote: > In D122215#3991648 , @MoritzS wrote: > >> Thanks for the patch! I just tried it out and I think this enables many >> interesting use cases for WebAsse

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks nicer than the old code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139988/new/ https://reviews.llvm.org/D139988 __

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

aprantl added a comment. Seems fine to me, I just have one inline comment about the name of the namespace. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be pr

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added a comment. > Is there a plan to enable ModelPOSIX by default, at least on POSIX-compliant > target triples? Yes, this would be more convenient. But all other modeled functions (not only in the ModelPOSIX part of the code) must be checked if they are POSIX compliant. The function

[PATCH] D139985: [clang][AST][NFC] Move isSubstitutedDefaultArgument out of TypePrinter into separate component

dblaikie added inline comments. Comment at: clang/include/clang/AST/TemplateUtils.h:19 +namespace clang { +namespace TemplateUtils { +/// Make a best-effort determination of whether the type T can be produced by aprantl wrote: > It looks like all the other namesp

[clang] 0e89f1c - [clang-format][NFC] Don't run any passes if Environment::make fails

Author: Owen Pan Date: 2022-12-14T10:27:05-08:00 New Revision: 0e89f1cca495055795d97b17cb38d43d0c9a7ec1 URL: https://github.com/llvm/llvm-project/commit/0e89f1cca495055795d97b17cb38d43d0c9a7ec1 DIFF: https://github.com/llvm/llvm-project/commit/0e89f1cca495055795d97b17cb38d43d0c9a7ec1.diff LOG:

[PATCH] D139999: [clang-format][NFC] Don't run any passes if Environment::make fails

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e89f1cca495: [clang-format][NFC] Don't run any passes if Environment::make fails (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Ugh, I left cvise running overnight and forgot to include the validity check by building with a previous clang, so my reduction is invalid. I'm going to run it again, but here's the invalid crasher in the meantime: struct SourceLocation { static SourceLocation c

[PATCH] D139995: [RISCV] Refactor RVV Policy by structure

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:105 + : TU(_TU), TA(_TA), MU(_MU), MA(_MA) {} + Policy(bool _TU, bool _TA, bool _MU, bool _MA, bool _IntrinsicWithoutMU) + : TU(_TU), TA(_TA), MU(_MU), MA(_MA), -

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { Aren't these two lines supposed to do this? Repository

[PATCH] D140018: [clang-tidy] Support std::string_view in readability-redundant-string-cstr

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM! Perhaps give the other reviewers a couple days to take a look in case I've missed anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira created this revision. joaomoreira added reviewers: samitolvanen, nickdesaulniers, xiangzhangllvm, pengfei, aaron.ballman, pcc, gftg85. joaomoreira added a project: LLVM. Herald added a subscriber: inglorion. Herald added a project: All. joaomoreira requested review of this revision. H

[clang] bd672e2 - [CodeComplete] Provide designated-init completions in (const) reference context

Author: Sam McCall Date: 2022-12-14T19:41:25+01:00 New Revision: bd672e2fc03823e536866da6721b9f053cfd586b URL: https://github.com/llvm/llvm-project/commit/bd672e2fc03823e536866da6721b9f053cfd586b DIFF: https://github.com/llvm/llvm-project/commit/bd672e2fc03823e536866da6721b9f053cfd586b.diff LO

[PATCH] D140029: [CodeComplete] Provide designated-init completions in (const) reference context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd672e2fc038: [CodeComplete] Provide designated-init completions in (const) reference context (authored by sammccall). Repository: rG LLVM Github

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > IIUC the labels have to match a line in the file uniquely, which the DW_TAGs > wouldn't CHECK-LABEL doesn't have to match a line in the file uniquely. What happens is that all the -LABEL directives are processed first, in order, subdividing the input text into regi

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

joaomoreira added a comment. Regarding https://github.com/ClangBuiltLinux/linux/issues/1737: Weirdly enough, I double-tested the behavior for -flto=thin + -mibt-seal; the kernel did boot fine on my setup, but when dumped/grep'ed for ENDBRs, it had ~500 less ENDBRs throughout the binary. Conside

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { zixuw wrote: > Aren't these two lines supposed to do this

[PATCH] D140035: [X86] Prevent -mibt-seal to work together with -flto=thin

samitolvanen added a comment. In D140035#3995703 , @joaomoreira wrote: > Regarding https://github.com/ClangBuiltLinux/linux/issues/1737: > > Weirdly enough, I double-tested the behavior for -flto=thin + -mibt-seal; the > kernel did boot fine on my setup

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > CHECK-LABEL doesn't have to match a line in the file uniquely. I mean, it's good practice if they do match uniquely; that way you don't get excessively confusing results when the output changes, and things start matching where you didn't expect. But it's not a requ

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Actually, that assertion failure is pre-existing. However, this is newly failing in a no-asserts clang, so I wonder if something about this patch is just surfacing an existing bug in clang. Anyway, I hope to have a better repro by EOD. Repository: rG LLVM Github M

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon added a comment. @GGanesh reverse-ping Comment at: llvm/lib/Target/X86/X86.td:1619 ProcessorFeatures.ZN3Tuning>; +def : ProcModel<"znver4", Znver3Model, ProcessorFeatures.ZN4Features, +ProcessorFeatures.ZN4Tuning>; RKSim

[PATCH] D139989: [clang][DebugInfo] Add DW_AT_default_value support for template template parameters

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2095-2097 +NamedDecl const *ND = Args.TList->getParam(i); +defaultParameter = TemplateUtils::isSubstitutedDefaultArgument( +CGM.getContext(), TA, ND, Args.Args, Args.TList->g

[PATCH] D140037: [clang][dataflow] Remove old diagnoser API

merrymeerkat created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a clean up following the revision D139868

[PATCH] D139988: [clang][DebugInfo] Re-use clang::TemplateUtils to determine guide DW_AT_default_value for template parameters

dblaikie added a comment. Partly feedback on D139989 too - if we could move this logic outside the switch, then it wouldn't need to be done in each different template parameter type? (& then D139989 I guess wouldn't be needed

[PATCH] D131858: [clang] Track the templated entity in type substitution.

steven_wu added a comment. The workaround in https://reviews.llvm.org/D139956 can get llvm-project bootstrap correctly, doesn't fix the underlying issue. The new failures is in building `SupportTests` where it issues a weird warning followed by missing symbol. It might be related to this commit

[PATCH] D140010: [clang][ExtractAPI] Fix naming of typedef'd anonymous enums

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIVisitor.cpp:174-175 + StringRef Name = Decl->getName(); if (Name.empty()) Name = getTypedefName(Decl); + if (Name.empty()) { dang wrote: > zixuw wrote: > > Aren't these two lines su

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman updated this revision to Diff 482950. dgoldman marked 5 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139458/new/ https://reviews.llvm.org/D139458 Files: clang-tools-ex

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a comment. Seems that this alone is insufficient as some build does run into issues, so I may need to refine this further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/ https://reviews.llvm.org/D139749 _

  1   2   >