[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

xen0n added a comment. Linux only requires `__cpucfg` among the ones you just added. Please amend the patch summary so it's more accurate. Otherwise LGTM, thanks! Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:797 +ASRT_LE_GT_CASE(asrtle_d) +ASRT_LE_G

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin added a comment. In D139915#3991089 , @xen0n wrote: > Linux only requires `__cpucfg` among the ones you just added. Please amend > the patch summary so it's more accurate. > > Otherwise LGTM, thanks! Thanks for your review, I will modify the

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin updated this revision to Diff 482372. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139915/new/ https://reviews.llvm.org/D139915 Files: clang/include/clang/Basic/BuiltinsLoongAr

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine);

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

MyDeveloperDay added a comment. I know I have situations where I like `inline` and `static` to be in a certain order to avoid them getting constantly swapped around, they are never going to be after the type but I still want them the same way, I'd be ok with allow `friend` for the same reason.

<    1   2   3