[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

sepavloff added a comment. LGTM. In D139507#3980555 , @qiucf wrote: > In D139507#3978449 , @sepavloff > wrote: > >> Thank you for working on this! >> >> Is there any reason why we should keep the old intrinsic?

[PATCH] D139608: [Clang][NFC] Add default `getBFloat16Mangling` impl

Pierre-vh created this revision. Pierre-vh added reviewers: MaskRay, stuij. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, StephenFan, kerbowa, jvesely. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: cfe-commits, jholewinski.

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. In D139507#3980555 , @qiucf wrote: > In D139507#3978449 , @sepavloff > wrote: > >> Thank you for wor

[clang] 579f3f0 - [LoongArch] Rename the test file and separate the tests on LA32 and LA64. NFC.

Author: gonglingqin Date: 2022-12-08T16:24:45+08:00 New Revision: 579f3f0606c351e9a939e1265d61cb9ace2adac8 URL: https://github.com/llvm/llvm-project/commit/579f3f0606c351e9a939e1265d61cb9ace2adac8 DIFF: https://github.com/llvm/llvm-project/commit/579f3f0606c351e9a939e1265d61cb9ace2adac8.diff L

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.h:119 + bool hasBFloat16Type() const override { return isAMDGCN(getTriple()); } + const char *getBFloat16Mangling() const override { return "u6__bf16"; }; + arsenm wrote: > Pierre-vh wr

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

isuckatcs added a comment. > If CFG can be updated so that the > synthesized variables occur in the block *before* the DeclStmt containing the > DecompositionDecl, then we can drop the workaround that is included in this > patch. I'm not sure that this is possible. If you look at the AST of the

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 481190. tbaeder added a comment. Remove conversion in `Floating::add()` and tests that relied on it. Compound assignment operators can be properly implemented later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org

[clang] a96a6ed - Implement CWG2631

Author: Corentin Jabot Date: 2022-12-08T10:32:54+01:00 New Revision: a96a6ed83230265f3eab09a94f0e9525d05f8a74 URL: https://github.com/llvm/llvm-project/commit/a96a6ed83230265f3eab09a94f0e9525d05f8a74 DIFF: https://github.com/llvm/llvm-project/commit/a96a6ed83230265f3eab09a94f0e9525d05f8a74.diff

[PATCH] D136554: Implement CWG2631

This revision was automatically updated to reflect the committed changes. Closed by commit rGa96a6ed83230: Implement CWG2631 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D136554?vs=479395&id=481194#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald adde

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks. You can add a `Fix: https://github.com/llvm/llvm-project/issues/59147` in the commit message, it will automatically close the github issue when you commit the patch. ==

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. In D136594#3973908 , @ckandeler wrote: > In D136594#3973812 , @sammccall > wrote: > >> For my part, I still need to understand why we want the >> `builtin`/`UserModified` modifier. (The `

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

bryanpkc updated this revision to Diff 481205. bryanpkc added a comment. Removed some more unnecessary lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsSME

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good. Add a `Fix ` in the commit message. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67 bool VisitMemberExpr(MemberExpr *E) { +// A

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 481213. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extr

[clang-tools-extra] 45659b3 - [include-cleaner] Remove filtering from UsingDecl visit.

Author: Viktoriia Bakalova Date: 2022-12-08T10:23:55Z New Revision: 45659b3bd98ea3b8ce13516bcf719669b934b9ba URL: https://github.com/llvm/llvm-project/commit/45659b3bd98ea3b8ce13516bcf719669b934b9ba DIFF: https://github.com/llvm/llvm-project/commit/45659b3bd98ea3b8ce13516bcf719669b934b9ba.diff

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45659b3bd98e: [include-cleaner] Remove filtering from UsingDecl visit. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67 bool VisitMemberExpr(MemberExpr *E) { +// A member expr implies a usage of the class type hokein wrote: > while reading it again, I realize that there is anot

[clang-tools-extra] d03e9f8 - [include-cleaner] Handle base class member access from derived class.

Author: Viktoriia Bakalova Date: 2022-12-08T10:39:18Z New Revision: d03e9f8fb0741a510308be09b29a13d0a66a6e41 URL: https://github.com/llvm/llvm-project/commit/d03e9f8fb0741a510308be09b29a13d0a66a6e41 DIFF: https://github.com/llvm/llvm-project/commit/d03e9f8fb0741a510308be09b29a13d0a66a6e41.diff

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03e9f8fb074: [include-cleaner] Handle base class member access from derived class. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D139087?vs=480422&id=481217#toc Repository:

[clang-tools-extra] 7fd8387 - [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

Author: Carlos Galvez Date: 2022-12-08T11:40:50Z New Revision: 7fd8387917167d9cb4bab14a8548f0f78b0eaa79 URL: https://github.com/llvm/llvm-project/commit/7fd8387917167d9cb4bab14a8548f0f78b0eaa79 DIFF: https://github.com/llvm/llvm-project/commit/7fd8387917167d9cb4bab14a8548f0f78b0eaa79.diff LOG:

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fd838791716: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] cebc348 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2022-12-08T11:44:18Z New Revision: cebc348f6735b1fb5607e408dfe2e4d34abe0002 URL: https://github.com/llvm/llvm-project/commit/cebc348f6735b1fb5607e408dfe2e4d34abe0002 DIFF: https://github.com/llvm/llvm-project/commit/cebc348f6735b1fb5607e408dfe2e4d34abe0002.diff LOG:

[clang-tools-extra] 71a014f - [clangd] Add a newline-eof to the system-include-extractor.test

Author: Haojian Wu Date: 2022-12-08T12:48:05+01:00 New Revision: 71a014fe9e92db40279f3901c9f03a048ec4da3f URL: https://github.com/llvm/llvm-project/commit/71a014fe9e92db40279f3901c9f03a048ec4da3f DIFF: https://github.com/llvm/llvm-project/commit/71a014fe9e92db40279f3901c9f03a048ec4da3f.diff LO

[clang] e321c53 - [C2x] Relaxing requirements for va_start

Author: Aaron Ballman Date: 2022-12-08T07:36:07-05:00 New Revision: e321c53f7bb8d61f64b33e8b1f6a97eb32eaaa69 URL: https://github.com/llvm/llvm-project/commit/e321c53f7bb8d61f64b33e8b1f6a97eb32eaaa69 DIFF: https://github.com/llvm/llvm-project/commit/e321c53f7bb8d61f64b33e8b1f6a97eb32eaaa69.diff

[PATCH] D139436: [C2x] Relaxing requirements for va_start

This revision was automatically updated to reflect the committed changes. Closed by commit rGe321c53f7bb8: [C2x] Relaxing requirements for va_start (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139436/new/ https://review

[clang] 67b72a2 - [tooling] use std::optional in tooling StandardLibrary.h/.cpp, NFC

Author: Haojian Wu Date: 2022-12-08T13:49:09+01:00 New Revision: 67b72a28903734372972740adb4a9ccc7626cb35 URL: https://github.com/llvm/llvm-project/commit/67b72a28903734372972740adb4a9ccc7626cb35 DIFF: https://github.com/llvm/llvm-project/commit/67b72a28903734372972740adb4a9ccc7626cb35.diff LO

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. @tahonermann Do you want to take a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 ___ cfe-commits mailing list cfe-comm

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. @tahonermann Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

aaron.ballman added a comment. LGTM as far as the functional changes go, but this should have a release note and a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 __

[PATCH] D139113: [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace

carlosgalvezp updated this revision to Diff 481257. carlosgalvezp added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 Files: clang-tools-extra/clang-tidy/misc/UseAnonymousNamespaceCh

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. @abidmalikwaterloo It seems you missed a few of the previous comments. Please fix these so that we can approve. Comment at: mlir/include/mlir

[PATCH] D139006: [UpdateTestChecks] Match define for labels

sebastian-ne added a comment. I guess this is fine to merge. I’ll leave it for a day in case someone has more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139006/new/ https://reviews.llvm.org/D139006 ___

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri added a subscriber: nikic. lebedev.ri added a comment. In D139006#3981326 , @sebastian-ne wrote: > I guess this is fine to merge. I’ll leave it for a day in case someone has > more comments. I guess, we could be pedantic and post an RFC to d

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. Thanks for clarifying the issues here. A few thoughts: 1. Thanks for clarifying about the blank lines. I was wondering how to read that and I think that fills in an important missing detail for me. 2. I'm particularly interested in the case of tuple-like containers, wh

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 481264. massberg added a comment. Use isLocalVarDecl to check if we have a local variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/include/cla

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm created this revision. arsenm added reviewers: mibintc, john.brawn, kpn, jcranmer-intel, sepavloff, zahiraam. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The attribute is a proper enum attribute, strictfp. We were getting strictfp

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

Szelethus added a comment. In D135360#3862260 , @martong wrote: > In D135360#3839890 , @balazske > wrote: > >> I found some anomalies during development: >> >> - If the checker **StdCLibraryFunctions** is added a

[PATCH] D139450: Warn about unsupported ibmlongdouble

nikic added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:74 +const Driver &D, +const llvm::opt::ArgList &Args) const { + if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx)) I don't think this formatting is right. You

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske added a comment. My current approach is that the POSIX is more strict than the C standard (POSIX allows a subset of what C allows). I do not see (errno related) contradiction between these standards (except initialization to zero of errno missing from POSIX, and possible negative value

[PATCH] D112932: [WIP] Use llvm.is_fpclass to implement FP classification functions

qiucf added a comment. Herald added a project: All. This patch looks good and `llvm.is.fpclass` will by default be expanded (except SystemZ which has their own lowering). Is there any blocker for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

pengfei requested changes to this revision. pengfei added a comment. This revision now requires changes to proceed. The use of `min-legal-vector-width` doesn't look great to me either. I'm more than glad if we can remove it totally without any user perceivable affects. I cannot agree with this ch

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 481271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. Gabor -- An alternative solution to this problem, assuming the current structure of the CFG, is to add a map to the `Environment` of type `VarDecl` -> `BindingDecl` that registers `BindingDecl`s in need of initialization. Then, I could modify the `DeclStmt` interpretati

[clang] 23e1078 - Add distinguished content to the empty test headers.

Author: Haojian Wu Date: 2022-12-08T16:27:04+01:00 New Revision: 23e1078a2fee686e54f1da93de20afc01c47f25d URL: https://github.com/llvm/llvm-project/commit/23e1078a2fee686e54f1da93de20afc01c47f25d DIFF: https://github.com/llvm/llvm-project/commit/23e1078a2fee686e54f1da93de20afc01c47f25d.diff LO

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added a comment. Thanks for the patch! But does libc++ support to be built with `-mabi=ieeelongdouble` now? (like libstdc++, if it works correctly, it should co-exist and be linked with different long double ABIs) Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:96

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. This is ready to land and I'd appreciate feedback from one of the authors. Anyone else I should add for review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td:49 + CCIfType<[bf16], CCBitConvertToType>, + CCIfType<[v2bf16], CCBitConvertToType>, CCIfNotInReg arsenm wrote: > > Without being added to a register class, all the tablegen changes should

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

saudi created this revision. saudi added reviewers: thakis, rnk, thieta. saudi added a project: clang. Herald added a project: All. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Those 2 pragmas are ignored by MSVC when not compiling with `/CLR`, which clang does

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

isuckatcs added a comment. > I'm particularly interested in the case of tuple-like containers, which is a > little different (though I think the same point holds) `std::pair<>` is actually tuple-like if that's what you meant. Only tuple-like types have holding vars inside a `DecompositionDecl`.

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

nikic added a comment. Checking back here again on whether there is any progress on finding the root cause of the issue. If no progress is expected in the near future, I'd ask for this patch to be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 4a68bab - [clang-doc] Add template support.

Author: Brett Wilson Date: 2022-12-08T08:02:02-08:00 New Revision: 4a68babd9973f043fd3e40f159fbb990880606a6 URL: https://github.com/llvm/llvm-project/commit/4a68babd9973f043fd3e40f159fbb990880606a6 DIFF: https://github.com/llvm/llvm-project/commit/4a68babd9973f043fd3e40f159fbb990880606a6.diff

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a68babd9973: [clang-doc] Add template support. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D13

[PATCH] D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged

thieta added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1960 +/// "\#pragma managed" +/// "\#pragma managed(...)" I don't see the other comments in this file having `"\#` I think you can drop that. Also two `/` for the comments, not three. Reposit

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

craig.topper added a comment. The attribute is supposed to tell the backend if there were any vectors used in the C source code and how big they were. A value of 0 means the code didn't contain any vectors. The backend assumes lack of the attributes means the IR didn't come from clang and can'

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom added a comment. In D139450#3981486 , @qiucf wrote: > Thanks for the patch! But does libc++ support to be built with > `-mabi=ieeelongdouble` now? @qiucf libc++ can be built with `-mabi=ieeelongdouble`, but it supports only a single long double

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 481295. massberg added a comment. Reuse existing error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/lib/Sema/SemaTemplate.cpp clang/test

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. In D139400#3974624 , @shafik wrote: > It looks like we have an existing message for the regular function case Thanks! We can indeed reuse this error message. In D139400#3974654 , @shafi

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

arsenm created this revision. arsenm added reviewers: fhahn, scanon. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Just copy paste from the other functions. I also need fma, but the current code seems to assume 1 or 2 arguments. https://r

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit added a comment. @MaskRay How may I get commit permissions if I may ask? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139547/new/ https://reviews.llvm.org/D139547 ___ cfe-commits mailing li

[PATCH] D139629: clang: Stop emitting "strictfp"

kpn added a comment. It looks like clang does have at least one test that checks for the strictfp attribute on function definitions. We also have a number that test for the strictfp attribute on function calls. So I think our test coverage is in good shape. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/RISCVTargetParser.def:22 PROC(SIFIVE_U74, {"sifive-u74"}, FK_64BIT, {"rv64gc"}) +PROC(SCR1_BASE, {"scr1-base"}, FK_NONE, {"rv32ic"}) +PROC(SCR1_MAX, {"scr1-max"}, FK_NONE, {"rv32imc"}) Alphabeti

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

craig.topper added a comment. Should the names be prefixed with "syntacore-". I assume there could be an SCR2, etc. in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139302/new/ https://reviews.llvm.org/D139302

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 updated this revision to Diff 481319. jyu2 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl added a subscriber: jrbyrnes. yaxunl added a comment. In D135269#3981561 , @nikic wrote: > Checking back here again on whether there is any progress on finding the root > cause of the issue. If no progress is expected in the near future, I'd ask

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

dblaikie reopened this revision. dblaikie added a comment. This revision is now accepted and ready to land. (just a side note I discovered while looking into this: seems someone else had this idea before & came to similar conclusions: https://reviews.llvm.org/D104118#2840490 ) Repository: rG

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 481339. to268 added a comment. Removed compound literal diagnostic in ParseExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/include/clang/Basic/Diagn

[PATCH] D139629: clang: Stop emitting "strictfp"

zahiraam added a comment. Can you please be more verbose in your summary? This change is related to the use of -ffp-exception-behavior=strict right? This attribute is set here https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L987 but under a condition. Is th

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction &CGF, SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool Emit

[clang] d694e24 - Update the status of a few more C DRs

Author: Aaron Ballman Date: 2022-12-08T13:19:29-05:00 New Revision: d694e2490af8b2e92c79b2c1b543bcc4bb3981d1 URL: https://github.com/llvm/llvm-project/commit/d694e2490af8b2e92c79b2c1b543bcc4bb3981d1 DIFF: https://github.com/llvm/llvm-project/commit/d694e2490af8b2e92c79b2c1b543bcc4bb3981d1.diff

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729 + if (!Opts.ProfileInstrumentUsePath.empty()) { +auto FS = llvm::vfs::getRealFileSystem(); +setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags); ---

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. In D139629#3981991 , @zahiraam wrote: > Can you please be more verbose in your summary? This change is related to the > use of -ffp-exception-behavior=strict right? > This attribute is set here > https://github.com/llvm/llvm-pro

[PATCH] D139629: clang: Stop emitting "strictfp"

arsenm added a comment. In D139629#3982052 , @arsenm wrote: > In D139629#3981991 , @zahiraam > wrote: > >> Can you please be more verbose in your summary? This change is related to >> the use of -ffp-exception-b

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang created this revision. yfyang added a reviewer: jyknight. Herald added a subscriber: pengfei. Herald added a project: All. yfyang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Thread sanitizer for x86_64 architecutre is sup

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool WasAlignedWithStartOfNextLine = false; owenpan wrote: > Don't

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

jrbyrnes added a comment. In D135269#3981856 , @yaxunl wrote: > In D135269#3981561 , @nikic wrote: > >> Checking back here again on whether there is any progress on finding the >> root cause of the issue. If no p

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Thanks for the change. The description is a bit misleading, this would be better: Allow TSan in clang driver for X86_64 WatchOS simulator. It was already functional, and Apple's dow

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione created this revision. kastiglione added a reviewer: jansvoboda11. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Without this change, the use of `-Rmodule-build` and `-Rmodule-import` o

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:334 llvm::Value *emitUpdateLocation(CodeGenFunction &CGF, SourceLocation Loc, - unsigned Flags = 0); + unsigned Flags = 0, bool EmitLoc

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. the following now produces a link error: $ cat /tmp/a.cc #include #include struct S { std::map a; }; using T = std::array; class C { T t{}; }; int main() { C c; } $ ./build/rel/bin/clang++ -o /dev/null /tm

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl added a comment. In D135269#3982103 , @jrbyrnes wrote: > In D135269#3981856 , @yaxunl wrote: > >> In D135269#3981561 , @nikic wrote: >> >>> Checking back here again

[PATCH] D139166: [OPENMP51] Codegen support for error directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139166/new/ https://reviews.llvm.org/D139166 ___

[clang] 90d4cbb - [clang] Add test for CWG418

Author: Vlad Serebrennikov Date: 2022-12-08T21:57:07+03:00 New Revision: 90d4cbb87ce297d93159d39528767f5f46aa4da4 URL: https://github.com/llvm/llvm-project/commit/90d4cbb87ce297d93159d39528767f5f46aa4da4 DIFF: https://github.com/llvm/llvm-project/commit/90d4cbb87ce297d93159d39528767f5f46aa4da4.

[PATCH] D139429: [clang] Add test for CWG418

This revision was automatically updated to reflect the committed changes. Closed by commit rG90d4cbb87ce2: [clang] Add test for CWG418 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429

[clang] 49c86ea - Revert "Implement CWG2631"

Author: Corentin Jabot Date: 2022-12-08T19:57:58+01:00 New Revision: 49c86eab627b0c4089c8d25dac48728c656448a9 URL: https://github.com/llvm/llvm-project/commit/49c86eab627b0c4089c8d25dac48728c656448a9 DIFF: https://github.com/llvm/llvm-project/commit/49c86eab627b0c4089c8d25dac48728c656448a9.diff

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

benlangmuir added subscribers: akyrtzi, benlangmuir. benlangmuir added inline comments. Comment at: clang/include/clang-c/Documentation.h:549 +typedef struct CXAPISetImpl *CXAPISet; + @dang please document what this type represents. @akyrtzi what's the preferr

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

jansvoboda11 added a comment. Nice. It would be nice to have tests for this, though. Also, do you think this should be configurable on the command line? I'm thinking about users that are trying to debug their own modular code, but don't really care what happens in the SDK. Repository: rG LL

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

anton-afanasyev added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSCR1.td:14 +// This model covers SCR1_CFG_RV32IMC_MAX configuration (scr1-max). +// SCR1_CFG_RV32EC_MIN (scr1-min) and SCR1_CFG_RV32IC_BASE (scr1-base) +// configurations have essentially same sche

[clang] 05dbdb0 - Revert "[InstCombine] canonicalize trunc + insert as bitcast + shuffle, part 1 (2nd try)"

Author: Sanjay Patel Date: 2022-12-08T14:16:46-05:00 New Revision: 05dbdb0088a3f5541d9e91c61a564d0aa4704f4f URL: https://github.com/llvm/llvm-project/commit/05dbdb0088a3f5541d9e91c61a564d0aa4704f4f DIFF: https://github.com/llvm/llvm-project/commit/05dbdb0088a3f5541d9e91c61a564d0aa4704f4f.diff

[PATCH] D139653: [clang] Set ShowInSystemHeader for module-build and module-import remarks

kastiglione added a comment. > Also, do you think this should be configurable on the command line? Do you have a flag in mind? I have worked around the current behavior with `-Wno-system-header`, but there are two problems with that: first, it's not obvious that it's needed (I had to debug clan

[clang] 4a1ccfe - When merging lambdas, keep track of the capture lists from each version.

Author: Richard Smith Date: 2022-12-08T11:37:00-08:00 New Revision: 4a1ccfe8a3cfd4569bc962a38b6117a9a2b8ad21 URL: https://github.com/llvm/llvm-project/commit/4a1ccfe8a3cfd4569bc962a38b6117a9a2b8ad21 DIFF: https://github.com/llvm/llvm-project/commit/4a1ccfe8a3cfd4569bc962a38b6117a9a2b8ad21.diff

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

jdoerfert added a comment. Isn't this (inherently) X86 specific? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139627/new/ https://reviews.llvm.org/D139627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

craig.topper added a comment. In D139627#3982349 , @jdoerfert wrote: > Isn't this (inherently) X86 specific? Yes it is. We could qualify the attribute emission with the targeting being X86? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139627/n

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3981475 , @pengfei wrote: > The use of `min-legal-vector-width` doesn't look great to me either. I'm more > than glad if we can remove it totally without any user perceivable affects. > I cannot agree with this change b

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3982385 , @arsenm wrote: >> [1] `"min-legal-vector-width" = "0"` was clear to indicate there are only >> scalar operations. > > It's not remotely clear what this means It also doesn't mean that, because the IR doesn't

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

arsenm added a comment. In D139627#3982381 , @craig.topper wrote: > In D139627#3982349 , @jdoerfert > wrote: > >> Isn't this (inherently) X86 specific? > > Yes it is. We could qualify the attribute emission with

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138571/new/ https://reviews.llvm.org/D138571 ___

  1   2   >