[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske added a reviewer: whisperity. balazske added a comment. Herald added a subscriber: rnkovacs. This check is not about removing any use of `new`. It is only about the memory leak problem that is easy to detect and mentioned in the CppCoreGuidelines and CERT MEM52-CPP rules. If it is moved

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.h:119 + bool hasBFloat16Type() const override { return isAMDGCN(getTriple()); } + const char *getBFloat16Mangling() const override { return "u6__bf16"; }; + Pierre-vh wrote: > arsenm wr

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. @lebedev.ri If you are happy with the patch, would you mind approving it? Or do you have additional comments that should be addressed? The patch does not need to be approved by the Code Owner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 62f20f5 - [PowerPC] Support test data class intrinsic of 128-bit float

Author: Qiu Chaofan Date: 2022-12-07T16:44:12+08:00 New Revision: 62f20f51ce39560e439f522536e0bf1e2f1f9fa9 URL: https://github.com/llvm/llvm-project/commit/62f20f51ce39560e439f522536e0bf1e2f1f9fa9 DIFF: https://github.com/llvm/llvm-project/commit/62f20f51ce39560e439f522536e0bf1e2f1f9fa9.diff L

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62f20f51ce39: [PowerPC] Support test data class intrinsic of 128-bit float (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480800. massberg added a comment. Simplify code and update description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139125/new/ https://reviews.llvm.org/D139125 Files: clang/include/clang/Sema/Sema.h cl

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added a comment. The "strange" test failures that showed up earlier were probably caused by a bug that is fixed in the D137722 . I just read that this patch is rebased to D137722 too, fixed the dependency stack. There

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType, Ellip

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb6f47e9ea4: [SVE] Change some bfloat lane intrinsics to use i32 immediates (authored by david-arm). Changed prior to commit: https://reviews.llv

[clang] bfb6f47 - [SVE] Change some bfloat lane intrinsics to use i32 immediates

Author: David Sherwood Date: 2022-12-07T09:19:54Z New Revision: bfb6f47e9ea463555833934ef714b03ee78eb01e URL: https://github.com/llvm/llvm-project/commit/bfb6f47e9ea463555833934ef714b03ee78eb01e DIFF: https://github.com/llvm/llvm-project/commit/bfb6f47e9ea463555833934ef714b03ee78eb01e.diff LOG

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg added a comment. In D139400#3974654 , @shafik wrote: > It looks like the existing diagnostic is issued by > `CheckDefaultArgumentVisitor`. I think you can reuse it here but not 100% on > that. Thanks for the pointer! I will have a look. Repo

[PATCH] D139397: [LoongArch] Add testcases for privileged intrinsic macros

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139397/new/ https://reviews.llvm.org/D139397 __

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang/include/clang/Sema/Sema.h:7101 + void addInitCapture(sema::LambdaScopeInfo *LSI, VarDecl *Var, + bool isRe

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

hokein created this revision. hokein added reviewers: dmgreen, reames. Herald added a subscriber: hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This fixes an infinite compiling loop caused by

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

dmgreen added a reviewer: kparzysz. dmgreen added a comment. Can you add the test cases from D137140 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 ___

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

hokein updated this revision to Diff 480843. hokein added a comment. add a testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 Files: llvm/lib/Target/Hexagon/HexagonISelLowering.cpp llvm/lib/Targ

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

hokein added a comment. In D139525#3977799 , @dmgreen wrote: > Can you add the test cases from D137140 ? Added one (I'm not familiar with this part of code, suggestions are welcome). Repository: rG LLVM Github Monore

[PATCH] D139429: [clang] Add test for CWG418

Endill updated this revision to Diff 480848. Endill edited the summary of this revision. Endill added a comment. Add example from [over.match.best]/4, and mark CWG418 as not available CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 Files: cl

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer added a comment. Mind moving the test case from `llvm/test/CodeGen/AArch64` to `llvm/test/CodeGen/Hexagon`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 ___

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

hokein updated this revision to Diff 480850. hokein added a comment. move to a new directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/D139525 Files: llvm/lib/Target/Hexagon/HexagonISelLowering.cpp llvm

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

hokein added a comment. In D139525#3977834 , @bkramer wrote: > Mind moving the test case from `llvm/test/CodeGen/AArch64` to > `llvm/test/CodeGen/Hexagon`? sure, done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, thanks. Let's land this now to unbreak things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139525/new/ https://reviews.llvm.org/

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2215149aeb7: Add implementation isTargetCanonicalConstantNode for hexagon. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D139525: Add implementation isTargetCanonicalConstantNode for hexagon.

hokein added inline comments. Comment at: llvm/test/CodeGen/Hexagon/infinite-loop.ll:1 +; RUN: ll < %s + oops, forget to fix typo here (to verify the test), fixed in 3abdd9b91bc17541e78de6251043e178efe0e3ee. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D138511: [CodeGen][AArch64] Fix AArch64ABIInfo::EmitAAPCSVAArg crash with empty record type in variadic arg

yronglin updated this revision to Diff 480853. yronglin added a comment. Rebase and apply changes from https://reviews.llvm.org/D138295 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138511/new/ https://reviews.llvm.org/D138511 Files: clang/lib/C

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

ilya-biryukov updated this revision to Diff 480857. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Add a comment to CMakelists.txt explaining motivation for the option - Add #include "Feature.h" - Revert changes to the order of compiler flags to keep this change m

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b325088d14: [clangd] Allow to build Clangd without decision forest (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] c9b3250 - [clangd] Allow to build Clangd without decision forest

Author: Ilya Biryukov Date: 2022-12-07T13:52:22+01:00 New Revision: c9b325088d14a816b101857eecd1042335aad4e0 URL: https://github.com/llvm/llvm-project/commit/c9b325088d14a816b101857eecd1042335aad4e0 DIFF: https://github.com/llvm/llvm-project/commit/c9b325088d14a816b101857eecd1042335aad4e0.diff

[clang-tools-extra] cdfce10 - [clangd] Fix a typo in -ranking-model documentation. NFC

Author: Ilya Biryukov Date: 2022-12-07T13:53:14+01:00 New Revision: cdfce10b28b158d2dcfeed289213eda1ad64f236 URL: https://github.com/llvm/llvm-project/commit/cdfce10b28b158d2dcfeed289213eda1ad64f236 DIFF: https://github.com/llvm/llvm-project/commit/cdfce10b28b158d2dcfeed289213eda1ad64f236.diff

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom updated this revision to Diff 480858. tuliom added a comment. I'm attaching a new version of the patch. > Can you please upload the patch with full context (-U9)? @nikic Done! > The assumption here is that libc++ is being compiled with a compiler that has > the same ieeelongdouble d

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

ilya-biryukov added a comment. I have sent a follow-up NFC change to fix a typo in the documentation of `--ranking-model=heuristics`. Note that I decided to avoid changing the order of options for `--ranking-model` in the documentation, this didn't seem important. Repository: rG LLVM Github

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

dang marked 6 inline comments as done. dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:234 ReadOnly = 1, -Class = 1 << 1, Dynamic = 1 << 2, zixuw wrote: > What's the reason for refactoring out instance vs. class property

[PATCH] D139185: [clang][Interp] Use placement new to construct opcode args into vector

tbaeder updated this revision to Diff 480873. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139185/new/ https://reviews.llvm.org/D139185 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/PrimType.h clang/lib/AST/Interp/So

[clang] cfd4422 - [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH

Author: Daniel Kiss Date: 2022-12-07T14:52:55+01:00 New Revision: cfd44221e3e1783c0f44d5b1694dfbe84187246a URL: https://github.com/llvm/llvm-project/commit/cfd44221e3e1783c0f44d5b1694dfbe84187246a DIFF: https://github.com/llvm/llvm-project/commit/cfd44221e3e1783c0f44d5b1694dfbe84187246a.diff L

[PATCH] D139445: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfd44221e3e1: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH (authored by danielkiss). Herald added a project: clang. Herald added a subscri

[PATCH] D139534: [analyzer] Don't escape local static memregions on bind

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, Szelethus. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revisio

[clang] 7925e28 - Revert "[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH"

Author: Daniel Kiss Date: 2022-12-07T15:19:31+01:00 New Revision: 7925e2828e3290f2851f29aec66c882597f8bc61 URL: https://github.com/llvm/llvm-project/commit/7925e2828e3290f2851f29aec66c882597f8bc61 DIFF: https://github.com/llvm/llvm-project/commit/7925e2828e3290f2851f29aec66c882597f8bc61.diff L

Re: [clang] 7925e28 - Revert "[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH"

Reminder to please always mention the reason for the revert in the commit message. On Wed, Dec 7, 2022 at 5:20 PM Daniel Kiss via cfe-commits wrote: > > > Author: Daniel Kiss > Date: 2022-12-07T15:19:31+01:00 > New Revision: 7925e2828e3290f2851f29aec66c882597f8bc61 > > URL: > https://github.com/

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. There is a problem in one of the tests with `DontModifyStdNamespaceCheck`: TEST 'Clang Tools :: clang-tidy/checkers/cert/dcl58-cpp.cpp' FAILED Script: -- : 'RUN: at line 1'; /usr/bin/python3.8 /home/tcwg-buildbot/work

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

lebedev.ri added a comment. In D139197#3977370 , @carlosgalvezp wrote: > @lebedev.ri If you are happy with the patch, would you mind approving it? Or > do you have additional comments that should be addressed? The patch does not > need to be approved b

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * tentzen wrote: > lebedev.ri wrote: > > efriedma wrote

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

uweigand added a comment. In D139444#3975182 , @probinson wrote: > The changes in this patch assume that there aren't any possible suffixes > after the `-zos` part of the triple (no version numbers, like you might find > with darwin or macos, and nothin

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. This test fails because `FirstDeclMatcher` does not find a node, probably `FromNs`. Probably adding `hasName("x")` fixes the problem. TEST_P(ASTImporterOptionSpecificTestBase, ImportCorrectTemplatedDecl) { auto Code = R"( namespace x {

[clang] edbea62 - [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

Author: Jens Massberg Date: 2022-12-07T16:00:58+01:00 New Revision: edbea62f72f7b9a5ee19c709d675d6083789c71f URL: https://github.com/llvm/llvm-project/commit/edbea62f72f7b9a5ee19c709d675d6083789c71f DIFF: https://github.com/llvm/llvm-project/commit/edbea62f72f7b9a5ee19c709d675d6083789c71f.diff

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedbea62f72f7: [clang] Correctly handle by-reference capture with an initializer that is a… (authored by massberg). Repository: rG LLVM Github Mono

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

balazske added a comment. The other tests except **Clang::complete-preamble.cpp** and **Clang::preamble.c** fail with this assertion: ./llvm/clang/lib/Serialization/ASTWriter.cpp:5455: clang::serialization::DeclID clang::ASTWriter::getDeclID(const clang::Decl *): Assertion `DeclIDs.find(D) !

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

arichardson updated this revision to Diff 480900. arichardson added a comment. use opaque pointers in the new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138722/new/ https://reviews.llvm.org/D138722 Files: clang/lib/CodeGen/CGBuiltin.cpp

[clang] cb3ea52 - Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

Author: Hans Wennborg Date: 2022-12-07T16:12:38+01:00 New Revision: cb3ea52a5ae5178b8cd257bd61c6e05d9a186b4d URL: https://github.com/llvm/llvm-project/commit/cb3ea52a5ae5178b8cd257bd61c6e05d9a186b4d DIFF: https://github.com/llvm/llvm-project/commit/cb3ea52a5ae5178b8cd257bd61c6e05d9a186b4d.diff

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3ea52a5ae5: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank() (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

daltenty accepted this revision. daltenty added a comment. New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename parameter in Sema::addInitCapture as proposed in review of Sema::addInit

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. For the test cases where we should be able to prove the case but return `Unknown` instead, should be marked by a FIXME stating the expected value. Approximating a concrete value with `Unknown` is (almost) always correct. So, in this case, you don't need to go and fix th

[clang] 7d40baa - [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH

Author: Daniel Kiss Date: 2022-12-07T16:30:16+01:00 New Revision: 7d40baa82b1f272f68de63f3c4f68d970bdcd6ed URL: https://github.com/llvm/llvm-project/commit/7d40baa82b1f272f68de63f3c4f68d970bdcd6ed DIFF: https://github.com/llvm/llvm-project/commit/7d40baa82b1f272f68de63f3c4f68d970bdcd6ed.diff L

[clang] bdfa310 - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-07T16:32:37+01:00 New Revision: bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81 URL: https://github.com/llvm/llvm-project/commit/bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81 DIFF: https://github.com/llvm/llvm-project/commit/bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81.d

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. In D139197#3978174 , @lebedev.ri wrote: > In D139197#3977370 , @carlosgalvezp > wrote: > >> @lebedev.ri If you are happy with the patch, would you mind approving it? Or >> do you

[PATCH] D137343: [clang] add -Wvla-stack-allocation

inclyc added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D139429: [clang] Add test for CWG418

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, thank you for all your efforts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 ___ cfe-c

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138614/new/ https://reviews.llvm.org/D138614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. Wondering if we could deduplicate the headers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139503/new/ https://reviews.llvm.org/D13950

[PATCH] D139429: [clang] Add test for CWG418

Endill added a comment. Thanks to all of you for your time to review this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139429/new/ https://reviews.llvm.org/D139429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel created this revision. ymandel added a reviewer: xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. This patch adds interpretation of binding declaratio

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. I think this is obsolete now that D139107 is in, right? Marking as "request changes" to get it off my dashboard. Ideally you'll hit "Abandon" (whic

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam abandoned this revision. thesamesam added a comment. Done, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136283/new/ https://reviews.llvm.org/D136283 ___ cfe-commits mailing list cfe-c

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.h:119 + bool hasBFloat16Type() const override { return isAMDGCN(getTriple()); } + const char *getBFloat16Mangling() const override { return "u6__bf16"; }; + Pierre-vh wrote: > Pierre-vh wr

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. BTW, feel free to send small changes like these without review. The common jargon for them in LLVM is NFC (non-functional change) Repository: rG LLVM Github Monorepo CH

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td:49 + CCIfType<[bf16], CCBitConvertToType>, + CCIfType<[v2bf16], CCBitConvertToType>, CCIfNotInReghttps://reviews.llvm.org/D139398/new/ https://reviews.llvm.org/D139398 ___

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

sepavloff added a comment. Thank you for working on this! Is there any reason why we should keep the old intrinsic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139507/new/ https://reviews.llvm.org/D139507 ___

[clang] 390029b - [clang][dataflow] Support (in)equality operators in `optional` model.

Author: Yitzhak Mandelbaum Date: 2022-12-07T16:24:49Z New Revision: 390029be8946cac807e8fc978b9cf3790e7456cc URL: https://github.com/llvm/llvm-project/commit/390029be8946cac807e8fc978b9cf3790e7456cc DIFF: https://github.com/llvm/llvm-project/commit/390029be8946cac807e8fc978b9cf3790e7456cc.diff

[PATCH] D139360: [clang][dataflow] Support (in)equality operators in `optional` model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG390029be8946: [clang][dataflow] Support (in)equality operators in `optional` model. (authored by ymandel). Repository: rG LLVM Github Monorepo CH

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. @njames93 @JonasToth @LegalizeAdulthood Do you have any comments that I should address? If not, could you approve the patch? To recap: this check is a few days old (I added it myself). I realized there's functionality that shouldn't be here so I'm just removing it

[clang] 40ade84 - Revert "Store OptTable::Info::Name as a StringRef"

Author: serge-sans-paille Date: 2022-12-07T17:29:53+01:00 New Revision: 40ade845be698355b230abc19c7a76b200188772 URL: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772 DIFF: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772.d

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note describing the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139197/new/ https://re

[PATCH] D139547: [NFC] Correct argument comment typo

gAlfonso-bit created this revision. gAlfonso-bit added a reviewer: MaskRay. gAlfonso-bit added projects: clang, LLVM. Herald added a subscriber: StephenFan. Herald added a project: All. gAlfonso-bit requested review of this revision. Herald added a subscriber: cfe-commits. For Darwin, the boolean

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

RKSimon added a comment. In D139507#3978449 , @sepavloff wrote: > Thank you for working on this! > > Is there any reason why we should keep the old intrinsic? I'm not clear on the general policy, but for x86 we tend to provide bc of old intrinsics/sigta

[PATCH] D139541: Fix parameter name in Sema::addInitCapture to ByRef.

shafik added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:892-894 + LSI->addCapture(Var, /*isBlock*/ false, ByRef, /*isNested*/ false, Var->getLocation(), SourceLocation(), Var->getType(), /*Invalid*/ false); T

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

thakis added a comment. In D137269#3925163 , @thakis wrote: > Heads-up: This very visibly broke web page rendering in Chromium (but only > when using LTO) (https://crbug.com/1383873) . Not clear yet if this exposed > UB on our end or not. After looking

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:109 +Floating RHS = B; +if (!A.compatibleWith(B)) + RHS = B.toSemantics(A, RM); tbaeder wrote: > sepavloff wrote: > > Do we really need this check? In AST operands of additi

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. In D139197#3978488 , @aaron.ballman wrote: > LGTM, though please add a release note describing the change The original check is just a few days old. It didn't exist in the previous release. Should I still add a comment ab

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

carlosgalvezp added a comment. PS thanks a lot for the review! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139197/new/ https://reviews.llvm.org/D139197 ___ cfe-commits mailing list cfe-commits@lists

[clang-tools-extra] 0f6dbb5 - [clang-doc] Add template support.

Author: Brett Wilson Date: 2022-12-07T09:48:13-08:00 New Revision: 0f6dbb5f164662c3e6a167a89e7a89f07c60e32b URL: https://github.com/llvm/llvm-project/commit/0f6dbb5f164662c3e6a167a89e7a89f07c60e32b DIFF: https://github.com/llvm/llvm-project/commit/0f6dbb5f164662c3e6a167a89e7a89f07c60e32b.diff

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6dbb5f1646: [clang-doc] Add template support. (authored by brettw). Changed prior to commit: https://reviews.llvm.org/D139154?vs=480560&id=480960#toc Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D139197: [clang-tidy] Do not warn about redundant static in misc-use-anonymous-namespace

aaron.ballman added a comment. In D139197#3978761 , @carlosgalvezp wrote: > In D139197#3978488 , @aaron.ballman > wrote: > >> LGTM, though please add a release note describing the change > > The original check i

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:572 PrioritizedCXXGlobalInits.push_back(std::make_pair(Key, Fn)); + } else if (D->hasConstantInitialization() && !(D->hasAttr())) { +OrderGlobalInitsOrStermFinalizers Key(201,

[clang-tools-extra] 91b38c6 - Revert "[clang-doc] Add template support."

Author: Brett Wilson Date: 2022-12-07T10:22:51-08:00 New Revision: 91b38c6aaddefabad2a4c959ea3865e356761ed5 URL: https://github.com/llvm/llvm-project/commit/91b38c6aaddefabad2a4c959ea3865e356761ed5 DIFF: https://github.com/llvm/llvm-project/commit/91b38c6aaddefabad2a4c959ea3865e356761ed5.diff

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

akhuang added a comment. ping @efriedma, do you mind looking at this again? thanks! Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:571 + /// Whether this function should avoid inalloca arguments. + unsigned DontInAlloca: 1; + rnk wrote: > This is an

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. arichardson marked 2 inline comments as done. Closed by commit rG9114ac67a986: Overload all llvm.annotation intrinsics for globals argument (authored by arichardson).

[clang] 9114ac6 - Overload all llvm.annotation intrinsics for globals argument

Author: Alex Richardson Date: 2022-12-07T18:29:18Z New Revision: 9114ac67a986400155b8b82013d09a9e4f48e534 URL: https://github.com/llvm/llvm-project/commit/9114ac67a986400155b8b82013d09a9e4f48e534 DIFF: https://github.com/llvm/llvm-project/commit/9114ac67a986400155b8b82013d09a9e4f48e534.diff LO

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

jrtc27 added inline comments. Comment at: clang/test/CodeGen/annotations-field.c:5 -// CHECK: private unnamed_addr constant [8 x i8] c"v_ann_{{.}}\00", section "llvm.metadata" -// CHECK: private unnamed_addr constant [8 x i8] c"v_ann_{{.}}\00", section "llvm.metadata" +// CHE

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480979. brettw added a comment. New patch with llvm::Optional converted to std::optional (previously collided with a refactor). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/cl

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480982. Amir added a comment. Avoid using perf2bolt, provide perf.data directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cma

[PATCH] D137343: [clang] add -Wvla-stack-allocation

aaron.ballman added reviewers: clang-language-wg, rjmccall. aaron.ballman added a comment. In D137343#3978313 , @inclyc wrote: > ping :) Thank you for your patience until I could get to this! I've added a few more reviewers for additional opinions on th

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu updated this revision to Diff 480990. steven_wu marked 13 inline comments as done. steven_wu added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052 Files: cl

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:164 LLVMIRGenerationRefCount(0), - Gen(CreateLLVMCodeGen(Diags, InFile, std::move(FS), HeaderSearchOpts, -PPOpts, CodeGenOpts, C, CoverageInfo)), +

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

arsenm created this revision. arsenm added a reviewer: aaron.ballman. Herald added subscribers: kosarev, jdoerfert, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. Herald added a reviewer: jdoerfert. This is the default beha

[PATCH] D136554: Implement CWG2631

aaron.ballman accepted this revision. aaron.ballman added a comment. The new changes LGTM as well and the bots seem to be happy with things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 480992. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/lib/Code

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. All my comments are addressed, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139052/new/ https://reviews.llvm.org/D139052 ___

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 480993. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase, use new callbrpad inst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.l

[PATCH] D139564: clang: Don't emit "frame-pointer"="none"

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding codegen code owners in for awareness, but in general I think this is a good cleanup. Thank you! Assuming the bots are happy, this LGTM, but please give the codegen folks a chance to speak up before landing.

  1   2   >