[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh marked an inline comment as done. Pierre-vh added inline comments. Comment at: clang/test/SemaCUDA/amdgpu-bf16.cu:9 + +__device__ void devicefn() { +} tra wrote: > We should probably also have a case verifying that actual attempt to use > `__bf16` in d

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

This revision was automatically updated to reflect the committed changes. kadircet marked 6 inline comments as done. Closed by commit rGf82f5b0507a2: [include-cleaner] Introduce symbol to location mapping (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D135953?vs=47861

[clang-tools-extra] f82f5b0 - [include-cleaner] Introduce symbol to location mapping

Author: Kadir Cetinkaya Date: 2022-12-01T09:46:05+01:00 New Revision: f82f5b0507a25cbef1cf44fa5ef481c786a40473 URL: https://github.com/llvm/llvm-project/commit/f82f5b0507a25cbef1cf44fa5ef481c786a40473 DIFF: https://github.com/llvm/llvm-project/commit/f82f5b0507a25cbef1cf44fa5ef481c786a40473.dif

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan accepted this revision. owenpan added a comment. Thanks for unstacking it! Comment at: clang/unittests/Format/FormatTestComments.cpp:66-67 const FormatStyle &Style = getLLVMStyle()) { EXPECT_EQ(Code.str(), format(Code, Style)) << "Expected code

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

HazardyKnusperkeks updated this revision to Diff 479189. HazardyKnusperkeks added a comment. Reverted the changes in the switch. We now only have a fast path. On my machine 4 consecutive runs of the clang format unittests, the last three times (as reported by gtest) are: | | Before patch

[PATCH] D137487: [clang][Interp] Start implementing builtin functions

tbaeder updated this revision to Diff 479201. tbaeder added a comment. Split `CallBI` out from `Call`, so we don't need special cases in `CheckCallable` etc. for builtin functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137487/new/ https://reviews.llvm.org/D137487 Files: clan

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This only contains the SelectionDAG implementation. Glob

[clang-tools-extra] bcdf590 - [include-cleaner] Fix build

Author: Kadir Cetinkaya Date: 2022-12-01T11:02:16+01:00 New Revision: bcdf590b81cf8cc1bb7a0e41b67e8b568843 URL: https://github.com/llvm/llvm-project/commit/bcdf590b81cf8cc1bb7a0e41b67e8b568843 DIFF: https://github.com/llvm/llvm-project/commit/bcdf590b81cf8cc1bb7a0e41b67e8b568843.dif

[PATCH] D139006: [UpdateTestChecks] Match define for labels

sebastian-ne added inline comments. Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/define_after_call.ll.expected:14 +define i32 @b(i32 %arg) { +; CHECK-LABEL: define {{[^@]+}}@b( +; CHECK-NEXT:ret i32 [[ARG:%.*]] arichardson wrote: >

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:447 + +if (FieldType->isRecordType()) { + Result &= CheckFieldsInitialized(S, OpPC, FieldPtr, FieldPtr.getRecord()); aaron.ballman wrote

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder updated this revision to Diff 479209. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139087 Fi

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv marked an inline comment as done. ilinpv added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1311 + // CPU features already initialized. + if (__aarch64_cpu_features.features) +return; danielkiss wrote: > I'd add a init value for

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 479213. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp clang-to

[PATCH] D139088: [clangd] Log diagnostics if we failed to create a preamble.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Rea

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked 4 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } kadircet wrote: >

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 479216. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments, remove excessive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D13

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1127 return false; - if (!this->emitInitGlobal(*T, *I, VD)) +} + } else { aaron.ballman wrote: > and if we have no `Gl

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder updated this revision to Diff 479219. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[clang-tools-extra] fa46e77 - [include-cleaner] Attempt two at fixing buildbots

Author: Kadir Cetinkaya Date: 2022-12-01T11:49:58+01:00 New Revision: fa46e77f17c6b699233e0a9e8b7b207c49738ba6 URL: https://github.com/llvm/llvm-project/commit/fa46e77f17c6b699233e0a9e8b7b207c49738ba6 DIFF: https://github.com/llvm/llvm-project/commit/fa46e77f17c6b699233e0a9e8b7b207c49738ba6.dif

[PATCH] D139090: [clang] Add test for CWG360

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : "CWG360 is resolved by applying access co

[PATCH] D139093: [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang-tools-extra. ASTMatchers are pulling in

[PATCH] D139090: [clang] Add test for CWG360

Endill updated this revision to Diff 479225. Endill added a comment. run make_cxx_dr_status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139090/new/ https://reviews.llvm.org/D139090 Files: clang/test/CXX/drs/dr3xx.cpp clang/www/cxx_dr_status.html Index: clang/www/cxx_dr_status.h

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

dmgreen added a comment. I can only comment on the target features part of the patch - I've been hoping it would add something similar and looks very useful in its own right. Comment at: clang/lib/Basic/Targets/AArch64.cpp:63 + switch (ArchKind) { + case llvm::AArch64::ArchK

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } VitaNuo wrote: > kadircet wrote: > > hokein wrote: > > > we

[PATCH] D139093: [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/unittests/LocateSymbolTest.cpp:60 + return true; +Out = ND; +return false; y

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:152 + case CK_FloatingToIntegral: { +llvm::RoundingMode RM = getRoundingMode(CE); +Optional ToT = classify(CE->getType()); sepavloff wrote: > According to C standard (6.3

[PATCH] D139093: [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/LocateSymbolTest.cpp:60 + return true; +Out = ND; +return false; sammccall wrote: > you might want to EXPEC

[clang-tools-extra] 4764ee6 - [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest

Author: Kadir Cetinkaya Date: 2022-12-01T12:35:34+01:00 New Revision: 4764ee6055c7ea1cd4818a2a5c496861c371660a URL: https://github.com/llvm/llvm-project/commit/4764ee6055c7ea1cd4818a2a5c496861c371660a DIFF: https://github.com/llvm/llvm-project/commit/4764ee6055c7ea1cd4818a2a5c496861c371660a.dif

[PATCH] D139093: [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG4764ee6055c7: [include-cleaner] Use RAV instead of ASTMatchers in LocateSymbolTest (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

owenpan added a comment. I ran (on macOS Ventura) the release build of clang-format 8627811 on the entire clang codebase and saw only a 0.12% reduction in runtime, which is what I expected. | | Run 1 | Run 2 |

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

owenpan added a comment. To my surprise, tools/clang/unittests/Format/FormatTests with the patch ran a little bit slower: | | Run 1 | Run 2 | Run 3 | Average | | w/o patch | 2707ms | 2697ms | 2710ms | 2705ms | | w/ patch | 2720ms | 2719ms | 2724ms | 2721ms | CHANGES SINCE LAST

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

kiranchandramohan added a comment. In D105584#3954144 , @abidmalikwaterloo wrote: > In D105584#3917238 , > @kiranchandramohan wrote: > >> Patch probably needs a rebase. A few more minor things to fix. Looks most

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139095 Files:

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:65 +Expr *BE = E->getBase()->IgnoreImpCasts(); +RecordDecl *RD = BE->getType()->getAsRecordDecl(); +report(E->getMemberLoc(), RD); This is not safe, we can get

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:115 +AARCH64_ARCH_EXT_NAME("rdm", AArch64::AEK_RDM, "+rdm", "-rdm", \ +RDM, "+rdm,+fp-armv8,+neon,+jsconv,+complxnum",

[clang-tools-extra] 00b9cef - [clangd] Log diagnostics if we failed to create a preamble.

Author: Sam McCall Date: 2022-12-01T13:25:15+01:00 New Revision: 00b9cefacbdf0ac764576c52fad6177aea2ed6b8 URL: https://github.com/llvm/llvm-project/commit/00b9cefacbdf0ac764576c52fad6177aea2ed6b8 DIFF: https://github.com/llvm/llvm-project/commit/00b9cefacbdf0ac764576c52fad6177aea2ed6b8.diff LO

[PATCH] D139088: [clangd] Log diagnostics if we failed to create a preamble.

This revision was automatically updated to reflect the committed changes. Closed by commit rG00b9cefacbdf: [clangd] Log diagnostics if we failed to create a preamble. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139088/new/

[clang] f57f086 - [AArch64TargetParser] getArchFeatures -> getArchFeature

Author: Tomas Matheson Date: 2022-12-01T12:50:17Z New Revision: f57f086714bc7a1399acf05d5ca1d665237cd725 URL: https://github.com/llvm/llvm-project/commit/f57f086714bc7a1399acf05d5ca1d665237cd725 DIFF: https://github.com/llvm/llvm-project/commit/f57f086714bc7a1399acf05d5ca1d665237cd725.diff LOG

[clang] 450de80 - [AArch64] Improve TargetParser API

Author: Tomas Matheson Date: 2022-12-01T12:50:23Z New Revision: 450de8008bb0ccb5dfc9dd69b6f5b434158772bd URL: https://github.com/llvm/llvm-project/commit/450de8008bb0ccb5dfc9dd69b6f5b434158772bd DIFF: https://github.com/llvm/llvm-project/commit/450de8008bb0ccb5dfc9dd69b6f5b434158772bd.diff LOG

[PATCH] D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf57f086714bc: [AArch64TargetParser] getArchFeatures -> getArchFeature (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138792: [AArch64] Improve TargetParser API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG450de8008bb0: [AArch64] Improve TargetParser API (authored by tmatheson). Changed prior to commit: https://reviews.llvm.org/D138792?vs=478617&id=4

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +DiagnosticsEngine::Error, "Unsupported statement

[clang] d1ef4b0 - Revert "[AArch64] Improve TargetParser API"

Author: Tomas Matheson Date: 2022-12-01T13:06:54Z New Revision: d1ef4b0a8da152fe4282f97c7c49f4930a3c66a2 URL: https://github.com/llvm/llvm-project/commit/d1ef4b0a8da152fe4282f97c7c49f4930a3c66a2 DIFF: https://github.com/llvm/llvm-project/commit/d1ef4b0a8da152fe4282f97c7c49f4930a3c66a2.diff LOG

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:152 + case CK_FloatingToIntegral: { +llvm::RoundingMode RM = getRoundingMode(CE); +Optional ToT = classify(CE->getType()); tbaeder wrote: > sepavloff wrote: > > Accordi

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

Endill added a comment. Is it fine that we're marking CWG405 as a duplicate even though it's not mentioned as such in official publication? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139095/new/ https://reviews.llvm.org/D139095 ___

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:115 +AARCH64_ARCH_EXT_NAME("rdm", AArch64::AEK_RDM, "+rdm", "-rdm", \ +RDM, "+rdm,+fp-armv8,+neon,+jsconv,+complxnum",

[PATCH] D139090: [clang] Add test for CWG360

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139090/new/ https://reviews.llvm.org/D139090 ___ cfe-commits mailing lis

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:152 + case CK_FloatingToIntegral: { +llvm::RoundingMode RM = getRoundingMode(CE); +Optional ToT = classify(CE->getType()); sepavloff wrote: > tbaeder wrote: > > sepavloff

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 479262. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGe

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 479264. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 479265. pmatos added a comment. Remove unnecessary attribute that lingered around after some refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clan

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. This is ready for review. RFC has been published here: https://discourse.llvm.org/t/rfc-webassembly-reference-types-in-clang/66939 Thanks to @tlively and @asb for the reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D139095: [clang] Mark CWG405 as a duplicate of CWG218

aaron.ballman added a comment. In D139095#3963334 , @Endill wrote: > Is it fine that we're marking CWG405 as a duplicate even though it's not > mentioned as such in official publication? I don't think we should mark it as a dup -- we want the status in

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:821 +(Precision == LangOptions::ExcessPrecisionKind::FPP_Standard || + Precision == LangOptions::ExcessPrecisionKind::FPP_Fast)) { if (Ty->isAnyComplexType()) {

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added a comment. In D138939#3958185 , @cjdb wrote: >> The clang-side interface to this seems a touch clunky, and I fear it'll make >> continuing its use/generalizing its use less likely. > > Is this w.r.t. the `FormatDiagnostic` being split up

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

tschuett added a comment. Maybe `void FormatDiagnostic(SmallVectorImpl &OutStr, DiagnosticMode mode)`instead of `void FormatDiagnostic(SmallVectorImpl &OutStr)`? To make the transition easer and future proof. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D138947: [Clang] Adjust assert from Sema::BuildCXXTypeConstructExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with the rewording suggestion applied. Please also add a release note for the fix, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138947/new/ https://reviews.llvm.org/D138947 __

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. Mak

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:115 +AARCH64_ARCH_EXT_NAME("rdm", AArch64::AEK_RDM, "+rdm", "-rdm", \ +RDM, "+rdm,+fp-armv8,+neon,+jsconv,+complxnum",

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

ilya-biryukov added a comment. This seems to build in both modes, but I still need to figure out what to do with tests with decision forest off. Also, maybe there is a way to minimize the use of preprocessor even more. Comment at: clang-tools-extra/clangd/decision-forest/Decis

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

erichkeane added a comment. In D138939#3963473 , @tschuett wrote: > Maybe `void FormatDiagnostic(SmallVectorImpl &OutStr, DiagnosticMode > mode)`instead of `void FormatDiagnostic(SmallVectorImpl &OutStr)`? > To make the transition easer and future proof.

[clang] 3f950ad - [clang] Add test for CWG360

Author: Vlad Serebrennikov Date: 2022-12-01T17:23:26+03:00 New Revision: 3f950ad58919309882a29bcb4bf6f8db62ffc384 URL: https://github.com/llvm/llvm-project/commit/3f950ad58919309882a29bcb4bf6f8db62ffc384 DIFF: https://github.com/llvm/llvm-project/commit/3f950ad58919309882a29bcb4bf6f8db62ffc384.

[PATCH] D139090: [clang] Add test for CWG360

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f950ad58919: [clang] Add test for CWG360 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D139090: [clang] Add test for CWG360

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; This bookmark isn't necessary, so no reason to have it. But thank you for using these! Repository: rG LLVM Github Monorepo

[PATCH] D138520: [clangd] Make decision forest model optional

mgorny abandoned this revision. mgorny added a comment. Closing in favor of D139107 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cf

[PATCH] D139107: [clangd] Allow to build Clangd without decision forest

mgorny added a comment. Thanks a lot for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139107/new/ https://reviews.llvm.org/D139107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:34 +// through the handler class. +void checkUnsafeBufferUsage(const Decl *D, UnsafeBufferUsageHandler &Handler); + N

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj updated this revision to Diff 479275. kawashima-fj edited the summary of this revision. kawashima-fj added a comment. Addressed to @zahiraam's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138117/new/ https://reviews.llvm.org/D138117 Files: clang/docs/UsersManual

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Happy now, thanks! Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiati

[PATCH] D139090: [clang] Add test for CWG360

Endill added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; erichkeane wrote: > This bookmark isn't necessary, so no reason to have it. But thank you for > using these! Nice catch, thank you!

[PATCH] D139090: [clang] Add test for CWG360

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; Endill wrote: > erichkeane wrote: > > This bookmark isn't necessary, so no reason to have it. But thank you for > > using th

[PATCH] D139013: [include-cleaner] clang-include-cleaner can print/apply edits

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:65 +llvm::ArrayRef MacroRefs, +

[PATCH] D136176: Implement support for option 'fexcess-precision'.

aaron.ballman added a reviewer: MaskRay. aaron.ballman added a comment. Herald added a subscriber: StephenFan. Adding @MaskRay for driver-specific expertise. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:821 +(Precision == LangOptions::ExcessPrecisionKind::FPP_Standard

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

yusuke-kadowaki added a comment. @mairacanal Thank you for the catch! Comment at: clang/unittests/Format/FormatTestComments.cpp:3101 + // Allow to keep 2 empty lines + Style.MaxEmptyLinesToKeep = 2; + EXPECT_EQ("// do not touch\n" This should probably be re

[PATCH] D138822: [clang] Add test for CWG36

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}}

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp created this revision. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. - Do not analyze header files, since we don't want to promote usi

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam accepted this revision. zahiraam added a comment. This revision is now accepted and ready to land. In D138117#3963560 , @kawashima-fj wrote: > Addressed to @zahiraam's comment Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 479281. pmatos added a comment. Ready for review. RFC: https://discourse.llvm.org/t/rfc-webassembly-reference-types-in-clang/66939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 479282. pmatos added a comment. Ready for review. RFC: https://discourse.llvm.org/t/rfc-webassembly-reference-types-in-clang/66939 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. This change enables Wshorten-64-to-32 waring for compound assignment statements which has implicit conversion

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...://10466193 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139114 Files: clang/lib/Sema/Se

[PATCH] D139113: Fix a couple additional cases in misc-use-anonymous-namespace only

carlosgalvezp updated this revision to Diff 479284. carlosgalvezp added a comment. Fix naming convention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 Files: clang-tools-extra/clang-tidy/misc/UseAnony

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

erichkeane added a comment. I unfortunately am equally not informed enough to help here. The code itself looks fine to me, but I'm unable to make a value judgement on the change itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ ht

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1127 return false; - if (!this->emitInitGlobal(*T, *I, VD)) +} + } else { tbaeder wrote: > aaron.ballman wrote: > > and if we have no `GlobalIndex`? > >

[clang] aa14968 - [PS4/PS5] Canonicalize tests to use 'target=.*-(ps4|ps5)'

Author: Paul Robinson Date: 2022-12-01T07:21:07-08:00 New Revision: aa149687dc76f304a5228a167f4eebf19e5fb2d7 URL: https://github.com/llvm/llvm-project/commit/aa149687dc76f304a5228a167f4eebf19e5fb2d7 DIFF: https://github.com/llvm/llvm-project/commit/aa149687dc76f304a5228a167f4eebf19e5fb2d7.diff

[PATCH] D139090: [clang] Add test for CWG360

erichkeane added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:908 +public: + using A::baz; // #dr360-baz-using-decl +}; aaron.ballman wrote: > Endill wrote: > > erichkeane wrote: > > > This bookmark isn't necessary, so no reason to have it. But tha

[clang] e83f150 - [AArch64] Improve TargetParser API

Author: Tomas Matheson Date: 2022-12-01T15:30:07Z New Revision: e83f1502f1be7a2a3b9a33f5a73867767e78ba6b URL: https://github.com/llvm/llvm-project/commit/e83f1502f1be7a2a3b9a33f5a73867767e78ba6b DIFF: https://github.com/llvm/llvm-project/commit/e83f1502f1be7a2a3b9a33f5a73867767e78ba6b.diff LOG

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1127 return false; - if (!this->emitInitGlobal(*T, *I, VD)) +} + } else { aaron.ballman wrote: > tbaeder wrote: > > aa

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder updated this revision to Diff 479294. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/I

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson added a comment. Lacking an LGTM from someone with AIX knowledge, I see there's a bot "clang-ppc64-aix" where I can verify that the test results haven't changed. For this review the set of tests are mostly UNSUPPORTED, except for three XFAIL. I'll let this sit a little while in case

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1127 return false; - if (!this->emitInitGlobal(*T, *I, VD)) +} + } else { tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wro

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1127 return false; - if (!this->emitInitGlobal(*T, *I, VD)) +} + } else { aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > tbaeder wrote:

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/AST/Interp/Interp.h:1346-1347 if (Func->hasThisPointer()) { +ThisPtr = NewFrame->getThis(); if (!CheckInvoke(S, PC, NewF

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev updated this revision to Diff 479310. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments, fix a fixme. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 Files: clang/include/clang/AST/AST

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5395-5400 + // FIXME: Tell the user this is unsupported. + if (!Stmts.empty()) { +unsigned ID = Actions.getDiagnostics().getCustomDiagID( +DiagnosticsEngine::Error, "Unsupported statement

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13896 + Diag(var->getLocation(), diag::err_constexpr_var_requires_const_init) + << var << Init->getSourceRange(); + } efriedma wrote: > rnk wrote: > > zahiraam wrot

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev planned changes to this revision. v.g.vassilev added a comment. I screwed up with the last diff. Let me fix it in a bit... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___ cfe-commits

[PATCH] D139122: Generalize clang-tidy modernize-pass-by-value

mbid created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. mbid added a comment. mbid published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Hi Nathan, Could

[PATCH] D139029: [clang-format] Don't move comments if AlignTrailingComments: Kind: Leave

mairacanal updated this revision to Diff 479312. mairacanal added a comment. Reset `Style.MaxEmptyLinesToKeep` after the test case to avoid side effects for other test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139029/new/ https://reviews.llvm.org/D139029 Files: clang/lib/

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 479319. VitaNuo added a comment. Handle pointer and reference types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-extra/include-cleaner/lib/Wa

  1   2   3   >