[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov updated this revision to Diff 478826. dvyukov added a comment. fixed the debug build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/clang/Basic/CodeGenOptions.def clang/i

[clang] e6aea4a - Use-after-return sanitizer binary metadata

Author: Dmitry Vyukov Date: 2022-11-30T09:14:19+01:00 New Revision: e6aea4a5db09c845276ece92737a6aac97794100 URL: https://github.com/llvm/llvm-project/commit/e6aea4a5db09c845276ece92737a6aac97794100 DIFF: https://github.com/llvm/llvm-project/commit/e6aea4a5db09c845276ece92737a6aac97794100.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6aea4a5db09: Use-after-return sanitizer binary metadata (authored by dvyukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. Kazu, thanks for taking care of the revert. I've fixed the assert and tested with -DLLVM_ENABLE_ASSERTIONS=On. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 ___

[clang] afa60d0 - [clang][Interp] Fix discarding non-primitive function call return values

Author: Timm Bäder Date: 2022-11-30T09:18:28+01:00 New Revision: afa60d08a2d4e99cec6cacdcdc36d568ac2b3118 URL: https://github.com/llvm/llvm-project/commit/afa60d08a2d4e99cec6cacdcdc36d568ac2b3118 DIFF: https://github.com/llvm/llvm-project/commit/afa60d08a2d4e99cec6cacdcdc36d568ac2b3118.diff LO

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafa60d08a2d4: [clang][Interp] Fix discarding non-primitive function call return values (authored by tbaeder). Repository: rG LLVM Github Monorepo

[PATCH] D138983: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 3 or 3)

jmciver created this revision. Herald added a project: All. jmciver added reviewers: vitalybuka, jdoerfert, rjmccall, aqjune, efriedma, nikic. jmciver added subscribers: mattd, asavonic, pengfei, pcwang-thead, sstefan1, xbolva00, nlopes. jmciver edited the summary of this revision. jmciver publis

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

rymiel added inline comments. Comment at: clang/include/clang/Frontend/DiagnosticRenderer.h:130 /// \param Message The diagnostic message to emit. + /// \param Reason Supplementary information for the message. /// \param Ranges The underlined ranges for this code snippet.

[clang] 0aedf9d - Revert "Use-after-return sanitizer binary metadata"

Author: Dmitry Vyukov Date: 2022-11-30T09:38:56+01:00 New Revision: 0aedf9d7141fcae75956c651f1c2474db6862350 URL: https://github.com/llvm/llvm-project/commit/0aedf9d7141fcae75956c651f1c2474db6862350 DIFF: https://github.com/llvm/llvm-project/commit/0aedf9d7141fcae75956c651f1c2474db6862350.diff

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

awarzynski added a comment. Thanks for all the updates @mnadeem! Mostly looks good. A few more nits, but nothing substantial :) In D137995#3958824 , @mnadeem wrote: > In D137995#3931005 , > @kiranchandramohan w

[clang] 8095b09 - [clang][Interp] Array initialization via CXXConstructExpr

Author: Timm Bäder Date: 2022-11-30T10:09:52+01:00 New Revision: 8095b090db20ac175b7a4db1a51c167249842e8f URL: https://github.com/llvm/llvm-project/commit/8095b090db20ac175b7a4db1a51c167249842e8f DIFF: https://github.com/llvm/llvm-project/commit/8095b090db20ac175b7a4db1a51c167249842e8f.diff LO

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG8095b090db20: [clang][Interp] Array initialization via CXXConstructExpr (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ htt

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

sdesmalen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2527 -def int_aarch64_sve_bfdot_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfmlalb_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfmlalt_lane : SVE_4Vec_BF16_Indexed; +def int_

[clang] c3380c3 - [clang][Interp] Handle undefined functions better

Author: Timm Bäder Date: 2022-11-30T10:09:52+01:00 New Revision: c3380c32f856925733a113c12cdeb3c3cb369f1f URL: https://github.com/llvm/llvm-project/commit/c3380c32f856925733a113c12cdeb3c3cb369f1f DIFF: https://github.com/llvm/llvm-project/commit/c3380c32f856925733a113c12cdeb3c3cb369f1f.diff LO

[PATCH] D136936: [clang][Interp] Handle undefined functions better

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rGc3380c32f856: [clang][Interp] Handle undefined functions better (authored by tbaeder). Changed prior to co

[clang] aaf73ae - [clang][Interp] Use placement new to construct opcode args into vector

Author: Timm Bäder Date: 2022-11-30T10:09:52+01:00 New Revision: aaf73ae266db44fce107a0b73fcb33527bfb52eb URL: https://github.com/llvm/llvm-project/commit/aaf73ae266db44fce107a0b73fcb33527bfb52eb DIFF: https://github.com/llvm/llvm-project/commit/aaf73ae266db44fce107a0b73fcb33527bfb52eb.diff LO

[PATCH] D138554: [clang][Interp] Use placement new to construct opcode arguments into bytecode vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf73ae266db: [clang][Interp] Use placement new to construct opcode args into vector (authored by tbaeder). Changed prior to commit: https://revie

[PATCH] D137392: [clang][Interp] Explicitly handle RVO Pointer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c215a457178: [clang][Interp] Explicitly handle RVO Pointer (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7c215a4 - [clang][Interp] Explicitly handle RVO Pointer

Author: Timm Bäder Date: 2022-11-30T10:37:57+01:00 New Revision: 7c215a457178174187cb975e6ee7d96105ea0ef8 URL: https://github.com/llvm/llvm-project/commit/7c215a457178174187cb975e6ee7d96105ea0ef8 DIFF: https://github.com/llvm/llvm-project/commit/7c215a457178174187cb975e6ee7d96105ea0ef8.diff LO

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. FTR ./llvm/test/CodeGen/AMDGPU/llc-pipeline.ll also failed as it hardcodes all passes: https://lab.llvm.org/buildbot/#/builders/123/builds/14397 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llv

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. In D136078#3959643 , @dvyukov wrote: > FTR ./llvm/test/CodeGen/AMDGPU/llc-pipeline.ll also failed as it hardcodes > all passes: > https://lab.llvm.org/buildbot/#/builders/123/builds/14397 Also these: LLVM :: CodeGen/X86/O0-pi

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

DavidSpickett added a comment. Looks like tests need updating for that new -1 return value: https://lab.llvm.org/buildbot/#/builders/178/builds/3419 That bot builds with threading disabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/

[clang] 26fa17e - Implement CWG2631

Author: Corentin Jabot Date: 2022-11-30T11:25:01+01:00 New Revision: 26fa17ed2914bd80c066d36b325fd3104e45554c URL: https://github.com/llvm/llvm-project/commit/26fa17ed2914bd80c066d36b325fd3104e45554c DIFF: https://github.com/llvm/llvm-project/commit/26fa17ed2914bd80c066d36b325fd3104e45554c.diff

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. cor3ntin marked 2 inline comments as done. Closed by commit rG26fa17ed2914: Implement CWG2631 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.or

[clang] 4403c4f - [Clang] Remove conflict markers from ReleaseNotes

Author: Corentin Jabot Date: 2022-11-30T11:27:16+01:00 New Revision: 4403c4f9e77e673a2771edfc7ab0ebb234e97485 URL: https://github.com/llvm/llvm-project/commit/4403c4f9e77e673a2771edfc7ab0ebb234e97485 DIFF: https://github.com/llvm/llvm-project/commit/4403c4f9e77e673a2771edfc7ab0ebb234e97485.diff

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Thanks Aaron. I hope it sticks this time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

asb added a comment. In D119541#3940597 , @arichardson wrote: > I just noticed that target features (e.g. -mrelax) are broken in all LLVM 14 > releases due to D113336 . This should have > been cherry-picked back tot t

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

asb added a comment. Thanks for sharing these patches. I appreciate you're probably not expecting in-depth reviews at this point, but if you could update the patch description to link to the current spec for these intrinsics it would be a lot easier for anyone who is able to give some early fee

[PATCH] D138295: [clang][TargetInfo] Use LangAS for getPointer{Width,Align}()

arichardson updated this revision to Diff 478867. arichardson marked 3 inline comments as done. arichardson added a comment. address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138295/new/ https://reviews.llvm.org/D138295 Files:

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

david-arm updated this revision to Diff 478868. david-arm added a comment. - Actually done the upgrade stuff properly this time. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138788/new/ https://reviews.llvm.org/D138788 Files: clang/include/clang/Basic/arm_sve.td clang/test/Code

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

david-arm marked an inline comment as done. david-arm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2527 -def int_aarch64_sve_bfdot_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfmlalb_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfm

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959693 , @DavidSpickett wrote: > Looks like tests need updating for that new -1 return value: > https://lab.llvm.org/buildbot/#/builders/178/builds/3419 > > That bot builds with threading disabled. Thanks for letting

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

arichardson updated this revision to Diff 478870. arichardson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTConte

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478875. Endill added a comment. Add examples with dependent types, and rearrange using declarations to group errors and notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/

[PATCH] D138930: [RISCV] Add macro to imply compiler availability on RISC-V Vector intrinsics version

asb accepted this revision. asb added a comment. LGTM, thanks! Comment at: clang/lib/Basic/Targets/RISCV.cpp:195 Builder.defineMacro("__riscv_vector"); +// Currently we support the v0.10 RISC-V V intrinsics +unsigned Version = (0 * 100) + (10 * 1000); -

[PATCH] D138822: [clang] Add test for CWG36

Endill updated this revision to Diff 478878. Endill added a comment. Get rid of unwanted changes supposedly cause by `arc diff` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138822/new/ https://reviews.llvm.org/D138822 Files: clang/test/CXX/drs/dr0xx.cpp clang/www/cxx_dr_status.htm

[PATCH] D138295: [clang][TargetInfo] Use LangAS for getPointer{Width,Align}()

arichardson added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1917 +EffectiveFieldSize = FieldSize = TI.Width; +FieldAlign = TI.Align; } else { rjmccall wrote: > This is a nice cleanup, but I actually can't figure out why we can'

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov updated this revision to Diff 478887. dvyukov added a comment. Herald added subscribers: kosarev, pcwang-thead, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, nio

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov added a comment. PTAL moved *.cpp tests to clang/test/ updated tests that hardcode pipeline passes fixed metadata update This did not work, it also changed all shared instances: const auto *NewMD = MDB.createPCSections( {{Section.getString(), {Features, IRB.getInt32(Size)}}});

[PATCH] D137415: [clang][Interp] Implement switch statements

tbaeder updated this revision to Diff 478895. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137415/new/ https://reviews.llvm.org/D137415 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.h clang/test/AST/I

[PATCH] D137415: [clang][Interp] Implement switch statements

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/switch.cpp:46 +constexpr int withInit() { + switch(int a = 2; a) { +case 1: return -1; aaron.ballman wrote: > I think it would be good to add a non-tri

[clang] 3f3438a - [CodeGen][X86] Crash fixes for "patchable-function" pass

Author: Sylvain Audi Date: 2022-11-30T07:29:54-05:00 New Revision: 3f3438a596d4883ecd934fc725a9d5f620082c3b URL: https://github.com/llvm/llvm-project/commit/3f3438a596d4883ecd934fc725a9d5f620082c3b DIFF: https://github.com/llvm/llvm-project/commit/3f3438a596d4883ecd934fc725a9d5f620082c3b.diff

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3438a596d4: [CodeGen][X86] Crash fixes for "patchable-function" pass (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 3ae07a4 - [clang-repl] Add basic documentation about clang-repl

Author: Sara Bellei Date: 2022-11-30T12:30:33Z New Revision: 3ae07a4372fca279ed27e0964130e9931f1807e6 URL: https://github.com/llvm/llvm-project/commit/3ae07a4372fca279ed27e0964130e9931f1807e6 DIFF: https://github.com/llvm/llvm-project/commit/3ae07a4372fca279ed27e0964130e9931f1807e6.diff LOG: [

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ae07a4372fc: [clang-repl] Add basic documentation about clang-repl (authored by sarabellei, committed by v.g.vassilev). Herald added a project: clan

[PATCH] D138698: [clang-repl] Add basic documentation about clang-repl

v.g.vassilev added a comment. I have modified it a little before landing it to capture better the intent and our off-list conversation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138698/new/ https://reviews.llvm.org/D138698 ___

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:552-553 bit LateParsed = 0; + // Set to true for attributes that should participate in ODR hashing. + bit IsODRHashable = 0; // Set to false to prevent an attribute from being propagated fr

[clang] bb1eca6 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2022-11-30T07:52:59-05:00 New Revision: bb1eca6bbb470e4fea111f4a6929be6f7a4524b3 URL: https://github.com/llvm/llvm-project/commit/bb1eca6bbb470e4fea111f4a6929be6f7a4524b3 DIFF: https://github.com/llvm/llvm-project/commit/bb1eca6bbb470e4fea111f4a6929be6f7a4524b3.diff

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

aaron.ballman added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3312 unsigned CharSize; + bool Diagnose = Result && !isLexingRawMode(); Spurious whitespace Comment at: clang/lib/Lex/Lexer.cpp:3379 - if (LooseMatch) + if (Loos

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

aaron.ballman added inline comments. Comment at: clang/docs/SafeBuffers.rst:40-41 + - Finally, in order to avoid bugs in newly converted code, the +Clang static analyzer provides a checker to find misconstructed +``std::span`` objects. + NoQ wrote: > aar

[PATCH] D136078: Use-after-return sanitizer binary metadata

melver requested changes to this revision. melver added a comment. This revision now requires changes to proceed. AFAIK Windows bot will break: https://buildkite.com/llvm-project/premerge-checks/builds/124003#0184c872-af5b-47c0-938c-b31ee8808241 Need to restrict test to Linux only. Repository:

[PATCH] D136078: Use-after-return sanitizer binary metadata

dvyukov updated this revision to Diff 478912. dvyukov added a comment. restrict tests to linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136078/new/ https://reviews.llvm.org/D136078 Files: clang/include/clang/Basic/CodeGenOptions.def clang

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478914. cor3ntin added a comment. Remove extraneous space and braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib

[clang] f607884 - [clang] Speedup LineOffsetMapping::get

Author: serge-sans-paille Date: 2022-11-30T14:35:53+01:00 New Revision: f607884a04b0ca06951227a01d00bc59b948d337 URL: https://github.com/llvm/llvm-project/commit/f607884a04b0ca06951227a01d00bc59b948d337 DIFF: https://github.com/llvm/llvm-project/commit/f607884a04b0ca06951227a01d00bc59b948d337.d

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

This revision was automatically updated to reflect the committed changes. Closed by commit rGf607884a04b0: [clang] Speedup LineOffsetMapping::get (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138474/new/ https://revi

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} erichkeane wrote: > Endill wrote: > >

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 478919. cor3ntin added a comment. Restore a macro test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3379 - if (LooseMatch) + if (LooseMatch && Diagnose) Res = LooseMatch->CodePoint; aaron.ballman wrote: > Why do we only want to do this if we're diagnosing? The scenario we want to avoid

[PATCH] D138822: [clang] Add test for CWG36

aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} Endill wrote: > erichkeane wrot

[clang] d3c851d - Use-after-return sanitizer binary metadata

Author: Dmitry Vyukov Date: 2022-11-30T14:50:22+01:00 New Revision: d3c851d3fc8b69dda70bf5f999c5b39dc314dd73 URL: https://github.com/llvm/llvm-project/commit/d3c851d3fc8b69dda70bf5f999c5b39dc314dd73 DIFF: https://github.com/llvm/llvm-project/commit/d3c851d3fc8b69dda70bf5f999c5b39dc314dd73.diff

[PATCH] D136078: Use-after-return sanitizer binary metadata

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3c851d3fc8b: Use-after-return sanitizer binary metadata (authored by dvyukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9 +that could instead be moved into an anonymous namespace. It also detects +instances moved to an anonymo

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos created this revision. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a reviewer: aaron.ballman. Herald added a project: All. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheej

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos planned changes to this revision. pmatos added a comment. Please wait to review until the RFC (coming soon) is published. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 ___

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. Subsumes D124162 and D123510 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 ___

[clang] 8fa2e93 - [clang] Do not merge traps in functions annotated optnone

Author: Henrik G. Olsson Date: 2022-11-30T15:06:32+01:00 New Revision: 8fa2e93538595e1ff973110cb3f301b65bc9d2eb URL: https://github.com/llvm/llvm-project/commit/8fa2e93538595e1ff973110cb3f301b65bc9d2eb DIFF: https://github.com/llvm/llvm-project/commit/8fa2e93538595e1ff973110cb3f301b65bc9d2eb.di

[PATCH] D137714: Do not merge traps in functions annotated optnone

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa2e9353859: [clang] Do not merge traps in functions annotated optnone (authored by hnrklssn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137714/new/ ht

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:177-178 + case tok::kw___attribute: + case tok::kw_const: + case tok::kw_volatile: + case tok::star: What about other qualifiers? `_Nullable` and `restrict` and whatnot?

[PATCH] D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature

pratlucas accepted this revision. pratlucas added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138753/new/ https://reviews.llvm.org/D138753 _

[PATCH] D139006: [UpdateTestChecks] Match define for labels

sebastian-ne updated this revision to Diff 478933. sebastian-ne added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jdoerfert, sstefan1. Herald added a project: clang. Thanks for the review! I updated the update_cc_tests tests and added a test where the File

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LGTM. I do think this is an important fix, not the least because i've also just hit that, but i do want to explicitly call out that this will cause a massive test case churn, so i do w

[clang] 11e51d9 - Remove 'modindex' from the Clang docs

Author: Aaron Ballman Date: 2022-11-30T09:37:49-05:00 New Revision: 11e51d9dfc4a582b6c83d3e16b6a093cc2b0dee9 URL: https://github.com/llvm/llvm-project/commit/11e51d9dfc4a582b6c83d3e16b6a093cc2b0dee9 DIFF: https://github.com/llvm/llvm-project/commit/11e51d9dfc4a582b6c83d3e16b6a093cc2b0dee9.diff

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

aaron.ballman accepted this revision as: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a request for a comment, but please give @tahonermann a chance to look at the review before landing. Comment at: clang/lib/Lex/Lexe

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:821 +(Precision == LangOptions::ExcessPrecisionKind::FPP_Standard || + Precision == LangOptions::ExcessPrecisionKind::FPP_Fast)) { if (

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jhuber6 added a comment. In D133539#3955099 , @sandoval wrote: > Overall this approach looks good to me, though I'd suggest some (hopefully > minor) changes that would help avoid breaking the ABI. It looks like > `__tgt_bin_desc` is only used by `__tgt

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous. testWalk(R"cpp( nit: update the

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } hokein wrote: > we should report all references as explici

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:13896 + Diag(var->getLocation(), diag::err_constexpr_var_requires_const_init) + << var << Init->getSourceRange(); + } efriedma wrote: > I don't understand why this

[clang] 9221bed - Revert "Implement CWG2631"

Author: Corentin Jabot Date: 2022-11-30T16:03:05+01:00 New Revision: 9221bedfd7d5f58ef36d45698823ca43030ce8eb URL: https://github.com/llvm/llvm-project/commit/9221bedfd7d5f58ef36d45698823ca43030ce8eb DIFF: https://github.com/llvm/llvm-project/commit/9221bedfd7d5f58ef36d45698823ca43030ce8eb.diff

[clang] ec23e55 - [clang][Interp][NFC] Avoid unnecessary work in compileFunc()

Author: Timm Bäder Date: 2022-11-30T16:07:29+01:00 New Revision: ec23e5584de0b7212db64f5e2aff355e8279537e URL: https://github.com/llvm/llvm-project/commit/ec23e5584de0b7212db64f5e2aff355e8279537e DIFF: https://github.com/llvm/llvm-project/commit/ec23e5584de0b7212db64f5e2aff355e8279537e.diff LO

[clang] 89b0095 - Revert "[clang][Interp] Use placement new to construct opcode args into vector"

Author: Timm Bäder Date: 2022-11-30T16:07:57+01:00 New Revision: 89b009559cea546f16f45105bb1ce90265f79c9c URL: https://github.com/llvm/llvm-project/commit/89b009559cea546f16f45105bb1ce90265f79c9c DIFF: https://github.com/llvm/llvm-project/commit/89b009559cea546f16f45105bb1ce90265f79c9c.diff LO

[PATCH] D136554: Implement CWG2631

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. There is still an ODR issue which caused linkers errors I think I managed to reduce the issue to template struct function_ref { function_ref(auto) {} }; struct S { f

[PATCH] D139013: [include-cleaner] clang-include-cleaner can print/apply edits

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This adds command-line flags to the

[clang-tools-extra] d9f8097 - [include-cleaner] don't clang-format tests. NFC

Author: Sam McCall Date: 2022-11-30T16:12:40+01:00 New Revision: d9f8097b3ab3081e1f3d55ccf368ea866d866fd8 URL: https://github.com/llvm/llvm-project/commit/d9f8097b3ab3081e1f3d55ccf368ea866d866fd8 DIFF: https://github.com/llvm/llvm-project/commit/d9f8097b3ab3081e1f3d55ccf368ea866d866fd8.diff LO

[PATCH] D138614: [Clang][OpenMP][AMDGPU] Fix capture of variably modified type alias in teams distribute

doru1004 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:243 if (!FD->getType()->isReferenceType()) { - assert(!VD->getType()->isVariablyModifiedType() && + bool isVMT = VD->getType()->isVariablyModifiedType(); + ass

[PATCH] D137415: [clang][Interp] Implement switch statements

aaron.ballman accepted this revision. aaron.ballman added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/Interp/switch.cpp:46 +constexpr int withInit() { + switch(int a = 2; a) { +case 1: return -1; tbaeder wrote

[PATCH] D139006: [UpdateTestChecks] Match define for labels

mtrofin accepted this revision. mtrofin added a comment. LGTM, but I'd wait for Johannes to review it, too (because of e67f6477fd1ed29acbeddf8482c25d8db826912f . I for one don't quite follow the reasoning there wrt adding the

[clang] 3faab85 - [AIX][LTO] Enabling Context Sensitive PGO Options

Author: Qiongsi Wu Date: 2022-11-30T10:22:26-05:00 New Revision: 3faab85c12bc1d96e144dcb6d8f75bcafa120c79 URL: https://github.com/llvm/llvm-project/commit/3faab85c12bc1d96e144dcb6d8f75bcafa120c79 DIFF: https://github.com/llvm/llvm-project/commit/3faab85c12bc1d96e144dcb6d8f75bcafa120c79.diff LO

[PATCH] D138854: [AIX][LTO] Enabling Context Sensitive PGO Options

This revision was automatically updated to reflect the committed changes. Closed by commit rG3faab85c12bc: [AIX][LTO] Enabling Context Sensitive PGO Options (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D139014: [include-cleaner] Move RecordedPP::RecordedIncludes -> Includes in Types.h. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Requiring everything that wants to match Includes to depend on Record

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959759 , @lenary wrote: > In D137836#3959693 , @DavidSpickett > wrote: > >> Looks like tests need updating for that new -1 return value: >> https://lab.llvm.org/buildbot/#/bui

[PATCH] D138822: [clang] Add test for CWG36

Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:489 + +using B::i; // expected-error {{redeclaration of using declaration}} +using C::i; // expected-error {{redeclaration of using declaration}} aaron.ballman wrote: > Endill wrote: >

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

aaron.ballman edited reviewers, added: clang-vendors; removed: mibintc. aaron.ballman added a comment. (Removed @mibintc because she retired, added clang-vendors because this can impact other downstreams.) This is outside my wheelhouse, so I don't have many technical comments to add. I'm hoping

[PATCH] D139006: [UpdateTestChecks] Match define for labels

lebedev.ri added a comment. In D139006#3960466 , @mtrofin wrote: > LGTM, but I'd wait for Johannes to review it, too (because of > e67f6477fd1ed29acbeddf8482c25d8db826912f > . I for >

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1032-1034 +// FIXME: Remove the incremental processing pre-condition and verify clang +// still can pass its test suite, which will harden +// `is

[PATCH] D139017: Changed the intentional spelling errors back to the original, made more slight grammar corrections

giannicrivello created this revision. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Herald added a project: All. giannicrivello requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

aaron.ballman added inline comments. Comment at: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h:30 + /// of primitive fixits (individual insertions/removals/replacements). + using FixItList = llvm::SmallVector; + steakhal wrote: > Unless we have a we

[PATCH] D139018: [include-cleaner] Record whether includes are spelled with quotes

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This is needed to accurately remove headers with tooling::IncludeHeade

[PATCH] D138964: Fixed a few spelling errors in clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td

giannicrivello updated this revision to Diff 478960. giannicrivello added a comment. Addressed the intentional spelling errors, also fixed a few more grammar errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138964/new/ https://reviews.llvm.org/

[PATCH] D139018: [include-cleaner] Record whether includes are spelled with quotes

sammccall updated this revision to Diff 478961. sammccall added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139018/new/ https://reviews.llvm.org/D139018 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner

  1   2   3   >