[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

alexfh added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc); -

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added a comment. That's roughly what I was thinking, yes. The one missing piece is the code to modify the constructor priorities to make sure that "constant" variables get initialized first. (This ensures we honor the C++ rules for "constant initialization".) Comme

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4822 Init = Initializer; + if (Initializer->isDLLImportDependent()) +NeedsGlobalCtor = true; This check probably needs to be inside tryEmitForInitializer, so other

[PATCH] D138947: [Clang] Remove invalid assert from Sema::BuildCXXTypeConstructExpr

shafik added a comment. The windows failure happened on the build before as well so not related to this change: https://buildkite.com/llvm-project/premerge-checks/builds/123890 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138947/new/ https://reviews.llvm.org/D138947 _

[PATCH] D138961: [clang-doc] Fix warnings about lock_guard.

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Fixes a warning about a potentially unsupported template argument deduction b

[PATCH] D138295: [clang][TargetInfo] Use LangAS for getPointer{Width,Align}()

rjmccall added a comment. This looks great, thanks! Skimmed through the changes pretty quickly. Comment at: clang/lib/AST/Mangle.cpp:237 } - Out << ((TI.getPointerWidth(0) / 8) * ArgWords); + Out << ((TI.getPointerWidth(LangAS::Default) / 8) * ArgWords); } --

[PATCH] D138947: [Clang] Remove invalid assert from Sema::BuildCXXTypeConstructExpr

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1464 - (Exprs.size() == 1 && isa(Exprs[0]))) && - "List initialization must have initializer list as expression."); SourceRange FullRange = SourceRange(TyBeginLoc, RParenOrBraceLoc); --

[PATCH] D138963: Fixed a few spelling errors.

giannicrivello created this revision. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Herald added a project: All. giannicrivello requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem updated this revision to Diff 478766. mnadeem marked 4 inline comments as done. mnadeem edited the summary of this revision. Herald added a subscriber: pengfei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137995/new/ https://reviews.llvm.org/D137995 Files: clang/include/clang

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added a comment. In D137995#3944145 , @awarzynski wrote: > Thanks for implementing this! > >> Processes target cpu and features in the flang driver. Right now features >> are only added for AArch64 because I only did basic testing on AArch64 but

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added a comment. In D137995#3931005 , @kiranchandramohan wrote: > We might need `-fc1` tests as well. What kind of tests do you think would be appropriate here? Can you point me to any examples, maybe from clang? CHANGES SINCE LAST ACTION h

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:99 + default: +// Untested for other targets but should work generally. +break; kiranchandramohan wrote: > I get a segfault in ` Fortran::frontend::CodeGenAction::setUpTarge

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

mnadeem added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:99 + default: +// Untested for other targets but should work generally. +break; mnadeem wrote: > kiranchandramohan wrote: > > I get a segfault in ` > > Fortran::frontend::C

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

alexfh added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc); -

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

ChuanqiXu added a subscriber: v.g.vassilev. ChuanqiXu added a comment. @sammccall @nridge in a chat, @v.g.vassilev mentioned that it may be possible to make clangd for modules a GSoC project. I feel it is pretty good idea. How do you think about it? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

dexonsmith added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:6343 "Invalid data, missing pragma diagnostic states"); - SourceLocation Loc = ReadSourceLocation(F, Record[Idx++]); - auto IDAndOffset = SourceMgr.getDecomposedLoc(Loc); -

[PATCH] D138970: [clang][Driver] Don't overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on `DiagnosticOptions::IgnoreWarnings` value.

vsapsai created this revision. vsapsai added reviewers: bnbarham, dyung, MaskRay. Herald added subscribers: StephenFan, ributzka, arphaman. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Driver overwrit

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai added a comment. Ok, I was able to reproduce the error on macOS by adding `-target x86_64-sie-ps5` to one of commands in "clang/test/ClangScanDeps/Inputs/no-werror.json" (wouldn't mind receiving PS5 DevKit, by the way). The problem is that `Driver::BuildCompilation` overwrites `Diagnos

[PATCH] D138970: [clang][Driver] Don't overwrite `DiagnosticsEngine::IgnoreAllWarnings`, rely on `DiagnosticOptions::IgnoreWarnings` value.

vsapsai added a comment. To help folks digging up the history, the code in driver was introduced in https://reviews.llvm.org/D11322 and the test case added in "test/Index/warning-flags.c" requires the change in "clang/tools/libclang/CIndex.cpp", that's why I don't have any extra test changes.

[clang-tools-extra] c995120 - [clang-doc] Fix warnings about lock_guard

Author: Petr Hosek Date: 2022-11-30T02:30:40Z New Revision: c995120968993b09aeb138868b30348d6724efe2 URL: https://github.com/llvm/llvm-project/commit/c995120968993b09aeb138868b30348d6724efe2 DIFF: https://github.com/llvm/llvm-project/commit/c995120968993b09aeb138868b30348d6724efe2.diff LOG: [c

[PATCH] D138961: [clang-doc] Fix warnings about lock_guard.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc99512096899: [clang-doc] Fix warnings about lock_guard (authored by phosek). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D138961: [clang-doc] Fix warnings about lock_guard.

phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138961/new/ https://reviews.llvm.org/D138961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D138947: [Clang] Remove invalid assert from Sema::BuildCXXTypeConstructExpr

shafik added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1464 - (Exprs.size() == 1 && isa(Exprs[0]))) && - "List initialization must have initializer list as expression."); SourceRange FullRange = SourceRange(TyBeginLoc, RParenOrBraceLoc);

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

vsapsai added a comment. In D138859#3955806 , @ChuanqiXu wrote: > And I think we should add tests for this. e.g., in the ASTImporterTests.cpp. I'm not sure which test would be useful in this case. We kinda already test that different modules agree which

[PATCH] D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation.

NoQ added inline comments. Comment at: clang/docs/SafeBuffers.rst:40-41 + - Finally, in order to avoid bugs in newly converted code, the +Clang static analyzer provides a checker to find misconstructed +``std::span`` objects. + aaron.ballman wrote: > NoQ

[PATCH] D138964: Fixed a few spelling errors in clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td

NoQ added a comment. Nice, thanks! For non-trivial patches it's recommended to include full diff context via `-U99` (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface) so that reviewers could easily see what does the surrounding code do. C

[PATCH] D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h

FreddyYe updated this revision to Diff 478781. FreddyYe added a comment. minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138900/new/ https://reviews.llvm.org/D138900 Files: clang/lib/Headers/cmpccxaddintrin.h clang/lib/Headers/immintr

[clang] 51679dc - [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h

Author: Freddy Ye Date: 2022-11-30T10:40:42+08:00 New Revision: 51679dc1c9d52ca906a739bafdd7be0041d7b3ce URL: https://github.com/llvm/llvm-project/commit/51679dc1c9d52ca906a739bafdd7be0041d7b3ce DIFF: https://github.com/llvm/llvm-project/commit/51679dc1c9d52ca906a739bafdd7be0041d7b3ce.diff LOG

[PATCH] D138900: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51679dc1c9d5: [X86] include cmpccxaddintrin.h from immintrin.h to x86gprintrin.h (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D138930: [RISCV] Add macro to imply compiler availability on RISC-V Vector intrinsics version

eopXD updated this revision to Diff 478784. eopXD added a comment. Add check for end-line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138930/new/ https://reviews.llvm.org/D138930 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Preproces

[PATCH] D138974: [CMake] Support injecting extra dependencies for perf-training

phosek created this revision. phosek added a reviewer: smeenai. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It may be necessary to build additional targets before running perf-training, the typical us

[PATCH] D138974: [CMake] Support injecting extra dependencies for perf-training

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Might be worth a mention in either https://llvm.org/docs/AdvancedBuilds.html#multi-stage-pgo, to make it a bit more discoverable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138975: [perf-training] Support additional test suffixes

phosek created this revision. phosek added a reviewer: smeenai. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. .cc and .test are commonly used and supported by other lit test suites. Repository: rG L

[PATCH] D138859: [ODRHash] Drive attribute hashing through TableGen. NFC intended.

ChuanqiXu added a comment. In D138859#3958958 , @vsapsai wrote: > In D138859#3955806 , @ChuanqiXu > wrote: > >> And I think we should add tests for this. e.g., in the ASTImporterTests.cpp. > > I'm not sure which

[PATCH] D138975: [perf-training] Support additional test suffixes

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138975/new/ https://reviews.llvm.org/D138975 _

[PATCH] D138964: Fixed a few spelling errors in clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td

giannicrivello added a comment. In D138964#3958986 , @NoQ wrote: > Nice, thanks! > > For non-trivial patches it's recommended to include full diff context via > `-U99` > (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interfa

[PATCH] D138964: Fixed a few spelling errors in clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td

NoQ added a comment. > So how would I move forward from here? There's the "Update Diff" button on the right! You can use it to address review comments until everyone's happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138964/new/ https://revie

[PATCH] D138979: [NFC] Cleanup: Replaces BB->getInstList().splice() with BB->splice().

vporpo created this revision. vporpo added reviewers: asbirlea, aeubanks. Herald added subscribers: ChuanqiXu, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is part of

[clang] 78acf91 - [perf-training] Support additional test suffixes

Author: Petr Hosek Date: 2022-11-30T05:36:46Z New Revision: 78acf911ee2c40f8d5e78603e446710d35bd URL: https://github.com/llvm/llvm-project/commit/78acf911ee2c40f8d5e78603e446710d35bd DIFF: https://github.com/llvm/llvm-project/commit/78acf911ee2c40f8d5e78603e446710d35bd.diff LOG: [p

[PATCH] D138975: [perf-training] Support additional test suffixes

This revision was automatically updated to reflect the committed changes. Closed by commit rG78acf911eddd: [perf-training] Support additional test suffixes (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138975/new/ https://revie

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added a comment. Oops! Thank you for your thoughtful consideration. You're right, but I currently get stuck there and need more time. And I prefer to clear the existing patches simultaneously if you don't mind. Or do you think I should merge the modification of this patch into ther

[clang] 862c3d4 - Fix obvious typo

Author: Gabriel F. T. Gomes Date: 2022-11-30T14:01:08+08:00 New Revision: 862c3d4fbe185c3d77c067e6e6ad1f07082a31e1 URL: https://github.com/llvm/llvm-project/commit/862c3d4fbe185c3d77c067e6e6ad1f07082a31e1 DIFF: https://github.com/llvm/llvm-project/commit/862c3d4fbe185c3d77c067e6e6ad1f07082a31e1

[PATCH] D117836: Fix obvious typo

This revision was automatically updated to reflect the committed changes. Closed by commit rG862c3d4fbe18: Fix obvious typo (authored by gftg, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117836/new/ https://reviews.llvm.org/

[clang] dabd239 - [CMake] Support injecting extra dependencies for perf-training

Author: Petr Hosek Date: 2022-11-30T06:13:33Z New Revision: dabd2391765154848d35f172fbbeb68c88ff9dd4 URL: https://github.com/llvm/llvm-project/commit/dabd2391765154848d35f172fbbeb68c88ff9dd4 DIFF: https://github.com/llvm/llvm-project/commit/dabd2391765154848d35f172fbbeb68c88ff9dd4.diff LOG: [C

[PATCH] D138974: [CMake] Support injecting extra dependencies for perf-training

This revision was automatically updated to reflect the committed changes. Closed by commit rGdabd23917651: [CMake] Support injecting extra dependencies for perf-training (authored by phosek). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:93 +// Return true if `LHS` is declared in `RHS` +bool declareIn(const NamedDecl *LHS, const DeclContext *RHS) { + const auto *D = LHS->getDeclContext(); -

[PATCH] D138964: Fixed a few spelling errors in clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td

tbaeder added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/CheckerBase.td:102 +/// Note that a checker has a name (e.g.: 'NullDereference'), and a full name, +/// that is auto-generated with the help of the ParentPackage field, that also /// includes

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

bigdavedev added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9 +that could instead be moved into an anonymous namespace. It also detects +instances moved to an anonymous namespace that still keep the redundant +``stati

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478814. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files: clang/in

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(), --

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478818. usaxena95 added a comment. Removed extraneous colons from diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files: clang/include/clang/AST/ASTCo

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478819. usaxena95 added a comment. Remove unintended whitespaces and new lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files: clang/include/clang/AST/AST

[PATCH] D138930: [RISCV] Add macro to imply compiler availability on RISC-V Vector intrinsics version

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM. I am thinking that we should use same way to define both `__riscv_v_intrinsic_overloading`[1] and `__riscv_v_intrinsic`, `__riscv_v_intrinsic_overloading` is defined in `riscv_v

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

jmciver updated this revision to Diff 478821. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2) Refactor test matrix-type-operators.c to contain the noundef attribute. This test will be fu

[PATCH] D136848: [clang][AST] Compare UnresolvedLookupExpr in structural equivalence.

balazske added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136848/new/ https://reviews.llvm.org/D136848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh updated this revision to Diff 478823. Pierre-vh marked 5 inline comments as done. Pierre-vh added a comment. - Recentering the patch around HIP only. - I was using too much from D57369 and was involving OpenMP when there's no reason to. Just checking

<    1   2   3