[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands added a comment. Re the whitespace - yeah that's me running clang-format on the whole function rather than just the lines I changed. I'll see if I can split those out. Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + Vis

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

xen0n added a comment. otherwise LGTM Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValu

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValueType

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin updated this revision to Diff 477393. gonglingqin added a comment. Address @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138418/new/ https://reviews.llvm.org/D138418 Files: clang/include/clang/Basic/BuiltinsLoongAr

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

courbet added a subscriber: titeup. courbet added a comment. In D97854#3944804 , @olologin wrote: > @courbet > Hi, sorry for pinging you. > Is this review stalled? Is there a reason for this? Judging by paper this > sanitizer looks promising. I was recen

[PATCH] D138377: add clang_Type_getFullyQualifiedName

anderslanglands added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + VisitorData *Data = (VisitorData *)d; PrintSingleTypeSize(T, " [type=%s] [typekind=%s]", " [sizeof=%lld]", anderslanglands wrote: >

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL, N->getValueType(

<    1   2   3