[PATCH] D137839: [Sema] check InitListExpr format strings like {"foo"}

inclyc added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137839/new/ https://reviews.llvm.org/D137839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] d584468 - [C++20] [Modules] Don't emit macro definitions with named module

Author: Chuanqi Xu Date: 2022-11-18T11:11:17+08:00 New Revision: d5844685810980399397a4310b943532361790ef URL: https://github.com/llvm/llvm-project/commit/d5844685810980399397a4310b943532361790ef DIFF: https://github.com/llvm/llvm-project/commit/d5844685810980399397a4310b943532361790ef.diff LO

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ created this revision. NoQ added reviewers: aaron.ballman, gribozavr2, xazax.hun, jkorous, t-rasmud, ziqingluo-90, malavikasamak. Herald added subscribers: steakhal, martong, rnkovacs. Herald added a project: All. NoQ requested review of this revision. This patch adds more abstractions that w

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3935391 , @MaskRay wrote: > In D137753#3935305 , @francii wrote: > >> Recall that the goal with `-p` is to create parity with GCC (at least with >> Linux and AIX), as per the R

[PATCH] D138254: [llvm] Remove LLVM_VERSION_SUFFIX from created shared library names

brad created this revision. brad added reviewers: thieta, tstellar, beanz. brad added a project: LLVM. Herald added a subscriber: krytarowski. Herald added a project: All. brad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes buil

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:236 + using UseSetTy = SmallSet; + using DefMapTy = DenseMap; + This extra payload wasn't advertised but it's very useful because it's hard to jump from `VarDecl` to `DeclStmt` wit

[PATCH] D138255: [Driver] -p: change from unused warning to error for most targets

MaskRay created this revision. MaskRay added reviewers: francii, hubert.reinterpretcast, cebowleratibm, thesamesam, brad. Herald added subscribers: StephenFan, krytarowski, arichardson, emaste. Herald added a reviewer: ctetreau. Herald added a project: All. MaskRay requested review of this revisio

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. In D137753#3935617 , @francii wrote: > In D137753#3935391 , @MaskRay wrote: > >> In D137753#3935305 , @francii >> wrote: >> >>> Recall that the g

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476320. mhjacobson added a comment. Herald added a subscriber: mstorsjo. Style fixes. Ensure include paths are sequential. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/

[clang] 1614d63 - [NFC] Remove unused codes after 4a7be42d922af

Author: Chuanqi Xu Date: 2022-11-18T11:52:44+08:00 New Revision: 1614d6340597d29ca8214acc2eff80df50392d36 URL: https://github.com/llvm/llvm-project/commit/1614d6340597d29ca8214acc2eff80df50392d36 DIFF: https://github.com/llvm/llvm-project/commit/1614d6340597d29ca8214acc2eff80df50392d36.diff LO

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

NoQ added a comment. > My biggest request is: please try to keep this document in sync with reality > so that we don't introduce confusion to the reviews. Yes, so we'll need the code to incrementally catch up to the document, but I'm absolutely updating this document every time the vision itsel

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:236 + using UseSetTy = SmallSet; + using DefMapTy = DenseMap; + NoQ wrote: > This extra payload wasn't advertised but it's very useful because it's hard > to jump from `VarDecl` to

[PATCH] D138194: [clang][Parser][NFC] Simplify ParseParenExprOrCondition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6147900739: [clang][Parser][NFC] Simplify ParseParenExprOrCondition (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D13

[clang] 9f61479 - [clang][Parser][NFC] Simplify ParseParenExprOrCondition

Author: Timm Bäder Date: 2022-11-18T04:53:59+01:00 New Revision: 9f614790073999c2da69101c77b783a90c1af5ca URL: https://github.com/llvm/llvm-project/commit/9f614790073999c2da69101c77b783a90c1af5ca DIFF: https://github.com/llvm/llvm-project/commit/9f614790073999c2da69101c77b783a90c1af5ca.diff LO

[clang] e78a43d - [clang][Parse][NFC] Remove unused CommaLocs parameters

Author: Timm Bäder Date: 2022-11-18T04:54:00+01:00 New Revision: e78a43dacafb8b97fc377a52f8f206e37d94d5d6 URL: https://github.com/llvm/llvm-project/commit/e78a43dacafb8b97fc377a52f8f206e37d94d5d6 DIFF: https://github.com/llvm/llvm-project/commit/e78a43dacafb8b97fc377a52f8f206e37d94d5d6.diff LO

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thanks! Comment at: clang-tools-extra/clangd/unittests/Annotations.h:29 - Position point(llvm::StringRef Name = "") const; + clangd::Position point(llvm:

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

sammccall added a comment. (please update the commit message too since the design changed) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137909/new/ https://reviews.llvm.org/D137909 ___ cfe-commits maili

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

rjmccall added a comment. I'm too often slow to actually apply edits to the ABI document. There's been plenty of time for feedback on this one; go ahead and act like it's accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126818/new/ https://reviews.llvm.org/D126818

[clang] ab9eac7 - [OpenMP] Initial parsing/sema for 'strict' modifier with 'grainsize' clause

Author: Fazlay Rabbi Date: 2022-11-17T20:59:07-08:00 New Revision: ab9eac762c35068e77f57795e660d06f578c9614 URL: https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614 DIFF: https://github.com/llvm/llvm-project/commit/ab9eac762c35068e77f57795e660d06f578c9614.diff

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rGab9eac762c35: [OpenMP] Initial parsing/sema for 'strict' modifier with 'grainsize' clause (authored by mdfazlay, committed by mikerice). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 34ab474 - [opt][clang] Enable using -module-summary/-flto=thin with -S/-emit-llvm

Author: Alexander Shaposhnikov Date: 2022-11-18T05:04:07Z New Revision: 34ab474348e2623cc67abddb7bb662385297ac65 URL: https://github.com/llvm/llvm-project/commit/34ab474348e2623cc67abddb7bb662385297ac65 DIFF: https://github.com/llvm/llvm-project/commit/34ab474348e2623cc67abddb7bb662385297ac65.d

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. Please mark review comments as done if you have addressed them. Can you also clean up the test cases, removing overlapping/redundant ones, making sure a test case doesn't end with a newline (e.g., line 5380), etc? Comment at: clang/lib/Format/Unwrappe

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. Yeah quite complex: https://godbolt.org/z/8T5Pqadro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/ https://reviews.llvm.org/D131295 ___ cfe-commits mailing list cfe-co

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:838 + // If this changes PPLevel needs to be used for get correct indentation. + assert(!(Line.InMacroBody && InPPDirective)); return Line.Level * Style.IndentWidth + Length <= ColumnLimit; -

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. This fixes a bug where tests would be disabled when LLVM_EXTERNAL_LIT was set if lit couldn't be found in a

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 14 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst, Src.is

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder updated this revision to Diff 476334. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476336. mhjacobson added a comment. Make the tests play nice with Windows path separators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Drive

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

MaskRay added a comment. > This matches OpenBSD, and it supports Swift's use of clang for its C interop > functionality. Recent changes to Swift use AddClangSystemIncludeArgs() to > inspect the cc1 args; this doesn't work for platforms where cc1 adds standard > include paths implicitly. Use a

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476337. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:69-75 + if (Line.InMacroBody) { +Indent = (Line.PPLevel + 1) * PPIndentWidth; +Indent += (Line.Level - Line.PPLevel - 1) * Style.IndentWidth; +Indent += Style

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3935752 , @owenpan wrote: > Please mark review comments as done if you have addressed them. Can you also > clean up the test cases, removing overlapping/redundant ones, making sure a > test case doesn't end with

[PATCH] D138234: [clang-format] Support new file formatting with vim

owenpan added inline comments. Comment at: clang/tools/clang-format/clang-format.py:48 import vim +import os.path Can you move it up to keep the module names sorted? Comment at: clang/tools/clang-format/clang-format.py:80 lines = ['-lin

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false);

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

akuegel added a comment. This introduced a dependency cycle: .-> @llvm-project//llvm:Analysis (2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) | @llvm-project//llvm:ProfileData (2825ebc8f5626030529afe0ae5a7d8790a8fc29e6765de6d31c86c448fd5e767) | | @llvm-project//llvm:Symboliz

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3935856 , @goldstein.w.n wrote: > In D137181#3935752 , @owenpan wrote: > >> Please mark review comments as done if you have addressed them. Can you also >> clean up the test c

[clang] ba7a1d9 - [Driver] move FreeBSD header search path management to the driver

Author: Matt Jacobson Date: 2022-11-18T02:29:49-05:00 New Revision: ba7a1d9e4aec5399e9cd45e47c7a548b1514b8ba URL: https://github.com/llvm/llvm-project/commit/ba7a1d9e4aec5399e9cd45e47c7a548b1514b8ba DIFF: https://github.com/llvm/llvm-project/commit/ba7a1d9e4aec5399e9cd45e47c7a548b1514b8ba.diff

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7a1d9e4aec: [Driver] move FreeBSD header search path management to the driver (authored by mhjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13818

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. I suppose it's fairly easy to annotate the `l_brace` of a namespace? If so, then wouldn't it be better to do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

akuegel added a comment. Fixed it in https://reviews.llvm.org/D138266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138258/new/ https://reviews.llvm.org/D138258 ___

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

mgorny added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT LLVM_E

[PATCH] D137885: [modules] Support zstd in .pcm file

MaskRay updated this revision to Diff 476360. MaskRay marked an inline comment as done. MaskRay added a comment. add a comment about the zlib header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137885/new/ https://reviews.llvm.org/D137885 Files:

<    1   2   3