[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:538-539 let allowedClauses = [ -VersionedClause +VersionedClause, +VersionedClause ]; ABataev wrote: > Add a version where these clauses were introduced Thanks. Ch

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

ABataev added a comment. Looks like you dud not add corresponding definitions to llvm/Frontend CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138217/new/ https://reviews.llvm.org/D138217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 476196. gedare added a comment. - fixup: use simpler logic for handling rparens - Revert "fixup: port other EXPECT_EQ to verifyFormat" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.ll

[PATCH] D138227: [OPENMP]Initial support for severity clause

ABataev added inline comments. Comment at: clang/test/OpenMP/error_message.cpp:85 return T(); } Di you have a test for tge directive with 2 or more severity clauses? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 8173405 - [CUDA] make use of deprecated texture API conditional on CUDA version.

Author: Artem Belevich Date: 2022-11-17T11:38:16-08:00 New Revision: 817340569bf98b696329c53508a0d87cc0daec25 URL: https://github.com/llvm/llvm-project/commit/817340569bf98b696329c53508a0d87cc0daec25 DIFF: https://github.com/llvm/llvm-project/commit/817340569bf98b696329c53508a0d87cc0daec25.diff

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476197. mdfazlay added a comment. Added static_cast<>. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138217/new/ https://reviews.llvm.org/D138217 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. I have changed the code as recommended by @owenpan with new unit tests passing, and reverting the modifications to existing unit tests. Someone else may janitor the EXPECT_EQ blocks separately. I will not be able to look at this again for ~2 weeks. with luck it is ready

[clang] 7b6fe71 - Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

Author: Vaibhav Yenamandra Date: 2022-11-17T14:47:02-05:00 New Revision: 7b6fe711b210a90cbb8facfe5343a0f999de5a0c URL: https://github.com/llvm/llvm-project/commit/7b6fe711b210a90cbb8facfe5343a0f999de5a0c DIFF: https://github.com/llvm/llvm-project/commit/7b6fe711b210a90cbb8facfe5343a0f999de5a0c.

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

aaron.ballman closed this revision. aaron.ballman added a comment. I've landed in 7b6fe711b210a90cbb8facfe5343a0f999de5a0c on your behalf, thank you for the improvements! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 476203. francii added a comment. Specify prof and gprof in help text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions

[PATCH] D136176: Implement support for option 'fexcess-precision'.

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:320 BENIGN_ENUM_LANGOPT(FPEvalMethod, FPEvalMethodKind, 2, FEM_UnsetOnCommandLine, "FP type used for floating point arithmetic") +BENIGN_ENUM_LANGOPT(FPPrecisionMode, FPExcessPrecisionModeKind

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

owenpan accepted this revision. owenpan added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D138224: WIP: AST{Reader,Writer} alternative

jansvoboda11 updated this revision to Diff 476205. jansvoboda11 added a comment. Prevent module redefinition errors, fix memory leak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138224/new/ https://reviews.llvm.org/D138224 Files: clang/include/

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay added a comment. In D138217#3934677 , @ABataev wrote: > Looks like you dud not add corresponding definitions to llvm/Frontend Do you mean in //llvm/include/llvm/Frontend/OpenMP/OMP.td// file? CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov updated this revision to Diff 476208. alexander-shaposhnikov edited the summary of this revision. alexander-shaposhnikov added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138081/new/ https://revie

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

alexander-shaposhnikov updated this revision to Diff 476209. alexander-shaposhnikov added a comment. Rebase on top of https://reviews.llvm.org/D138081 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 Files

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

ABataev added a comment. In D138217#3934786 , @mdfazlay wrote: > In D138217#3934677 , @ABataev wrote: > >> Looks like you dud not add corresponding definitions to llvm/Frontend > > Do you mean in //llvm/include/ll

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

alexander-shaposhnikov updated this revision to Diff 476210. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 Files: clang/lib/CodeGen/BackendUtil

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Driver.h:239 + /// enviroment variable CC_PRINT_HEADERS_FORMAT. + std::string CCPrintHeadersFormat; Can we make this `HeaderIncludeFormatEnum` instead of `std::string`? =

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 updated this revision to Diff 476212. jyu2 added a comment. Thanks Alexey! Address his comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 Files: clang/include/clang/AST/OpenMPClause.h clan

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 added inline comments. Comment at: clang/test/OpenMP/error_message.cpp:85 return T(); } ABataev wrote: > Di you have a test for tge directive with 2 or more severity clauses? Sorry, added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D138227: [OPENMP]Initial support for severity clause

ABataev added inline comments. Comment at: clang/test/OpenMP/error_ast_print.cpp:16 // CHECK: static int a; -// CHECK-NEXT: #pragma omp error at(execution) +// CHECK-NEXT: #pragma omp error at(execution) severity(fatal // CHECK-NEXT: a = argv[0][0]; Missed `)`

[PATCH] D138234: [clang-format] Support new file formatting with vim

jsji created this revision. jsji added reviewers: djasper, klimek. Herald added a project: All. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The vim Formatonsave integration is not working if we create a new file directly using vim

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson accepted this revision. tejohnson added a comment. lgtm with one comment update still needed Comment at: llvm/lib/IR/IRPrintingPasses.cpp:9 // // PrintModulePass and PrintFunctionPass implementations. // tejohnson wrote: > Update comment Please upd

[PATCH] D138073: [clang-doc] Move file layout to the generators.

paulkirth added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137939/new/ https://reviews.llvm.org/D137939

[PATCH] D138160: [clang] Use InMemoryModuleCache for readASTFileControlBlock NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Does this give us measurable perf improvement? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138160/new/ https://reviews.llvm.

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

ymandel added a comment. In D138204#3933861 , @v1nh1shungry wrote: > @ymandel Thank you for reviewing! > > If this patch is okay to land, could you please help me commit it? Thanks > again! Sure. I'm running tests now and, assuming all's green, i'll co

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 476220. dgoldman marked 10 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-e

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 updated this revision to Diff 476223. jyu2 added a comment. Thanks Alexey! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Re

[PATCH] D138227: [OPENMP]Initial support for severity clause

jyu2 added inline comments. Comment at: clang/test/OpenMP/error_ast_print.cpp:16 // CHECK: static int a; -// CHECK-NEXT: #pragma omp error at(execution) +// CHECK-NEXT: #pragma omp error at(execution) severity(fatal // CHECK-NEXT: a = argv[0][0]; ABataev wrote:

[PATCH] D138031: Add clang-tidy check for missing move constructors

mbid added a comment. Hi Nathan, thanks for looking into this. I did indeed not know about the existing check in cppcoreguidelines -- maybe I should've been more suspicious about assuming something so obvious supposedly doesn't exist yet :) But perhaps the replacements could still be integrated

[PATCH] D138227: [OPENMP]Initial support for severity clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138227/new/ https://reviews.llvm.org/D138227 ___

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. Please make `-p` accepted for AIX only and don't change the semantics for other targets. For FreeBSD and Linux (musl and gnu) we can try rejecting `-p`. If OpenBSD wants to make `-p` an alias for `-pg`, that's fine. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] c4436f6 - [clang] Use InMemoryModuleCache for readASTFileControlBlock NFC

Author: Ben Langmuir Date: 2022-11-17T13:47:46-08:00 New Revision: c4436f675d8f5903303fc13d2c2eff2c5800d49b URL: https://github.com/llvm/llvm-project/commit/c4436f675d8f5903303fc13d2c2eff2c5800d49b DIFF: https://github.com/llvm/llvm-project/commit/c4436f675d8f5903303fc13d2c2eff2c5800d49b.diff

[PATCH] D138160: [clang] Use InMemoryModuleCache for readASTFileControlBlock NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4436f675d8f: [clang] Use InMemoryModuleCache for readASTFileControlBlock NFC (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders updated this revision to Diff 476230. tom-anders marked 8 inline comments as done. tom-anders added a comment. Use std::pair for returning payloads along with points/ranges. Also, refactor internal logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D137909: [Support] Allow complex names for annotation points and ranges via ${}

tom-anders added a comment. In D137909#3933730 , @sammccall wrote: > Thanks! sorry about continuing to drift this patch, but this looks like a > great improvement. No problem! I wasn't quite happy yet with the previous version of this patch either, rea

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov added inline comments. Comment at: llvm/lib/IR/IRPrintingPasses.cpp:9 // // PrintModulePass and PrintFunctionPass implementations. // tejohnson wrote: > tejohnson wrote: > > Update comment > Please update this comment before committing,

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

nicovank added a comment. Ping. @njames93 If you have a minute, could you please take a second look at this? Let me know what's needed to get this change landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131939/new/ https://reviews.llvm.org/D

[clang] eb2a57e - Add generic KCFI operand bundle lowering

Author: Sami Tolvanen Date: 2022-11-17T21:55:00Z New Revision: eb2a57ebc7aaad551af30462097a9e06c96db925 URL: https://github.com/llvm/llvm-project/commit/eb2a57ebc7aaad551af30462097a9e06c96db925 DIFF: https://github.com/llvm/llvm-project/commit/eb2a57ebc7aaad551af30462097a9e06c96db925.diff LOG:

[PATCH] D135411: Add generic KCFI operand bundle lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb2a57ebc7aa: Add generic KCFI operand bundle lowering (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135411/new/ https://reviews

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/GwpAsan.rst:174 ++-++

Re: How can Autoconf help with the transition to stricter compilation defaults?

Am Thu, Nov 17, 2022 at 10:58:52AM -0800 schrieb Paul Eggert via cfe-commits: > On 2022-11-16 10:59, Zack Weinberg wrote: > > I'm generally in agreement with Rich Felker's argument > > (inhttps://ewontfix.com/13/) that AC_CHECK_FUNC*should not* just probe for > > linkability of a symbol > > So

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. Thanks, it seems to be that simple case, but I still see multiple lenses when I add template int Foo::foo() { return 0; } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/ https://reviews.llvm.org/D

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim updated this revision to Diff 476241. hctim marked 2 inline comments as done. hctim added a comment. Remove unrelated diff from doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 Files: clang/li

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added inline comments. Comment at: llvm/docs/GwpAsan.rst:174 ++-++ -| PerfectlyRightAlign| false | When allocations are right-aligned, should we

[clang] c9320bc - [X86] Use correctly sized floating point literals in *zero_ps/pd.

Author: Craig Topper Date: 2022-11-17T14:28:52-08:00 New Revision: c9320bc87121af2a198f174c8d58f75295efbbd7 URL: https://github.com/llvm/llvm-project/commit/c9320bc87121af2a198f174c8d58f75295efbbd7 DIFF: https://github.com/llvm/llvm-project/commit/c9320bc87121af2a198f174c8d58f75295efbbd7.diff

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:16 +#include "llvm/ADT/Statistic.h" +#include "llvm/CodeGen/TargetLowering.h" +#include "llvm/CodeGen/TargetSubtargetInfo.h" Sorry, I just noticed this include. lib/Transforms

[clang] fc91c70 - Revert D135411 "Add generic KCFI operand bundle lowering"

Author: Fangrui Song Date: 2022-11-17T22:45:30Z New Revision: fc91c705937d7ba3b92da38f3a883dde720c41f2 URL: https://github.com/llvm/llvm-project/commit/fc91c705937d7ba3b92da38f3a883dde720c41f2 DIFF: https://github.com/llvm/llvm-project/commit/fc91c705937d7ba3b92da38f3a883dde720c41f2.diff LOG:

[clang-tools-extra] 8003c1d - [clang-tidy] Fix misc-unused-using-decls for user-defined literals

Author: v1nh1shungry Date: 2022-11-17T22:47:15Z New Revision: 8003c1d61e69142cb6e87df719c17f3c4ad86c98 URL: https://github.com/llvm/llvm-project/commit/8003c1d61e69142cb6e87df719c17f3c4ad86c98 DIFF: https://github.com/llvm/llvm-project/commit/8003c1d61e69142cb6e87df719c17f3c4ad86c98.diff LOG:

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG8003c1d61e69: [clang-tidy] Fix misc-unused-using-decls for user-defined literals (authored by v1nh1shungry, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. In D137753#3934932 , @MaskRay wrote: > Please make `-p` accepted for AIX only and don't change the semantics for > other targets in this patch. For FreeBSD and Linux (musl and gnu) we can try > rejecting `-p`. If OpenBSD wants t

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

aaronpuchert added a comment. This include-if-exists mechanism seems brittle to me. Can we not make it dependent on the triple, i.e. include the file if we're using a libc implementation that's known to provide (and require) this file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. In D137753#3935126 , @francii wrote: > In D137753#3934932 , @MaskRay wrote: > >> Please make `-p` accepted for AIX only and don't change the semantics for >> other targets in this patch.

[clang] 98bfd7f - Fix declare target implementation to support enter.

Author: Doru Bercea Date: 2022-11-17T17:35:53-06:00 New Revision: 98bfd7f976f166e2eb7b444f3ee86843815ca73c URL: https://github.com/llvm/llvm-project/commit/98bfd7f976f166e2eb7b444f3ee86843815ca73c DIFF: https://github.com/llvm/llvm-project/commit/98bfd7f976f166e2eb7b444f3ee86843815ca73c.diff L

[PATCH] D138159: [Clang][OpenMP] Add enter clause to declare target for OpenMP 5.2

doru1004 closed this revision. doru1004 added a comment. Commit: 98bfd7f976f166e2eb7b444f3ee86843815ca73c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138159/new/ https://revie

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

phosek added a comment. Is the plan to eventually rename `scudo_standalone` to `scudo` once the santiizer-based Scudo implementation is deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138157/new/ https://reviews.llvm.org/D138157 __

[PATCH] D138157: Make -fsanitize=scudo use scudo_standalone. Delete check-scudo.

hctim added a comment. In D138157#3935173 , @phosek wrote: > Is the plan to eventually rename `scudo_standalone` to `scudo` once the > santiizer-based Scudo implementation is deleted? Ideally, yes (as well as make scudo_standalone not be in a subfolder)

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

mdfazlay updated this revision to Diff 476259. mdfazlay added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Added corresponding definitions in// llvm/include/llvm/Frontend/OpenMP/OMP.td// file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138217/new/

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

jansvoboda11 added a comment. In D135128#3926404 , @stella.stamenova wrote: > In D135128#3921902 , @jansvoboda11 > wrote: > >> @stella.stamenova Any updates? > > We haven't had time to come up with a proper solu

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

anderslanglands updated this revision to Diff 476261. anderslanglands added a comment. Added release note, incorporated other review notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137818/new/ https://reviews.llvm.org/D137818 Files: clang/do

[PATCH] D135411: Add generic KCFI operand bundle lowering

samitolvanen updated this revision to Diff 476260. samitolvanen added a comment. Dropped the CodeGen dependency. Note that Clang already only adds KCFIPass for targets that don't support back-end lowering, so the check in the pass itself was a bit redundant. The existing CodeGen/kcfi.c test also

[PATCH] D138217: [OpenMP] Initial parsing and semantic analysis support for 'strict' modifier with 'grainsize' clause of 'taskloop' construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138217/new/ https://reviews.llvm.org/D138217 ___ cfe-commits mailing list cfe-commits@l

[clang] 1e054e6 - [OPENMP5.1] Initial support for severity clause

Author: Jennifer Yu Date: 2022-11-17T16:05:02-08:00 New Revision: 1e054e6b522b3f7e13c30caebfa63aafc7173220 URL: https://github.com/llvm/llvm-project/commit/1e054e6b522b3f7e13c30caebfa63aafc7173220 DIFF: https://github.com/llvm/llvm-project/commit/1e054e6b522b3f7e13c30caebfa63aafc7173220.diff L

[PATCH] D138227: [OPENMP]Initial support for severity clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e054e6b522b: [OPENMP5.1] Initial support for severity clause (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a72d8d7 - Update lambda mangling test to C++17

Author: David Blaikie Date: 2022-11-18T00:24:40Z New Revision: a72d8d704178118b254d9ff84a78afb18813b888 URL: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888 DIFF: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888.diff LOG:

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii added a comment. Recall that the goal with `-p` is to create parity with GCC (at least with Linux and AIX), as per the RFC discussion. In D137753#3935138 , @MaskRay wrote: > In D137753#3935126 , @francii

[clang] 6536a67 - [Linux] Revert 1e56821bac02a5d3c6249bbf3ef43b8b569d2551

Author: Brad Smith Date: 2022-11-17T19:48:01-05:00 New Revision: 6536a67338fceece914746d3f654e5f2e881f73b URL: https://github.com/llvm/llvm-project/commit/6536a67338fceece914746d3f654e5f2e881f73b DIFF: https://github.com/llvm/llvm-project/commit/6536a67338fceece914746d3f654e5f2e881f73b.diff LO

[PATCH] D136515: [builtins] Add __builtin_assume_separate_storage.

davidtgoldblatt created this revision. Herald added a project: All. davidtgoldblatt updated this revision to Diff 476281. davidtgoldblatt added a comment. davidtgoldblatt updated this revision to Diff 476283. davidtgoldblatt retitled this revision from "[builtins] add separate storage builtin supp

[clang-tools-extra] 2483a7f - [include-cleaner] Fix the build of include-cleaner with LLVM_BUILD_LLVM_DYLIB=ON

Author: Alexander Shaposhnikov Date: 2022-11-18T00:54:45Z New Revision: 2483a7fffbdf8e04addfbbf9f333155edc2c0346 URL: https://github.com/llvm/llvm-project/commit/2483a7fffbdf8e04addfbbf9f333155edc2c0346 DIFF: https://github.com/llvm/llvm-project/commit/2483a7fffbdf8e04addfbbf9f333155edc2c0346.d

[clang-tools-extra] f962daf - [include-cleaner] Fix -DBUILD_SHARED_LIBS=on build

Author: Fangrui Song Date: 2022-11-18T00:56:04Z New Revision: f962dafbbdf61234bfa51bde95e2e5c52a02e9b9 URL: https://github.com/llvm/llvm-project/commit/f962dafbbdf61234bfa51bde95e2e5c52a02e9b9 DIFF: https://github.com/llvm/llvm-project/commit/f962dafbbdf61234bfa51bde95e2e5c52a02e9b9.diff LOG:

[clang-tools-extra] 4620254 - [CMake] Remove a duplicate clangLex entry

Author: Fangrui Song Date: 2022-11-18T00:58:04Z New Revision: 46202543c9ba4dd2aca355b3b553ce9caeed9a80 URL: https://github.com/llvm/llvm-project/commit/46202543c9ba4dd2aca355b3b553ce9caeed9a80 DIFF: https://github.com/llvm/llvm-project/commit/46202543c9ba4dd2aca355b3b553ce9caeed9a80.diff LOG:

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

dblaikie created this revision. dblaikie added reviewers: clang-vendors, rsmith, probinson, rjmccall. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://llvm.org/pr58819 - clang is giving an extern

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

MaskRay added a comment. In D137753#3935305 , @francii wrote: > Recall that the goal with `-p` is to create parity with GCC (at least with > Linux and AIX), as per the RFC discussion. > > In D137753#3935138 , @Ma

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/KCFI.h:24 +public: + KCFIPass() {} + static bool isRequired() { return true; } remove default constructor? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138249: [WebAssembly] Update relaxed-simd instruction names

tlively created this revision. tlively added reviewers: aheejin, maratyszcza. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM.

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb71b5e1d13: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches. (authored by vsapsai). Repository: rG LLVM Github Monorepo CH

[clang] dcb71b5 - [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-11-17T17:22:03-08:00 New Revision: dcb71b5e1d1311c41f409c8dab26e04b084875be URL: https://github.com/llvm/llvm-project/commit/dcb71b5e1d1311c41f409c8dab26e04b084875be DIFF: https://github.com/llvm/llvm-project/commit/dcb71b5e1d1311c41f409c8dab26e04b084875be.di

[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130326/new/ https://reviews.llvm.org/D130326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 7059a6c - [IR] Split out IR printing passes into IRPrinter

Author: Alexander Shaposhnikov Date: 2022-11-18T01:47:56Z New Revision: 7059a6c32cfad8f272fad47265e3890cd7a1a7e1 URL: https://github.com/llvm/llvm-project/commit/7059a6c32cfad8f272fad47265e3890cd7a1a7e1 DIFF: https://github.com/llvm/llvm-project/commit/7059a6c32cfad8f272fad47265e3890cd7a1a7e1.d

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7059a6c32cfa: [IR] Split out IR printing passes into IRPrinter (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa added a comment. In D138179#3934543 , @MaskRay wrote: > Rubber stamp. I try to find some mips folks who can verify, so maybe wait a > day or so. > >> When we use llc or lld to compiler IR files, the features +nan2008 and >> +fpxx/+fp64 are not u

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu added a comment. Thanks for every one to review this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476302. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s llvm/lib/Target/Mips/MipsAs

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

wzssyqa updated this revision to Diff 476303. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 Files: clang/lib/Driver/ToolChains/Arch/Mips.cpp clang/test/Driver/mips-as.c clang/test/Driver/mips-integrated-as.s llvm/lib/Target/Mips/MipsAs

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. In D137043#3935129 , @aaronpuchert wrote: > This include-if-exists mechanism seems brittle to me. Do you mean the way that we used to test a file and include it (inserting `#if __has_include`) is brittle or compilation flags

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai created this revision. vsapsai added reviewers: jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before the fix the scanning would fai

[PATCH] D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas.

vsapsai added a comment. Should admit that approach with `DiagOpts.IgnoreWarnings` is pretty blunt but I'm not aware of any reasons to use something more elaborate, like stripping away all `-Werror=...` flags. So going with a simple change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf marked an inline comment as done. qiucf added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 ___ cfe-commits mailing list cfe-commits@

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak updated this revision to Diff 476306. ahatanak marked 2 inline comments as done. ahatanak added a comment. Address review comments. Also, change check string in test case to fix pre-merge checks that were failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:251 + FileID MainID = SM.getMainFileID(); + std::string MainFilename; + jansvoboda11 wrote: > This can be `StringRef` I think. I simplified this part by removing the code that c

[clang] a65d530 - [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

Author: Volodymyr Sapsai Date: 2022-11-17T18:31:32-08:00 New Revision: a65d5309d5b73527efcbdec49a3ba9bba0fd873d URL: https://github.com/llvm/llvm-project/commit/a65d5309d5b73527efcbdec49a3ba9bba0fd873d DIFF: https://github.com/llvm/llvm-project/commit/a65d5309d5b73527efcbdec49a3ba9bba0fd873d.di

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa65d5309d5b7: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing. (authored by vsapsai). Repository: rG LLVM Github Monor

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai added a comment. Thanks for reviews! It was a long journey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130327/new/ https://reviews.llvm.org/D130327 ___ cfe-commits mailing list cfe-commits@lis

[clang] cab9c02 - [Clang] Fix behavior of -ffp-model option when overriden

Author: Qiu Chaofan Date: 2022-11-18T10:34:41+08:00 New Revision: cab9c02bd97f520cb8a01a9197505438581f7de8 URL: https://github.com/llvm/llvm-project/commit/cab9c02bd97f520cb8a01a9197505438581f7de8 DIFF: https://github.com/llvm/llvm-project/commit/cab9c02bd97f520cb8a01a9197505438581f7de8.diff L

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab9c02bd97f: [Clang] Fix behavior of -ffp-model option when overriden (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D137618?vs=475981&id=476309#toc Repository: rG LLVM Githu

[clang] 4a7be42 - [C++20] [Modules] Remove unmaintained Header Module

Author: Chuanqi Xu Date: 2022-11-18T10:39:33+08:00 New Revision: 4a7be42d922af0e2a60e08cbac062f57666c0003 URL: https://github.com/llvm/llvm-project/commit/4a7be42d922af0e2a60e08cbac062f57666c0003 DIFF: https://github.com/llvm/llvm-project/commit/4a7be42d922af0e2a60e08cbac062f57666c0003.diff LO

[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3935027 , @Trass3r wrote: > Thanks, it seems to fix the base case, but I still see multiple lenses when I > add > > template > int Foo::foo() > { > return 0; > } Interesting, I see the same issue

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a7be42d922a: [C++20] [Modules] Remove unmaintained Header Module (authored by ChuanqiXu). Herald added a subscriber: MaskRay. Changed prior to commit: https://reviews.llvm.org/D137609?vs=473884&id=4763

<    1   2   3   >