[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 475706. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsLoongArch.def:20-23 TARGET_BUILTIN(__builtin_loongarch_dbar, "vIUi", "nc", "") +TARGET_BUILTIN(__builtin_loongarch_ibar, "vIUi", "nc", "") +TARGET_BUILTIN(__builtin_loongarch_break, "vIUi", "nc", ""

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

gonglingqin updated this revision to Diff 475715. gonglingqin added a comment. Address @arsenm's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ https://reviews.llvm.org/D138094 Files: clang/include/clang/Basic/BuiltinsLoongA

[clang] d128a03 - [clang][Interp][NFC] Use constexpr if in OffsetHelper

Author: Timm Bäder Date: 2022-11-16T09:56:29+01:00 New Revision: d128a03ff3b1d3e48fae41a10e790faf3a775d35 URL: https://github.com/llvm/llvm-project/commit/d128a03ff3b1d3e48fae41a10e790faf3a775d35 DIFF: https://github.com/llvm/llvm-project/commit/d128a03ff3b1d3e48fae41a10e790faf3a775d35.diff LO

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689

ChuanqiXu updated this revision to Diff 475719. ChuanqiXu retitled this revision from "[C++20] [Modules] [ClangScanDeps] Support to query separate file for P1689 (3/3)" to "[C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689". ChuanqiXu edit

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, PowerPC, quinnp, stefanp. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commit

[clang] 0512303 - [clang][NFC] Remove unused CastForMoving parameter

Author: Timm Bäder Date: 2022-11-16T10:02:52+01:00 New Revision: 051230359c6e405a41ecad48162939f8a00c0532 URL: https://github.com/llvm/llvm-project/commit/051230359c6e405a41ecad48162939f8a00c0532 DIFF: https://github.com/llvm/llvm-project/commit/051230359c6e405a41ecad48162939f8a00c0532.diff LO

[clang] 981dac8 - [clang][Parse][NFC] Remove unused DenseMap

Author: Timm Bäder Date: 2022-11-16T10:02:52+01:00 New Revision: 981dac8bd6fef375847e81ea5df19d4e760532b8 URL: https://github.com/llvm/llvm-project/commit/981dac8bd6fef375847e81ea5df19d4e760532b8 DIFF: https://github.com/llvm/llvm-project/commit/981dac8bd6fef375847e81ea5df19d4e760532b8.diff LO

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138010/new/ https://reviews.llvm.org/D138010 _

[clang] 983f63f - [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

Author: Ties Stuij Date: 2022-11-16T10:20:14Z New Revision: 983f63f7f0d1643eb138db004351a18d1b3e91a3 URL: https://github.com/llvm/llvm-project/commit/983f63f7f0d1643eb138db004351a18d1b3e91a3 DIFF: https://github.com/llvm/llvm-project/commit/983f63f7f0d1643eb138db004351a18d1b3e91a3.diff LOG: [A

[PATCH] D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG983f63f7f0d1: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. Ping @Ericson2314 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice added a comment. Ping @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj created this revision. kawashima-fj added reviewers: masoud.ataei, zahiraam. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. `-fapprox-func` should be disabled by `-fp-mod

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

kawashima-fj added a comment. I found some errors in Clang Compiler User’s Manual . I will update of the Manual in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://revi

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

kadircet added a comment. yeah unfortunately testing this is hard, but bug&fix are obvious so it's fine to land without a test. but i think we should rather fix the broken call site at clang-tools-extra/clangd/ParsedAST.cpp and move `BuildDir` to outer scope where it'll outlive IncludeFixer (~

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

mgorny added a comment. Ah, I'm sorry for the delay. I have time right now, so I'll test and push it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 ___ cfe-co

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

kadircet added a comment. thanks for pinging @tom-anders , i've added some concerns about the behaviour in general. sorry if these are discussed somewhere else but i've missed. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294 +} +using n

[PATCH] D137919: [clangd] use fine-grained code action kinds

kadircet added a comment. as discussed in https://github.com/clangd/clangd/issues/1326#issuecomment-1313502572, we've decided to not move forward with the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137919/new/ https://reviews.llvm.org/

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

ilya-biryukov added a comment. We discussed this with Utkarsh offline, he's OOO for some time, so I wanted to leave the summary here. This patch attempts to attack the problem by keeping the information about substitution failure in template arguments of `ConceptSpecializationExpr`. However, it

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

urnathan added a comment. Thanks, I didn;'t know about ClassifyName, and obviously never hit a need to adjust it. Thanks for fixing. The comment above says we don't resolve member-access non-overload sets in order to check access. Do we still get that right for, say, class B { enum A {E

[PATCH] D138115: [clang] Short-circuit evaluation in ::EvaluateAsConstantExpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds another case to `FastEvaluateAsRValue()` for boolean expressio

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj created this revision. kawashima-fj added reviewers: zahiraam, andrew.w.kaylor. kawashima-fj added a project: clang. Herald added a project: All. kawashima-fj requested review of this revision. Herald added a subscriber: cfe-commits. Explanations for options of floating point are upda

[PATCH] D137531: [clang] Add the check of membership in decltype for the issue #58674

lime updated this revision to Diff 475768. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/decltype.cpp Index: clang/test/SemaCXX/decltype.cpp =

[PATCH] D138117: [clang][docs] Correct floating point option explanations

kawashima-fj added a comment. I don't know it is inteded that `-fno-fast-math` does not imply `-ftrapping-math` and `-frounding-math`. `-ffast-math` and `-fno-fast-math` is not symmetric in RenderFloatingPointOptions

[clang] b3f94fe - [clang][Driver] allow tilde in user config dir

Author: Michał Górny Date: 2022-11-16T13:23:25+01:00 New Revision: b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2 URL: https://github.com/llvm/llvm-project/commit/b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2 DIFF: https://github.com/llvm/llvm-project/commit/b3f94fe1c3c4f4fd7a937288b5543c4067b3e2f2.diff

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3f94fe1c3c4: [clang][Driver] allow tilde in user config dir (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews

Re: How can Autoconf help with the transition to stricter compilation defaults?

Can you cite any examples of a real-world security flaw what would be found by Clang erroring out because 'char foo(void);' is the wrong prototype? Is it plausible that any such security flaw exists? CVE-2006-1174 is a possibly reasonable example. CVE-2006-1174 is not an example, because no p

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Tue, Nov 15, 2022 at 15:09:19 -0800, Paul Eggert wrote: > This may be a hack, but it's a *good* hack. It's likely to fix > real-world bugs that would be caused if Clang becomes overly pedantic by > default here. And the probability of introducing real-world bugs is > essentially zero. FWIW,

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Tue, 15 Nov 2022, Sam James wrote: On 13 Nov 2022, at 00:43, Paul Eggert wrote: On 2022-11-11 07:11, Aaron Ballman wrote: We believe the runtime behavior is sufficiently dangerous to warrant a conservative view that any call to a function will be a call that gets executed at runtime, he

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @kadircet Thank you for reviewing and giving suggestions! Please check my reply to your concerns. Sorry if I misunderstood anything. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294 +} +using namespace ns1::

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

sgraenitz created this revision. sgraenitz added reviewers: rnk, efriedma, dblaikie, compnerd. Herald added subscribers: Enna1, wenlei, pengfei, hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added projects

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! FYI: there's still some unrelated formatting changes ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137960/new/ https://reviews.llvm.org/D137960 ___ cfe-commits mai

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294 +} +using namespace ns1::ns2; +using namespace ns1::ns3; v1nh1shungry wrote: > kadircet wrote: > > sorry i am having trouble understanding why

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. A scalar which exceeds 4 byte

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} This file should be renamed to return.c instead of current struct.c, I will do that in another patch, just let you see clearly what I

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please add a release note when landing so folks know about the improvements here. Thanks! Comment at: clang/include/clang/Basic/SourceManager.h:1695-1696

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

aykevl added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} benshi001 wrote: > This file should be renamed to return.c instead of current struct.c, I will > do that in another patch, just let you

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @kadircet Thank you for the excellent suggestions! Will dive into it to figure out the implementations. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294 +} +using namespace ns1::ns2; +using namespace ns1::ns

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 updated this revision to Diff 475808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138125/new/ https://reviews.llvm.org/D138125 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/return-value.c clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/r

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} aykevl wrote: > benshi001 wrote: > > This file should be renamed to return.c instead of cu

[PATCH] D138115: [clang] Short-circuit evaluation in ::EvaluateAsConstantExpr

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This seems to make sense to me. I'll accept, but please give others time to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

Re: How can Autoconf help with the transition to stricter compilation defaults?

Hi, On Tue, 15 Nov 2022, Paul Eggert wrote: > On 2022-11-15 11:27, Jonathan Wakely wrote: > > Another perspective is that autoconf shouldn't get in the way of > > making the C and C++ toolchain more secure by default. > > Can you cite any examples of a real-world security flaw what would be > f

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

aaron.ballman edited reviewers, added: eandrews; removed: elizabethandrews. aaron.ballman added a comment. I added the wrong account for Elizabeth, so fixing that up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Wed, 16 Nov 2022, Michael Matz via Gcc wrote: > I sympathize, and I would think a compiler emitting an error (not a > warning) in the situation at hand (in absence of -Werror) is overly > pedantic. But, could autoconf perhaps avoid the problem? AFAICS the > ac_fn_c_check_func really does

[clang] cb3f8d5 - [Lexer] Speedup LexTokenInternal

Author: serge-sans-paille Date: 2022-11-16T15:57:32+01:00 New Revision: cb3f8d53e6c35e6538ccbb54fdd848de2b3d0d1e URL: https://github.com/llvm/llvm-project/commit/cb3f8d53e6c35e6538ccbb54fdd848de2b3d0d1e DIFF: https://github.com/llvm/llvm-project/commit/cb3f8d53e6c35e6538ccbb54fdd848de2b3d0d1e.d

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3f8d53e6c3: [Lexer] Speedup LexTokenInternal (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D137960?vs=475699&id=475818#toc Repository: rG LLVM Github Monorepo

[PATCH] D138134: [include-cleaner] Defer decl->stdlib conversion into decl->location conversion

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. We preserve decls for stdlib symbols after this patch in symbol.

Re: How can Autoconf help with the transition to stricter compilation defaults?

Hey, On Wed, 16 Nov 2022, Alexander Monakov wrote: > > The idea is so obvious that I'm probably missing something, why autoconf > > can't use that idiom instead. But perhaps the (historic?) reasons why it > > couldn't be used are gone now? > > Ironically, modern GCC and LLVM optimize '&foobar

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. At some point, you should also add a release note to tell users about the new functionality. Comment at: clang/include/clang/AST/Type.h:4008 bool HasTrailingReturn : 1; +unsigned AArch64SMEAttributes : 8; Qualifiers TypeQuals; -

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

masoud.ataei accepted this revision. masoud.ataei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://reviews.llvm.org/D138109 ___

[clang] 6c38ffc - [Concepts] Fix friend-checking to include NTTPs

Author: Erich Keane Date: 2022-11-16T07:33:15-08:00 New Revision: 6c38ffc7b6f46fda94e29ed6cf34b814aeeaab45 URL: https://github.com/llvm/llvm-project/commit/6c38ffc7b6f46fda94e29ed6cf34b814aeeaab45 DIFF: https://github.com/llvm/llvm-project/commit/6c38ffc7b6f46fda94e29ed6cf34b814aeeaab45.diff L

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added inline comments. Comment at: lld/COFF/LTO.cpp:238 + sys::path::append(path, directory, +outputFileBaseName + ".lto." + baseName); + sys::path::remove_dots(path, true); MaskRay wrote: > What if two input bitcode fi

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Wed, Nov 16, 2022 at 4:02 PM Michael Matz via Gcc wrote: > > Hey, > > On Wed, 16 Nov 2022, Alexander Monakov wrote: > > > > The idea is so obvious that I'm probably missing something, why autoconf > > > can't use that idiom instead. But perhaps the (historic?) reasons why it > > > couldn't be

Re: How can Autoconf help with the transition to stricter compilation defaults?

> On 16 Nov 2022, at 15:27, Richard Biener wrote: > > On Wed, Nov 16, 2022 at 4:02 PM Michael Matz via Gcc wrote: >> >> Hey, >> >> On Wed, 16 Nov 2022, Alexander Monakov wrote: >> The idea is so obvious that I'm probably missing something, why autoconf can't use that idiom instead

[clang-tools-extra] e5739eb - [include-cleaner] Defer decl->stdlib conversion into decl->location conversion

Author: Kadir Cetinkaya Date: 2022-11-16T16:52:39+01:00 New Revision: e5739eb4f8135e20da7590c86d724920fd66753e URL: https://github.com/llvm/llvm-project/commit/e5739eb4f8135e20da7590c86d724920fd66753e DIFF: https://github.com/llvm/llvm-project/commit/e5739eb4f8135e20da7590c86d724920fd66753e.dif

[PATCH] D138134: [include-cleaner] Defer decl->stdlib conversion into decl->location conversion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5739eb4f813: [include-cleaner] Defer decl->stdlib conversion into decl->location conversion (authored by kadircet). Repository: rG LLVM Github Mo

Re: How can Autoconf help with the transition to stricter compilation defaults?

Hello, On Wed, 16 Nov 2022, Sam James wrote: > Unrelated but I was a bit tempted to ask for throwing in > -Wbuiltin-declaration-mismatch to default -Werror while Clang 16 was at > it, but I suppose we don't want the world to burn too much, :-) It's IMHO a bug in the standard that it misses "i

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

zahiraam added inline comments. Comment at: clang/test/Driver/fp-model.c:162 +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffast-math" +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffinite-math-only" Shouldn't be worth adding a rule for -ffast-math and ffp-model=fast (even if it

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

paulwalker-arm added a comment. Hi @rsandifo-arm , what are your thoughts on Arron's observations? My interpretation is that Arm originally figured the distinction between keywords and gnu attributes was minimal and thus using our previous norms made most sense. This is not my world so my under

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Wed, 16 Nov 2022 at 15:59, Michael Matz wrote: > > Hello, > > On Wed, 16 Nov 2022, Sam James wrote: > > > Unrelated but I was a bit tempted to ask for throwing in > > -Wbuiltin-declaration-mismatch to default -Werror while Clang 16 was at > > it, but I suppose we don't want the world to burn to

[PATCH] D137995: [Flang][Driver] Handle target CPU and features

kiranchandramohan added a comment. Thanks @mnadeem for this patch. A few minor comments first. Try to replace auto in all places except where the type is on the RHS. We might need `-fc1` tests as well. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:85 +

[PATCH] D138137: [CodeGen][ARM] Fix ARMABIInfo::EmitVAAarg crash with empty record type variadic arg

yronglin created this revision. yronglin added reviewers: rjmccall, asl. Herald added a subscriber: kristof.beyls. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix ARMABIInfo::EmitVAAarg crash with e

Re: How can Autoconf help with the transition to stricter compilation defaults?

Hello, On Wed, 16 Nov 2022, Jonathan Wakely wrote: > > > Unrelated but I was a bit tempted to ask for throwing in > > > -Wbuiltin-declaration-mismatch to default -Werror while Clang 16 was at > > > it, but I suppose we don't want the world to burn too much, > > > > :-) It's IMHO a bug in the sta

[PATCH] D137875: clang/AMDGPU: Drop volatile from builtin_atomic* pointers

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137875/new/ https://reviews.llvm.org/D137875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane updated this revision to Diff 475836. erichkeane added a comment. Updated to work via option-3 above, I believe this is the appropriate solution based on the itanium proposal and the C++ standard. @rjmccall, what concerns do we still have about Itanium being willing to add this? Do

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Wed, 16 Nov 2022 at 16:34, Michael Matz wrote: > > Hello, > > On Wed, 16 Nov 2022, Jonathan Wakely wrote: > > > > > Unrelated but I was a bit tempted to ask for throwing in > > > > -Wbuiltin-declaration-mismatch to default -Werror while Clang 16 was at > > > > it, but I suppose we don't want th

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. In D127762#3930988 , @paulwalker-arm wrote: > Hi @rsandifo-arm , what are your thoughts on Arron's observations? My > interpretation is that Arm originally figured the distinction between > keywords and gnu attributes was

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

ymandel added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:259-268 + // Includes attributes through macro expansion. + Visitor.runOverAnnotated(R"cpp( + #define MACRO_EXPANSION __attribute__((deprecated("message"))) + $r[[MACRO_EXPANSION +

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

daltenty added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. I feel like we sh

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. It would probably be better to make these changes with the appropriate code changes you are making for each semantic mode. And may be keep this patch only for the other changes you are proposing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

thetruestblue added a comment. This breaks our use case. We run sanitizer tests built in a standalone build using an artifact toolchain that contains binaries only. Compiler-rt tests rely on the llvm tools binary being in the PATH. This patch removes the logic that sets the binary tools dir usi

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3930423 , @kawashima-fj wrote: > I don't know it is inteded that `-fno-fast-math` does not imply > `-ftrapping-math` and `-frounding-math`. > `-ffast-math` and `-fno-fast-math` is not symmetric in > RenderFloatingPo

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk added subscribers: efriedma, hans. rnk added a comment. Sorry for the delay, dev meeting. I think we should try to add some reviewers for IR gen to help, I don't have a lot of time to be responsive: https://github.com/llvm/llvm-project/blob/main/clang/CodeOwners.rst#clang-llvm-ir-generation +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. In D137024#3931126 , @thetruestblue wrote: > This patch removes the logic that sets the binary tools dir using > llvm-config. We don't have llvmConfig.cmake in our toolchain or our build > tree and relied on llvm-config to > se

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. > the question "when is the best time to split critical edges" is perhaps > important to consider. In D138078#3929590 , @efriedma wrote: > You can't put transforms that

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman updated this revision to Diff 475850. dgoldman added a comment. Fix in ParsedAST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047 Files: clang-tools-extra/clangd/ParsedAST.cpp Index: clang

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

dgoldman added a comment. In D138047#3930211 , @kadircet wrote: > yeah unfortunately testing this is hard, but bug&fix are obvious so it's fine > to land without a test. > > but i think we should rather fix the broken call site at > clang-tools-extra/cl

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

xingxue updated this revision to Diff 475853. xingxue marked 5 inline comments as done. xingxue edited the summary of this revision. xingxue added a comment. Addressed comments: - rename `AIXLongDoubleBuiltins` to `AIXLongDouble64Builtins` - test IR output instead of assembly output - fix a typo

[PATCH] D138047: Fix use of dangling stack allocated string in IncludeFixer

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138047/new/ https://reviews.llvm.org/D138047

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

john.brawn created this revision. john.brawn added reviewers: t.p.northover, fhahn, umesh.kalappa0. Herald added subscribers: arphaman, kristof.beyls. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. T

[PATCH] D138078: [CodeGenPrepare] split critical indirect edges from callbr w/ outputs

nickdesaulniers added a comment. > in SelectionDAGBuilder::visitCallBr So the issue I hit immediate is that the ValueMap SelectionDAG has maps the indirect destination BB to the original MBB; I can't split the edge and have the CallBrInst lower correctly to refer to the synthesized MBB. I thin

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

lenary retitled this revision from "[ARM] Move ARM::parseBranchProtection into ARMTargetParser" to "[ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon". lenary edited the summary of this revision. lenary updated this revision to Diff 475860. Repository: rG LLVM Github Monorepo C

[PATCH] D134921: [HLSL] add cos library function

bob80905 updated this revision to Diff 475861. bob80905 added a comment. - clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134921/new/ https://reviews.llvm.org/D134921 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/CodeG

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added a comment. There are multiple notions of "constant" here: - Whether a value is invariant at runtime. - Whether a value is legal in a "constexpr" expression. - Whether we can emit a constant without emitting code that runs at startup to initialize it. The third is generally a supe

[PATCH] D137835: [ARM] Move ARM::parseBranchProtection into ARMTargetParserCommon

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:47 #include "llvm/Option/ArgList.h" +#include "llvm/Support/ARMTargetParser.h" #include "llvm/Support/CodeGen.h" tmatheson wrote: > For cons

[PATCH] D138115: [clang] Short-circuit evaluation in ::EvaluateAsConstantExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138115/new/ https://reviews.llvm.org/D138115 ___ cfe-commits mailing list cfe-commi

[PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. I've updated the patch to use forwarding headers (and to rebase past some changes that have happened in the interim). The patch is still huge because of the number of places using the TargetParsers, which need the component added to their CMakeLists.txt. I think after t

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

thetruestblue added a comment. > While I sympathize with you, I don't think this is valid reason to maintain > full compatibility with `llvm-config`. A standalone build with LLVM_TOOLS_BINARY_DIR set directly could be a valid code path. We already have code to mock LLVMConfig.cmake. I believe

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 475869. brettw added a comment. Updated the lit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp cla

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-16 06:26, Michael Matz wrote: char foobar(void); int main(void) { return &foobar != 0; } That still has undefined behavior according to draft C23, which says behavior is undefined when foobar is (say) 'memset_explicit' because the declaration 'char memset_explicit(void);' disagr

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

tejohnson added a comment. Why not just move IRPrintingPasses.{h,cpp} as is to the new directory, vs splitting up the legacy vs new pm handling into separate places? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138081/new/ https://reviews.llvm.or

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Wed, Nov 16, 2022 at 1:18 PM Paul Eggert wrote: > ... > If Clang's threatened pickiness were of some real use elsewhere, it > might be justifiable for default Clang to break Autoconf. But so far we > haven't seen real-world uses that would justify this pickiness for > Autoconf's use of 'char me

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

xingxue added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. daltenty wrote: >

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2000 "overridden virtual function is here">; +def err_conflicting_overriding_attributes : Error< + "virtual function %0 has different attributes " aaron.ballman w

[PATCH] D138081: [IR] Split out IR printing passes into IRPrinter

alexander-shaposhnikov added a comment. @tejohnson - the legacy pass manager depends on the interface defined in IRPrintingPasses.h (https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LegacyPassManager.cpp#L266) so without splitting this would face the same issue - circular dependency b

[PATCH] D138137: [CodeGen][ARM] Fix ARMABIInfo::EmitVAAarg crash with empty record type variadic arg

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138137/new/ https://reviews.llvm.org/D138137 ___

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Wed, Nov 16, 2022, at 1:17 PM, Paul Eggert wrote: ... > If Clang's threatened pickiness were of some real use elsewhere, it > might be justifiable for default Clang to break Autoconf. But so far we > haven't seen real-world uses that would justify this pickiness for > Autoconf's use of 'char

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2000 "overridden virtual function is here">; +def err_conflicting_overriding_attributes : Error< + "virtual function %0 has different attributes " rsandifo-arm wr

[clang-tools-extra] 2d5c4b8 - Fix use of dangling stack allocated string in IncludeFixer

Author: David Goldman Date: 2022-11-16T11:09:06-08:00 New Revision: 2d5c4b8f6e040eef33d4f49820868a81c4c9f1e9 URL: https://github.com/llvm/llvm-project/commit/2d5c4b8f6e040eef33d4f49820868a81c4c9f1e9 DIFF: https://github.com/llvm/llvm-project/commit/2d5c4b8f6e040eef33d4f49820868a81c4c9f1e9.diff

  1   2   3   >