[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

2022-11-11 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0f7e8631547a: [LinkerWrapper] Perform device linking steps in parallel (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ http

[clang] 88aac16 - [LinkerWrapper] Fix -Wpessimizing-move

2022-11-11 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-11-11T11:53:06-08:00 New Revision: 88aac163241ac8eaec5274b4ead0107aeb1102b3 URL: https://github.com/llvm/llvm-project/commit/88aac163241ac8eaec5274b4ead0107aeb1102b3 DIFF: https://github.com/llvm/llvm-project/commit/88aac163241ac8eaec5274b4ead0107aeb1102b3.diff

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

2022-11-11 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. I intend to base this patch on D137838 once it goes through the major refactoring of bridging the header files. For the sake of simplicity, for now I'll keep it on top of D137516 . Repository:

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

2022-11-11 Thread Micah Weston via Phabricator via cfe-commits
red1bluelost marked an inline comment as done. red1bluelost added a comment. I noticed that the Premerge seemed ran into an issue with 'InsertBraces'. It looks to me that it is unrelated and probably due to the pre-merge machine using a pre-15 clang-format (I ran into similar issue on my local m

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-11-11 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D137762#3919092 , @MyDeveloperDay wrote: > Definitely needs tests Could you please add tests in the `clang/unittests/Format/FormatTest.cpp` file? Comment at: clang/lib/Format/TokenAnnotator.cpp:

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-11 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 474826. jyu2 added a comment. Herald added a project: Flang. Thanks Alexey, for the review. This is addressing his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-11 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:1613-1615 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + ABataev wrote: > Make it private Thanks. Yes. Changed Co

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

2022-11-11 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale updated this revision to Diff 474828. michele.scandale added a comment. Rebase on top of compiler driver changes for `-funsafe-math-optimizations` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136786/new/ https://reviews.llvm.org/D

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

2022-11-11 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, minor nits. Nice cleanup. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729 + const llvm::StringRef &Na

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

2022-11-11 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: rymiel, MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

2022-11-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 474848. aeubanks added a comment. use getNameForDiagnostics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemC

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

2022-11-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 474850. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lld

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

2022-11-11 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple template

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-11-11 Thread Gedare Bloom via Phabricator via cfe-commits
gedare marked 2 inline comments as done. gedare added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5006-5010 +return !((Previous && (Previous->is(tok::kw_for) || Previous->isIf())) || + (Right.Next && + (Right.Next->is(tok::l_paren

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-11 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:102 .Default(OMPC_ATOMIC_DEFAULT_MEM_ORDER_unknown); + case OMPC_at: + return llvm::StringSwitch(Str) I run git-clang-format I don't see any change. I don't know where has prob

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

2022-11-11 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137872 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/C

[PATCH] D137851: [OPENMP]Initial support for at clause

2022-11-11 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 474874. jyu2 added a comment. Fix format problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/A

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-11-11 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 474876. gedare added a comment. add unit tests for BlockIndent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp cla

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

2022-11-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. Herald added subscribers: kosarev, StephenFan. Herald added a project: All. Is this still relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84743/new/ https://reviews.llvm.org/D84743 __

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-11-11 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 474881. gedare added a comment. Refactor horrible to read logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp cl

[PATCH] D137874: clang/AMDGPU: Use Support's wrapper around getenv

2022-11-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: MaskRay, wdng. This does some extra stuff for Windows, so m

[PATCH] D137875: clang/AMDGPU: Drop volatile from builtin_atomic* pointers

2022-11-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The codegen takes the volatileness from the used val

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

2022-11-11 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 474889. akhuang marked an inline comment as done. akhuang added a comment. Move cloning code into a function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files:

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

2022-11-11 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. In D136998#3906881 , @efriedma wrote: > Might also be worth considering if we can avoid cloning here. It should be > possible to emit the lambda body into a separate function with a calling > convention of your choice, and make

[clang] 76db4e3 - clang: Fix unnecessary truncation of resource limit values

2022-11-11 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2022-11-11T16:38:51-08:00 New Revision: 76db4e3c439e6bc2921690e501ba025998f4599d URL: https://github.com/llvm/llvm-project/commit/76db4e3c439e6bc2921690e501ba025998f4599d DIFF: https://github.com/llvm/llvm-project/commit/76db4e3c439e6bc2921690e501ba025998f4599d.diff

[PATCH] D137876: Dummy change to test the Clang/libc++ CI

2022-11-11 Thread Louis Dionne via Phabricator via cfe-commits
ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Pinging some folks just for awareness, I'll abandon this if CI passes. Repository: rG LLVM Github Monorepo http

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

2022-11-11 Thread Amara Emerson via Phabricator via cfe-commits
aemerson added a comment. Sorry, for some reason I hadn’t received any emails about this so I only noticed now. I’ll look into the issues and come back once the issues are resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https:

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-11-11 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 474901. gedare added a comment. - fixup typo in unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp clang/li

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

2022-11-11 Thread Gedare Bloom via Phabricator via cfe-commits
gedare marked an inline comment as done. gedare added a comment. I've added unit tests and confirmed (1) the new tests fail on current `main` and (2) all unit tests pass with this revision applied. [100%] Running lit suite /llvm-project/clang/test/Unit Testing Time: 250.49s Skipped:

[PATCH] D137876: Dummy change to test the Clang/libc++ CI

2022-11-11 Thread Louis Dionne via Phabricator via cfe-commits
ldionne abandoned this revision. ldionne added a comment. libc++ CI passed. So I think this is working. Nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137876/new/ https://reviews.llvm.org/D137876 __

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

2022-11-11 Thread Dhruva Chakrabarti via Phabricator via cfe-commits
dhruvachak added a comment. In D102107#3921948 , @jhuber6 wrote: > @dhruvachak Do you still need help updating the LLVM tests? If you go a few messages back, there are some llvm tests that @jdoerfert said were not updated properly. Can someone help upda

Re: How can Autoconf help with the transition to stricter compilation defaults?

2022-11-11 Thread Zack Weinberg via cfe-commits
Florian Weimer writes: > based on a limited attempt to get this fixed about three years > ago, I expect that many of the problematic packages have not had their > configure scripts regenerated using autoconf for a decade or more. This > means that as an autoconf maintainer, you unfortunately won'

[PATCH] D137883: [clang-format][NFC] Improve documentation of FixNamespaceComments

2022-11-11 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[clang] e588d23 - Add back single quotes when dontcall attribute was split into dontcall-error/dontcall-warn

2022-11-11 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-11-11T22:59:51-08:00 New Revision: e588d23a91fd28cd4218995a33c2a46fe721ff62 URL: https://github.com/llvm/llvm-project/commit/e588d23a91fd28cd4218995a33c2a46fe721ff62 DIFF: https://github.com/llvm/llvm-project/commit/e588d23a91fd28cd4218995a33c2a46fe721ff62.diff

[PATCH] D137768: [opt][clang] Enable using -module-summary with -S / -emit-llvm

2022-11-11 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexander-shaposhnikov updated this revision to Diff 474921. alexander-shaposhnikov retitled this revision from "[opt] Enable using -module-summary with -S" to "[opt][clang] Enable using -module-summary with -S / -emit-llvm". Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D137768: [opt][clang] Enable using -module-summary with -S / -emit-llvm

2022-11-11 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexander-shaposhnikov updated this revision to Diff 474922. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/split-lto-unit.c llvm/include/l

<    1   2