[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

arsenm added a comment. In D137269#3916911 , @fhahn wrote: > It looks like GISel crashes when building `llvm-test-suite` with -O3 on > ARM64. If it isn't trivial to fix we should probably revert the patch to > bring things back to green. > > Reproducer:

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder updated this revision to Diff 474459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137706/new/ https://reviews.llvm.org/D137706 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td clang/lib/AST/Interp/Pointer.cpp

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu updated this revision to Diff 474462. ChuanqiXu added a comment. Set the path to clang correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137693/new/ https://reviews.llvm.org/D137693 Files: clang-tools-extra/clangd/test/CMakeLists.txt clang-tools-extra/clangd/test/c

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. Please be aware of https://reviews.llvm.org/D137673 - you may need to rebase if it lands before this patch. Please just go ahead and merge, but please keep `WIN32` in the final version of "flang/test/CMakeLists.txt" (see my comment inline). LGTM

[clang] 04fb3e3 - [C++20] [Modules] Document the behavior about reserved module names

Author: Chuanqi Xu Date: 2022-11-10T16:43:50+08:00 New Revision: 04fb3e3de7329a11b75c77fc418e3e5f5ddcac77 URL: https://github.com/llvm/llvm-project/commit/04fb3e3de7329a11b75c77fc418e3e5f5ddcac77 DIFF: https://github.com/llvm/llvm-project/commit/04fb3e3de7329a11b75c77fc418e3e5f5ddcac77.diff LO

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474466. v1nh1shungry added a comment. Modify the name in the hover info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 __

[clang] 135a927 - [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

Author: Weining Lu Date: 2022-11-10T17:27:28+08:00 New Revision: 135a9272a4c99b7f960086d0bf9d7e7da4c0396d URL: https://github.com/llvm/llvm-project/commit/135a9272a4c99b7f960086d0bf9d7e7da4c0396d DIFF: https://github.com/llvm/llvm-project/commit/135a9272a4c99b7f960086d0bf9d7e7da4c0396d.diff LO

[clang] 60e5cfe - [Clang][LoongArch] Define more LoongArch specific built-in macros

Author: Weining Lu Date: 2022-11-10T17:27:29+08:00 New Revision: 60e5cfe2a4eba3bf0a642aeeb53a3f37dfed5fdb URL: https://github.com/llvm/llvm-project/commit/60e5cfe2a4eba3bf0a642aeeb53a3f37dfed5fdb DIFF: https://github.com/llvm/llvm-project/commit/60e5cfe2a4eba3bf0a642aeeb53a3f37dfed5fdb.diff LO

[clang] 85f08c4 - [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

Author: gonglingqin Date: 2022-11-10T17:27:44+08:00 New Revision: 85f08c4197aea68b2444e6874524b5f8b4067cfd URL: https://github.com/llvm/llvm-project/commit/85f08c4197aea68b2444e6874524b5f8b4067cfd DIFF: https://github.com/llvm/llvm-project/commit/85f08c4197aea68b2444e6874524b5f8b4067cfd.diff L

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG135a9272a4c9: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options (authored by SixWeining, committed by gonglingqin). Chang

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85f08c4197ae: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin (authored by gonglingqin). Changed prior to commit: https://reviews.ll

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG60e5cfe2a4eb: [Clang][LoongArch] Define more LoongArch specific built-in macros (authored by SixWeining, committed by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

ChuanqiXu created this revision. ChuanqiXu added reviewers: sammccall, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Intro

[PATCH] D137154: Adding nvvm_reflect clang builtin

bader added a comment. Is binary size a concern here? NVIDIA, AMD and Intel GPUs are already have ~ 20 different architectures each, so I want my app/library to run on any GPU from these vendors (which is quite reasonable expectation), I'll need to have/distribute ~ 60 different binaries. libde

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu added a comment. The failed tests in windows says: > Failed to find compilation database for > \\C:\ws\w9\llvm-project\premerge-checks\build\tools\clang\tools\extra\clangd\test\Output\completion-modules.test.tmp\Use.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137693/new

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

MyDeveloperDay added a comment. Its always good if you have a github issue to add that to the summary (just to tie stuff together), if you don't feel free to go over there an log a bug. Comment at: clang/lib/Format/TokenAnnotator.cpp:2355 +NextToken->isOneOf(tok::arrow

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

MyDeveloperDay added a comment. On first inspection this looks ok, but lets wait for the others chime in, please add the annotator test too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137755/new/ https://reviews.llvm.org/D137755 __

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

sammccall added a comment. The status quo for modules on clangd is all flavors are completely unsupported: https://github.com/clangd/clangd/issues/1293. I don't think we should encourage people to set up workflows that are known not to work properly and will probably break in future. It's true

[PATCH] D134791: [clang] Unify Sema and CodeGen implementation of isFlexibleArrayMemberExpr

steakhal added a comment. I wonder if we could come up with an overload or something for cases when we only have a `FieldDecl`. For example, in the Clang Static Analyzer, we have something similar at MemRegion.cpp#L784-L811

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailin

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:69 + // main-file #include with export pragma should never be removed. + if (Top.Exporter == SM.getMainFileID()) +Out->ShouldKeep.insert( hokein wrote:

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

sammccall added a comment. I think at this point we specifically don't want to commit to preserving particular modules behavior, this is more or less what the unsupported state means (https://github.com/clangd/clangd/issues/1293). In particular the pattern where modules are built externally by

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet added a comment. sure i am happy to land, @tom-anders do you have anything else to add ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commit

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

MyDeveloperDay added a comment. Definitely needs tests Comment at: clang/lib/Format/ContinuationIndenter.cpp:720 (!Previous.Previous || !Previous.Previous->isOneOf( - tok::kw_for, tok::kw_while, tok::kw_switch)) && + tok:

[PATCH] D137650: [clangd] Implement hover for string literals

tom-anders added a comment. In D137650#3919089 , @kadircet wrote: > sure i am happy to land, @tom-anders do you have anything else to add ? LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.llvm.org/D127762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] 92297bd - [clangd] Implement hover for string literals

Author: v1nh1shungry Date: 2022-11-10T12:16:05+01:00 New Revision: 92297bde5ce13825dd6609e4eb99688e6019 URL: https://github.com/llvm/llvm-project/commit/92297bde5ce13825dd6609e4eb99688e6019 DIFF: https://github.com/llvm/llvm-project/commit/92297bde5ce13825dd6609e4eb99688e6019.diff

[PATCH] D137650: [clangd] Implement hover for string literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG92297bde5ce1: [clangd] Implement hover for string literals (authored by v1nh1shungry, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

alexfh added a comment. Thanks for adding this diagnostic! I wonder whether we can include SLoc usage information into `-print-stats` output? Comment at: clang/lib/Basic/SourceManager.cpp:2251 + uint64_t CountedSize = 0; + for (int IDIndex = -(int)LoadedSLocEntryTable.size()

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

hokein updated this revision to Diff 474505. hokein marked 8 inline comments as done. hokein added a comment. address remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137319/new/ https://reviews.llvm.org/D137319 Files: clang-too

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

kadircet added a comment. In D136723#3915898 , @sammccall wrote: > (and sorry, it seems I was sitting on a pile of comments I thought I'd sent, > LMK if I should follow up on them) no looks good. the only meaty discussion was fileentry to multiple incl

[PATCH] D137714: Do not merge traps in functions annotated optnone

hnrklssn created this revision. Herald added a project: All. delcypher added a comment. hnrklssn updated this revision to Diff 474504. hnrklssn added reviewers: delcypher, rapidsna, fcloutier, t.p.northover, patrykstefanski. hnrklssn published this revision for review. Herald added a project: clan

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks for bearing with me, LG! Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:72 + void checkForExport(FileID FileSeenHash, int HashLine, +

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aaron.ballman added a comment. In D137583#3917735 , @dblaikie wrote: > In D137583#3917706 , @aaron.ballman > wrote: > >>> ...we expect template params to be fully qualified when comparing them for >>> simple tem

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

zahiraam updated this revision to Diff 474515. zahiraam edited the summary of this revision. zahiraam added reviewers: andrew.w.kaylor, michele.scandale. zahiraam set the repository for this revision to rG LLVM Github Monorepo. zahiraam changed the visibility from "Custom Policy" to "All Users". za

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet created this revision. courbet added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang-tools-extra. Handle iterators that do

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

zahiraam added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3957 - if (Arg *A = Args.getLastArg(OPT_ffp_contract)) { -StringRef Val = A->getValue(); -if (Val == "fast") + if (auto *A = Args.getLastArg(OPT_ffp_contract, OPT_cl_fast_relaxed_mat

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet updated this revision to Diff 474520. courbet added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/D137782 Files: clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

zahiraam added a comment. In D137578#3918314 , @michele.scandale wrote: > Looks good to me @michele.scandale Now that I opened up the patch to all, it needs another stamp from you. Would you mind reviewing it again please? I will wait for a day before

[PATCH] D137770: [docs] Introduce clangd part in StandardCPlusPlusModules

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. @sammccall Thanks for you professional and valuable input. It is very helpful. From the perspective of clangd, it looks not good indeed that the user can't get a stable support for modules. > This situation is not at all obv

[PATCH] D137765: [NFC] Fixing a comment and some indentations

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137765/new/ https://reviews.llvm.org/D137765 ___

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. Thanks for the explanation. I got your point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137693/new/ https://reviews.llvm.org/D137693 ___ cfe-commits mailing list cfe-c

[libunwind] 4fde94f - [libunwind][NFC] Fix typo in libunwind debug string

Author: jinge90 Date: 2022-11-10T21:46:49+08:00 New Revision: 4fde94fb43297934428a685a90fd48ddf62457dc URL: https://github.com/llvm/llvm-project/commit/4fde94fb43297934428a685a90fd48ddf62457dc DIFF: https://github.com/llvm/llvm-project/commit/4fde94fb43297934428a685a90fd48ddf62457dc.diff LOG:

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:58 +Results = {{FE}}; +// FIXME: compute a closure of exporter headers. +for (con

[PATCH] D125860: [clang] Only use major version in resource dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1b88c8a09be: [clang] Only use major version in resource dir (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu marked 2 inline comments as done. tarunprabhu added a comment. Yes, I am aware of the other patch which also adds `test/Driver/pass-plugin.f90`. I will keep an eye out for it. Comment at: flang/test/CMakeLists.txt:65 ) +if (NOT WIN32) + list(APPEND FLANG_TEST_DEP

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:84 +Out->IWYUExportBy[IncludedHeader->getUniqueID()].push_back( +save(SM.getFileEntryForID(Top.SeenAtFile)->tryGetRealPathName()

[clang-tools-extra] f3e8a11 - [include-cleaner] Add export IWYU pragma support.

Author: Haojian Wu Date: 2022-11-10T15:39:30+01:00 New Revision: f3e8a117d2bc8d439434db5cb77b1c8a425a38c0 URL: https://github.com/llvm/llvm-project/commit/f3e8a117d2bc8d439434db5cb77b1c8a425a38c0 DIFF: https://github.com/llvm/llvm-project/commit/f3e8a117d2bc8d439434db5cb77b1c8a425a38c0.diff LO

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGf3e8a117d2bc: [include-cleaner] Add export IWYU pragma support. (authored by hokein). Changed prior to comm

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as the new attributes code owner. Comment at: clang/include/clang/Basic/Attr.td:2322 +def ArmStreamingCompatible : DeclOrTypeAttr, TargetSpecificAttr { + let Spellings = [Clang<"arm_stre

[clang] c3821b8 - [flang] Add -fpass-plugin option to flang

Author: Tarun Prabhu Date: 2022-11-10T08:03:46-07:00 New Revision: c3821b8d2aacd1d7c0281db1b8db011e1158cf4d URL: https://github.com/llvm/llvm-project/commit/c3821b8d2aacd1d7c0281db1b8db011e1158cf4d DIFF: https://github.com/llvm/llvm-project/commit/c3821b8d2aacd1d7c0281db1b8db011e1158cf4d.diff

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

aaron.ballman added a comment. Thank you for working on this, I think this will help folks who run out of source locations. Can you also add a release note and public docs for this extension? Comment at: clang/include/clang/Basic/SourceManager.h:1695-1696 + // Produce notes

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, mantognini, ChuanqiXu, Bigcheese. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the `Decl` pointers are not identical, `decla

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/fold-init-type.cpp:205 } + Excessive newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

kadircet added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/Header.h:1 +//===--- Header.h *- C++-*-===// +// rather than calling this `Header` can we call this `HeaderAnalysis`? ===

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. This fixes the assertion for a downstream case in ROOT/Cling with the involvement of modules. If anyone has ideas how to test this, please let me know... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/ https://

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

carlosgalvezp added a comment. @njames93 Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D137782: [clang-tidy]bugprone-fold-init-type

courbet updated this revision to Diff 474548. courbet added a comment. remove extra training newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137782/new/ https://reviews.llvm.org/D137782 Files: clang-tools-extra/clang-tidy/bugprone/FoldInit

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

kadircet added a comment. i guess this patch needs a rebase for other pieces as well? but LG in general Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:47 + const PragmaIncludes &PI) { + const FileEntry *FE = SM.getFil

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 474551. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGe

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 474556. balazske added a comment. Rebase to main and D137722 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135247/new/ https://reviews.llvm.org/D135247 Files: clang/lib/S

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske updated this revision to Diff 474558. balazske added a comment. Rebase to main and D137722 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135360/new/ https://reviews.llvm.org/D135360 Files: clang/lib/S

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added a comment. Ping. This review has been open for a month now and a lot of following functionality depends on it, so if you need to decide which one of the patches to review, choose this one :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.o

[PATCH] D137714: Do not merge traps in functions annotated optnone

fcloutier requested changes to this revision. fcloutier added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5321 + SetLLVMFunctionAttributesForDefinition(D, Fn); CodeGenFunction(*this).GenerateCode(GD, Fn, FI

[PATCH] D137790: [clang][analyzer] Remove report of null stream from StreamChecker.

balazske added a comment. Test file //std-c-library-functions-vs-stream-checker.c// could be removed. It tests the same as the newly added //stream-stdlibraryfunctionargs.c//. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137790/new/ https://revie

How can Autoconf help with the transition to stricter compilation defaults?

I’m the closest thing Autoconf has to a lead maintainer at present. It’s come to my attention (via https://lwn.net/Articles/913505/ and https://fedoraproject.org/wiki/Changes/PortingToModernC) that GCC and Clang both plan to disable several “legacy” C language features by default in a near-future

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM to me with those formatting fixes. Comment at: clang/test/CodeGen/builtins-elementwise-math.c:337 +void test_builtin_elementwise_cos(float f1, float f2, doub

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D137246#3911881 , @diseraluca wrote: > I finally had some time to look into the pre-merge failure. I couldn't > replicate it on my m

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, 10 Nov 2022 at 17:52, Nick Bowler wrote: > It saddens me to see so much breakage happening in "modern C", a > language that has (until now) a long history of new language features > being carefully introduced to avoid these sort of problems. The features were introduced in 1999. Compilers

Re: How can Autoconf help with the transition to stricter compilation defaults?

* Zack Weinberg via Gcc: > I’m the closest thing Autoconf has to a lead maintainer at present. > > It’s come to my attention (via https://lwn.net/Articles/913505/ and > https://fedoraproject.org/wiki/Changes/PortingToModernC) that GCC and > Clang both plan to disable several “legacy” C language fe

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, 10 Nov 2022 at 17:58, Jonathan Wakely wrote: > > On Thu, 10 Nov 2022 at 17:52, Nick Bowler wrote: > > It saddens me to see so much breakage happening in "modern C", a > > language that has (until now) a long history of new language features > > being carefully introduced to avoid these sort

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

cebowleratibm updated this revision to Diff 473756. cebowleratibm retitled this revision from "[clang] Linkage computation of static locals may require forcing visibility computation" to "[clang] Cached linkage assertion for static locals of static function". cebowleratibm edited the summary of t

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 474570. bob80905 added a comment. - make format change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.rst clang/docs/Releas

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, Nov 10, 2022 at 12:16 PM Zack Weinberg via cfe-commits wrote: > > I’m the closest thing Autoconf has to a lead maintainer at present. > > It’s come to my attention (via https://lwn.net/Articles/913505/ and > https://fedoraproject.org/wiki/Changes/PortingToModernC) that GCC and > Clang both

[PATCH] D128223: [clang] Cached linkage assertion for static locals of static function

cebowleratibm added a comment. I believe the fix for a52d151f9dde7 inadvertently exposed a code path where by the linkage of a static local of a static function, which would otherwise return LinkageInfo::none() may now return VisibleNoLinkage depending on the incoming computation argument. I d

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 474571. dgoldman marked an inline comment as done. dgoldman added a comment. Fix serialization and isSelfContainedHeader - Keep serialization as a single var uint32 - Keep old imported logic in isSelfContainedHeader in addition to a new check for import lin

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-10, Zack Weinberg wrote: > The biggest remaining (potential) problem, that I’m aware of, is that > AC_CHECK_FUNC unconditionally declares the function we’re probing for > as ‘char NAME (void)’, and asks the compiler to call it with no > arguments, regardless of what its prototype actual

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, Nov 10, 2022 at 12:16:20PM -0500, Zack Weinberg wrote: > I’m the closest thing Autoconf has to a lead maintainer at present. > > It’s come to my attention (via https://lwn.net/Articles/913505/ and > https://fedoraproject.org/wiki/Changes/PortingToModernC) that GCC and > Clang both plan to

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Thu, Nov 10, 2022 at 1:12 PM Jonathan Wakely via cfe-commits wrote: > > On Thu, 10 Nov 2022 at 17:58, Jonathan Wakely wrote: > > > > On Thu, 10 Nov 2022 at 17:52, Nick Bowler wrote: > > > It saddens me to see so much breakage happening in "modern C", a > > > language that has (until now) a long

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

hans added a comment. Looks like there are a few issues flagged already. Is someone reverting, or what's the plan? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137269/new/ https://reviews.llvm.org/D137269

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

kito-cheng added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:469 +if (STI.getFeatureBits()[RISCV::FeatureVendorXVentanaCondOps]) { + LLVM_DEBUG(dbgs() << "Trying Vemtama custom opcode table:\n"); + Result = decodeInstruction

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

aeubanks added a comment. In D137269#3916916 , @nikic wrote: > I'd like to object to enabling this via the frontend. This means that > non-clang frontends will now use a non-default configuration that is not > extensively tested by upstream anymore. > >

[clang] 790cbaa - [OpenCL] Fix diagnostics with templates in kernel args.

Author: Anastasia Stulova Date: 2022-11-10T18:55:12Z New Revision: 790cbaafc9e276aa740373c00849951338056174 URL: https://github.com/llvm/llvm-project/commit/790cbaafc9e276aa740373c00849951338056174 DIFF: https://github.com/llvm/llvm-project/commit/790cbaafc9e276aa740373c00849951338056174.diff

[PATCH] D134445: [PR57881][OpenCL] Fix incorrect diagnostics with templated types in kernel arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG790cbaafc9e2: [OpenCL] Fix diagnostics with templates in kernel args. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a proj

[PATCH] D137794: [clangd] Enable configuring include insertions

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, nridge. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ext

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3906766 , @rnk wrote: > In D137107#3905443 , @zahiraam > wrote: > >> extern int __declspec(dllimport) next(int n); >> int main () { >> extern int _declspec(dllimport)

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante marked 6 inline comments as done. Mordante added a comment. Thanks for all feedback! Comment at: clang/www/hacking.html:311-312 + Unlike Clang, libc++ supports multiple versions of Clang. Therefore when a + patch changes the diagnostics it might be required to use a

[clang] 0c111dd - [libc++] Documents details of the pre-commit CI.

Author: Mark de Wever Date: 2022-11-10T20:20:17+01:00 New Revision: 0c111dd86fffa91fbca502fd5f8e3db28f89270a URL: https://github.com/llvm/llvm-project/commit/0c111dd86fffa91fbca502fd5f8e3db28f89270a DIFF: https://github.com/llvm/llvm-project/commit/0c111dd86fffa91fbca502fd5f8e3db28f89270a.diff

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG0c111dd86fff: [libc++] Documents details of the pre-commit CI. (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D133249?vs=460827&id=4

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

rjmccall added a comment. Okay. That raises the question of what the default semantics should be for `std::bfloat16_t`, i.e. whether we should semantically default the type to using excess-precision `float` arithmetic. If we did, we'd still be able to demote solitary `float` operations to BF1

[clang] 380a038 - Updated contact email address.

Author: Anastasia Stulova Date: 2022-11-10T19:50:19Z New Revision: 380a038d147454afb16b97fd9739f4c3d7307401 URL: https://github.com/llvm/llvm-project/commit/380a038d147454afb16b97fd9739f4c3d7307401 DIFF: https://github.com/llvm/llvm-project/commit/380a038d147454afb16b97fd9739f4c3d7307401.diff

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. Getting this false positive: #include extern std::string str() { std::string ret; return ret.empty() ? ret : ret.substr(1); } input.cpp:6:23: warning: Parameter 'ret' is copied on last use, consider moving it instead. [performance-unnece

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. Another false positive: #include void evaluateLibraryFunction() { std::unordered_map m; auto f = [m]() {}; } input.cpp:7:12: warning: Parameter 'm' is copied on last use, consider moving it instead. [performance-unnecessary-copy-on-la

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-10 09:16, Zack Weinberg wrote: Changes to handle C23 built-in ‘bool’ better are under development but the design has not yet been finalized. [I'm cc'ing this to bug-gnulib too.] To my mind this is the biggest outstanding issue in Autoconf as far as C23 goes, as the upgrade path for

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added inline comments. Comment at: clang/test/Sema/aarch64-sve-vector-trig-ops.c:4 +// RUN: -disable-O0-optnone -o - -fsyntax-only %s -verify + +#include Need limit to aarch64 enabled with // REQUIRES: aarch64-registered-target

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

firewave added a comment. I am also experiencing a crash: #include #include class Token; class Value { public: using ErrorPathItem = std::pair; using ErrorPath = std::list; explicit Value(long long val = 0)

[clang] f6b2529 - [clang-format] Add BreakBeforeInlineASMColon configuration

Author: Anastasiia Lukianenko Date: 2022-11-10T22:31:09+01:00 New Revision: f6b252978c40bc437d8495218a69e3bd166b105b URL: https://github.com/llvm/llvm-project/commit/f6b252978c40bc437d8495218a69e3bd166b105b DIFF: https://github.com/llvm/llvm-project/commit/f6b252978c40bc437d8495218a69e3bd166b10

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b252978c40: [clang-format] Add BreakBeforeInlineASMColon configuration (authored by anastasiia_lukianenko, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D91950?v

  1   2   >