[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

abrachet added a comment. I believe this patch might be the cause of some assertion failures we are seeing in a two stage lto build, as it's only happening for arm64-darwin. See https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-mac-xarm64/b8798097341668696785/overview and it's correspond

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

Eugene.Zelenko added a comment. Will be good idea to combine this patch with D137738 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137740/new/ https://reviews.llvm.org/D137740 __

[clang] a11cd0d - Move googletest to the third-party directory

Author: Tom Stellard Date: 2022-11-09T15:28:08-08:00 New Revision: a11cd0d94ed3cabf0998a0289aead05da94c86eb URL: https://github.com/llvm/llvm-project/commit/a11cd0d94ed3cabf0998a0289aead05da94c86eb DIFF: https://github.com/llvm/llvm-project/commit/a11cd0d94ed3cabf0998a0289aead05da94c86eb.diff

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474381. tarunprabhu added a comment. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files: clang/include/clang/Driver/Options.td c

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474382. tarunprabhu added a comment. Previous revision was missing the tests. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files:

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith created this revision. rsmith added a reviewer: aaron.ballman. Herald added a subscriber: mgrang. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If Clang runs out of source location address space,

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore added a comment. In D137740#3918271 , @Eugene.Zelenko wrote: > Will be good idea to combine this patch with D137738 > . My intent was to land the simpler linter fixes first while iterating on the fixes i

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith updated this revision to Diff 474385. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137751/new/ https://reviews.llvm.org/D137751 Files: clang/test/Driver/aix-ld.c Index: clang/test/Driver/aix-ld.c === --- clang/te

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

Eugene.Zelenko added a comment. In D137740#3918335 , @stephanemoore wrote: > In D137740#3918271 , > @Eugene.Zelenko wrote: > >> Will be good idea to combine this patch with D137738 >>

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 474391. haowei added a comment. Add additional unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml c

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', haowei wrote: > haowei wrote: > > bnbarham wrote: > > > bnbarham wrote: > > > > I

[PATCH] D137753: [Clang][p]Enable -p Functionality

francii created this revision. Herald added a subscriber: ormris. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch enables general, non-platform-specific `-p` functionality into Clang t

[PATCH] D137753: [Clang][p]Enable -p Functionality

francii added a comment. A test case will be added shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 474396. francii added a comment. Update the recently-added test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp c

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost created this revision. red1bluelost added a reviewer: curdeius. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ran into an issue where function declarations inside function scopes or u

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474399. v1nh1shungry added a comment. Apply the reviewing suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Thanks for your suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Throw an error when trying to compile with `-p` or `-pg` on z/OS, as the platform does not support `prof` and `gprof

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-comm

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining updated this revision to Diff 474414. SixWeining added a comment. Revise the `err_drv_loongarch_invalid_mfpu_EQ` diagnostic info. Add necessary braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136146/new/ https://reviews.llvm.org/D

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

reedwm created this revision. reedwm added reviewers: stellaraccident, bkramer, rengolin, jpienaar. Herald added subscribers: bzcheeseman, rriddle, hiraditya, kristof.beyls. Herald added a project: All. reedwm requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, s

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare created this revision. Herald added a project: All. gedare requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The BracketAlignmentStyle BAS_BlockIndent was forcing breaks before a closing right parenthesis yielding strange-looking resul

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10634 "OpenMP constructs may not be nested inside an atomic region">; +def err_omp_prohibited_region_order +: Error<"construct %0 not allowed in a region associated with a dir

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. Something about this is still a bit off though. This change seems to prevent any more breaking on the line. For example, the test example given in GitHub Issue https://github.com/llvm/llvm-project/issues/57250 when formatted with this change becomes: `clang-format -styl

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

SeanP added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:241 +def err_option_unsupported_zos: Error< + "the clang compiler does not support the '%0' option on z/OS.">; + Rather than saying "on z/OS" you should say "by the targe

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474429. gedare added a comment. Allow line breaks in a continuation with BlockIndent after )( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474430. gedare added a comment. Add a fix to enable breaking for continuation after a )( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/Cont

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. A test case from the GitHub Issue https://github.com/llvm/llvm-project/issues/57250 is attached here: F25258989: test.c When run without these changes, it yields: clang-format -style="{BasedOnStyle: LLVM, AlignAfterOpenBracket: BlockI

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. Another test case for function pointers is here: F25259090: tmp.c Before applying these changes, it is: clang-format -style="{BasedOnStyle: LLVM, AlignAfterOpenBracket: BlockIndent}" tmp.c int foo(long l) { return l; } int m

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 474440. francii added a comment. Use existing error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/ZOS.cpp clang/test/Driver/z

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3918117 , @goldstein.w.n wrote: >>> maybe you did something different? >> >> Here is what I did: >> >> $ git diff UnwrappedLineParser.cpp >> diff --git a/clang/lib/Format/UnwrappedLineParser.cpp >> b/clang/lib/For

[PATCH] D137765: [NFC] Fixing a comment and some indentations

sandeepkosuri created this revision. sandeepkosuri added reviewers: cchen, ABataev, RitanyaB, soumitra. Herald added a project: All. sandeepkosuri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu updated this revision to Diff 474445. ChuanqiXu added a comment. Add dependency to clangd tests to make sure they can find the corresponding rules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137693/new/ https://reviews.llvm.org/D137693 Files: clang-tools-extra/clangd/te

[clang] a86b506 - [NFC] Fixing a comment and some indentations

Author: sandeepkosuri Date: 2022-11-10T01:02:12-06:00 New Revision: a86b506294bc7b9a921e3e613f49730c5780eb22 URL: https://github.com/llvm/llvm-project/commit/a86b506294bc7b9a921e3e613f49730c5780eb22 DIFF: https://github.com/llvm/llvm-project/commit/a86b506294bc7b9a921e3e613f49730c5780eb22.diff

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474447. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3918673 , @owenpan wrote: > In D137181#3918117 , @goldstein.w.n > wrote: > maybe you did something different? >>> >>> Here is what I did: >>> >>> $ git diff Unwrap

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdd9f7963e434: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is… (authored by mhjacobson). C

[clang] dd9f796 - [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

Author: Matt Jacobson Date: 2022-11-10T02:10:30-05:00 New Revision: dd9f7963e434a53e8d70f607392ee9abf76f1d99 URL: https://github.com/llvm/llvm-project/commit/dd9f7963e434a53e8d70f607392ee9abf76f1d99 DIFF: https://github.com/llvm/llvm-project/commit/dd9f7963e434a53e8d70f607392ee9abf76f1d99.diff

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 474455. sepavloff added a comment. Rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Diag

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:509-517 +class RISCVProcessorModelPROC { + string Enum = enum; + string EnumFeatures = enum_features; + string DefaultMarch = default_march; +} + +class RISCVProcessorModelTUNE_PROC { Giv

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

rymiel added a comment. This patch will probably need unit tests Comment at: clang/lib/Format/TokenAnnotator.cpp:5004-5005 const FormatToken *Previous = Right.MatchingParen->Previous; -return !(Previous && (Previous->is(tok::kw_for) || Previous->isIf())); +// avoid

<    1   2