[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3914083 , @goldstein.w.n wrote: > In D137181#3914066 , @owenpan wrote: > >> @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, >> and MacroCallReconstr

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

phosek added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:660 /// 'use-external-names': +/// 'root-relative': /// 'overlay-relative': Could we make this just a boolean akin to `overlay-relative` since there are only two o

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3914100 , @goldstein.w.n wrote: > Err I'm not sure that's right. I thought we where going for the C-code should > start at the column that the 'd' in define is. > So it would be: > > #define X \ >switch (x

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added inline comments. Comment at: llvm/test/CodeGen/LoongArch/intrinsic-error.ll:10 + +declare void @llvm.loongarch.dbar(i32) SixWeining wrote: > It's better to add a test that immediate is out of range. Thanks, I will add test cases. Repository:

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473906. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914245 , @owenpan wrote: > In D137181#3914083 , @goldstein.w.n > wrote: > >> In D137181#3914066 , @owenpan >> wrote: >> >>> @g

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin updated this revision to Diff 473909. gonglingqin added a comment. Add test cases to detect whether the immediate is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906 Files: clan

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta updated this revision to Diff 473912. thieta added a comment. Updated from feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 Files: clang/test/CodeGen/debug-info-codeview-buildinfo.c llv

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta added a comment. Thanks @hans Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] aa99b60 - [clang][pdb] Don't include -fmessage-length in PDB buildinfo

Author: Tobias Hieta Date: 2022-11-08T10:05:59+01:00 New Revision: aa99b607b5cf8ef1260f5661dcbf077f26ee797c URL: https://github.com/llvm/llvm-project/commit/aa99b607b5cf8ef1260f5661dcbf077f26ee797c DIFF: https://github.com/llvm/llvm-project/commit/aa99b607b5cf8ef1260f5661dcbf077f26ee797c.diff

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa99b607b5cf: [clang][pdb] Don't include -fmessage-length in PDB buildinfo (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf created this revision. qiucf added reviewers: aaron.ballman, mibintc, andrew.w.kaylor, masoud.ataei, zahiraam. Herald added a project: All. qiucf requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. `-ffp-model=strict -ffp-model=f

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473917. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914292 , @owenpan wrote: > In D137181#3914100 , @goldstein.w.n > wrote: > >> Err I'm not sure that's right. I thought we where going for the C-code >> should start at t

[clang] f3a86a2 - [Test] Fix driverkit-path.c with lib64 dir

Author: Thomas Preud'homme Date: 2022-11-08T09:54:47Z New Revision: f3a86a23c10db44cbcb432d56201475721c64bdc URL: https://github.com/llvm/llvm-project/commit/f3a86a23c10db44cbcb432d56201475721c64bdc DIFF: https://github.com/llvm/llvm-project/commit/f3a86a23c10db44cbcb432d56201475721c64bdc.diff

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3a86a23c10d: [Test] Fix driverkit-path.c with lib64 dir (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/ https://reviews.llv

[PATCH] D137338: Fix dupe word typos

kadircet added a comment. LGTM for changes under `clang-tools-extra/clangd` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-com

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5425 +// node in AST for such cases which is good for AST readers. +if (IsUnknownTypedefName() && !getLangOpts().ObjC) + return true; sammccall wrote: > urazoff wrote: > > aaron

[PATCH] D137309: [clang] Added Swift support for RISCV64

asb added a comment. First of all, thanks for the contribution. I've not looked at all into the Swift calling convention requirements, but at a minimum this patch is going to need test coverage. I also think RV32 should be handled somehow - either by adding equivalent support, or at least error

[PATCH] D137309: [clang] Added Swift support for RISCV

colemancda added a comment. RV32 is enabled as well. I'll add unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137309/new/ https://reviews.llvm.org/D137309 ___ cfe-commits mailing list cfe-commi

[PATCH] D136817: [RISCV] Add H extension

asb added a comment. Thanks Kito, I think my only remaining request would be to add at least some test coverage for using a H extensions when h isn't included in the ISA string. I don't think such tests are handled very cleanly or consistently right now, but adding something to rv32i-invalid.s

[PATCH] D137309: [clang] Added Swift support for RISCV

asb added a comment. In D137309#3914494 , @colemancda wrote: > RV32 is enabled as well. I'll add unit tests. Great, thanks. Is it really the case that shouldPassIndirectlyForSwift has the same result regardless of native word size? Repository: rG L

[clang] 3c50f0d - Add const information about AST nodes used to construct CFG elements.

Author: Dani Ferreira Franco Moura Date: 2022-11-08T12:11:38+01:00 New Revision: 3c50f0d879bf73e7cf64c83017ccb442d780aae6 URL: https://github.com/llvm/llvm-project/commit/3c50f0d879bf73e7cf64c83017ccb442d780aae6 DIFF: https://github.com/llvm/llvm-project/commit/3c50f0d879bf73e7cf64c83017ccb442d

[PATCH] D137584: Add const information about AST nodes used to construct CFG elements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c50f0d879bf: Add const information about AST nodes used to construct CFG elements. (authored by merrymeerkat, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang-tools-extra] 5426a1e - [include-cleaner] Add the missing parts of Symbol and Header clases.

Author: Sam McCall Date: 2022-11-08T12:19:23+01:00 New Revision: 5426a1e51d20a13f575ae03c10b274430b4a3539 URL: https://github.com/llvm/llvm-project/commit/5426a1e51d20a13f575ae03c10b274430b4a3539 DIFF: https://github.com/llvm/llvm-project/commit/5426a1e51d20a13f575ae03c10b274430b4a3539.diff LO

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG5426a1e51d20: [include-cleaner] Add the missing parts of Symbol and Header clases. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

tbaeder updated this revision to Diff 473939. tbaeder added a comment. Tried to find an example for an invalid declaration but couldn't even manage to find one :| CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137386/new/ https://reviews.llvm.org/D137386 Files: clang/lib/AST/Interp/B

[PATCH] D137531: [clang] Add the check of decltype in derived templates for issue #58674

lime updated this revision to Diff 473943. lime retitled this revision from "[clang] Fix the GitHub issue #58674" to "[clang] Add the check of decltype in derived templates for issue #58674". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137531/new/ https://reviews.llvm.org/D137531 File

[clang] 73ecff2 - [clang][Sema][NFC] Remove two nonsensical dyn_cast_or_null

Author: Timm Bäder Date: 2022-11-08T12:47:41+01:00 New Revision: 73ecff2859ad10163f92e36d1f8588c4d686 URL: https://github.com/llvm/llvm-project/commit/73ecff2859ad10163f92e36d1f8588c4d686 DIFF: https://github.com/llvm/llvm-project/commit/73ecff2859ad10163f92e36d1f8588c4d686.diff LO

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 473951. tbaeder added a comment. Add a release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver

[clang] 94738a5 - Fix duplicate word typos; NFC

Author: Rageking8 Date: 2022-11-08T07:21:23-05:00 New Revision: 94738a5ac34283bb034b022602b9f9e93d67081f URL: https://github.com/llvm/llvm-project/commit/94738a5ac34283bb034b022602b9f9e93d67081f DIFF: https://github.com/llvm/llvm-project/commit/94738a5ac34283bb034b022602b9f9e93d67081f.diff LOG

[PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. I landed the Clang bits in 94738a5ac34283bb034b022602b9f9e93d67081f , thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1373

[PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913932 , @mizvekov wrote: > @alexfh Thanks! > > While there is a huge increase in the amount of UsingTypes, it seems the > total amount is still reasonable and does not explain the perf hit. > > Perhaps this is a case

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder added a comment. I'm worried that this is gonna break build bots. Has anyone seen the ThreadSanitizer timeout reported by the precommit-ci before? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 ___

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2844 FPContract = "fast"; +FPExceptionBehavior = ""; } else if (Val.equals("precise")) { I would expect the same thing should happen with -ffp-model=strict -

[PATCH] D137338: Fix dupe word typos

thakis added inline comments. Herald added a reviewer: njames93. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:47 // complete architecture list, nor a reasonable subset. The problem is that - // historically the driver driver accepts this and also ties its -march= //

[clang-tools-extra] 8249dc2 - [include-cleaner] Record main-file macro occurences and includes

Author: Sam McCall Date: 2022-11-08T15:20:40+01:00 New Revision: 8249dc21046af57ad3b2c72414aa8a7f16b67687 URL: https://github.com/llvm/llvm-project/commit/8249dc21046af57ad3b2c72414aa8a7f16b67687 DIFF: https://github.com/llvm/llvm-project/commit/8249dc21046af57ad3b2c72414aa8a7f16b67687.diff LO

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8249dc21046a: [include-cleaner] Record main-file macro occurences and includes (authored by sammccall). Changed prior to commit: https://reviews.l

[clang-tools-extra] c8f4792 - Fix dupe word typos

Author: Rageking8 Date: 2022-11-08T15:29:12+01:00 New Revision: c8f4792510f40bdf614f904f45e93eae8e306ddb URL: https://github.com/llvm/llvm-project/commit/c8f4792510f40bdf614f904f45e93eae8e306ddb DIFF: https://github.com/llvm/llvm-project/commit/c8f4792510f40bdf614f904f45e93eae8e306ddb.diff LOG

[clang-tools-extra] d19ba74 - [Includecleaner] Introduce RefType to ast walking

Author: Kadir Cetinkaya Date: 2022-11-08T16:29:31+01:00 New Revision: d19ba74dee0b9ab553bd8a6ef5b67ff349f4bf13 URL: https://github.com/llvm/llvm-project/commit/d19ba74dee0b9ab553bd8a6ef5b67ff349f4bf13 DIFF: https://github.com/llvm/llvm-project/commit/d19ba74dee0b9ab553bd8a6ef5b67ff349f4bf13.dif

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

This revision was automatically updated to reflect the committed changes. Closed by commit rGd19ba74dee0b: [Includecleaner] Introduce RefType to ast walking (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D135859?vs=472925&id=474001#toc Repository: rG LLVM Github Mo

[PATCH] D137644: [include-cleaner] pass through recorded macro refs in walkUsed

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D13764

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:25 namespace clang::include_cleaner { namespace { +using DeclCallback = tschuett wrote: > There is a cuter way to use anonymous namespaces: > https://llvm.org/docs/Cod

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

tschuett added a comment. No worries. The style asks to move the definitions out of the anonymous namespace, but Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135859/new/ https://reviews.llvm.org/D135859 _

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos added a comment. @tschuett Do you want me to put the note about 'native' detection for neoverse-v2 back? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

tschuett added a comment. In D136589#3915126 , @vhscampos wrote: > @tschuett Do you still want me to put the note about 'native' detection for > neoverse-v2 back? Up to you. No worries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137644: [include-cleaner] pass through recorded macro refs in walkUsed

sammccall updated this revision to Diff 474008. sammccall added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137644/new/ https://reviews.llvm.org/D137644 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/A

[PATCH] D137644: [include-cleaner] pass through recorded macro refs in walkUsed

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:47 /// (e.g. IWYU pragmas). -void walkUsed(llvm::ArrayRef ASTRoots,

[clang-tools-extra] a5c18fc - Revert "[clang] Instantiate alias templates with sugar"

Author: Alexander Kornienko Date: 2022-11-08T17:19:54+01:00 New Revision: a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc URL: https://github.com/llvm/llvm-project/commit/a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc DIFF: https://github.com/llvm/llvm-project/commit/a5c18fcf6e7ffeea72aaf079477caf2ac1d641bc

[PATCH] D137649: [Clang][OpenMP] Warn and discard write to host for const variable

jplehr created this revision. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jplehr requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Resolves a potential segmentation fau

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:88-97 +constexpr int invalid() { + // Invalid expression in visit(). + while(huh) {} +} + +constexpr void invalid2() { + int i = 0; There should definitely be diagnostics here

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry created this revision. v1nh1shungry added reviewers: nridge, tom-anders. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[clang-tools-extra] 322cf74 - Fix call to utohexstr

Author: Aaron Ballman Date: 2022-11-08T11:51:47-05:00 New Revision: 322cf744b926a31986f78d74c79713e412cf811d URL: https://github.com/llvm/llvm-project/commit/322cf744b926a31986f78d74c79713e412cf811d DIFF: https://github.com/llvm/llvm-project/commit/322cf744b926a31986f78d74c79713e412cf811d.diff

[clang] 92e1723 - [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

Author: Adhemerval Zanella Date: 2022-11-08T13:58:37-03:00 New Revision: 92e172309cf6624487ef6b3a79a5445276f9 URL: https://github.com/llvm/llvm-project/commit/92e172309cf6624487ef6b3a79a5445276f9 DIFF: https://github.com/llvm/llvm-project/commit/92e172309cf6624487ef6b3a79a5445276f9.

[PATCH] D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137267/new/

[PATCH] D137652: Remove mandatory define of optional features macros for OpenCL C 3.0

FMarno created this revision. FMarno added a reviewer: Anastasia. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. FMarno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A number of feature macros were being

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz marked 2 inline comments as done. zatrazz added inline comments. Comment at: clang/lib/Headers/stdarg.h:17 +#ifndef __GNUC_VA_LIST +#define __GNUC_VA_LIST 1 +typedef __builtin_va_list __gnuc_va_list; MaskRay wrote: > To match gcc stdarg.h, `#define __GNUC

[PATCH] D137558: [clang][Interp] Reject reinterpret_casts

aaron.ballman added a comment. This is lacking test coverage. (Other interesting related test coverage are casts that perform a reinterpret_cast under the hood but that might be somewhat separate.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz updated this revision to Diff 474028. zatrazz marked 2 inline comments as done. zatrazz added a comment. Update review based on reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos updated this revision to Diff 474029. vhscampos added a comment. Rebasing and conflict resolution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 Files: clang/docs/ReleaseNotes.rst clang/tes

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D136936: [clang][Interp] Handle undefined functions better

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:24-31 + bool HasBody = true; + + // Function is not defined at all or not yet. We will + // create a Function instance but not compile the body. That + // will (maybe) happen later. i

[clang] 445a2ab - [OpenMP][NFC] Unclaim iterators in 'map' clause and motion clauses

Author: Chi Chun Chen Date: 2022-11-08T11:43:07-06:00 New Revision: 445a2ab60568be0a051cc2c9d2cc174cd0ab545d URL: https://github.com/llvm/llvm-project/commit/445a2ab60568be0a051cc2c9d2cc174cd0ab545d DIFF: https://github.com/llvm/llvm-project/commit/445a2ab60568be0a051cc2c9d2cc174cd0ab545d.diff

[PATCH] D137488: [clang][Interp] Array initialization via string literal

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1133-1134 + } else if (const auto *SL = dyn_cast(Initializer)) { +const ArrayType *AT = SL->getType()->getAsArrayTypeUnsafe(); +const auto *CAT = cast(AT); +size_t NumElems = CA

[clang] 28f9636 - [Assignment Tracking][7/*] Add assignment tracking functionality to clang

Author: OCHyams Date: 2022-11-08T17:49:08Z New Revision: 28f9636edd7d4e5f3eba1e3d0d37ec53d616481f URL: https://github.com/llvm/llvm-project/commit/28f9636edd7d4e5f3eba1e3d0d37ec53d616481f DIFF: https://github.com/llvm/llvm-project/commit/28f9636edd7d4e5f3eba1e3d0d37ec53d616481f.diff LOG: [Assi

[PATCH] D132226: [Assignment Tracking][7/*] Add assignment tracking functionality to clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28f9636edd7d: [Assignment Tracking][7/*] Add assignment tracking functionality to clang (authored by Orlando). Herald added a project: clang. Herald

[PATCH] D125860: [clang] Only use major version in resource dir

tstellar added a comment. @tbaeder That CI failure seems unrelated. Maybe just commit early in the day so you have time to deal with the bot failures (if any). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 _

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

dreachem added subscribers: dhruvachak, dreachem. dreachem added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @jdoerfert @tianshilei1992 @atmnpatel @dhruvachak Is the target to get this merged in for LLVM 16? Does the VGPU implementation provide a way to support OM

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

Bigcheese added a comment. I'm not aware of anyone using this mode, but please wait for responses from Google and Meta people to verify that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 ___ cfe-

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham added a subscriber: dexonsmith. bnbarham added a comment. This seems reasonable to me in general. @dexonsmith in case you have any thoughts. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'roo

[PATCH] D137399: [clang][Interp] Emit negated integers directly as constants

aaron.ballman added a comment. This is missing test coverage (possibly around integer promotion behavior as well). Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1525 +return true; + APSInt V = APSInt(IL->getValue(), /*IsUnsigned=*/false); + return this

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Okay, now I am getting what I believe to be segfaults: #0 0x564383482be4 PrintStackTraceSignalHandler(void*) Signals.cpp:0:0 #1 0x564383480464 SignalHandler(int) Signals.cpp:0:0 #2 0x7f7c275c9420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x

[clang] 98fa954 - Revert "[Assignment Tracking][7/*] Add assignment tracking functionality to clang"

Author: OCHyams Date: 2022-11-08T18:43:05Z New Revision: 98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e URL: https://github.com/llvm/llvm-project/commit/98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e DIFF: https://github.com/llvm/llvm-project/commit/98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e.diff LOG: Rever

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

tom-anders accepted this revision. tom-anders added a comment. This revision is now accepted and ready to land. Would be cool if in the future we could instead transform something like using namespace std; int main() { auto t = 5ms; } into using namespace std::chrono_literals; in

[PATCH] D137192: [clang][serialization] NFCI: Avoid re-reading input file info

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm, thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137192/new/ https://reviews.llvm.org/D137192

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:421-425 +// [Pointer] -> [] +def IncPtr : Opcode { + let HasGroup = 0; +} +// [Pointer] -> [] Don't both of these result in a `Pointer`? And should they have a `Types` field?

[PATCH] D137650: [clangd] Implement hover for C++ string literals

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:785 + + // TODO: Show string literal's contents + HI.Name = "String Literal"; Is it really useful to show the contents inside the Hover? You already see the contents of the string

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman added a comment. Precommit CI looks to have potentially found something interesting here. Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + aaron.ballman wrote: >

[PATCH] D137197: [clang][modules][deps] Transitive module maps are not affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Yeah, I agree with this. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137197/new/ https://reviews.llvm.org/D137197 ___

[clang-tools-extra] 38cccb9 - [include-cleaner] pass through recorded macro refs in walkUsed

Author: Sam McCall Date: 2022-11-08T20:10:39+01:00 New Revision: 38cccb90660347939dd7bfdd57ba66760cba39c2 URL: https://github.com/llvm/llvm-project/commit/38cccb90660347939dd7bfdd57ba66760cba39c2 DIFF: https://github.com/llvm/llvm-project/commit/38cccb90660347939dd7bfdd57ba66760cba39c2.diff LO

[PATCH] D137644: [include-cleaner] pass through recorded macro refs in walkUsed

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG38cccb906603: [include-cleaner] pass through recorded macro refs in walkUsed (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] c333b92 - [include-cleaner] Missing changes from 38cccb906603

Author: Sam McCall Date: 2022-11-08T20:18:10+01:00 New Revision: c333b92b72b40d1f39d89ab94f764baeb8bb0cab URL: https://github.com/llvm/llvm-project/commit/c333b92b72b40d1f39d89ab94f764baeb8bb0cab DIFF: https://github.com/llvm/llvm-project/commit/c333b92b72b40d1f39d89ab94f764baeb8bb0cab.diff LO

[PATCH] D137198: [clang][modules][deps] Parent module maps are affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137198/new/ https://reviews.llvm.org/D137198

[PATCH] D137659: [Driver] Refactor err_drv_unsupported_option_argument call sites to use llvm::opt::Arg::getSpelling

MaskRay created this revision. MaskRay added a reviewer: lenary. Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook

[clang] 9e95699 - [clang][Headers] Do not define varargs macros for __need___va_list

Author: Adhemerval Zanella Date: 2022-11-08T16:29:35-03:00 New Revision: 9e956995db1fc7e792e3dfb3a465a52626195557 URL: https://github.com/llvm/llvm-project/commit/9e956995db1fc7e792e3dfb3a465a52626195557 DIFF: https://github.com/llvm/llvm-project/commit/9e956995db1fc7e792e3dfb3a465a52626195557.

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e956995db1f: [clang][Headers] Do not define varargs macros for __need___va_list (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/

[clang] f0e6c40 - [AArch64] Allow users-facing feature names in clang target attributes

Author: David Green Date: 2022-11-08T19:30:26Z New Revision: f0e6c403c2d399e4fd821aa5a7e4a20534494c71 URL: https://github.com/llvm/llvm-project/commit/f0e6c403c2d399e4fd821aa5a7e4a20534494c71 DIFF: https://github.com/llvm/llvm-project/commit/f0e6c403c2d399e4fd821aa5a7e4a20534494c71.diff LOG: [

[PATCH] D137617: [AArch64] Allow users-facing feature names in clang target attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0e6c403c2d3: [AArch64] Allow users-facing feature names in clang target attributes (authored by dmgreen). Herald added a project: clang. Herald adde

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

iains added a comment. I think that (if this change is approved) there will be also some simplifications possible in the driver (since the mode that produces a wrapper header for multiple command-line headers is different from the mode where multiple command line headers would each produce a si

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

aaron.ballman added a comment. Thanks for this! Can you also add a release note for the changes? Comment at: clang/include/clang/AST/Decl.h:673 +class VarDecl; + This should be moved up to around line 77 or so (and kept in alphabetical order).

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added a comment. In D137244#3915633 , @aaron.ballman wrote: > Thanks for this! Can you also add a release note for the changes? Thanks for the Review! As mentioned this fixes an unreleased feature, hence why I don't think a release note entry

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:3234-3237 + if (auto *Var = llvm::dyn_cast(this)) +return Var; + if (auto *BD = llvm::dyn_cast(this)) +return llvm::dyn_cast(BD->getDecomposedDecl()); aaron.ballman wrote: > No need t

[PATCH] D137512: [clang] Add Swift support for MIPS

aschwaighofer added a comment. This looks good to me. Can you rebase your patch so that it applies on top of github.com:apple/llvm-project.git main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137512/new/ https://reviews.llvm.org/D137512 __

[PATCH] D137206: [clang][modules][deps] Including module maps are affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137206/new/ https://reviews.llvm.org/D137206 _

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ben.boeckel added a comment. FWIW, I was able to make CMake's module test suite pass with this patch on top of you MyP1689 branch on your Github fork. I also added some diffs to help clean up output files. I'll try and get it to work with the replacement patches as well, but I just want this to

[PATCH] D137409: [clang-format][NFCish] Alphabetical sort Format.(h|pp)

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23323 "WhitespaceSensitiveMacros: ['FOO', 'BAR']"))); - std::vector NonDefaultWhiteSpaceMacros{"FOO", "BAR"}; + std::vector NonDefaultWhiteSpaceMacros = +

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

dexonsmith added a comment. In D137473#3915497 , @bnbarham wrote: > This seems reasonable to me in general. @dexonsmith in case you have any > thoughts. SGTM! (I haven't reviewed in detail but I figure @bnbarham is on it...) Repository: rG LLVM Gith

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a subscriber: owenpan. HazardyKnusperkeks added a comment. @MyDeveloperDay @owenpan What shall we do? 1. Abandon this 2. Commit it in our name 3. Use the email from this commit: https://github.com/Wandalen/game_chess/commit/a84bba03667643ded0cfe7aff2907c6546a6a192 I'm p

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. More than one year silence. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

bnbarham added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', bnbarham wrote: > I'd prefer a test without `overlay-relative` set to make it c

  1   2   >