[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3909043 , @zahiraam wrote: > In D136786#3907235 , > @michele.scandale wrote: > >> In D136786#3903646 , @zahiraam >> wrote: >> >>> Th

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3912243 , @Skylion007 wrote: > One other bug I found with this diff, is it seems to suggest calling > std::move() on function args that are references, despite the fact that > invalidating the reference to the input ar

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. In D137205#3913192 , @Febbe wrote: > In D137205#3912243 , @Skylion007 > wrote: > >> One other bug I found with this diff, is it seems to suggest calling >> std::move() on function arg

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Generally LGTM, though I found a few minor things. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1 <

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman added a comment. I'd like to see some test coverage for what these changes catch that wasn't caught before. On its face, this seems reasonable in that we don't want to bother running the interpreter (further) once we know we've hit an expression, declaration, or type that's not va

[clang] cafe50d - Explicitly initialize opaque pointer mode in CodeGenAction

Author: Matthias Braun Date: 2022-11-07T12:31:28-08:00 New Revision: cafe50daf525971ffc3b8c5f2f6343d24e381384 URL: https://github.com/llvm/llvm-project/commit/cafe50daf525971ffc3b8c5f2f6343d24e381384 DIFF: https://github.com/llvm/llvm-project/commit/cafe50daf525971ffc3b8c5f2f6343d24e381384.diff

[PATCH] D137475: Explicitly initialize opaque pointer mode in CodeGenAction

This revision was automatically updated to reflect the committed changes. Closed by commit rGcafe50daf525: Explicitly initialize opaque pointer mode in CodeGenAction (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137475/new/ htt

[clang] cd8c6ab - [NFC] clang-format part of TypePrinter.cpp

Author: Arthur Eubanks Date: 2022-11-07T13:20:36-08:00 New Revision: cd8c6ab084c05b50c41163cd9f415a4c70aea8e9 URL: https://github.com/llvm/llvm-project/commit/cd8c6ab084c05b50c41163cd9f415a4c70aea8e9 DIFF: https://github.com/llvm/llvm-project/commit/cd8c6ab084c05b50c41163cd9f415a4c70aea8e9.diff

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Followup to D134378 . With PrintingPolicy::SuppressScope, we'd also n

[PATCH] D137584: Add const information about AST nodes used to construct CFG elements.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most constructors and destructors in CFG.h already specify const arguments, but som

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 473770. Febbe added a comment. Fixed lValueReference detection in matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/performa

[PATCH] D137531: [clang] Fix the GitHub issue #58674

cor3ntin added a comment. Thanks for working on this. I agree with Aaron, can you make the commit message clearer as to what is fixed, and mention in clang/docs/ReleaseNotes that the issue is fixed. Comment at: clang/lib/Sema/SemaExpr.cpp:2698-2704 + if (!SS.isEmpty()) +

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473772. ayzhao added a comment. whoops, uploaded the wrong commit. should be fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473779. ayzhao added a comment. remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.

[clang] 86674f6 - [HLSL] Added HLSL this as a reference

Author: Grace Jennings Date: 2022-11-07T13:50:08-08:00 New Revision: 86674f66cc78a1a121d43fe51f076cbfa8710b1a URL: https://github.com/llvm/llvm-project/commit/86674f66cc78a1a121d43fe51f076cbfa8710b1a DIFF: https://github.com/llvm/llvm-project/commit/86674f66cc78a1a121d43fe51f076cbfa8710b1a.diff

[PATCH] D135721: [HLSL] Added HLSL this as a reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG86674f66cc78: [HLSL] Added HLSL this as a reference (authored by gracejennings, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1357

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473789. ayzhao added a comment. s/pro20/post20/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

yln accepted this revision. yln added a comment. This revision is now accepted and ready to land. Looks harmless enough.. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/ https://reviews.llvm.org/D137484

[clang-tools-extra] afa22c5 - [clangd] Pass the entire tooling::CompileCommand to CommandMangler

Author: Nathan Ridge Date: 2022-11-07T17:58:37-05:00 New Revision: afa22c563f12f22da93b8f172d18c7991392d071 URL: https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071 DIFF: https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071.diff

[clang-tools-extra] 68e230a - [clangd] Perform system include extraction inside CommandMangler

Author: Nathan Ridge Date: 2022-11-07T17:58:39-05:00 New Revision: 68e230aa29f71ed840a0ea9c0be97c8c6ead1c69 URL: https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69 DIFF: https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69.diff

[PATCH] D133756: [clangd] Pass the entire tooling::CompileCommand to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGafa22c563f12: [clangd] Pass the entire tooling::CompileCommand to CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/n

[clang-tools-extra] 428ac8f - [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

Author: Nathan Ridge Date: 2022-11-07T17:58:42-05:00 New Revision: 428ac8f3a0f9572fcff03c2fae62c4ae8420a0df URL: https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df DIFF: https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df.diff

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e230aa29f7: [clangd] Perform system include extraction inside CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137401: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG428ac8f3a0f9: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp (authored by nridge). Repository: rG LLVM Github Monorepo CHA

[clang] f64802e - [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

Author: Amara Emerson Date: 2022-11-07T15:04:09-08:00 New Revision: f64802e8d3e9db299cad913ffcb734c8d35dc5f0 URL: https://github.com/llvm/llvm-project/commit/f64802e8d3e9db299cad913ffcb734c8d35dc5f0 DIFF: https://github.com/llvm/llvm-project/commit/f64802e8d3e9db299cad913ffcb734c8d35dc5f0.diff

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf64802e8d3e9: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D137269?vs=472753&id=473807#toc Repositor

[clang] 41ce74e - [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

Author: Sami Tolvanen Date: 2022-11-07T23:05:28Z New Revision: 41ce74e6e983f523d44d3a80be5ae778c35df85a URL: https://github.com/llvm/llvm-project/commit/41ce74e6e983f523d44d3a80be5ae778c35df85a DIFF: https://github.com/llvm/llvm-project/commit/41ce74e6e983f523d44d3a80be5ae778c35df85a.diff LOG:

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

This revision was automatically updated to reflect the committed changes. Closed by commit rG41ce74e6e983: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136790

[PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. In D137338#3912135 , @aaron.ballman wrote: > In D137338#3907281 , @Rageking8 > wrote: > >> I am ok with you guys taking the parts of this revision that you reviewed >> and directly co

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 473819. Febbe added a comment. Added some tests. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/performance/CMakeLi

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

jkorous added a comment. @aaron.ballman We'd like to start making progress on the implementation in parallel to iterating on the documentation and this is our first patch: https://reviews.llvm.org/D137346 Since we'll have about 4 people working full-time on this it isn't reasonable to expect yo

[libunwind] 32a2af4 - [CMake] Fix -Wstrict-prototypes

Author: Sam James Date: 2022-11-08T01:37:04Z New Revision: 32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d URL: https://github.com/llvm/llvm-project/commit/32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d DIFF: https://github.com/llvm/llvm-project/commit/32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d.diff LOG: [CM

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

cor3ntin added a comment. There is a C++ standard meeting this week so some folks won't be able to review it. Feel free to re-ping next week if nobody else replies. Because it's a fairly big change and I've been known to miss glaring things, I don't feel comfortable to approve it. But it looks g

[PATCH] D137514: [clang-tidy] add check for capturing lambda coroutines

ChuanqiXu added a comment. In D137514#3912626 , @dotnwat wrote: > In D137514#3911046 , @ChuanqiXu > wrote: > >> This is helpful. I feel it is OK to add the warning in the clang too. Are >> you interested in that

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. lgtm. Though `__PPC64__` is kept in https://reviews.llvm.org/D137511, we prefer to use `__powerpc64__` which is documented in https://reviews.llvm.org/D137511. Repository: rG LLVM G

[PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913065 , @mizvekov wrote: > In D136565#3911884 , @alexfh wrote: > >> Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d >>

[PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. @alexfh Thanks! While there is a huge increase in the amount of UsingTypes, it seems the total amount is still reasonable and does not explain the perf hit. Perhaps this is a case of bad hashing and they are all falling into the same bucket? cc @sam.mcall for awarene

Re: [PATCH] D136565: [clang] Instantiate alias templates with sugar

Given the broad impact of this in our code I'm inclined to revert the patch to unblock us. The test case I have so far is still too large, but I hope to get something shareable tomorrow. On Tue, 8 Nov 2022, 04:03 Matheus Izvekov via Phabricator, < revi...@reviews.llvm.org> wrote: > mizvekov added

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

pcwang-thead added a comment. A rough implementation just for your reference: diff --git a/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp b/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp index 47e11b9a1eab..f91f969c2b17 100644 --- a/llvm/utils/TableGen/RISCVTargetDefEmitter.cpp +++ b/llvm/

[PATCH] D137603: [Clang][Sema] Fix attribute((format)) bug on non-variadic functions

fcloutier created this revision. fcloutier added reviewers: ahatanak, dcoughlin, aaron.ballman. fcloutier added a project: clang. Herald added a project: All. fcloutier requested review of this revision. Herald added a subscriber: cfe-commits. The initial implementation

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, and MacroCallReconstructorTest.cpp? Leaving them out wouldn't break any existing tests. Adding `PPBranchLevel` (or `PPLevel` in your case) to `UnwrappedLine` and `AnnotatedLine` worked for me. I

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3911602 , @owenpan wrote: > In D137181#3911005 , @sstwcw wrote: > >> Here is one problem: >> >> clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1,

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914066 , @owenpan wrote: > @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, > and MacroCallReconstructorTest.cpp? Leaving them out wouldn't break any > existing tests. > > Adding `PPBr

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473875. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3911602 , @owenpan wrote: > In D137181#3911005 , @sstwcw wrote: > >> Here is one problem: >> >> clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1,

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining added inline comments. Comment at: llvm/test/CodeGen/LoongArch/intrinsic-error.ll:10 + +declare void @llvm.loongarch.dbar(i32) It's better to add a test that immediate is out of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, iains, dblaikie, Bigcheese. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

ChuanqiXu updated this revision to Diff 473884. ChuanqiXu added a comment. Remove other logics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llvm.org/D137609 Files: clang/include/clang/Frontend/FrontendActions.h clang/include/clang/Frontend/FrontendOpti

[clang] 13f8336 - [Driver] Add -fsample-profile-use-profi

Author: haoyuintel Date: 2022-11-08T15:51:38+08:00 New Revision: 13f83365cdb5bb752066ee8f4149ae24dfe46cf1 URL: https://github.com/llvm/llvm-project/commit/13f83365cdb5bb752066ee8f4149ae24dfe46cf1 DIFF: https://github.com/llvm/llvm-project/commit/13f83365cdb5bb752066ee8f4149ae24dfe46cf1.diff LO

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

This revision was automatically updated to reflect the committed changes. Closed by commit rG13f83365cdb5: [Driver] Add -fsample-profile-use-profi (authored by HaoyuZhang, committed by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/ne

[clang] d1f90b6 - [NFC] [C++20] [Modules] Rename ASTWriter::isWritingStdCXXNamedModules

Author: Chuanqi Xu Date: 2022-11-08T15:58:46+08:00 New Revision: d1f90b61292045d395ba5b94bc9098f4b5d4e55d URL: https://github.com/llvm/llvm-project/commit/d1f90b61292045d395ba5b94bc9098f4b5d4e55d DIFF: https://github.com/llvm/llvm-project/commit/d1f90b61292045d395ba5b94bc9098f4b5d4e55d.diff LO

<    1   2