[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. In D136572#3890835 , @mgorny wrote: > In D136572#3889317 , @mstorsjo > wrote: > >> Also for the record, I'd love to get rid of this symlink based setup, if I >> could make cmake produce

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

balazske added a comment. > (gdb) p Decl->getUnderlyingType().dump() > ConstantArrayType 0x118ea470 'struct __va_list_tag[1]' 1 > `-RecordType 0x118ea2b0 'struct __va_list_tag' > `-Record 0x118ea228 '__va_list_tag' > $2 = void > (gdb) p Underlying > $3 = {Value = {Value = 29504611

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxneconvert-intrinsics.ll:4 +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+avxneconvert | FileCheck %s --check-prefixes=X86 + +define <4 x float> @test_int_x86

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei created this revision. pengfei added reviewers: RKSimon, ldionne, bkramer. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC folks decided to make the mangling of __bf16 the same as std::bfloat

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D136090: Handle errors in expansion of response files

mgorny added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:604-606 + char *StrBuff = (char *)Alloc.Allocate(6, 2); + std::memcpy(StrBuff, "\xFF\xFE\x00\xD8\x00\x00", 6); + StringRef BadUTF(StrBuff, 6); Wouldn't it be possible to use `st

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:1253 +Flags<[NoXarchOption, CC1Option]>, Group, +HelpText<"Use profi to infer block and edge counts.">; def fno_profile_sample_accurate : Flag<["-"], "fno-profile-sample-accurate">, ---

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

hokein added a comment. In D136564#3890676 , @rtrieu wrote: > I noticed some build failures after your commit. I'm trying to get a > standalone reproducer. Here is the broken testcase: // -std=c++17 #include template using FixedTypeT = Ty

[PATCH] D136925: [clangd] Index scoped enums for code completion

tom-anders created this revision. tom-anders added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[clang] beb9977 - [Clang] Improve diagnostic message for loop hint pragma

Author: eopXD Date: 2022-10-28T01:51:24-07:00 New Revision: beb997799d823aece097494f156c6d277d26571c URL: https://github.com/llvm/llvm-project/commit/beb997799d823aece097494f156c6d277d26571c DIFF: https://github.com/llvm/llvm-project/commit/beb997799d823aece097494f156c6d277d26571c.diff LOG: [C

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rGbeb997799d82: [Clang] Improve diagnostic message for loop hint pragma (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https:/

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

frasercrmck accepted this revision. frasercrmck added a comment. LGTM other than a nit, but I concur that a comment in AutoUpgrade would be nice. Comment at: llvm/docs/ReleaseNotes.rst:123 +* i32 is now a native type in the datalayout string. This enables + LoopStrengthReduce

[PATCH] D136710: [include-cleaner] Add the missing parts of Symbol and Header clases.

kadircet added a comment. thanks, i agree with your comments around `std::variant`, let's see what kind of patterns will emerge in the future. so, still LG, but please address the triple slash issue and const-ness before landing Comment at: clang-tools-extra/include-cleaner

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

pcwang-thead created this revision. pcwang-thead added reviewers: kito-cheng, craig.topper, asb. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosb

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

peter.smith added a comment. I've got about as far as the clang changes. As I mentioned in Discourse I'm not familiar enough in this area to give good feedback on the implementation, most if not all my comments fall under the bike shedding category. Will need to leave the high-level feedback to

[clang] bf07c33 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Author: Haojian Wu Date: 2022-10-28T11:56:19+02:00 New Revision: bf07c338bb78c54b8d96fb42a75b168bf1550ad7 URL: https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7 DIFF: https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7.diff LO

[clang-tools-extra] bf07c33 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Author: Haojian Wu Date: 2022-10-28T11:56:19+02:00 New Revision: bf07c338bb78c54b8d96fb42a75b168bf1550ad7 URL: https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7 DIFF: https://github.com/llvm/llvm-project/commit/bf07c338bb78c54b8d96fb42a75b168bf1550ad7.diff LO

[PATCH] D136936: [clang][Interp] Handle undefined functions better

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make sure we add body-less functions to our program

[PATCH] D136090: Handle errors in expansion of response files

sepavloff added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:604-606 + char *StrBuff = (char *)Alloc.Allocate(6, 2); + std::memcpy(StrBuff, "\xFF\xFE\x00\xD8\x00\x00", 6); + StringRef BadUTF(StrBuff, 6); mgorny wrote: > Wouldn't it be

[clang] 6e7f421 - [clang][Interp][NFC] Fix a file header comment

Author: Timm Bäder Date: 2022-10-28T12:49:38+02:00 New Revision: 6e7f421e5574b5669153a73ac0f1879098d2dd0e URL: https://github.com/llvm/llvm-project/commit/6e7f421e5574b5669153a73ac0f1879098d2dd0e DIFF: https://github.com/llvm/llvm-project/commit/6e7f421e5574b5669153a73ac0f1879098d2dd0e.diff LO

[clang] b61e8c5 - [clang][Interp][NFC] Add Record::getName()

Author: Timm Bäder Date: 2022-10-28T12:49:34+02:00 New Revision: b61e8c517eff2083252b1b74544bc25f7ad5a368 URL: https://github.com/llvm/llvm-project/commit/b61e8c517eff2083252b1b74544bc25f7ad5a368 DIFF: https://github.com/llvm/llvm-project/commit/b61e8c517eff2083252b1b74544bc25f7ad5a368.diff LO

[clang] c1dd7f9 - [clang][Interp][NFC] Print more info in Program::dump()

Author: Timm Bäder Date: 2022-10-28T12:49:38+02:00 New Revision: c1dd7f90132a8a767d91f9b2b3e2bf1a9d7aa04f URL: https://github.com/llvm/llvm-project/commit/c1dd7f90132a8a767d91f9b2b3e2bf1a9d7aa04f DIFF: https://github.com/llvm/llvm-project/commit/c1dd7f90132a8a767d91f9b2b3e2bf1a9d7aa04f.diff LO

[clang] 0ad3ad6 - [clang][Interp][NFC] Remove leftover comment fragment

Author: Timm Bäder Date: 2022-10-28T12:49:38+02:00 New Revision: 0ad3ad6bc7e1629703d931222514b2a97e885cb9 URL: https://github.com/llvm/llvm-project/commit/0ad3ad6bc7e1629703d931222514b2a97e885cb9 DIFF: https://github.com/llvm/llvm-project/commit/0ad3ad6bc7e1629703d931222514b2a97e885cb9.diff LO

[clang] 6fa1795 - [clang][Interp] Implement String- and CharacterLiterals

Author: Timm Bäder Date: 2022-10-28T12:49:38+02:00 New Revision: 6fa1795d1fd4770f9f5c00f5a30937d68c3feb17 URL: https://github.com/llvm/llvm-project/commit/6fa1795d1fd4770f9f5c00f5a30937d68c3feb17 DIFF: https://github.com/llvm/llvm-project/commit/6fa1795d1fd4770f9f5c00f5a30937d68c3feb17.diff LO

[clang] 7f3013c - [clang][Interp][NFC] Fix instance method check

Author: Timm Bäder Date: 2022-10-28T12:49:38+02:00 New Revision: 7f3013c5f9767c3dabd41d4219893e3154b126ea URL: https://github.com/llvm/llvm-project/commit/7f3013c5f9767c3dabd41d4219893e3154b126ea DIFF: https://github.com/llvm/llvm-project/commit/7f3013c5f9767c3dabd41d4219893e3154b126ea.diff LO

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa1795d1fd4: [clang][Interp] Implement String- and CharacterLiterals (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

thakis added a comment. One of your commits doesn't build on windows with clang-cl as host compiler: http://45.33.8.238/win/68965/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice created this revision. paperchalice added a reviewer: MaskRay. paperchalice added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. paperchalice requested review of this revision. Herald added a subscriber: cfe-commits. This patch allows users to co

[clang] 63e3fe1 - Revert "[clang][Interp] Implement String- and CharacterLiterals"

Author: Timm Bäder Date: 2022-10-28T13:34:37+02:00 New Revision: 63e3fe10882476696d8a05907dfe627bd61638a3 URL: https://github.com/llvm/llvm-project/commit/63e3fe10882476696d8a05907dfe627bd61638a3 DIFF: https://github.com/llvm/llvm-project/commit/63e3fe10882476696d8a05907dfe627bd61638a3.diff LO

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

martong added a comment. In D136603#3888065 , @steakhal wrote: > Previously, even in the `RegionStoreManager::getBinding()` even if `T` was > non-null, we replaced it with `TVR->getValueType()` in case the `MR` was > `TypedValueRegion`. Yeah, that mean

[PATCH] D136940: [clang][Driver] allow tilde in user config dir

paperchalice updated this revision to Diff 471494. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136940/new/ https://reviews.llvm.org/D136940 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp =

[PATCH] D136941: [clang][Interp] Implement String-and CharacterLiterals

tbaeder created this revision. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Including a fix for the ambiguous APInt constructor. Precommit CI should work on this now. Repository: rG LLVM Github M

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman created this revision. aaron.ballman added reviewers: clang-language-wg, erichkeane, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. The changes in this paper add a new recommended practice. I had originally mark

[PATCH] D136567: [clangd] Avoid hanging in Selection when PP corrects the token sequence.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:316 // return the eof token. if (ExpandedTokens.back().kind() == tok::eof) ExpandedTokens = ExpandedTo

[clang] 76cf890 - Add some more C11 DR tests and update the status page

Author: Aaron Ballman Date: 2022-10-28T08:17:03-04:00 New Revision: 76cf890984bf091bfd9efd6dc7bf0ef96b8b9f45 URL: https://github.com/llvm/llvm-project/commit/76cf890984bf091bfd9efd6dc7bf0ef96b8b9f45 DIFF: https://github.com/llvm/llvm-project/commit/76cf890984bf091bfd9efd6dc7bf0ef96b8b9f45.diff

[PATCH] D136090: Handle errors in expansion of response files

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/Driver/ToolChainTest.cpp:604-606 + char *StrBuff = (char *)Alloc.Allocate(6, 2); + std::memcpy(StrBuff, "\xFF\xFE\x00\xD8\x00\x00", 6); +

[PATCH] D134453: Disambiguate type names when printing NTTP types

This revision was automatically updated to reflect the committed changes. Closed by commit rG835b99e4c838: Disambiguate type names when printing NTTP types (authored by DoDoENT, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 835b99e - Disambiguate type names when printing NTTP types

Author: Nenad Mikša Date: 2022-10-28T08:18:38-04:00 New Revision: 835b99e4c8381f6dd1dda7e2ef0e9c72359460dd URL: https://github.com/llvm/llvm-project/commit/835b99e4c8381f6dd1dda7e2ef0e9c72359460dd DIFF: https://github.com/llvm/llvm-project/commit/835b99e4c8381f6dd1dda7e2ef0e9c72359460dd.diff L

Re: [Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Also, please be sure to post something to https://discourse.llvm.org/c/announce/46 with the potentially-breaking tag applied to it. ~Aaron On Thu, Oct 27, 2022 at 8:19 PM Hubert Tong via Phabricator via cfe-commits wrote: > > hubert.reinterpretcast added inline comments. > > BRANCHES > main >

[PATCH] D136941: [clang][Interp] Implement String-and CharacterLiterals

tbaeder updated this revision to Diff 471505. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136941/new/ https://reviews.llvm.org/D136941 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/literals.cpp clang/test/Lexer/char

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h:33 +/// Indicates the relation between the reference and the target. +enum class RefType { + /// Target is explicit from the reference,

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet updated this revision to Diff 471512. kadircet added a comment. - Fix typo in Ambiguous - Rebase for Types.h, introduce SymbolReference - Use comments rather than an optional parameter to indicate header-ness of main files in tests - Rather than assuming Root is in main file, check that

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:465 +bool CheckCtorCall(InterpState &S, CodePtr OpPC, const Pointer &This) { + assert(!This.isZero()); + const Record *R = This.getRecord(); shafik wrote: > Should we also check `isLive(

[clang] 52ba50c - [clang][Interp] Implement String- and CharacterLiterals

Author: Timm Bäder Date: 2022-10-28T15:05:21+02:00 New Revision: 52ba50c24c5572330a04b86879fdefaa81705a18 URL: https://github.com/llvm/llvm-project/commit/52ba50c24c5572330a04b86879fdefaa81705a18 DIFF: https://github.com/llvm/llvm-project/commit/52ba50c24c5572330a04b86879fdefaa81705a18.diff LO

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

erichkeane added a comment. In D134128#3890447 , @h-vetinari wrote: > Congratulations for landing this! > > How far do you (both) think we're away from completing concepts? Are the > issues (aside from CWG1496 & CWG1734) mentioned on > https://clang.ll

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 471515. sdesmalen marked 9 inline comments as done. sdesmalen edited the summary of this revision. sdesmalen added a comment. - Rebased patch - Use `InheritableAttr` for the `ArmLocallyStreaming` attribute instead of `DeclOrTypeAttr` - Added test-case to te

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added a subscriber: rsandifo-arm. sdesmalen added a comment. The past few months we've worked to get the attributes at the LLVM IR side implemented. Since that work has now landed, this patch should no longer be held up by the LLVM side of things. @aaron.ballman I've updated and rebas

[clang] 83b97b3 - [clang] Fix a -Wcast-qual GCC warning. NFC.

Author: Martin Storsjö Date: 2022-10-28T16:11:34+03:00 New Revision: 83b97b3b277281c3b90d245c7816addccc756158 URL: https://github.com/llvm/llvm-project/commit/83b97b3b277281c3b90d245c7816addccc756158 DIFF: https://github.com/llvm/llvm-project/commit/83b97b3b277281c3b90d245c7816addccc756158.diff

[PATCH] D136936: [clang][Interp] Handle undefined functions better

tbaeder updated this revision to Diff 471517. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136936/new/ https://reviews.llvm.org/D136936 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/

[clang] fd448bb - [clang][LTO] Passing vec-extabi to the Backend on AIX

Author: Qiongsi Wu Date: 2022-10-28T09:13:17-04:00 New Revision: fd448bbedce91bcc6aad9072af58a4fcb7f7bf70 URL: https://github.com/llvm/llvm-project/commit/fd448bbedce91bcc6aad9072af58a4fcb7f7bf70 DIFF: https://github.com/llvm/llvm-project/commit/fd448bbedce91bcc6aad9072af58a4fcb7f7bf70.diff LO

[PATCH] D136874: [clang][LTO] Passing vec-extabi to the Backend on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd448bbedce9: [clang][LTO] Passing vec-extabi to the Backend on AIX (authored by Qiongsi Wu ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. My suggestion would be to properly handle cycles in `CheckConstraintSatisfaction`. This problem goes beyond cycles introduced by conversion. See #53213 and #44304

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

erichkeane added a comment. I had two suggestions for more tests, but this is probably covering everything. Comment at: clang/test/C/C2x/n2322.c:44 + ) == 2007); +} + I might suggest: _Static_assert(555 == __\ LI\ NE\ __) Which, is basically exactly what the

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 471528. TIFitis added a comment. Moved loadOffloadInfoMetadata inside OpenMPIRBuilder class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 Files: clang/lib/CodeGe

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4717 + if (!isDevice) +return; + jdoerfert wrote: > Why do we call it if isDevice is false? Module should be available to the > IR

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder updated this revision to Diff 471534. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ https://reviews.llvm.org/D136920 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/arrays.cpp Index: clang/test/AST/In

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 471535. to268 added a comment. Reworked the parsing side of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/include/clang/Basic/DiagnosticParse

[clang] dce7864 - clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

Author: Nicolai Hähnle Date: 2022-10-28T15:48:20+02:00 New Revision: dce78646f07ff67f7d4887525e908dbf47d9e86b URL: https://github.com/llvm/llvm-project/commit/dce78646f07ff67f7d4887525e908dbf47d9e86b DIFF: https://github.com/llvm/llvm-project/commit/dce78646f07ff67f7d4887525e908dbf47d9e86b.diff

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

This revision was automatically updated to reflect the committed changes. Closed by commit rGdce78646f07f: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134637/ne

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 added a comment. Also i'm not sure if must add C2x to this condition just in case (falling back or add an assertion) Comment at: clang/lib/Sema/DeclSpec.cpp:1362 // type specifier. if (S.getLangOpts().CPlusPlus && TypeSpecType == TST_unspecified && StorageCl

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ldionne added a comment. Is it possible that it would be one of those two bugs? https://github.com/llvm/llvm-project/issues?q=is%3Aopen+is%3Aissue+author%3Aldionne+availability+ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://rev

[PATCH] D136951: [clangd] Populate ranges and symbol origin for paramname completions

kadircet created this revision. kadircet added reviewers: nridge, hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Reposito

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3891905 , @ldionne wrote: > Is it possible that it would be one of those two bugs? > https://github.com/llvm/llvm-project/issues?q=is%3Aopen+is%3Aissue+author%3Aldionne+availability+ I don't think so. It does look l

[clang] 8b87cb4 - [clang][Interp] Remove unused getGlobalIdx()

Author: Timm Bäder Date: 2022-10-28T16:34:29+02:00 New Revision: 8b87cb4853409ea8066e451ee87f550a9ecd3c34 URL: https://github.com/llvm/llvm-project/commit/8b87cb4853409ea8066e451ee87f550a9ecd3c34 DIFF: https://github.com/llvm/llvm-project/commit/8b87cb4853409ea8066e451ee87f550a9ecd3c34.diff LO

[clang] 0ccff03 - [clang][Interp] Fix record members of reference type

Author: Timm Bäder Date: 2022-10-28T16:34:45+02:00 New Revision: 0ccff030f3b4145bd658e362a63db9aae2942bee URL: https://github.com/llvm/llvm-project/commit/0ccff030f3b4145bd658e362a63db9aae2942bee DIFF: https://github.com/llvm/llvm-project/commit/0ccff030f3b4145bd658e362a63db9aae2942bee.diff LO

[PATCH] D136012: [clang][Interp] Fix record members of reference type

This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG0ccff030f3b4: [clang][Interp] Fix record members of reference type (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types

mizvekov added a comment. I agree having two different val_list types is suspect, it might not have been imported and is simply referring to the va_list of the original context. One other note, is that if a problem exists for TypedefType, it probably exists for UsingType as well, as they are ve

[clang] 38ffc89 - [clang][Interp] Fix ignoring expression return values

Author: Timm Bäder Date: 2022-10-28T16:45:38+02:00 New Revision: 38ffc89c87ac3b0b1c2173728fba2258dead9ae0 URL: https://github.com/llvm/llvm-project/commit/38ffc89c87ac3b0b1c2173728fba2258dead9ae0 DIFF: https://github.com/llvm/llvm-project/commit/38ffc89c87ac3b0b1c2173728fba2258dead9ae0.diff LO

[PATCH] D136013: [clang][Interp] Fix ignoring expression return values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38ffc89c87ac: [clang][Interp] Fix ignoring expression return values (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D1360

[PATCH] D136953: [C++20] Diagnosed invalid and reserved module names

aaron.ballman created this revision. aaron.ballman added reviewers: iains, urnathan, ChuanqiXu, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. [module.unit]p1 specifies that `module` and `import` are invalid component

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman updated this revision to Diff 471554. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Added an additional test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136942/new/ https://reviews.llvm.org/D136942 Files: clang/test/C/C2x/n2322.c

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

aaron.ballman added inline comments. Comment at: clang/test/C/C2x/n2322.c:44 + ) == 2007); +} + erichkeane wrote: > I might suggest: > > _Static_assert(555 == __\ > LI\ > NE\ > __) > > Which, is basically exactly what the first bullet point in J.1 is trying to

[PATCH] D136942: [C2x] Add test coverage for WG14 N2322

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm OK with this either way, I think you've proved out the important cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136942/new/ https://reviews.llvm.org/D136942 ___

[PATCH] D136826: [clang][Interp] Make sure we free() allocated InitMaps

This revision was automatically updated to reflect the committed changes. Closed by commit rGee9bbfa5e6ac: [clang][Interp] Make sure we free() allocated InitMaps (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136826/new/ https:

[clang] ee9bbfa - [clang][Interp] Make sure we free() allocated InitMaps

Author: Timm Bäder Date: 2022-10-28T17:00:15+02:00 New Revision: ee9bbfa5e6acaea6d2a116bc29b7086441f86b6a URL: https://github.com/llvm/llvm-project/commit/ee9bbfa5e6acaea6d2a116bc29b7086441f86b6a DIFF: https://github.com/llvm/llvm-project/commit/ee9bbfa5e6acaea6d2a116bc29b7086441f86b6a.diff LO

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:257 +else if (PartName.startswith("std") && + (PartName.size() == 3 || isDigit(PartName.drop_front(3)[0]))) + Reason = /*reserved*/ 1; Comment at: c

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

erichkeane added a comment. I'll leave it to the modules experts to decide whether they're happy with this, but I had a drive-by. Also, I see none of the tests validate 'import', just 'export'. Based on the standard, BOTH are illegal, right :D Comment at: clang/lib/Sema/Sem

[clang] 524c640 - [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

Author: Eduard Zingerman Date: 2022-10-28T08:07:54-07:00 New Revision: 524c640090a8463305acbafd7606f1db3c1256e2 URL: https://github.com/llvm/llvm-project/commit/524c640090a8463305acbafd7606f1db3c1256e2 DIFF: https://github.com/llvm/llvm-project/commit/524c640090a8463305acbafd7606f1db3c1256e2.di

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

This revision was automatically updated to reflect the committed changes. Closed by commit rG524c640090a8: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names (authored by eddyz87, committed by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

cor3ntin added a comment. In D136953#3892060 , @erichkeane wrote: > I'll leave it to the modules experts to decide whether they're happy with > this, but I had a drive-by. > > Also, I see none of the tests validate 'import', just 'export'. Based on the

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D136953#3892077 , @cor3ntin wrote: > In D136953#3892060 , @erichkeane > wrote: > >> I'll leave it to the modules experts to decide

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:257 +else if (PartName.startswith("std") && + (PartName.size() == 3 || isDigit(PartName.drop_front(3)[0]))) + Reason = /*reserved*/ 1; aaron.ballman wrote: > cor3ntin

[PATCH] D136956: [clang][Interp] Implement BitXor opcode

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:257 +else if (PartName.startswith("std") && + (PartName.size() == 3 || isDigit(PartName.drop_front(3)[0]))) + Reason = /*reserved*/ 1; erichkeane wrote: > aaron.ballman

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:257 +else if (PartName.startswith("std") && + (PartName.size() == 3 || isDigit(PartName.drop_front(3)[0]))) + Reason = /*reserved*/ 1; cor3ntin wrote: > erichkeane wr

[PATCH] D136957: [AArch64] Add support for the Cortex-A715 CPU

simpal01 created this revision. simpal01 added reviewers: vhscampos, dmgreen, stuij. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. simpal01 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[clang] 974e2e6 - [RISCV] Adjust RV64I data layout by using n32:64 in layout string

Author: Craig Topper Date: 2022-10-28T08:27:03-07:00 New Revision: 974e2e690b4024c2677dde26cc76ec31e0047c1d URL: https://github.com/llvm/llvm-project/commit/974e2e690b4024c2677dde26cc76ec31e0047c1d DIFF: https://github.com/llvm/llvm-project/commit/974e2e690b4024c2677dde26cc76ec31e0047c1d.diff

[PATCH] D116735: [RISCV] Adjust RV64I data layout by using n32:64 in layout string

This revision was automatically updated to reflect the committed changes. Closed by commit rG974e2e690b40: [RISCV] Adjust RV64I data layout by using n32:64 in layout string (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D116735?vs=471385&id=471564#toc Repository:

[PATCH] D136817: [RISCV] Add H extension

reames added inline comments. Comment at: llvm/docs/RISCVUsage.rst:54 ``F``Supported + ``H``Supported ``M``Supported If I'm reading the code right here, we only have assembly support here. Given that, shouldn'

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 471565. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp cl

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. >> I'm not following entirely, but -funsafe-math-optimizations is just a subset >> of -ffast-math, so checking only the properties that contribute to >> -funsafe-math-optimizations should be enough. >> I think it is way simpler to reason in these terms than enumeratin

[clang] 5eb1fbd - [clang][Docs] Correct typo: "may_trap" is rejected, the value is "maytrap".

Author: Kevin P. Neal Date: 2022-10-28T11:40:42-04:00 New Revision: 5eb1fbd109734771554465aa307e8205c2a2632e URL: https://github.com/llvm/llvm-project/commit/5eb1fbd109734771554465aa307e8205c2a2632e DIFF: https://github.com/llvm/llvm-project/commit/5eb1fbd109734771554465aa307e8205c2a2632e.diff

[clang] 55b4344 - [HIP] add --offload-add-rpath

Author: Yaxun (Sam) Liu Date: 2022-10-28T11:42:38-04:00 New Revision: 55b43449978cc7050bef3ec255cbf5c5feee274e URL: https://github.com/llvm/llvm-project/commit/55b43449978cc7050bef3ec255cbf5c5feee274e DIFF: https://github.com/llvm/llvm-project/commit/55b43449978cc7050bef3ec255cbf5c5feee274e.dif

[PATCH] D136854: [HIP] add --offload-add-rpath

This revision was automatically updated to reflect the committed changes. Closed by commit rG55b43449978c: [HIP] add --offload-add-rpath (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136854/new/ h

[PATCH] D135930: [X86] Add AVX-NE-CONVERT instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512vlbf16intrin.h:164 +#define _mm_cvtneps_pbh(A) \ + ((__m128bh)__builtin_ia32_vcvtneps2bf16128((__v4sf)(A))) Is there no way for __attribute__ to allow different attribute permutations? Also, c

[clang] ddec896 - [clang][Interp][NFC] Use right visit() function

Author: Timm Bäder Date: 2022-10-28T17:44:53+02:00 New Revision: ddec89670dd873a293c958a8fc7f778e3cc4297b URL: https://github.com/llvm/llvm-project/commit/ddec89670dd873a293c958a8fc7f778e3cc4297b DIFF: https://github.com/llvm/llvm-project/commit/ddec89670dd873a293c958a8fc7f778e3cc4297b.diff LO

[PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

arsenm created this revision. arsenm added reviewers: nickdesaulniers, yaxunl, aaron.ballman, qcolombet, aeubanks, olista01, dnovillo, echristo, MaskRay. Herald added subscribers: kosarev, StephenFan, tpr. Herald added a project: All. arsenm requested review of this revision. Herald added a subscr

[clang] f79f64b - [clang][Interp] Implement inc and dec operators

Author: Timm Bäder Date: 2022-10-28T17:47:32+02:00 New Revision: f79f64b8d0829c404609d98f069580fa8cfb4d82 URL: https://github.com/llvm/llvm-project/commit/f79f64b8d0829c404609d98f069580fa8cfb4d82 DIFF: https://github.com/llvm/llvm-project/commit/f79f64b8d0829c404609d98f069580fa8cfb4d82.diff LO

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf79f64b8d082: [clang][Interp] Implement inc and dec operators (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D136423?vs=

[clang] 5a72df2 - [clang][Interp] Add missing expected test output

Author: Timm Bäder Date: 2022-10-28T18:07:10+02:00 New Revision: 5a72df21cbbe2092e5f58e94d733f95df87daf09 URL: https://github.com/llvm/llvm-project/commit/5a72df21cbbe2092e5f58e94d733f95df87daf09 DIFF: https://github.com/llvm/llvm-project/commit/5a72df21cbbe2092e5f58e94d733f95df87daf09.diff LO

  1   2   3   >