[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

2022-10-24 Thread Jakub Chlanda via Phabricator via cfe-commits
jchlanda accepted this revision. jchlanda added a comment. This revision is now accepted and ready to land. Looks good. Comment at: llvm/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:838 } } +static int getLdStRegType(EVT VT) { New line here. Co

[PATCH] D136664: [CMake] Support building crt with the bootstrapping build

2022-10-24 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: smeenai, beanz. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. On platforms like Linux, we nee

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

2022-10-24 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see Flang has copied the same logic too, so might be worthwhile to remove it there as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ h

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

2022-10-24 Thread Tobias Hieta via Phabricator via cfe-commits
thieta updated this revision to Diff 470380. thieta added a comment. git clang-format removed accidental include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ https://reviews.llvm.org/D136336 Files: clang/lib/Format/TokenAnnotator.cp

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

2022-10-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D136660#3881602 , @mgorny wrote: > I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see > Flang has copied the same logic too, so might be worthwhile to remove it > there as well. `set(BACKEND_PACKAGE_S

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-10-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoP.td:599 + Sched<[]>; +def UKSTSA32 : RVPBinary<0b1110001, 0b011, "ukstsa32">, + Sched<[]>; `0b011` should be `0b010`. https://github.com/riscv/riscv-p-s

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

2022-10-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 470383. MaskRay edited the summary of this revision. MaskRay added a comment. Remove cmake variable BACKEND_PACKAGE_STRING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

2022-10-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Since the patch subject is called `[clang] ` I am deferring the flang cmake change to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136660 __

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

2022-10-24 Thread Tobias Hieta via Phabricator via cfe-commits
thieta abandoned this revision. thieta added a comment. In D136337#3881476 , @owenpan wrote: > Can you create an issue on GitHub and include the details on how to reproduce > the problem using the latest clang-format? Ah I re-tested this with main and i

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

2022-10-24 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ https://reviews.llvm.org/D136336 _

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

2022-10-24 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D136660#3881617 , @MaskRay wrote: > In D136660#3881602 , @mgorny wrote: > >> I suppose you want to remove it from `clang/CMakeLists.txt` as well. I see >> Flang has copied the same logi

<    1   2   3