[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e8af2fc0c06: [ARM] Support -mexecute-only with -mlong-calls. (authored by ZhiyaoMa98, committed by efriedma). Changed prior to commit: https://reviews.llvm.org/D136203?vs=469049&id=470236#toc Reposito

[clang] b876f6e - Reapply "GH58368: Correct concept checking in a lambda defined in concept""

Author: Erich Keane Date: 2022-10-24T11:46:54-07:00 New Revision: b876f6e2f28779211a829d7d4e841fe68885ae20 URL: https://github.com/llvm/llvm-project/commit/b876f6e2f28779211a829d7d4e841fe68885ae20 DIFF: https://github.com/llvm/llvm-project/commit/b876f6e2f28779211a829d7d4e841fe68885ae20.diff L

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

erichkeane added a comment. Reapplied after revert: https://reviews.llvm.org/rGb876f6e2f28779211a829d7d4e841fe68885ae20 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/new/ https://reviews.llvm.org/D136451 ___

[PATCH] D136120: [Clang] follow-up D128745, remove ClangABICompat checks

ychen added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136120/new/ https://reviews.llvm.org/D136120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping (hoping to ensure enough progress is made on this that we can get it in before the LLVM 16 branch - since it's complicated the last couple of releases already due to not having all the fallout of the ABI fixes in together) Repository: rG LLVM Github Monorepo C

[PATCH] D136633: [clang][AST] avoid unnecessary FunctionProtoTypes.FindNodeOrInsertPos call

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getFunctionTypeInternal forms a FoldingSetNodeID and then calls FunctionProtoTypes.FindNodeOrIns

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1217 + assert(PPBranchLevel >= -1); + if (PPBranchLevel <= -1) +conditionalCompilationStart(/*Unreachable=*/true); You assert >= -1, that means this has to be ==

[clang] 0487728 - [PGO] Make emitted symbols hidden

Author: Alex Brachet Date: 2022-10-24T19:05:10Z New Revision: 04877284b4592e9286cab43467662c1b4ff81861 URL: https://github.com/llvm/llvm-project/commit/04877284b4592e9286cab43467662c1b4ff81861 DIFF: https://github.com/llvm/llvm-project/commit/04877284b4592e9286cab43467662c1b4ff81861.diff LOG:

[clang] 6eaad74 - Correct a typo in the release notes; NFC

Author: Aaron Ballman Date: 2022-10-24T15:11:03-04:00 New Revision: 6eaad74147b20a8602da63d3d07a58d722507472 URL: https://github.com/llvm/llvm-project/commit/6eaad74147b20a8602da63d3d07a58d722507472 DIFF: https://github.com/llvm/llvm-project/commit/6eaad74147b20a8602da63d3d07a58d722507472.diff

[clang] f43ef6b - Update the status of more C99 DRs

Author: Aaron Ballman Date: 2022-10-24T15:11:04-04:00 New Revision: f43ef6b2dced4c5fa4fa7676142d9a20f7dbe733 URL: https://github.com/llvm/llvm-project/commit/f43ef6b2dced4c5fa4fa7676142d9a20f7dbe733 DIFF: https://github.com/llvm/llvm-project/commit/f43ef6b2dced4c5fa4fa7676142d9a20f7dbe733.diff

[clang] 5635f00 - Fix failing test case

Author: Aaron Ballman Date: 2022-10-24T15:19:41-04:00 New Revision: 5635f005f91c3a4a07361f6d70d16fc13768279e URL: https://github.com/llvm/llvm-project/commit/5635f005f91c3a4a07361f6d70d16fc13768279e DIFF: https://github.com/llvm/llvm-project/commit/5635f005f91c3a4a07361f6d70d16fc13768279e.diff

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

nickdesaulniers added a comment. Updating the description to note support for `-g` in gas looks like 2.16 (not 2.15) based on: $ git describe --contains 329e276daf98 --match 'bin*' binutils-2_16-branchpoint~2248 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. Thanks. Since this is not urgent, I'll let it wait for others to chime in a while more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ cfe-commits mailing list cfe-commi

[clang] cecc9a9 - Revert "Reapply "GH58368: Correct concept checking in a lambda defined in concept"""

Author: Erich Keane Date: 2022-10-24T12:20:23-07:00 New Revision: cecc9a92cfca71c1b6c2a35c5e302ab649496d11 URL: https://github.com/llvm/llvm-project/commit/cecc9a92cfca71c1b6c2a35c5e302ab649496d11 DIFF: https://github.com/llvm/llvm-project/commit/cecc9a92cfca71c1b6c2a35c5e302ab649496d11.diff L

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:592 + llvm::ArrayRef arguments() const { return Arguments; } + llvm::MutableArrayRef arguments() { return Arguments; } erichkeane wrote: > Ooh, really? Are the use cases ones

[PATCH] D136602: NFC: [clang] Template argument cleanups.

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM once that one overload is removed (the non const one). I'd rather we justify at that point WHY we need that overload in a separate review. Comment at: clang/in

[PATCH] D135866: [clang-format][NFC] Fix comment grammer in ContinuationIndenter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11b8795bb94c: [clang-format][NFC] Fix comment grammer in ContinuationIndenter (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorep

[clang] 11b8795 - [clang-format][NFC] Fix comment grammer in ContinuationIndenter

Author: Björn Schäpers Date: 2022-10-24T21:28:12+02:00 New Revision: 11b8795bb94c3606d8eed6f45bc3e4fbb0683c14 URL: https://github.com/llvm/llvm-project/commit/11b8795bb94c3606d8eed6f45bc3e4fbb0683c14 DIFF: https://github.com/llvm/llvm-project/commit/11b8795bb94c3606d8eed6f45bc3e4fbb0683c14.diff

[clang] c5755f4 - [clang-format] Handle unions like structs and classes

Author: Björn Schäpers Date: 2022-10-24T21:28:12+02:00 New Revision: c5755f44f0cfcd90aa130497eb114f94182ebc69 URL: https://github.com/llvm/llvm-project/commit/c5755f44f0cfcd90aa130497eb114f94182ebc69 DIFF: https://github.com/llvm/llvm-project/commit/c5755f44f0cfcd90aa130497eb114f94182ebc69.diff

[PATCH] D135872: [clang-format] Handle unions like structs and classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5755f44f0cf: [clang-format] Handle unions like structs and classes (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[clang] 006bf8d - [clang-format][NFC] Handle language specific stuff at the top...

Author: Björn Schäpers Date: 2022-10-24T21:28:13+02:00 New Revision: 006bf8d817704eb8addd95d894152a6199dc0718 URL: https://github.com/llvm/llvm-project/commit/006bf8d817704eb8addd95d894152a6199dc0718 DIFF: https://github.com/llvm/llvm-project/commit/006bf8d817704eb8addd95d894152a6199dc0718.diff

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked 2 inline comments as done. Closed by commit rG006bf8d81770: [clang-format][NFC] Handle language specific stuff at the top... (authored by Haza

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. In D134453#3877127 , @mizvekov wrote: > I think the type printer's purpose is for printing types for diagnostics, not > for generating a lossless representation of types as strings, as the ast > dumper does. > So packing so muc

[clang] e3bb359 - [clang][Toolchains][Gnu] pass -g through to assembler

Author: Nick Desaulniers Date: 2022-10-24T12:30:44-07:00 New Revision: e3bb359aacddb5e0266e219f33d27b642089fd53 URL: https://github.com/llvm/llvm-project/commit/e3bb359aacddb5e0266e219f33d27b642089fd53 DIFF: https://github.com/llvm/llvm-project/commit/e3bb359aacddb5e0266e219f33d27b642089fd53.di

[PATCH] D136309: [clang][Toolchains][Gnu] pass -g through to assembler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3bb359aacdd: [clang][Toolchains][Gnu] pass -g through to assembler (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 975740b - "Reapply "GH58368: Correct concept checking in a lambda defined in concept""

Author: Erich Keane Date: 2022-10-24T12:36:54-07:00 New Revision: 975740bf8db92e054b95a7cedd646d7bc3f74fed URL: https://github.com/llvm/llvm-project/commit/975740bf8db92e054b95a7cedd646d7bc3f74fed DIFF: https://github.com/llvm/llvm-project/commit/975740bf8db92e054b95a7cedd646d7bc3f74fed.diff L

[clang] c3ead85 - [RISCV][clang] Support RISC-V vectors in UninitializedValues.

Author: Craig Topper Date: 2022-10-24T12:38:32-07:00 New Revision: c3ead85e2f1c94b9be40d6c24532f2b932c8bfc7 URL: https://github.com/llvm/llvm-project/commit/c3ead85e2f1c94b9be40d6c24532f2b932c8bfc7 DIFF: https://github.com/llvm/llvm-project/commit/c3ead85e2f1c94b9be40d6c24532f2b932c8bfc7.diff

[PATCH] D136511: [RISCV][clang] Support RISC-V vectors in UninitializedValues.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3ead85e2f1c: [RISCV][clang] Support RISC-V vectors in UninitializedValues. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov retitled this revision from "Fix missing diagnostic of declaration use when accessing TypeDecls through typename access" to "[clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access". mizvekov updated this revision to Diff 470264. Repository:

[clang] 3637dc6 - [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

Author: Markus Böck Date: 2022-10-24T21:41:13+02:00 New Revision: 3637dc601c4923721a69426187aa69dd6a71a053 URL: https://github.com/llvm/llvm-project/commit/3637dc601c4923721a69426187aa69dd6a71a053 DIFF: https://github.com/llvm/llvm-project/commit/3637dc601c4923721a69426187aa69dd6a71a053.diff L

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3637dc601c49: [clang][CodeGen] Consistently return nullptr Values for void builtins and… (authored by zero9178). Repository: rG LLVM Github Monore

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470266. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

ychen added inline comments. Comment at: clang/include/clang/Sema/Sema.h:2569 + enum class TypeAccessKind { Explicit, Implicit, Typename }; + QualType getTypeDeclType(DeclContext *LookupCtx, TypeAccessKind AK, mizvekov wrote: > ychen wrote: > > I find it hard

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

erichkeane accepted this revision. erichkeane added a comment. I'm happy, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 ___ cfe-commits mailing list c

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks updated this revision to Diff 470272. HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added a comment. Override in `canBreak()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Form

[clang] 0de10a6 - Fix a failing C DR test case found by post-commit CI

Author: Aaron Ballman Date: 2022-10-24T16:25:10-04:00 New Revision: 0de10a60af24056cd7f2afc55e1508aa2cb13b3b URL: https://github.com/llvm/llvm-project/commit/0de10a60af24056cd7f2afc55e1508aa2cb13b3b DIFF: https://github.com/llvm/llvm-project/commit/0de10a60af24056cd7f2afc55e1508aa2cb13b3b.diff

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3880403 , @dblaikie wrote: > Could you describe this in more detail? I find that to be more verbose than > is necessary/helpful and probably the variable name based option to be more > informative than the type name

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

Bigcheese added a comment. This looks reasonable. Have you measured the performance impact of this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136624/new/ https://reviews.llvm.org/D136624 ___ c

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470278. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

sammccall accepted this revision. sammccall added a comment. Still LG! Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: nridge wro

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

shafik added a comment. I am going to do another pass but this is my initial set of comments. Comment at: clang/include/clang-c/Index.h:1537 + * initializer. + * + */ nit: extra line Comment at: clang/include/clang/AST/ExprCXX.h:4728-47

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Provides an initializer for the TypedefInfo.IsUsing member. Previously this m

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1158 + +if (DiscardResult && !T) { + // If we need to discard the return value but the function returns its Could you alternatively use `Func->hasRVO()`? Repository:

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov updated this revision to Diff 470289. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136602/new/ https://reviews.llvm.org/D136602 Files: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp clang-tools-extra/clang-tidy/

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a comment. I checked through private.h, this header actually does the functionality that contains all kmp and kmpc related data structures and APIs, so should we still have to split a separate header file? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://revi

[PATCH] D136639: [CodeGen][ObjC] Fix a memory leak that occurs when a non-trivial C struct property is set using dot notation

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Make sure the destructor is called if needed. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136639 Fi

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

jcranmer-intel added a comment. In D136568#3878104 , @Izaron wrote: > The online documentation > (https://en.cppreference.com/w/cpp/numeric/math/ilogb) says: > > 1. If the correct result is greater than INT_MAX or smaller than INT_MIN, > FE_INVALID is

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 470294. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. In D134453#3880525 , @mizvekov wrote: > In D134453#3880403 , @dblaikie > wrote: > >> Could you describe this in more detail? I find that to be more verbose than >> is necessary/helpful

[PATCH] D136638: [clang-doc] Fix typedef/using output.

paulkirth added a comment. Can you add a test that checks the `IsUsing == false` case? Otherwise LGTM modulo one small nit. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:396-397 +template <> llvm::Expected getCommentInfo(TypedefInfo *I) { + I->Description.emplace_

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added a comment. In D136103#3880651 , @jz10 wrote: > I checked through private.h, this header actually does the functionality > that contains all kmp and kmpc related data structures and APIs, so should > we still have to split a separate h

[PATCH] D134453: Disambiguate type names when printing NTTP types

mizvekov added a comment. In D134453#3880729 , @dblaikie wrote: > I think we should restrict the discussion in this review to being only about > the case where we have the canonical type (acknowledging that there's broader > work to reduce the number of

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 added a comment. Sure, where should I add those tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added a comment. `openmp/libomptarget/test/api/` is where we usually tests those APIs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] 1acffe8 - NFC: [clang] Template argument cleanups.

Author: Matheus Izvekov Date: 2022-10-25T00:29:56+02:00 New Revision: 1acffe81ee9117691812b9bf8747c03354177d15 URL: https://github.com/llvm/llvm-project/commit/1acffe81ee9117691812b9bf8747c03354177d15 DIFF: https://github.com/llvm/llvm-project/commit/1acffe81ee9117691812b9bf8747c03354177d15.dif

[PATCH] D136602: NFC: [clang] Template argument cleanups.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1acffe81ee91: NFC: [clang] Template argument cleanups. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra added a comment. @jchlanda PTAL. You probably have the most context for NVPTX and bf16 instructions there. We need this change to unbreak CUDA compilation after D132329 exposed __bf16 to GPU-side compilation. https://godbolt.org/z/Kz8PYfPj5 Repository:

[PATCH] D136311: [CUDA,NVPTX] Implement __bf16 support for NVPTX.

tra added a comment. @yaxunl It appears that AMDGPU also does not support `__bf16`, but for some reason it does not error out in clang headers: https://godbolt.org/z/GrTGMn49f Any ideas why that may be the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao marked 11 inline comments as done. ayzhao added a comment. In D129531#3873872 , @royjacobson wrote: > Thanks for working on it! It looks really good. Please remember to update the > feature test macro (__cpp_aggregate_paren_init). Done > Also,

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 470311. ayzhao added a comment. some comment fixes, add a test for serialization which doesn't work yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 470314. ayzhao added a comment. remove whitespace change and disable test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

ellis added inline comments. Comment at: llvm/lib/ProfileData/InstrProfCorrelator.cpp:208 maybeSwap(CounterOffset), + maybeSwap(BitmaskOffset), maybeSwap(FunctionPtr), Since `BitmaskOffset` and `NumBitmaskBytes` are always zero, I would rather

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss created this revision. friss added reviewers: jansvoboda11, bnbarham, arphaman. Herald added a subscriber: hiraditya. Herald added a project: All. friss requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Every Clang i

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

tschuett added inline comments. Comment at: clang/tools/clang-stat-cache/clang-stat-cache.cpp:61 + +namespace { + Sorry, but you misuse anonymous namespaces. You want static instead. https://llvm.org/docs/CodingStandards.html#anonymous-namespaces Repository:

[clang] dc17043 - [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

Author: Matheus Izvekov Date: 2022-10-25T02:46:35+02:00 New Revision: dc170433137aeda5e5276bd292cac12aa93fee7c URL: https://github.com/llvm/llvm-project/commit/dc170433137aeda5e5276bd292cac12aa93fee7c DIFF: https://github.com/llvm/llvm-project/commit/dc170433137aeda5e5276bd292cac12aa93fee7c.dif

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc170433137a: [clang] Fix missing diagnostic of declaration use wh

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 470339. jz10 added a comment. Thanks Johannes and Shilei I added few test cases for asynchronous routine at test/api folder CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/libomptarget/includ

[PATCH] D136532: [clang][Interp] Implement left and right shifts

shafik added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:57 +//c >>= 99; // expected-warning {{shift count >= width of type}} +//c <<= CHAR_BIT; // expected-warning {{shift count >= width of type}} +//c >>= CHAR_BIT; // expected-warning {{shift c

[PATCH] D136532: [clang][Interp] Implement left and right shifts

shafik added inline comments. Comment at: clang/test/AST/Interp/shifts.cpp:70 +i = 1 << (WORD_BIT - 1); // cxx17-warning-not {{sets the sign bit of the shift expression}} +i = -1 << (WORD_BIT - 1); // cxx17-warning {{shifting a negative signed value is undefined}} \ +

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov updated this revision to Diff 470346. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/TemplateDeduction.h clang/lib/Sema/SemaLo

[PATCH] D136563: [clang] Perform sugared substitution of builtin templates

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 470347. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136563/new/ https://reviews.llvm.org/D136563 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaTemplat

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

mizvekov updated this revision to Diff 470348. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134604/new/ https://reviews.llvm.org/D134604 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/PropertiesBase.td clang/include/clang

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

bnbarham added a comment. Mostly just skimmed so far, will hopefully have some time to look at this more tomorrow. Out of interest, do you have any performance numbers using this change? I assume this mainly impacts implicit modules (since I suspect we'd also be opening the file as well anyway)

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/test/api/omp_target_memcpy_async1.c:1 +// Test case for omp_target_memcpy_async, oringally from GCC + There is no `RUN` line here so the test will not be triggered. Can you refer to other tes

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 470354. jz10 added a comment. Thanks Shilei Add RUN line for each test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136103/new/ https://reviews.llvm.org/D136103 Files: openmp/libomptarget/include/interop.h openmp/libomptarget/src/api.cpp

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/test/api/omp_target_memcpy_async1.c:2 +// RUN: %libomptarget-compile-run-and-check-nvptx64-nvidia-cuda +// REQUIRES: nvptx64-nvidia-cuda + Does it work on AMDGPU and other targets? Why does it

[PATCH] D136103: OpenMP asynchronous memory copy support

jz10 updated this revision to Diff 470357. jz10 added a comment. Thanks Shilei 1. "Does it work on AMDGPU and other targets? Why does it require Nvidia here?" No, I just remove this line 2. "We don't have any performance test cases yet, and I'm not sure we need them right now." Yes, I remove

[clang] 37e754e - [clang-format] Insert closing braces after an unaffected line

Author: owenca Date: 2022-10-24T20:00:06-07:00 New Revision: 37e754e5801c5de2e84ca2d7d40a48c780787f01 URL: https://github.com/llvm/llvm-project/commit/37e754e5801c5de2e84ca2d7d40a48c780787f01 DIFF: https://github.com/llvm/llvm-project/commit/37e754e5801c5de2e84ca2d7d40a48c780787f01.diff LOG: [

[PATCH] D136437: [clang-format] Insert closing braces after an unaffected line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37e754e5801c: [clang-format] Insert closing braces after an unaffected line (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. Thanks for the initial feedback! > Mostly just skimmed so far, will hopefully have some time to look at this > more tomorrow. Out of interest, do you have any performance numbers using > this change? I assume this mainly impacts implicit modules (since I suspect > we'd a

[PATCH] D136012: [clang][Interp] Fix record members of reference type

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:867 - if (Optional T = classify(Init->getType())) { + if (Optional T = classify(Init)) { if (!this->visit(Init)) sha

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also add line ra

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

MaskRay added a comment. In D136436#3876684 , @SixWeining wrote: > In D136436#3873987 , @xen0n wrote: > >> In D136436#3873949 , @SixWeining >> wrote: >> >>> How about th

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:336 + Previous.MatchingParen && Previous.MatchingParen->Previous && + Previous.MatchingParen->Previous->is(tok::r_brace) && + Previous.MatchingParen

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:94 + << Val << A->getOption().getName() << "fast"; + FPContract = "fast"; +} else I know I suggested myself mapping `on` to `fast`, but it seems it will be more r

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

bnbarham added a comment. > You're correct that this overhead has been measured on implicit module > builds. As I mentioned in the commit message this saves over 20% of the > overall built time in some cases. This time is split between module > validation (which could be skipped) and HeaderSear

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

owenpan accepted this revision. owenpan added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1077-1079 + EXPECT_TOKEN(Tokens[6], tok::identifier, TT_Unknown); + EXPECT_TOKEN(Tokens[7], tok::l_brace, TT

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

MaskRay created this revision. MaskRay added reviewers: mgorny, thieta, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. 420d7ccbac0f499a

[PATCH] D111778: [WIP][X86] Update CPU_SPECIFIC list.

LuoYuanke added a comment. It seems @craig.topper supported __cpu_features2 in compiler-rt revision 94ccb2acbf2c5 . Anything else that we need to address before landing the patch? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. This seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136660 _

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1217 + assert(PPBranchLevel >= -1); + if (PPBranchLevel <= -1) +conditionalCompilationStart(/*Unreachable=*/true); HazardyKnusperkeks wrote: > You assert >= -1, that means t

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

owenpan added a comment. Can you run git-clang-format? Comment at: clang/lib/Format/TokenAnnotator.cpp:1340 Keywords.kw_region)) { - bool IsMark = CurrentToken->is(Keywords.kw_mark); + bool IsMarkOrRegion = CurrentToken->isOneOf(Keywords

[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:259 + + if (Op != BO_Add && Op != BO_Sub) +return false; or neither left or right operand is a pointer type Comment at: clang/lib/AST/Interp/ByteCodeExprGen

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

owenpan added a comment. Can you create an issue on GitHub and include the details on how to reproduce the problem using the latest clang-format? Comment at: clang/unittests/Format/FormatTest.cpp:19975-19978 + verifyFormat("CxxClass::CxxClass() {\n#pragma region test(hello)\n

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. This breaks compiling many things on macOS, including compiler-rt: /tmp/llvm2/obj/bin/clang++ --target=aarch64-apple-darwin -I/tmp/llvm2/compiler-rt/lib/fuzzer/../../include -Wall -Wno-unused-parameter -O3 -DNDEBUG -arch arm64 -isysroot /tmp/MacOSX11.3.sdk -stdlib=l

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen updated this revision to Diff 470374. ychen marked an inline comment as done. ychen added a comment. - do the same when 1. taking the address of a non-template function 2. computing SMF eligibility. - restore removed test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

ychen added a comment. In D136545#3877899 , @royjacobson wrote: > LGTM, thanks for picking it up! I wonder how much effect this has on > compilation times given that `SubsumptionCache` caches subsumption by the > `Decl *` pair... It seems neutral htt

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan accepted this revision. skan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135933/new/ https://reviews.llvm.org/D135933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136545: [Clang] use non-instantiated function declaration for constraints partial ordering

ychen added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p2.cpp:10 }; - bool k1 = A() < A(); // not ordered by constraints: prefer non-rewritten form - bool k2 = A() < A(); // prefer more-constrained 'operator<=>' erichkeane w

<    1   2   3   >