[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468728. void added a comment. Update the error message to remove the reference to bytes, which can be confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files:

[PATCH] D133668: [HLSL] Disable int16_t to avoid promote to int for HLSL.

python3kgae updated this revision to Diff 468731. python3kgae marked an inline comment as done. python3kgae added a comment. Update comment and fix tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 F

[clang] 14ae5d2 - [HLSL] Add SV_DispatchThreadID

Author: Xiang Li Date: 2022-10-18T16:17:19-07:00 New Revision: 14ae5d2b745f76018a963b395fc9d7ad987f1c5c URL: https://github.com/llvm/llvm-project/commit/14ae5d2b745f76018a963b395fc9d7ad987f1c5c DIFF: https://github.com/llvm/llvm-project/commit/14ae5d2b745f76018a963b395fc9d7ad987f1c5c.diff LOG:

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

This revision was automatically updated to reflect the committed changes. Closed by commit rG14ae5d2b745f: [HLSL] Add SV_DispatchThreadID (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

sammccall created this revision. sammccall added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Thi

[PATCH] D135657: add time traces for AST serialization

jansvoboda11 added a comment. In D135657#3865581 , @Trass3r wrote: > Thanks, could you also commit it? I don't have the rights. Sure. What name and email do you want me to associate with the commit? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

sammccall updated this revision to Diff 468741. sammccall added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136212/new/ https://reviews.llvm.org/D136212 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. > Can you describe a little more what you're trying to do here? Sure. My eventual goal is to enable fine-granular live-update on ARM based microcontrollers, which requires the system to do some relocation at runtime. Below I will describe the challenge with a simple

[clang] d239f3c - [clang][deps] Remove unintentional `move`

Author: Jan Svoboda Date: 2022-10-18T16:40:31-07:00 New Revision: d239f3c627a396a80181806960957d5d0eba7e91 URL: https://github.com/llvm/llvm-project/commit/d239f3c627a396a80181806960957d5d0eba7e91 DIFF: https://github.com/llvm/llvm-project/commit/d239f3c627a396a80181806960957d5d0eba7e91.diff L

[PATCH] D136124: [clang][deps] Remove unintentional `move`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd239f3c627a3: [clang][deps] Remove unintentional `move` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

rupprecht added a comment. In D129755#3866213 , @aaronpuchert wrote: > Are you seeing warnings because of the different treatment of copy-elided > construction, or because we've started to consider `CXXConstructorCall`s > outside of the initializer of

[clang] 13d6a57 - [Clang] constraints partial ordering should work with deduction guide

Author: Yuanfang Chen Date: 2022-10-18T17:30:47-07:00 New Revision: 13d6a57cbe2776c4873302c0cf04e27b77bd2862 URL: https://github.com/llvm/llvm-project/commit/13d6a57cbe2776c4873302c0cf04e27b77bd2862 DIFF: https://github.com/llvm/llvm-project/commit/13d6a57cbe2776c4873302c0cf04e27b77bd2862.diff

[PATCH] D134597: [CMake] install clang and other resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice added a comment. Ping @phosek, but may need suggestions from other reviewers... Thanks in advance if someone can commit this change. Comment at: openmp/CMakeLists.txt:80 if(${OPENMP_STANDALONE_BUILD}) set(LIBOMP_HEADERS_INSTALL_PATH "${CMAKE_INSTALL_INCLUDEDIR}

[PATCH] D135128: [clang][cli] Simplify repetitive macro invocations

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. Looks good with the suggestion to split the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135128/new/ https://reviews.llvm.org/D13

[PATCH] D136080: [flang] Add -ffp-contract option processing

DavidTruby added a comment. Glad to see this flag being added to `flang-new`! As a note to self I've written some tests that should be updated once this lands that currently don't pass through the `flang-new` driver. Comment at: flang/test/Driver/driver-help.f90:108 ! HELP-F

[PATCH] D136019: [clang][lex] Avoid `DirectoryLookup` copies

jansvoboda11 added a comment. In D136019#3860557 , @ributzka wrote: > We could invoke clang with the `-stats` option and compare the result against > the expected number of stat calls. The `-stats-file=` option only tells you how many times Clang reques

[PATCH] D136187: [clang][AIX] Omitting Explicit Debugger Tuning Option

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:91 llvm::DebuggerKind getDefaultDebuggerTuning() const override { -return llvm::DebuggerKind::DBX; +return llvm::DebuggerKind::Default; } This sounds not right. Omitting `-

[PATCH] D136216: [clangd] go-to-def on new/delete targets the constructor

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Related to

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. The construct you want is pretty similar to a GOT. if you compile with -fPIE -fsemantic-interposition, you get basically the code you want, except that the compiler uses a plt by default instead of a got. If we supported -fno-plt for ARM, it would be almost exactly wh

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

MaskRay added a comment. Nice. This also fixes DW_AT_call_all_calls for functions which call builtins/reserved name functions. Comment at: llvm/test/Verifier/callsite-dbgloc.ll:49 +; CHECK-NOT: inlinable function call in a function with debug info must have a !dbg location +;

[PATCH] D136103: OpenMP asynchronous memory copy support

tianshilei1992 requested changes to this revision. tianshilei1992 added inline comments. This revision now requires changes to proceed. Comment at: openmp/libomptarget/src/api.cpp:208 + + TargetMemcpyArgsTy *Args = (TargetMemcpyArgsTy *)Task->shareds; + I didn't

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

ZhiyaoMa98 added a comment. Unfortunately, `-fPIE` seems not to be generating the PLT on LLVM for embedded ARM. C source file (test.c): extern void bar(void); void foo(void) { bar(); } LLVM with `clang -O2 -fPIE -fsemantic-interposition -mlong-calls --target=armv7em-none-eabi -c t

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

MaskRay added inline comments. Comment at: llvm/lib/IR/Verifier.cpp:3473 !Call.getCalledFunction()->isInterposable() && + !Call.getCalledFunction()->isDeclaration() && Call.getCalledFunction()->getSubprogram()) Removing this check does not brea

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth updated this revision to Diff 468770. paulkirth added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: abrachet, sstefan1, pengfei, ormris. Refactor printing into a dedicated pass - add some basic lit tests - change the printing format to be more machine readable

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth planned changes to this revision. paulkirth added a comment. I plan to add/update the tests, and give the new pass a few cleanups. The test code can probably be much smaller & have its debug info reduced significantly. There is also a lack of documentation. Repository: rG LLVM Gith

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added a comment. In D135938#3864521 , @RKSimon wrote: > Can you fix the MC + disasm test file names - drop att/intel and ensure you > test both syntaxes for 32 and 64 bits. > > Ideally the 32/64 bit nam

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > Are there tests for commuting? Hi Craig, Can you show an exampl

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth added a subscriber: rnk. paulkirth added a comment. @rnk This is the prototype I mentioned the other night at the meetup. I'm pretty sure something like the `LiveDebugValues` pass has a mapping of all the debug information to locations that I'd ever need, but I'm not sure how to poke

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + FreddyYe wrote: > craig.topper wrote: > > Are there tests for commuting? > Hi Cra

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

craig.topper added a comment. Can the intrinsics changes be split from this patch so they don't depend on D136145 . There's no reason to block assembler/disassembler support for that. Comment at: clang/lib/Headers/prfchiintrin.h:16 +/// Loads

[PATCH] D136203: [ARM] Support -mexecute-only with -mlong-calls.

efriedma added a comment. One, -mlong-calls isn't currently compatible with PIE. Two, on ARM, there are no special plt relocations; the linker just takes care of it. (You can see the differences if you try to take the address of a function without calling it.) Repository: rG LLVM Github Mo

[PATCH] D136224: [clang-tidy] Skip private default ctors in modernize-use-equals-default

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: gribozavr2, alexfh, rsmith. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-shaposhnikov requested

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7574 - if (NumArgs > 3) + if (NumArgs > 4) return Diag(TheCall->getEndLoc(), Not clear to me that we should be changing the definition of `__builtin_prefetch`. It wouldn't

[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7574 - if (NumArgs > 3) + if (NumArgs > 4) return Diag(TheCall->getEndLoc(), craig.topper wrote: > Not clear to me that we should be changing the definition of > `__builtin_

[PATCH] D136040: [X86][1/2] Support PREFETCHI instructions

craig.topper added inline comments. Comment at: clang/lib/Headers/prfchiintrin.h:16 +/// Loads an instruction sequence containing the specified memory address into +///all level cache. +/// craig.topper wrote: > It looks old that this indented differently tha

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/test/CodeGen/X86/avxvnniint8-intrinsics.ll:6 + +declare <4 x i32> @llvm.x86.avx2.vpdpbssd.128(<4 x i32>, <4 x i32>, <4 x i32>) + craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote: > > > Are there tests f

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

serge-sans-paille accepted this revision. serge-sans-paille added a comment. I really like the new message, thanks for taking account the diverging reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920

[PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 468784. tstellar marked 4 inline comments as done. tstellar added a comment. Herald added a subscriber: zero9178. Rebase and fix some missed path updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/ne

[PATCH] D136212: [clangd] consider ~^foo() to target the destructor, not the type

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks for fixing! Comment at: clang-tools-extra/clangd/Selection.cpp:881 + return CDD->getNameInfo().getNamedTypeInfo()->getTypeLoc().getBeginLoc(); +if (const Stmt

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Can we log a GitHub issue I can’t see what you are trying to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 ___ cfe-commits

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay added a comment. Is it seeing the ‘ :’ as a binary operator? And not an inheritance colon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136154/new/ https://reviews.llvm.org/D136154 ___ cf

[PATCH] D136154: [clang-format] Fix the continuation indenter

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Needs a better title to the review please to explain what it’s doing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1361

[PATCH] D136229: [include-cleaner] Fix link errors when -DBUILD_SHARED_LIBS=ON

lkail created this revision. lkail added reviewers: hokein, sammccall, PowerPC. Herald added a project: All. lkail requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixed ppc buildbot https://lab.llvm.org/buildbot/#/builders/121/b

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135429/new/ https://reviews.llvm.org/D135429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. How should I proceed with a stale rejecting review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 ___ cfe-commits mailing list cfe-com

[PATCH] D136017: [clang][Interp] Materializing primitive temporaries

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:513 + + if (!this->emitSetLocal(PT_Sint32, *LocalIndex, E)) +return false; shafik wrote: > Should this use `*SubExprT` instead? Ah, yes. Thanks! Co

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:144 + +if (!this->emitCast(*FromT, PT_Float, CE)) + return false; sepavloff wrote: > Does this two-stage conversion make sense? In contrast to things like > `PT_Sint8` `

[PATCH] D136013: [clang][Interp] Fix ignoring expression return values

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:208 + +struct S { + int a = 0; aaron.ballman wrote: > Hmmm, this feels related to the discarded value results changes, but it might > be a test case for a different scenario as well, s

[PATCH] D132329: [X86][RFC] Using `__bf16` for AVX512_BF16 intrinsics

LuoYuanke added inline comments. Comment at: clang/lib/Headers/avx512bf16intrin.h:13 +#ifdef __SSE2__ + What is this macro check used for? Comment at: clang/test/CodeGen/X86/avx512bf16-error.c:14 +__bfloat16 bar(__bfloat16 a, __bfloat16 b) {

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. In D129443#3867364 , @rymiel wrote: > How should I proceed with a stale rejecting review? You can commit as https://reviews.llvm.org/D129443#3641571 has been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. In D135920#3863648 , @shafik wrote: > The current approach of mixing bytes and indices in the same diagnostic is > too confusing. "Current" approach? > I think we see some acceptable messages for out of bounds access by looking >

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3864248 , @iains wrote: > I am also OK with doing this in two steps (first in the driver with this > patch and then by updating the FE to allow the two outputs from one > invocation - my draft patch series). For yo

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. I haven't looked into the details. But I feel the feature worth a sentence in ReleaseNotes. (Maybe in the potential-breaking-change section). Also I think it'll be better to have an option `-fenable-discarding-unreachable-decls-in-gmf` to control the behavior. It'll

[clang] ccd314d - [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

Author: Dominik Adamski Date: 2022-10-18T02:04:18-05:00 New Revision: ccd314d3209a192fc17ad621cf7fe3f09f7c7b9f URL: https://github.com/llvm/llvm-project/commit/ccd314d3209a192fc17ad621cf7fe3f09f7c7b9f DIFF: https://github.com/llvm/llvm-project/commit/ccd314d3209a192fc17ad621cf7fe3f09f7c7b9f.dif

[PATCH] D133578: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder

This revision was automatically updated to reflect the committed changes. domada marked an inline comment as done. Closed by commit rGccd314d3209a: [OpenMP][OMPIRBuilder] Add generation of SIMD align assumptions to OMPIRBuilder (authored by domada). Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3