[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe marked 3 inline comments as done. FreddyYe added a comment. THX for review! Gcc is also recently reviewing related patches. So to align with the compiler-rt and libgcc, let's wait for their land first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 2662009 - [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-10-17T18:48:24-07:00 New Revision: 2662009c87f470ec5bc13c237cd62c57b28e4032 URL: https://github.com/llvm/llvm-project/commit/2662009c87f470ec5bc13c237cd62c57b28e4032 DIFF: https://github.com/llvm/llvm-project/commit/2662009c87f470ec5bc13c237cd62c57b28e4032.di

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2662009c87f4: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches. (authored by vsapsai). Changed prior to commit: https://reviews.

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 ___ cfe-commits mailing list c

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao added inline comments. Comment at: clang/test/SemaCXX/references.cpp:93 -struct C : B, A { }; // expected-warning {{direct base 'A' is inaccessible due to ambiguity:\nstruct C -> struct B -> struct A\nstruct C -> struct A}} +struct C : B, A { }; // expected-warnin

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:588 +else if (A->getOption().matches(options::OPT_ggdb) || + Args.getLastArg(options::O

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added subscribers: ruoso, ben.boeckel. ChuanqiXu added a comment. >> Although modular code is user-facing - BMIs are an implementational detail, >> right? > > but I don't think BMIs are an implementation detail, anymore than object > files are - users should/will be as aware of BMIs as

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__CMPCCXADD__"); + Builder.defineMacro("__CMPCCXADD_SUPPORTED__"); if (HasAVXVNNI) What is __CMPCCXADD_SUPPORTED__ for? Comment at

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86_64.def:138 +TARGET_BUILTIN(__builtin_ia32_cmpccxadd64, "SLLiv*SLLiSLLiIi", "n", "cmpccxadd") #undef BUILTIN #undef TARGET_BUILTIN There was a blank line here. Put it back.

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt:1 +# RUN: llvm-mc --disassemble %s -triple=i686 | FileCheck %s + RKSimon wrote: > I think we'd be better off merging the att

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8118 +let Predicates = [HasCMPCCXADD, In64BitMode], Constraints = "$dstsrc2 = $dst" in +multiclass CMPCCXADD_BASE Opc, string OpcodeStr> { craig.topper wrote: > This feels like

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe updated this revision to Diff 468398. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D136124: [clang][deps] Remove unintentional `move`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: DavidSpickett. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a fix related to D13541

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8141 + i128mem, X86vpdpbssd, SchedWriteVecIMul.XMM, + 1>, T8XD; + defm VPDPBSSDY : avx_dotprod_rm<0x50,"vpdpbssd", v8i32, VR2

[clang] db82096 - [NFC] [C++20] [Modules] Test if the functions in importee are generated

Author: Chuanqi Xu Date: 2022-10-18T11:40:49+08:00 New Revision: db82096ff0aaadd4ce9b76ea3ffb188c9e5a0a64 URL: https://github.com/llvm/llvm-project/commit/db82096ff0aaadd4ce9b76ea3ffb188c9e5a0a64 DIFF: https://github.com/llvm/llvm-project/commit/db82096ff0aaadd4ce9b76ea3ffb188c9e5a0a64.diff LO

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-redefinition.m:37 +// RUN: %clang @%t/third.cc1.rsp +// RUN: %clang @%t/first.cc1.rsp Before this patch, this would fail with duplicate definition of module 'X'. It would be reached

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire updated this revision to Diff 468409. junaire added a comment. Add the original mailformed test case, thanks Shafik! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136018/new/ https://reviews.llvm.org/D136018 Files: clang/lib/Sema/SemaChe

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire marked 5 inline comments as done. junaire added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:17398-17399 + const bool IsDiscardMisalignedPointer = + T->isPointerType() && + (T->getPointeeType()->isIncompleteType() || T->isDependentTy

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:413 + EXPECT_TOKEN(Tokens[3], tok::string_literal, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[5], tok::l_paren, TT_Over

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 468414. rymiel added a comment. Swap the default for LLVM style, and adjust tests which depended on the previous style to still use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.

[clang] 8e7d5d5 - [NFC] Add missing ABI requirement from the previous patch

Author: Chuanqi Xu Date: 2022-10-18T13:16:04+08:00 New Revision: 8e7d5d5863105aa2c0610bc5d00e5cfad683c7fd URL: https://github.com/llvm/llvm-project/commit/8e7d5d5863105aa2c0610bc5d00e5cfad683c7fd DIFF: https://github.com/llvm/llvm-project/commit/8e7d5d5863105aa2c0610bc5d00e5cfad683c7fd.diff LO

[clang] 94215d2 - [clang-format] Correctly annotate star/amp in function pointer params

Author: Emilia Dreamer Date: 2022-10-18T08:17:23+03:00 New Revision: 94215d2b2103c5ad74596dd51704836f92afec89 URL: https://github.com/llvm/llvm-project/commit/94215d2b2103c5ad74596dd51704836f92afec89 DIFF: https://github.com/llvm/llvm-project/commit/94215d2b2103c5ad74596dd51704836f92afec89.diff

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94215d2b2103: [clang-format] Correctly annotate star/amp in function pointer params (authored by rymiel). Repository: rG LLVM Github Monorepo CHA

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

MaskRay added a comment. I am not familiar with `ExpansionContext`. Is there any behavior difference which can be demonstrated by a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 _

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

yonghong-song added a comment. In D136041#3863748 , @dblaikie wrote: > Hmm - this does mean linking IR can produce invalid code, though, right (you > link in a definition of the function, so what was valid is now invalid - > because it now has a definit

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet updated this revision to Diff 468425. abrachet added a comment. The error @zequanwu ran into happens only on MacOS because it this Darwin-only test happens to be the only one that tests instrprof with no code. `__llvm_profile_filename` doesn't get emitted in this case so it ends up pul

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added a comment. In D135439#3864165 , @MaskRay wrote: > I am not familiar with `ExpansionContext`. Is there any behavior difference > which can be demonstrated by a test? This is an NFC test, it does not change behavior. However moving these

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for the detailed explanations, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135801/new/ https://reviews.llvm.org/D135801 __

[clang] 4e2a629 - [Clang] add DR tests for D128745

Author: Yuanfang Chen Date: 2022-10-17T23:24:29-07:00 New Revision: 4e2a629c7238008de0ab45e6bb96aeaecac2bca9 URL: https://github.com/llvm/llvm-project/commit/4e2a629c7238008de0ab45e6bb96aeaecac2bca9 DIFF: https://github.com/llvm/llvm-project/commit/4e2a629c7238008de0ab45e6bb96aeaecac2bca9.diff

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen created this revision. ychen added reviewers: royjacobson, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For https://github.com/llvm/llvm-project/issues/58382 Repository: rG LLVM Gi

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Move Re

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen updated this revision to Diff 468430. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 Files: clang/test/CXX/drs/dr25xx.cpp clang/test/CXX/drs/dr2xx.cpp clang/ww

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3863938 , @ChuanqiXu wrote: >>> Although modular code is user-facing - BMIs are an implementational detail, >>> right? >> >> but I don't think BMIs are an implementation detail, anymore than object >> files are - users

[clang] dbfa97b - [doc] Fix invalid reference to `hasReturnArgument` matcher.

Author: Clement Courbet Date: 2022-10-18T08:47:21+02:00 New Revision: dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b URL: https://github.com/llvm/llvm-project/commit/dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b DIFF: https://github.com/llvm/llvm-project/commit/dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b.dif

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. I am also OK with doing this in two steps (first in the driver with this patch and then by updating the FE to allow the two outputs from one invocation - my draft patch series). BTW: I did mean to ask before .,, did you consider this (existing) command syntax? `-fmodule

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. > Yes, all of this stuff is important (and, yes, we are drifting into other > [related] topics) - we already have a mechanism for providing function bodies > to optimisation [LTO] - I do not think we should want to make module > interfaces larger than necessary to dup

<    1   2   3