[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; cor3ntin wrote: > tahonermann wrote: > > cor3ntin wrote: > > > tbaeder wrote: > > > > cor3ntin wrote: > > > > > tahonermann wrote: > > > > > > As others already noted, additiona

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. @tarunprabhu Could you confirm that with the build command above "pass-plugin.f90" is failing for you? It is for me. In order to fix that, you will have to add this

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5511-5539 + template ::value, bool> = true> + bool operator()(T1 *PS1, T2 *PS2) { +return hasEqualTemplateArgumentList( +PS1->getTemplateArgsAsWritten()->arguments(), +PS2->

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:327 +/// if the argument is smaller than a slot, set this flag will force +/// right-adjust the argument in its slot irrespective of the type. static Address emitVoidPtrDirectVAArg(CodeGenFunction &

[PATCH] D133488: [clang][PowerPC][NFC] Add base test case for PPC64 VAArg aggregate smaller than a slot

tingwang updated this revision to Diff 467040. tingwang added a reviewer: rjmccall. tingwang added a comment. Add test case according to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133488/new/ https://reviews.llvm.org/D133488 Files: c

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 467039. lime added a comment. I updated the patch as I said, while kept the key of `NormalizationCache` relatively heavy. That means I: - changed the parameter of `IsAtLeastAsConstrained` to `MutableArrayRef`, - and let the new `CalculateTemplateDepthForConstra

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang updated this revision to Diff 467048. tingwang added a comment. Update according to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18/new/ https://reviews.llvm.org/D18 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test

[clang-tools-extra] 5d12b13 - [clang-tidy] Dump effective diagnostics level in YAML output

Author: Dmitry Polukhin Date: 2022-10-12T02:03:56-07:00 New Revision: 5d12b13b0b26bc58b02ee23c369da8b83240cceb URL: https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb DIFF: https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb.dif

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d12b13b0b26: [clang-tidy] Dump effective diagnostics level in YAML output (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

boris added a comment. Just to add a few points on the module mapper discussion: overall, the current view is that there are two ways to handle C++20 modules from the build system's POV: (1) pre-scan the codebase to figure out what is what and who depends on whom ahead of compilation and (2) mo

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. In D134267#3852047 , @boris wrote: > Just to add a few points on the module mapper discussion: overall, the > current view is that there are two ways to handle C++20 modules from the > build system's POV: (1) pre-scan the code

[PATCH] D134947: [analyzer] Fix the liveness of Symbols for values in regions referred by LazyCompoundVal

steakhal added a comment. What do you think @NoQ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134947/new/ https://reviews.llvm.org/D134947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

boris added a comment. > For example, my experimental support for P1689 > is at: [...]. The implementation looks > relatively trivial to me. The simplicity is pretty important. Two points: 1. It's worth considering the simplicity of the overall system (compiler

[PATCH] D135724: [HIP] Fix unbundling archive

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thank you! It is fixing our OpenMP smoke test failure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135724/new/ https://reviews.llvm.org/D135724

[PATCH] D135763: [analyzer] Workaround crash on encountering Class non-type template parameters

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus, xazax.hun. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D135764: [clang][Interp] Implement for loops

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

aaron.ballman added a comment. In D135551#3850511 , @dblaikie wrote: > In D135551#3850391 , @aaron.ballman > wrote: > >> In D135551#3850308 , @dblaikie >> wrote: >> >>>

[PATCH] D135690: [ASTMatchers] Add matcher for functions that are effectively inline

aaron.ballman added a comment. Thanks for the new matcher, can you also add a release note for the addition? One question I have is: what's the need for adding this matcher? Do you plan to use it for some in-tree needs? We usually only add new matchers where there's an immediate need for them b

[PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a comment. In D134878#3836840 , @aaron.ballman wrote: > Pinging reviewers from projects other than libcxx (I'm hoping to get buy-in > from someone on the LLVM side of things; lldb would be nice as well). I'll be landing this later t

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

aaron.ballman added a comment. In D128745#3851225 , @ychen wrote: > As a next step, I'll remove the ClangABICompat checks for these DRs (make > these DRs effective unconditionally). If we saw proof that these have > deployment difficulties. We can (1) r

[PATCH] D135682: Fix false positive related to handling of [[noreturn]] function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec6da3fb9d8c: Fix false positive related to handling of [[noreturn]] function pointers (authored by arseniy-sonar, committed by steakhal). Changed

[clang] ec6da3f - Fix false positive related to handling of [[noreturn]] function pointers

Author: Arseniy Zaostrovnykh Date: 2022-10-12T14:46:32+02:00 New Revision: ec6da3fb9d8c7859da22d9eb7e814faf2e5a524a URL: https://github.com/llvm/llvm-project/commit/ec6da3fb9d8c7859da22d9eb7e814faf2e5a524a DIFF: https://github.com/llvm/llvm-project/commit/ec6da3fb9d8c7859da22d9eb7e814faf2e5a524

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Reported as it showed up as a constriants failure after the deferred instantiation patch, we were checking constraints TWICE after overload r

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3849583 , @erichkeane wrote: > In D126907#3846591 , @erichkeane > wrote: > >> In D126907#3844788 , @BertalanD >> wrote: >> >>> Hi

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ODRDiagsEmitter.cpp:302 +llvm::raw_string_ostream OutputStream(FullText); +A->printPretty(OutputStream, Ctx.getPrintingPolicy()); +return OutputStream.str(); vsapsai wrote: > aaron.ballman

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 467119. qiongsiwu1 added a comment. Rebase with latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/l

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3851843 , @awarzynski wrote: > @tarunprabhu Could you confirm that with the build command above > "pass-plugin.f90" is failing for you? It is for me. What compiler do you use to build this? gcc doesn't seem to li

[PATCH] D135569: [clang][Interp] Don't run functions immediately after compiling them

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this change makes sense to me. Ultimately, this API is about the potential to be constexpr, so there's no need to pay for the expense of running the function with some gi

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:590 +// FIXME: may be incomplete +static unsigned CalculateTemplateDepthForConstraints(const Expr *Constr) { I'd like some sort of assert in the case where you don't know what to do he

[clang] 01bbe87 - [CGStmt] Use helper functions to set memory attributes (NFC)

Author: Nikita Popov Date: 2022-10-12T16:38:39+02:00 New Revision: 01bbe87fbb66cad9193c97843b0dd20aa2bd24ae URL: https://github.com/llvm/llvm-project/commit/01bbe87fbb66cad9193c97843b0dd20aa2bd24ae DIFF: https://github.com/llvm/llvm-project/commit/01bbe87fbb66cad9193c97843b0dd20aa2bd24ae.diff

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

nikic added a comment. In D135118#3851050 , @akyrtzi wrote: > @nikic, it seems to have recovered > (http://llvm-compile-time-tracker.com/compare.php?from=c49cde6467f9bf200640db763152a9dc7f009520&to=0456acbfb942f127359a8defd1b4f1f44420df3e&stat=instructio

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime added a comment. > Unless I'm missing something, I don't think this idea of 'unify constraint > depth' is correct. We should be able, from the decl itself, to determine the > depths? What is the difference here that I'm not getting? It is explained by the inline comments in sequence. > Ca

[PATCH] D134654: [clang] Detect header loops

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:323 "whitespace recommended after macro name">; +def warn_include_cycle : Warning<"#include cycle">, + InGroup>, DefaultIgnore; urnathan wrote: > urnathan wrote:

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. To avoid more tangential discussion here - I've opened https://discourse.llvm.org/t/generating-pcm-module-interfaces-and-regular-object-files-from-the-same-compiler-invocation/65918 ... it would be great if the major stakeholders here especially @rsmith could comment on

[PATCH] D135784: Add option to reparse an ASTUnit keeping its SourceManager

giulianobelinassi created this revision. Herald added a project: All. giulianobelinassi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When issuing a reparse, the SourceManager is then rebuilt from the FileMgr object it had in ASTUnit. Thi

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

BertalanD added a comment. I tried out D135772 , and our build got significantly farther than before! I unfortunately discovered another piece of code that pre babdef27c503c0bbbcc017e9f88affddda90ea4e

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. In D129156#3852553 , @tarunprabhu wrote: > In D129156#3851843 , @awarzynski > wrote: > >> @tarunprabhu Could you confirm that with the build command above >> "pass-plugin.f90" is fai

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:706 + std::tie(OldConstr, NewConstr) = + AdjustConstraintDepth::UnifyConstraintDepthFromDecl(*this, Old, OldConstr, + New, NewConstr);

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3852909 , @BertalanD wrote: > I tried out D135772 , and our build got > significantly farther than before! I unfortunately discovered another piece > of code that pre babdef27c503c

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

BertalanD added a comment. (I know this is a very contrived example with `void operator!=`, but that is what CVise spat out, and the actual failures are related to comparison operators too) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a subscriber: Uthkarsh. erichkeane added a comment. In D126907#3852975 , @BertalanD wrote: > (I know this is a very contrived example with `void operator!=`, but that is > what CVise spat out, and the actual failures are related to compa

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

erichkeane added subscribers: BertalanD, erichkeane. erichkeane added a comment. Note that @BertalanD noticed an issue with what I expect to be this patch: https://godbolt.org/z/Wjb9rsEYG Can someone more knowledgable about this paper please make sure it is an intended change? It seems to me

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

ilya-biryukov added a comment. In D134529#3852990 , @erichkeane wrote: > Note that @BertalanD noticed an issue with what I expect to be this patch: > https://godbolt.org/z/Wjb9rsEYG > > Can someone more knowledgable about this paper please make sure it

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. In D129156#3851843 , @awarzynski wrote: > @tarunprabhu Could you confirm that with the build command above > "pass-plugin.f90" is failing for you? It is for me. The tests still passed. Some relevant output from the test is

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

erichkeane added a comment. In D134529#3853036 , @ilya-biryukov wrote: > In D134529#3852990 , @erichkeane > wrote: > >> Note that @BertalanD noticed an issue with what I expect to be this patch: >> https://god

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. In D134529#3852990 , @erichkeane wrote: > Note that @BertalanD noticed an issue with what I expect to be this patch: > https://godbolt.org/z/Wjb9rsEYG > > Can someone more knowledgable about this paper please make sure it is

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

BertalanD added a comment. Thank you all for the help and clarification! I'll go fix our code then. As an aside, I understand that this paper now retroactively applies to the C++ standard, but code has already been written that assumes that what my example is doing is valid. Does it deserve a m

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

sammccall added a comment. Hmm, as mentioned on the bug, I think wrapping the deps and generated sources into a library is an important part of what the build rule does. If we need to split it up like this, I think a `generate_clang_protos` wrapper in FindGRPC.cmake might be the right place to

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3851458 , @rjmccall wrote: > Was this change in LLVM 15, or is it still unreleased? This is still unreleased. It will be released in Clang16. In D128745#3852409 , @aaron.ballman

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. If an invalid architecture is set we currently ret

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

phosek added a comment. In D134637#3835935 , @nhaehnle wrote: > Thank you all for the reviews. I've integrated the suggestions except for: > >> A possible alternative solution would be to build clangSupport_sources as an >> object library, and then link

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 updated this revision to Diff 467188. jhuber6 added a comment. Fix missing `None` return on HIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/new/ https://reviews.llvm.org/D135791 Files: clang/lib/Driver/Driver.cpp clang/test/D

[PATCH] D135724: [HIP] Fix unbundling archive

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839 auto Ext = IsMSVC ? ".lib" : ".a"; - if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) { -ArchiveOfBundles = Lib; -FoundAOB = true; + if (!Lib.startswith(":") && !Lib.startsw

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D135724: [HIP] Fix unbundling archive

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839 auto Ext = IsMSVC ? ".lib" : ".a"; - if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) { -ArchiveOfBundles = Lib; -FoundAOB = true; + if (!Lib.startswith(":") && !Lib.star

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. HIP is installed at /usr or /usr/local on Debin/Fedora, and the version file i

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few nits. Comment at: clang/lib/Driver/Driver.cpp:4191 /// or CUDA architecture. -static StringRef getCanonicalArchString(Compilation &C, -

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added inline comments. Comment at: clang/docs/ReleaseNotes.rst:473 --- +- Add ``__builtin_elementwise_sin`` and ``__builtin_elementwise_cos`` llvm builtins for floating point types only. Drop "llvm" from this sentence.

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4191 /// or CUDA architecture. -static StringRef getCanonicalArchString(Compilation &C, -const llvm::opt::DerivedArgList &Args, -

[clang-tools-extra] 2eaf6f9 - [AST] Preserve more structure in UsingEnumDecl node.

Author: Sam McCall Date: 2022-10-12T19:54:51+02:00 New Revision: 2eaf6f973cacd7f24691b72a9c6a3ee2a3d1a60b URL: https://github.com/llvm/llvm-project/commit/2eaf6f973cacd7f24691b72a9c6a3ee2a3d1a60b DIFF: https://github.com/llvm/llvm-project/commit/2eaf6f973cacd7f24691b72a9c6a3ee2a3d1a60b.diff LO

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 5 inline comments as done. Closed by commit rG2eaf6f973cac: [AST] Preserve more structure in UsingEnumDecl node. (authored by sammccall). Changed prio

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309 + ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local", + /*StrictChecking=*/true); Should it be done for Debian/Fedora only? See clang/include/clan

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/TargetInfo.cpp:327 +/// if the argument is smaller than a slot, set this flag will force +/// right-adjust the argument in its slot

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:3618 + /// The source location of the 'enum' keyword. + SourceLocation EnumLoc; + /// 'qual::SomeEnum' as an EnumType, possibly with Elaborated/Typedef sugar. hokein wrote: > nit: w

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 updated this revision to Diff 467199. jhuber6 added a comment. Making suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/new/ https://reviews.llvm.org/D135791 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/cu

[PATCH] D135724: [HIP] Fix unbundling archive

tra accepted this revision. tra added a comment. LGTM Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1839 auto Ext = IsMSVC ? ".lib" : ".a"; - if (!Lib.startswith(":") && llvm::sys::fs::exists(Lib)) { -ArchiveOfBundles = Lib; -FoundAOB = true; + if (!Lib.st

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309 + ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local", + /*StrictChecking=*/true); tra wrote: > Should it be done for Debian/Fedora only? See >

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 467201. bob80905 added a comment. - drop llvm from release notes description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

rjmccall added a comment. In D135326#3851678 , @dblaikie wrote: > In D135326#3851672 , @dblaikie > wrote: > >> (abandoned this, but still kind of curious) >> >> @rjmccall - any background/history of having the CX

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

tra accepted this revision. tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4211 if (IsNVIDIAGpuArch(Arch)) -return Args.MakeArgStringRef(CudaArchToString(Arch)); +return StringRef(Args.MakeArgStringRef(CudaArchToString(Arch))); Th

[clang] a6ebd30 - [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

Author: Volodymyr Sapsai Date: 2022-10-12T11:10:08-07:00 New Revision: a6ebd3083dbf8aadae58f6f2a2f1071976649d56 URL: https://github.com/llvm/llvm-project/commit/a6ebd3083dbf8aadae58f6f2a2f1071976649d56 DIFF: https://github.com/llvm/llvm-project/commit/a6ebd3083dbf8aadae58f6f2a2f1071976649d56.di

[PATCH] D135232: [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6ebd3083dbf: [modules] Allow to validate system headers less often with `-fmodules-validate… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

jhuber6 updated this revision to Diff 467204. jhuber6 added a comment. Making suggested changes, Early exists is part of the LLVM style so it's definitely better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/new/ https://reviews.llvm.org/D

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added a comment. In D135326#3853324 , @rjmccall wrote: > In D135326#3851678 , @dblaikie > wrote: > >> In D135326#3851672 , @dblaikie >> wrote: >> >>> (abandoned

[PATCH] D135796: [HIP] Detect HIP for Debian/Fedora

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:309 + ROCmSearchDirs.emplace_back(D.SysRoot + "/usr/local", + /*StrictChecking=*/true); yaxunl wrote: > tra wrote: > > Should it be done for Debian/Fedor

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

rnk added a comment. I think the disagreement here highlights the need to have a serious discussion about the future of error handling across the LLVM project. As you say, it sounds like you're not going to reach agreement on this code review, so maybe the best short term next step is to land t

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. HeaderSearch already uses a caching system to avoid duplicate searches, but the initial cold mis

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tahonermann added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; tbaeder wrote: > cor3ntin wrote: > > tahonermann wrote: > > > cor3ntin wrote: > > > > tbaeder wrote: > > > > > cor3ntin wrote: > > > > > > tahonermann wrote: > > > > > > > A

[PATCH] D135060: [HLSL] Add groupshare address space.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10299 Error<"attribute %0 can only be applied to an OpenCL kernel function">; -def err_opencl_return_value_with_address_space : Error< - "return value cannot be qualified with ad

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu updated this revision to Diff 467215. steven_wu added a comment. Herald added a subscriber: bmahjour. Herald added a project: clang. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135712/new/ https://reviews.llvm.or

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:143 + +}; tahonermann wrote: > tbaeder wrote: > > cor3ntin wrote: > > > tahonermann wrote: > > > > cor3ntin wrote: > > > > > tbaeder wrote: > > > > > > cor3ntin wrote: > > > > > > >

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu updated this revision to Diff 467217. steven_wu added a comment. Was missing the latest feedback. Bump FindGRPC module to top layer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135712/new/ https://reviews.llvm.org/D135712 Files: clan

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added a comment. Ping @awarzynski and @klausler--could you please let me know if the driver and runtime portions look good to you, respectively? (Apologies in advance if this isn't necessary, but as you both gave me significant feedback I wanted to make sure you are ok with the patc

[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ExtractAPI was emitting a separate symbol for anonymous record declaration

[clang] 2c09016 - [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

Author: Fangrui Song Date: 2022-10-12T11:55:27-07:00 New Revision: 2c090162746a6b901c5639562c090e4bb2b7327e URL: https://github.com/llvm/llvm-project/commit/2c090162746a6b901c5639562c090e4bb2b7327e DIFF: https://github.com/llvm/llvm-project/commit/2c090162746a6b901c5639562c090e4bb2b7327e.diff

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c090162746a: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135045/new/ h

[PATCH] D134371: [clang-doc] Add typedef/using information.

paulkirth added a comment. The premerge check is failing, because it can't apply the patch. Often this just means you need to rebase, so can you try rebasing your change and reuploading? Also, do you have commit access? you've made enough changes that its appropriate to request, which should m

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler accepted this revision. klausler added a comment. The runtime parts look good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] 8d72f44 - [Clang] Do not crash when an invalid offload architecture is set

Author: Joseph Huber Date: 2022-10-12T14:07:52-05:00 New Revision: 8d72f445f79992fd860a73ca4ebd78c1bcc6324b URL: https://github.com/llvm/llvm-project/commit/8d72f445f79992fd860a73ca4ebd78c1bcc6324b DIFF: https://github.com/llvm/llvm-project/commit/8d72f445f79992fd860a73ca4ebd78c1bcc6324b.diff

[PATCH] D135791: [Clang] Do not crash when an invalid offload architecture is set

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d72f445f799: [Clang] Do not crash when an invalid offload architecture is set (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135791/ne

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

arsenm added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:598 } else { -assert(false && "Unhandled type in array initializer initlist"); +llvm_unreachable("Unhandled type in array initializer initlist"); } aa

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. In D134529#3853086 , @BertalanD wrote: > Does it deserve a mention in the Potentially Breaking Changes section of the > release notes? You are right. I was thinking the same after this discussion. I will add this to the secti

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:950-952 + if (RestoredLineLength >= Style.ColumnLimit && Style.ColumnLimit != 0) { +break; + } Elide the braces. Comment at: clang/un

[PATCH] D135595: [HLSL] Add utility to convert environment to stage

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. Even without the tooling aspect the addition of the static asserts is a strict improvement. looks good, thanks! Comment at: clang/include/clang/Basic/HLSLRuntime.h:39 + ret

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. thanks! Comment at: cmake/Modules/FindGRPC.cmake:111 # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos LibraryName

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:540 -- Add `RemoveSemicolon` option for removing `;` after a non-empty function definition. +- Add ``RemoveSemicolon`` option for removing ``;`` after a non-empty function definition

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1189-1194 +// User defined literal without a space +if (CurrentToken->Previous->is

[PATCH] D135712: [CMake] Fix FindGRPC cmake module to allow different layering

steven_wu added inline comments. Comment at: cmake/Modules/FindGRPC.cmake:111 # They may be relative to the source dir or absolute (for generated protos). -function(generate_protos LibraryName ProtoFile) +macro(generate_protos_source GeneratedSource ProtoFile) cmake_parse_arg

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. In D135740#3851405 , @sstwcw wrote: > Should I add a test with comments to be aligned like in the bug report? I > was not sure because I didn't find an existing test for alignment of comments. Yes you should. Repos

  1   2   >