[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

kees added a comment. Change log typo? "but for all" should be "but not for all" ? Comment at: clang/lib/AST/Expr.cpp:223 // arrays to be treated as flexible-array-members, we still emit diagnostics // as if they are not. Pending further discussion... +if (Strict

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan, sammccall. Herald added a project: All. sstwcw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 2183fe2

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw added a project: clang-format. sstwcw added a comment. Should I add a test with comments to be aligned like in the bug report? I was not sure because I didn't find an existing test for alignment of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D135372: [clang-format] Fix for #58188

sstwcw abandoned this revision. sstwcw added a comment. I am closing it now there is D135740 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135372/new/ https://reviews.llvm.org/D135372 ___

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:852 +def err_module_odr_violation_attribute : Error< + "%q0 has different definitions in different modules; first difference is " + "%select{definition in module '%2'|defined here}1 found

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

rjmccall added a reviewer: t.p.northover. rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5461 // Otherwise, just use the general rule. + // TODO: a better approach may refer to SystemZABI use same logic for caller Please add th

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu added a comment. > In the near future I was planning to add various Objective-C and Swift > attributes. For other attributes I don't know which are high-value. I > definitely want to check attributes affecting the memory layout (alignment, > packing) and believe I've addressed them (t

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:327 +/// if the argument is smaller than a slot, set this flag will force +/// right-adjust the argument in its slot irrespective of the type. static Address emitVoidPtrDirectVAArg(CodeGenFunction &

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

rjmccall added a comment. I think that's fair. I don't know how much concrete information we'll get about this in a short period of time, but it's worth trying to collect it. Was this change in LLVM 15, or is it still unreleased? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a reviewer: tschuett. ChuanqiXu added a comment. In D134267#3849629 , @dblaikie wrote: > To the original point I was making about implicit modules (which might've > been my own confusion due to the term being brought up in D134269 >

[clang] 1fbb6d8 - Fix assert in generated `direct` property getter/setters due to removal of `_cmd` parameter.

Author: Michael Wyman Date: 2022-10-11T21:15:53-07:00 New Revision: 1fbb6d8b34dec217179d8e46d8c5d8e243047045 URL: https://github.com/llvm/llvm-project/commit/1fbb6d8b34dec217179d8e46d8c5d8e243047045 DIFF: https://github.com/llvm/llvm-project/commit/1fbb6d8b34dec217179d8e46d8c5d8e243047045.diff

[PATCH] D135091: Fix assert in generated `direct` property getter/setters due to removal of `_cmd` parameter.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbb6d8b34de: Fix assert in generated `direct` property getter/setters due to removal of… (authored by mwyman). Repository: rG LLVM Github Monorep

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny added a comment. In D135701#3850251 , @MaskRay wrote: > I don't understand this well, though. Is `CLANG_VERSION_MAJOR` wrong or not > defined in some cases? It's about `LLVM_VERSION_SUFFIX`. Normally, `SOVERSION` for all libraries is `${LLVM_VER

[PATCH] D135384: [AIX] Enable the use of the -pg flag

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Transforms/Utils/EntryExitInstrumenter.cpp:38-40 +const Twine targetTwine(M.getTargetTriple()); +Triple targetTriple(targetTwine); +if (targetTriple.isOSAIX()) { A `Twine` can be impli

[clang] d3ce133 - [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

Author: Michał Górny Date: 2022-10-12T07:14:28+02:00 New Revision: d3ce1339264dff3ea5571e9d5cf53d41e49a0879 URL: https://github.com/llvm/llvm-project/commit/d3ce1339264dff3ea5571e9d5cf53d41e49a0879 DIFF: https://github.com/llvm/llvm-project/commit/d3ce1339264dff3ea5571e9d5cf53d41e49a0879.diff

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ce1339264d: [clang] Do not override libclang.so's SOVERSION if… (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 467024. dblaikie added a comment. Add doc comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/include/clang/Basic/LangOptions.h clang/include/cl

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added a subscriber: rjmccall. dblaikie added a comment. (abandoned this, but still kind of curious) @rjmccall - any background/history of having the CXXABI distinct from the OS? I guess the point might've been that the C ABI is part of/the definition of the OS, but maybe the CXX ABI is

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie added a comment. In D135326#3851672 , @dblaikie wrote: > (abandoned this, but still kind of curious) > > @rjmccall - any background/history of having the CXXABI distinct from the OS? > I guess the point might've been that the C ABI is part of/th

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

phosek added a comment. This is just a nit, but I'd avoid extra formatting such as using `|` for separators and instead use just spaces and alignment akin to https://github.com/ClangBuiltLinux/frame-larger-than (or `llvm-readelf`) since that output tends to be easier to parse with tools like `c

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135707/new/ https://reviews.llvm.org/D135707 ___

[PATCH] D135727: [clang] Correct sanitizer behavior in union FAMs

serge-sans-paille added inline comments. Comment at: clang/lib/AST/Expr.cpp:228 +if (StrictFlexArraysLevel == FAMKind::OneZeroOrIncomplete && Size.uge(2)) + return false; } else if (!Context.getAsIncompleteArrayType(getType())) I <3 this simplificatio

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

mizvekov added inline comments. Comment at: clang/include/clang/Sema/SemaConcept.h:53-62 + if (const auto *SubstB = + ArgB.getAsType()->getAs()) { +QualType ReplacementA = SubstA->getReplacementType(); +QualType ReplacementB = Sub

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. In D129755#3850731 , @aaronpuchert wrote: > @hans, where you able to fix or work around the warnings? I'd like to land > this again, but if you need more time it can also wait a bit. The work-around for gRPC is still pending, but

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is a bit all over the place, sorry for t

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder added a comment. Anything still missing here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D135013: [clang][Interp] Array initialization via ImplicitValueInitExpr

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135013/new/ https://reviews.llvm.org/D135013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. Any other opinions on the new approach? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:139 + // ref-note {{in call to 'foo()'}} +}; aaron.ballman wrote: > The other thing I think we need some tests for are constructor and destructor > call

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 467031. ychen added a comment. - remove dead code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTe

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. @mizvekov it turns out I don't need that code anymore. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing li

<    1   2   3