[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

2022-10-05 Thread Liming Liu via Phabricator via cfe-commits
lime updated this revision to Diff 465652. lime added a comment. Thanks for the advice. I used `AdjustConstraintDepth` before `subsume`. The adjusted constraints are assigned to new addresses, but I think `MutableArrayRef` could be used here. > what do you mean by 'tailing' here? I wanted to e

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

2022-10-05 Thread Animesh Kumar via Phabricator via cfe-commits
animeshk-amd added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_10.cpp:19 +// RUN: %clang_cc1 -no-opaque-pointers -DCK11 -fopenmp -fopenmp-targets=i386-pc-linux-gnu -x c++ -std=c++11 -triple i386-unknown-unknown -emit-pch -o %t %s +// RUN: %clang_cc1 -no-op

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

2022-10-05 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cbc9206697e: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[clang] 7cbc920 - [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

2022-10-05 Thread via cfe-commits
Author: owenca Date: 2022-10-05T21:54:40-07:00 New Revision: 7cbc9206697e2e7ce0ae2c671c80133327631e7f URL: https://github.com/llvm/llvm-project/commit/7cbc9206697e2e7ce0ae2c671c80133327631e7f DIFF: https://github.com/llvm/llvm-project/commit/7cbc9206697e2e7ce0ae2c671c80133327631e7f.diff LOG: [

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

2022-10-05 Thread serge via Phabricator via cfe-commits
serge-sans-paille accepted this revision. serge-sans-paille added a comment. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 ___ cfe-com

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

2022-10-05 Thread serge via Phabricator via cfe-commits
serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:2 // REQUIRES: x86-registered-target -// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0 -fsanitize=array-bounds%s -o - | FileCheck %s --check-prefixes=CHECK,

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

2022-10-05 Thread Kees Cook via Phabricator via cfe-commits
kees added inline comments. Comment at: clang/test/CodeGen/object-size-flex-array.c:45 + // CHECK-STRICT-2: ret i32 -1 + // CHECK-STRICT-3: ret i32 0 return OBJECT_SIZE_BUILTIN(f->c, 1); serge-sans-paille wrote: > This one worries me a bit, as an array of si

[PATCH] D135060: [HLSL] Add groupshare address space.

2022-10-05 Thread Xiang Li via Phabricator via cfe-commits
python3kgae updated this revision to Diff 465661. python3kgae added a comment. Fix test fail caused by max address space change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clan

<    1   2   3