[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

sammccall added a comment. Started a thread: https://discourse.llvm.org/t/macro-performance-lexer-and-sourcemanager/65713 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20401/new/ https://reviews.llvm.org/D20401 ___ cfe

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, bnbarham. Herald added a subscriber: arphaman. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update `SourceManager::Con

[PATCH] D135142: Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI

rprichard accepted this revision. rprichard added a comment. This revision is now accepted and ready to land. It looks OK to me, but I wonder if you need someone else to accept it also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135142/new/ http

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4151 + QualType T = Entity.getType(); + // FIXME: Union is unsupported. + int InitKind = T->isArrayType() ? 0 : 4; ayzhao wrote: > Hmm...it seems like as is this patch generates

[clang] 43fe6f7 - [flang] Add -fpass-plugin option to Flang frontend

Author: Tarun Prabhu Date: 2022-10-04T17:02:45-06:00 New Revision: 43fe6f7cc35ded691bbc2fa844086d321e705d46 URL: https://github.com/llvm/llvm-project/commit/43fe6f7cc35ded691bbc2fa844086d321e705d46 DIFF: https://github.com/llvm/llvm-project/commit/43fe6f7cc35ded691bbc2fa844086d321e705d46.diff

[PATCH] D129156: Add -fpass-plugin option to Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rG43fe6f7cc35d: [flang] Add -fpass-plugin option to Flang frontend (authored by tarunprabhu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. Thanks for the review and the comments. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list cfe-commit

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Curre

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Pro

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

ABataev added a comment. Test is needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135224/new/ https://reviews.llvm.org/D135224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks updated this revision to Diff 465223. brooks added a comment. Add a test as requested by @arichardson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465230. stellaraccident added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add fix to MicrosoftMangle.cpp that caused buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465231. stellaraccident added a comment. Switch to explicit case per comment from ctopper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133823/new/ https://reviews.llvm.org/D133823 Files: clang/lib/

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465233. stellaraccident marked an inline comment as done. stellaraccident added a comment. Remove break after llvm_unreachable for consistency with other switches in file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465235. bob80905 added a comment. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rba

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465236. bob80905 added a comment. - add new line to end of new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.rst cla

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Sym

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

sammccall added a comment. My first take on this was to keep track in various ways of whether GC was required (statically known at callsite, or have builder track whether symbols were overwritten). However these failed to identify a bunch of cases where the arena wasn't shrinking, and this seem

[clang] e28b15b - Add APFloat and MLIR type support for fp8 (e5m2).

Author: Stella Laurenzo Date: 2022-10-04T17:18:17-07:00 New Revision: e28b15b572b58e5db4375da35745a4131858fc4c URL: https://github.com/llvm/llvm-project/commit/e28b15b572b58e5db4375da35745a4131858fc4c DIFF: https://github.com/llvm/llvm-project/commit/e28b15b572b58e5db4375da35745a4131858fc4c.dif

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe28b15b572b5: Add APFloat and MLIR type support for fp8 (e5m2). (authored by stellaraccident). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident added a comment. Ran the full clang/llvm/mlir test suite in debug mode just to be safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133823/new/ https://reviews.llvm.org/D133823 ___ cfe-

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM with a couple of small suggestions. Comment at: clang/include/clang/Basic/SourceManager.h:1062 +Optional F = sloc.getFile().getContentCache().OrigEntry;

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi updated this revision to Diff 465241. akyrtzi added a comment. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Remove `PropertyDeclOrder` parameter from the `collectPropertiesToImplement` functions. This is not necessary with `PropertyMap` becoming a `MapVector`

[PATCH] D135232: [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

vsapsai created this revision. vsapsai added reviewers: benlangmuir, MaskRay. Herald added subscribers: StephenFan, ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make flags `-fmodules-validat

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:1091 virtual void collectPropertiesToImplement(PropertyMap &PM, PropertyDeclOrder &PO) const {} --

[PATCH] D135232: [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

vsapsai added a comment. Here is the documentation for both flags: - https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fmodules-validate-system-headers - https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fmodules-validate-once-per-build-session

[PATCH] D135026: [clang-format] Handle C# interpolated verbatim string prefix @$

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb60e7a7f1afc: [clang-format] Handle C# interpolated verbatim string prefix @$ (authored by owenpan). Changed prior to commit: https://reviews.llvm

[clang] b60e7a7 - [clang-format] Handle C# interpolated verbatim string prefix @$

Author: owenca Date: 2022-10-04T18:27:36-07:00 New Revision: b60e7a7f1afc45af5a6ca9fc8a531c41d0e93c85 URL: https://github.com/llvm/llvm-project/commit/b60e7a7f1afc45af5a6ca9fc8a531c41d0e93c85 DIFF: https://github.com/llvm/llvm-project/commit/b60e7a7f1afc45af5a6ca9fc8a531c41d0e93c85.diff LOG: [

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. I see that this revision is reverted along with reversion of D128143 , I see that D128143 is re-commited. The commit message of D128143 says that it depends on this pat

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. Please disregard my previous comment, I missed the latest commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 ___ cfe-commits mailing

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

jdoerfert updated this revision to Diff 465256. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135155/new/ https://reviews.llvm.org/D13515

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

arsenm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 ClangBuiltin<"__builtin_amdgcn_ds_swizzle">, - Intrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty], -[IntrNoMem, IntrConvergent, IntrWillReturn, + DefaultAttrsIntrinsic<[llvm_

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

jdoerfert updated this revision to Diff 465262. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135155/new/ https://reviews.llvm.org/D135155 Files: clang/test/

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1226 def int_amdgcn_raw_tbuffer_store : Intrinsic < [], Default Comment a

[PATCH] D134546: [clang-offload-bundler] extracting compatible bundle entry

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/OffloadBundler.cpp:1008 +auto Output = Worklist.begin(); +for (auto E = Worklist.end(); Output != E; Output++) { + if (isCodeObjectCompatible( tra wro

[PATCH] D134546: [clang-offload-bundler] extracting compatible bundle entry

yaxunl updated this revision to Diff 465265. yaxunl marked an inline comment as done. yaxunl added a comment. check bundle entry ID compatibility when bundling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134546/new/ https://reviews.llvm.org/D134546 Files: clang/include/clang/Basic/

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 465271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb updated this revision to Diff 465272. cjdb added a comment. Changes `T`/`F` to `static_assert` to match D116203 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135175/new/ https://reviews.llvm.org/D135175 Fil

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 465273. cjdb added a comment. Replaces `T`/`F` with `static_assert` to match D116203 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135177

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb created this revision. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_copy_constructible` - `__is_nothrow_copy_constructible` - `__is_trivially_copy_constructible` This is information that th

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 465277. cjdb edited the summary of this revision. cjdb added a comment. Updates the commit message so patch applications work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb updated this revision to Diff 465278. cjdb added a comment. Restarts CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ https://reviews.llvm.org/D135238 Files: clang/include/clang/Basic/TokenKinds.def clang/lib/Parse/ParseDeclCX

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder updated this revision to Diff 465279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/I

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added a comment. In D135011#3835553 , @bob80905 wrote: > - add sve tests to prove compiler doesn't crash Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.l

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:607 + T __builtin_elementwise_cos(T x)return the ratio of the adjacent side length over thefloating point types + hypoteneuse sid

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:606 T __builtin_elementwise_ceil(T x) return the smallest integral value greater than or equal to xfloating point types + T __builtin_elementwise_cos(T x)return the rati

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 465280. to268 added a comment. Added a check to not diagnose a missing type specifier in C2x mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/include

[PATCH] D135239: [clang] adds copy-assignable type-trait builtins

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_copy_assignable` - `__is_nothrow_copy_assignable` - `__is_trivially_copy_assignable`

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle updated this revision to Diff 465283. nhaehnle added a comment. - define an alias so that clang-tblgen can always link against "clangSupport_tablegen" - use add_llvm_library(... BUILDTREE_ONLY ...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle updated this revision to Diff 465284. nhaehnle added a comment. Remove the confusing "accidentally" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134637/new/ https://reviews.llvm.org/D134637 Files: clang/lib/Support/CMakeLists.txt cla

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle added a comment. Thank you all for the reviews. I've integrated the suggestions except for: > A possible alternative solution would be to build clangSupport_sources as an > object library, and then link that library into clangSupport and clang-tblgen > which could be done unconditional

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb updated this revision to Diff 465285. cjdb edited the summary of this revision. cjdb added a comment. rewords commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ https://reviews.llvm.org/D135238 Files: clang/include/cla

[PATCH] D135239: [clang] adds copy-assignable type-trait builtins

cjdb updated this revision to Diff 465286. cjdb edited the summary of this revision. cjdb added a comment. corrects commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135239/new/ https://reviews.llvm.org/D135239 Files: clang/include/cl

[PATCH] D135240: [clang] adds move-constructible type-trait builtins

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_move_constructible` - `__is_nothrow_move_constructible` - `__is_trivially_move_const

<    1   2   3