[PATCH] D134626: [clang-format] Correctly indent closing brace of compound requires

rymiel added a comment. I built 2 versions of clang-format, before and after this patch, and made 2 separate clones of all of LLVM+clang and ran them through either, removing all `.clang-format`s, then ran a recursive diff. I found 1 difference, in a test case at `clang/test/CodeGen/constraine

[PATCH] D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang does not emit debuginfo for the switch stmt case valu

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

sepavloff added a comment. In D134337#3815705 , @MaskRay wrote: > In D134337#3815412 , @mgorny wrote: > >> In D134337#3815339 , @sepavloff >> wrote: >> >>> In D134337#380

[PATCH] D130510: Missing tautological compare warnings due to unary operators

ebevhan added a comment. Hi! A bit of late feedback on this patch. We found a failure in our downstream testing likely originating from here. The failing case is: void f(int a) { (0 != (a | !0LL)); } built with `clang -cc1 -emit-llvm-bc -O2 -v -o foo.bc -x c foo.c` =

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice updated this revision to Diff 463114. paperchalice added a comment. Update the //output_dir//. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134597/new/ https://reviews.llvm.org/D134597 Files: clang/lib/Headers/CMakeLists.txt Inde

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134671/new/ https://reviews.llvm.org/D134671 _

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. > Also I applied this patch with D134698 and > used on our large test set, expecting significant number of pre-existing > reports. To my surprise I see not many of them. Something wrong with my msan experiment, I'll re-evaluate size

[PATCH] D134523: [clang][Interp] Fix copy constructors with record array members

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:332 + // ArrayIndex might not be set if a ArrayInitIndexExpr is being evaluated + // stand-alone, e.g. via EvaluateAsInt(). + if (!ArrayIndex) erichkeane wrote: > For my edific

[clang] fbb1194 - [AArch64] Add Neoverse V2 CPU support

Author: David Sherwood Date: 2022-09-27T07:56:08Z New Revision: fbb119412f143530a23d22b6b0f90d4cf2303fbf URL: https://github.com/llvm/llvm-project/commit/fbb119412f143530a23d22b6b0f90d4cf2303fbf DIFF: https://github.com/llvm/llvm-project/commit/fbb119412f143530a23d22b6b0f90d4cf2303fbf.diff LOG

[PATCH] D134352: [AArch64] Add Neoverse V2 CPU support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. david-arm marked 3 inline comments as done. Closed by commit rGfbb119412f14: [AArch64] Add Neoverse V2 CPU support (authored by david-arm). Changed prior to commit:

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 463134. VincentWu marked 9 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 463137. VincentWu added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/Suppor

[clang] 712de9d - [AArch64] Add all predecessor archs in target info

Author: Daniel Kiss Date: 2022-09-27T10:23:21+02:00 New Revision: 712de9d1716c010e895a578ad86cbd47680a4fdd URL: https://github.com/llvm/llvm-project/commit/712de9d1716c010e895a578ad86cbd47680a4fdd DIFF: https://github.com/llvm/llvm-project/commit/712de9d1716c010e895a578ad86cbd47680a4fdd.diff L

[PATCH] D134353: [AArch64] Add all predecessor archs in target info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG712de9d1716c: [AArch64] Add all predecessor archs in target info (authored by danielkiss). Herald added a project: clang. Herald added a subscriber:

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

Amanieu created this revision. Amanieu added a reviewer: MaskRay. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. Amanieu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With -mgeneral-regs-only, all argume

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

cor3ntin added a comment. It's great to see this make progress. Can you update cxx_status.html and ReleaseNotes.txt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 _

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

10ne1 added inline comments. Comment at: clang/lib/Driver/Distro.cpp:213 + // that the Linux OS and distro are properly detected in this cases. + llvm::Triple NormTargetOrHost = llvm::Triple(Twine(TargetOrHost.normalize())); + nickdesaulniers wrote: > 10ne1 wr

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134597/new/ https://reviews.llvm.org/D134597 ___

[PATCH] D134454: [Driver][Distro] Fix ArchLinux triplet and sysroot detection

10ne1 added a comment. In D134454#3816460 , @MaskRay wrote: > I am nervous as well as Arch Linux has many derivatives. They likely don't > use `ID=arch` in `/etc/os-release`. The patch won't work for them. > In general, I don't think our current approach

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. > Assume we have `(int)(short)(int x)`. `VisitSymbolCast` will try to get the > constant recursively in the next order: > > - `(short)(int x)` > - `(int x)` > > And here is my concern. Whether it is correct to get the range for `int x` > and consider it as a correct simp

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice added a comment. If it is ready to land, could you commit this change? I don't have commit right, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134597/new/ https://reviews.llvm.org/D134597

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. Looks good, aside some points: - Please add test for the conditioning on `ClangABICompat15`. - Missing release notes. - FWIW GCC treats the `g(42)` case as not ambiguous, as I expected, so

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3817133 , @sepavloff wrote: > It make sense but the algorithm looks overcomplicated. The current > implementation is already too complex and documenting the new algorithm is a > challenge. > > What about making minimal

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. Unfortunately this is failing the "premerge checks" F24716144: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 _

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 updated this revision to Diff 463177. 10ne1 retitled this revision from "[Driver][Distro] Fix ArchLinux triplet and sysroot detection" to "[Driver][Distro] Fix ArchLinux sysroot detection". 10ne1 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1344

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3815057 , @davrec wrote: >> So this patch at least puts that into consistency. > > Is there already an analogous breakage for classes then? I am not sure I follow the question, but I meant that classes were already d

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 marked 2 inline comments as done. 10ne1 added a comment. @nickdesaulniers @MaskRay I've updated the diff & summary based on the review comments which I've marked as done. Please tell me what you think. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://r

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

whisperity added a comment. I agree with @martong that `$ = realloc($, ...)` is indicative of something going wrong, even if the developer has saved the original value somewhere. Are we trying to catch this with Tidy specifically for this reason (instead of CSA's stdlib checker, or some taint-r

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousReallocUsageCheck.cpp:89-90 +return; + diag(Call->getBeginLoc(), + "memory block passed to 'realloc' may leak if 'realloc' fails"); +} I have some reservatio

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousReallocUsageCheck.cpp:89-90 +return; + diag(Call->getBeginLoc(), + "memory block passed to 'realloc' may leak if 'realloc' fails"); +} whisperity wrote: > I

[PATCH] D133574: [C2x] reject type definitions in offsetof

aaron.ballman added a comment. In D133574#3816688 , @inclyc wrote: > This revision fixes: > > **anonymous struct** > >> You should be able to pass in the TagDecl directly because the diagnostics >> engine knows how to print a NamedDecl. > > I've switch ba

[PATCH] D127484: [clang-format] Use tabs on GNU style

MyDeveloperDay added a comment. @a4lg If we have decided NOT to do this can we Abandon the review so as to remove it from the reviewers "clang-format" lists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127484/new/ https://reviews.llvm.org/D12748

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec added a comment. In D131858#3817646 , @mizvekov wrote: > In D131858#3815057 , @davrec wrote: > >>> So this patch at least puts that into consistency. >> >> Is there already an analogous breakage for classes

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

MyDeveloperDay added a comment. @kwk have we bottomed out on this issue? its been stale for a bit. If we are not going to work on it further can be "Abandon" the review to get it off our lists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 463187. VincentWu marked 9 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

10ne1 updated this revision to Diff 463189. 10ne1 added a comment. Fixed some clang-format problems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454 Files: clang/include/clang/Driver/Distro.h clang/lib/Driver/ToolChains/Linux.cpp Index:

[PATCH] D134177: Add MC support of RISCV Zcd Extension

VincentWu updated this revision to Diff 463202. VincentWu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134177/new/ https://reviews.llvm.org/D134177 Files: clang/test/Preprocessor/riscv-target-features.c llvm/l

[PATCH] D134176: Add MC support of RISCV Zcf Extension

VincentWu updated this revision to Diff 463203. VincentWu added a comment. add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134176/new/ https://reviews.llvm.org/D134176 Files: clang/test/Preprocessor/riscv-target-features.c llvm/lib/

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 463201. mgorny edited the summary of this revision. mgorny added a comment. Ok, how about this variant? I think it's the simplest I can come up with that roughly matches the old behavior and adds what's necessary for the new. The algorithm is to use: 1. `-.c

[PATCH] D134733: [clang-format][chore] transparent #include name regex

kwk created this revision. kwk added a reviewer: MyDeveloperDay. Herald added a project: All. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The foundation for this patch was done in: https://reviews.llvm.org/D121370. I wanted to "resc

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk abandoned this revision. kwk added a comment. In D121370#3817753 , @MyDeveloperDay wrote: > @kwk have we bottomed out on this issue? its been stale for a bit. If we are > not going to work on it further can be "Abandon" the review to get it off our

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

erichkeane accepted this revision. erichkeane added a comment. Just fix @mizvekov 's nits (the fixme, release notes, and ABI test), and LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 __

[PATCH] D134507: [Clang] add missing ClangABICompat check

probinson added a subscriber: rjmccall. probinson added a comment. It feels odd to use a ClangABI check for something that is affecting what source is accepted, but this is not my area of expertise. @aaron.ballman or @rjmccall would probably be the right people to weigh in on this. Repository:

[PATCH] D134673: [Driver][PS4] pass -fcrash-diagnostics-dir to LTO

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134673/new/ https://reviews.llvm.org/D134673 _

[PATCH] D134175: [clang][Interp] Implement record instance functions and returning struct types

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134175/new/ https://reviews.llvm.org/D134175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6b0b306 - Fix regression from Deferred Concepts with lambda in var init

Author: Erich Keane Date: 2022-09-27T06:32:39-07:00 New Revision: 6b0b306e6221ba3f8f02944b8e5a8140f4d52324 URL: https://github.com/llvm/llvm-project/commit/6b0b306e6221ba3f8f02944b8e5a8140f4d52324 DIFF: https://github.com/llvm/llvm-project/commit/6b0b306e6221ba3f8f02944b8e5a8140f4d52324.diff L

[PATCH] D134737: [pseudo][wip] Recovery for statements.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The main idea is to reuse the existing declaration recovery strategy -- exten

[PATCH] D134737: [pseudo][wip] Recovery for statements.

hokein added a comment. it should demonstrate the main idea. I will do some more tweaks (rename etc), and add tests once we agree on the direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134737/new/ https://reviews.llvm.org/D134737 ___

[PATCH] D134660: [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Better than before. Thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134660/new/ https://reviews.llvm.org/D134660 __

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 463237. usaxena95 added a comment. Added better diagnostic for non-const symmetric operator==. Added release notes. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llv

[PATCH] D133574: [C2x] reject type definitions in offsetof

nathanchance added a comment. Diff 463063 looks good against the Linux kernel with https://lore.kernel.org/20220925153151.2467884-1...@inclyc.cn/ applied. I see no additional errors/warnings and the `drivers/media/platform/nvidia/tegra-vde/v4l2.c` did disappear. Once that patch has been fully

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

nathanchance added a comment. Thanks a lot for fixing this! I took it for a spin against the Linux kernel and all instances of `-Wvoid-ptr-dereference` disappeared :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134702/new/ https://reviews.llvm.o

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

sepavloff added a comment. In D134337#3817878 , @mgorny wrote: > Ok, how about this variant? I think it's the simplest I can come up with that > roughly matches the old behavior and adds what's necessary for the new. > > The algorithm is to use: > > 1. `

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

junaire added a comment. In D134702#3818274 , @nathanchance wrote: > Thanks a lot for fixing this! I took it for a spin against the Linux kernel > and all instances of `-Wvoid-ptr-dereference` disappeared :) Awesome! Glad to hear this fixed your proble

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Something easier to review I hope :) Implement an

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder updated this revision to Diff 463245. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD created this revision. eopXD added reviewers: sdesmalen, paulwalker-arm, fhahn, reames, hfinkel. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabua

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Please feel free to add appropriate reviewer to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 ___ cfe-commits mailing list

[clang] f50a7c7 - [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO

Author: Joseph Huber Date: 2022-09-27T10:49:17-05:00 New Revision: f50a7c7a26e074231cc9a60a3fcaef7520ceb67f URL: https://github.com/llvm/llvm-project/commit/f50a7c7a26e074231cc9a60a3fcaef7520ceb67f DIFF: https://github.com/llvm/llvm-project/commit/f50a7c7a26e074231cc9a60a3fcaef7520ceb67f.diff

[PATCH] D134660: [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGf50a7c7a26e0: [LinkerWrapper] Fix optimized debugging builds for NVPTX LTO (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134660/new/

[PATCH] D134744: [clang][Interp] Implement rem opcode

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:213 + static bool rem(Integral A, Integral B, unsigned OpBits, Integral *R) { +*R = Integral(A.V % B.V); Its a touch weird we return 'bool' in all these places, rather than an `

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. Thanks. Since the algorithm's good, I'll work on updating the docs and tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder updated this revision to Diff 463251. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134744/new/ https://reviews.llvm.org/D134744 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:213 + static bool rem(Integral A, Integral B, unsigned OpBits, Integral *R) { +*R = Integral(A.V % B.V); erichkeane wrote: > Its a touch weird we return 'bool' in all these places,

[PATCH] D134744: [clang][Interp] Implement rem opcode

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Integral.h:213 + static bool rem(Integral A, Integral B, unsigned OpBits, Integral *R) { +*R = Integral(A.V % B.V); --

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

ilya-biryukov added a comment. A few ideas for tests: - Static operators. Technically disallowed by the standard, but Clang seems to recover without dropping the member, so it seems we can actually look it up. struct X { bool operator ==(X const&) const; static bool operator !=(X con

[PATCH] D134744: [clang][Interp] Implement rem opcode

tbaeder marked 7 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Integral.h:213 + static bool rem(Integral A, Integral B, unsigned OpBits, Integral *R) { +*R = Integral(A.V % B.V); erichkeane wrote: > tbaeder wrote:

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

mwyman added a comment. In D86049#3816006 , @plotfi wrote: > @dmaclach @ahatanak @mwyman How do things look from here? Do you want > something for properties as well or would it be ok if we did this in a later > commit? Huh, for some reason I thought wh

[PATCH] D134749: [clang][Interp] Implement Div opcode

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same as the `rem` patch basically. Repository:

[PATCH] D134749: [clang][Interp] Implement Div opcode

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:189 + const unsigned Bits = RHS.bitWidth() * 2; + T Result; + if (!T::div(LHS, RHS, Bits, &Result)) { Could use a helper function here and in `Rem` to reduce code duplication. Repositor

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

jyu2 updated this revision to Diff 463257. jyu2 added a comment. Merge duplicate code as Alexey suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134556/new/ https://reviews.llvm.org/D134556 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

ilya-biryukov added a reviewer: clang-language-wg. ilya-biryukov added a comment. Overall LG, thanks! The only major comment from me is that we probably want to implement the full "corresponds" check so we handle various cases mentioned in the FIXMEs. Also adding the Language WG as reviewers in

[PATCH] D134749: [clang][Interp] Implement Div opcode

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Seems good enoguh to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134749/new/ https://reviews.llvm.org/D134749 ___

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

mcberg2021 added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:673 +setInterleaveEnable(false); setInterleaveCount(1); break; Can you update the comments on lines: 665 and 671 as they both need update. Repository: rG

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD updated this revision to Diff 463261. eopXD added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD marked an inline comment as done. eopXD added a comment. After this patch, we can remove setVectorizeWidth(1) and setInterleaveCount(1) when vectorize(disable) and interleave(disable) is specified. For now it is not removed to keep the patch limited and simple enough. Repository: rG LL

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov added a comment. @martong wrote: I think you did get it. I'm not talking about range but about concrete int. And I see that the current behavior needs an improvement or rework. Consider next code, which I used in my example: 1. void test(int x) { 2. assert((short)x == 0); 3

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

thakis added a comment. Maybe we could have a `-f` flag to control whether to prefer annotations or profile data when they conflict? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 __

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGed8409dfa0a9: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D134556: [Clang][OpenMP] Fix run time crash when use_device_addr is used.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134556/new/ https://reviews.llvm.org/D134556 ___

[clang] d1ad006 - [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

Author: Craig Topper Date: 2022-09-27T10:07:20-07:00 New Revision: d1ad006a8f64bdc17f618deffa9e7c91d82c444d URL: https://github.com/llvm/llvm-project/commit/d1ad006a8f64bdc17f618deffa9e7c91d82c444d DIFF: https://github.com/llvm/llvm-project/commit/d1ad006a8f64bdc17f618deffa9e7c91d82c444d.diff

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ad006a8f64: [Driver] Prevent Mips specific code from claiming -mabi argument on other… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] cbbce9b - [Driver] Silence a -Wparentheses error. NFC

Author: Craig Topper Date: 2022-09-27T10:25:23-07:00 New Revision: cbbce9b537adfbc2271424ab66b3f2d818a2499f URL: https://github.com/llvm/llvm-project/commit/cbbce9b537adfbc2271424ab66b3f2d818a2499f DIFF: https://github.com/llvm/llvm-project/commit/cbbce9b537adfbc2271424ab66b3f2d818a2499f.diff

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 463274. mgorny added a comment. Update tests. Docs coming up next. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp clang/test/Dri

[PATCH] D134693: [CMake] Add `CLANG_ENABLE_HLSL` CMake option

This revision was automatically updated to reflect the committed changes. Closed by commit rGe432108bf254: [CMake] Add `CLANG_ENABLE_HLSL` CMake option (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D134693?vs=463079&id=463275#toc Repository: rG LLVM Github Monorepo

[clang] e432108 - [CMake] Add `CLANG_ENABLE_HLSL` CMake option

Author: Chris Bieneman Date: 2022-09-27T12:33:22-05:00 New Revision: e432108bf25456f428a3956fd79d29ea7fc196ac URL: https://github.com/llvm/llvm-project/commit/e432108bf25456f428a3956fd79d29ea7fc196ac DIFF: https://github.com/llvm/llvm-project/commit/e432108bf25456f428a3956fd79d29ea7fc196ac.diff

[PATCH] D134705: [clang][DebugInfo] Emit debuginfo for non-constant case value

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. SGTM - could you also add some CHECKs in the test that show the enumeration was added to the enumerators list on the CU (& you can probably test with just one enumerator - don't need two i

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

dblaikie added a comment. Ping on this. (also sent out D134688 for the HFA stuff, which separates that from the "isTrivialFor" functionality entirely making it easier to make the different choices here) Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3818435 , @mwyman wrote: > In D86049#3816006 , @plotfi wrote: > >> @dmaclach @ahatanak @mwyman How do things look from here? Do you want >> something for properties as well or woul

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen updated this revision to Diff 463283. ychen added a comment. - add test for the conditioning on `ClangABICompat15`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133683/new/ https://reviews.llvm.org/D133683 Files: clang/lib/Sema/SemaTempla

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added a comment. In D131858#3817750 , @davrec wrote: > Question was referring to @ChuanqiXu 's comment about this patch breaking > modules for function importing, see his repro (which I haven't looked at > closely). I was asking if this meant

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

mwyman added a comment. I think it's reasonable to do `@property` behavior in a follow-up. Are we thinking to allow `__attribute__((visibility("default")))` on an `@property` declaration, to keep the visibility behavior consistent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 463288. mgorny added a comment. Added doc update. Would use some help with release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Dri

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

ychen added a comment. In D133683#3817523 , @mizvekov wrote: > - Missing release notes. I didn't add that because this patch is logically part of D128745 which has a release note already. > - FWIW GCC treats the `g(42

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3817928 , @probinson wrote: > It feels odd to use a ClangABI check for something that is affecting what > source is accepted, but this is not my area of expertise. > @aaron.ballman or @rjmccall would probably be the righ

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. Yeah okay. I get it now. Thank you for your patience and your time on elaborating the issue. First, I think we'd need to fabricate a test case that shows us the bug even without applying your patch (D103096 ). Then we can iterate onto

[PATCH] D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134702/new/ https://reviews.llvm.org/D134702

[PATCH] D133683: [c++] implements tentative DR1432 for partial ordering of function template

mizvekov added a comment. In D133683#3818752 , @ychen wrote: > I didn't add that because this patch is logically part of D128745 > which has a release note already. Okay, I see that the existing release note entry talk

[PATCH] D134507: [Clang] add missing ClangABICompat check

rjmccall added a comment. I don't think I agree that changes to template partial ordering rules are "ABI-breaking changes". They're breaking changes to *language semantics*, and the ABI break is downstream of that, just like any other semantic change to overload resolution would be. I think t

  1   2   3   >