[clang] a3becb3 - [clang][AMDGPU] Temporarily disable clang atomic fadd test for gfx90a

Author: Petar Avramovic Date: 2022-09-23T21:49:16+02:00 New Revision: a3becb333d7faae695e18728e9b8fa3a3579a240 URL: https://github.com/llvm/llvm-project/commit/a3becb333d7faae695e18728e9b8fa3a3579a240 DIFF: https://github.com/llvm/llvm-project/commit/a3becb333d7faae695e18728e9b8fa3a3579a240.dif

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

arlosi abandoned this revision. arlosi added a comment. Closing in favor of D134544 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___

[PATCH] D134020: [clang][Interp] Handle enums

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; Maybe some edge case values for enumerators like `__INT_MAX__ *2U +1U` (UINT_M

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak reopened this revision. dhruvachak added a comment. This revision is now accepted and ready to land. This patch was reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 ___

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:344 +/// Set debug info source file hashing algorithm +ENUM_CODEGENOPT(DebugSrcHashAlgorithm, SrcHashAlgorithm, 2, CSK_MD5) hans wrote: > ultra nit: period. But maybe the com

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak updated this revision to Diff 462582. dhruvachak added a comment. Updated llvm tests. The following 3 tests still fail: LLVM :: Transforms/OpenMP/spmdization_constant_prop.ll LLVM :: Transforms/OpenMP/spmdization_guarding_two_reaching_kernels.ll LLVM :: Transforms/OpenMP/spmdizat

[PATCH] D134544: [clang-cl] Implement /ZH: flag

probinson added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-ch

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3812554 , @dhruvachak wrote: > Updated llvm tests. The following 3 tests still fail: > > LLVM :: Transforms/OpenMP/spmdization_constant_prop.ll > LLVM :: Transforms/OpenMP/spmdization_guarding_two_reaching_kerne

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

glandium added a comment. In D131465#3812424 , @rnk wrote: > I think both driver share the logic for MSVC version detection, which checks > for cl.exe on PATH and looks at the registry if that fails. > > I think we should try to lean towards making this

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 462587. ayzhao marked an inline comment as done. ayzhao added a comment. address some more review comments + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-check

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN: %S/Inputs/debug-info-file-check

[PATCH] D134544: [clang-cl] Implement /ZH: flag

thakis updated this revision to Diff 462596. thakis added a comment. don't accidentally add a flag for this to the gcc-style driver CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544 Files: clang/include/clang/Basic/CodeGenOptions.def clang/i

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen added a comment. In D134542#3812292 , @erichkeane wrote: > In D134542#3812211 , @ychen wrote: > >> The patch looks good. Two high-level questions: >> >> - Does the similar thing happen for class templates?

[PATCH] D134542: [Concepts] Recover properly from a RecoveryExpr in a concept

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134542/new/ https://reviews.llvm.org/D134542 ___ cfe-commits mailing list cfe-

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. In D134507#3811488 , @probinson wrote: > Would this be clearer if the BEFORE-15/AFTER-15 test cases used the same > template construct? Currently they are different so it's hard to work out > the effect of the change. In particu

[PATCH] D133574: [C2x] reject type definitions in offsetof

shafik added a comment. LGTM but I will Aaron give the final approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list cfe-commits@

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:367 +// with this method returning a non-null ParsedType? +if (isa(CurContext)) + return nullptr; erichkeane wrote: > Hmm... this scares me quite a bit, I don't really

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

MaskRay added a comment. I am not a Windows driver user. This patch is entirely motivated by Windows discussions in D131465 and I want to make `/std:` default rule simple (say, clang 16 uses C++17 for every mode for Windows). If the `-fno-threadsafe-statics` c

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao marked 2 inline comments as done. ayzhao added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:367 +// with this method returning a non-null ParsedType? +if (isa(CurContext)) + return nullptr; ayzhao wrote: > erichkeane wr

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae updated this revision to Diff 462624. python3kgae marked an inline comment as done. python3kgae added a comment. Rebase for allow SV_GroupIndex in lib profile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/new/ https://reviews.llv

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#3812582 , @dhruvachak wrote: > In D102107#3812554 , @dhruvachak > wrote: > >> Updated llvm tests. The following 3 tests still fail: >> >> LLVM :: Transforms/OpenMP/spmdiza

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen abandoned this revision. ychen added a comment. Herald added a project: All. 327141f is landed as an alternative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/

[PATCH] D102147: [Clang][Coroutines] Implement P2014R0 Option 1 behind -fcoroutines-aligned-alloc

ychen abandoned this revision. ychen added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. 327141f was landed as an alternative. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D134578: Add missing `struct` keyword to the test p2-2.cpp

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on D53847 , I noticed that this test would fail once we started recognizing th

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 462633. ayzhao added a comment. remove the hack for the test p2-2.cpp and patch in patch in D134578 which fixes the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao marked an inline comment as done. ayzhao added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:367 +// with this method returning a non-null ParsedType? +if (isa(CurContext)) + return nullptr; ayzhao wrote: > ayzhao wrote:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added a comment. In D53847#3809072 , @erichkeane wrote: > I think this is on the right track, but would like to see more work done on > that fixme before we commit (or at least better understand what is causing > this). I'm afraid of what else ca

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3812946 , @jdoerfert wrote: > In D102107#3812582 , @dhruvachak > wrote: > >> In D102107#3812554 , @dhruvachak >> wrote: >> >>> Upd

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2251-2256 +def ObjCDirectVisible : Attr { + let Spellings = [Clang<"objc_direct_visible">]; + let Subjects = SubjectList<[ObjCMethod], ErrorDiag>; + let LangOpts = [ObjC]; + let Documentation = [ObjCD

[PATCH] D134550: [Clang] Make Clang driver suggest '-Xclang' for CC1 options passed to the driver

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. I think this is fine. Driver options take precedence and cc1 options cannot be suggested. If the user writes a cc1-only option without `-Xclang`, they likely have the particular need and wil

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

barcisz added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/MatchersTest.cpp:2 +#include "utils/Matchers.h" +#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h" + njames93 wrote: > kwk wrote: > > njames93 wrote: > > > @kwk I seem

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

junaire added inline comments. Comment at: clang/test/C/drs/dr1xx.c:140 /* The behavior changed between C89 and C99. */ - (void)&*p; /* c89only-warning {{ISO C forbids taking the address of an expression of type 'void'}} */ + (void)&*p; /* c89only-warning {{ISO C forbids ta

[PATCH] D134461: [Clang] Warn when trying to deferencing void pointers in C

junaire updated this revision to Diff 462643. junaire added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134461/new/ https://reviews.llvm.org/D134461 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Di

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134513/new/ https://reviews.llvm.org/D134513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134513/new/ https://reviews.llvm.org/D134513 ___

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added a comment. The following are results from test-suite execution. LHS is a main build (17dde371e773 ) and the RHS is main with patch applied. The `results-subset.txt` is absent of unit, micro, and torture tests. E

[PATCH] D134544: [clang-cl] Implement /ZH: flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Basic/CodeGenOptions.h:106 + enum SrcHashAlgorithm { +CSK_MD5, +CSK_SHA1, thakis wrote: > hans wrote: > > what does

<    1   2