[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

bcl5980 added a comment. In D125418#3806720 , @efriedma wrote: >> Sometimes we will emit the alias here but later the function will be inlined >> or eliminated by DCE. > > If the alias is externally visible, it can't be eliminated; the compiler > can't

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the same spirit of da6187f566b7881cb

[clang] 10409bf - [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

Author: eopXD Date: 2022-09-22T18:13:16-07:00 New Revision: 10409bf86e58320443db5c5ea2adf5e437104ee9 URL: https://github.com/llvm/llvm-project/commit/10409bf86e58320443db5c5ea2adf5e437104ee9 DIFF: https://github.com/llvm/llvm-project/commit/10409bf86e58320443db5c5ea2adf5e437104ee9.diff LOG: [F

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10409bf86e58: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless (authored by eopXD). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D134507: [Clang] add missing ClangABICompat check

ychen added a comment. Address comments in https://reviews.llvm.org/D128745/new/#3809692. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134507/new/ https://reviews.llvm.org/D134507 ___ cfe-commits mailin

[PATCH] D134507: [Clang] add missing ClangABICompat check

probinson added a comment. Anytime there's a Clang ABI version check, I have to wonder whether PS4/PS5 need an exception. (And I'm sorry I missed the earlier patches in this series.) We are pretty much locked to however things worked for Clang 3.2. Is this specific to C++20 (or later)? In th

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} You may use BLAKE3 instead of MD5. BLAKE3 is mu

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:1247 +uint32_t Column) { + return hash_combine(Function, LineOffset, Column); +} MaskRay wrote: > You may use BLAKE3 instead of

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2907-2908 +// which are not object files. Files with extension ".lib" is classified +// as TY_Object but they are actually archives, therefore should no

[PATCH] D133705: [HIP] Fix unbundling archive

yaxunl updated this revision to Diff 462376. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133705/new/ https://reviews.llvm.org/D133705 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/T

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

eopXD created this revision. eopXD added reviewers: nlopes, khchen, craig.topper. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[clang] 5d12e9a - [Clang][NFC] Make unused flag `-fopenmp-new-driver` help hidden

Author: Joseph Huber Date: 2022-09-22T21:34:33-05:00 New Revision: 5d12e9a5717c738522cd5ec98f098fbf4ce1aec2 URL: https://github.com/llvm/llvm-project/commit/5d12e9a5717c738522cd5ec98f098fbf4ce1aec2 DIFF: https://github.com/llvm/llvm-project/commit/5d12e9a5717c738522cd5ec98f098fbf4ce1aec2.diff

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining updated this revision to Diff 462388. SixWeining added a comment. Address @rengolin's comments. 1. Clip the '$' from original constraint string and match table-gen'd names. 2. Delete unnecessary check prefix in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1958 + // constraints while the official register name is prefixed with a '$'. + // So we manually select general purpose registers here. + // For now, no need to support ABI name

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rtrieu added inline comments. Comment at: clang/include/clang/AST/Type.h:3947 + Info) { +FunctionTypeBits.FastTypeQuals = 0; + } rmaz wrote: > aaron.ballman wrote: > > It seems a bit odd to me that we only want to initialize one member of

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

serge-sans-paille added a comment. Shouldn't this be a situation where `-Wmisexpect` shold / could trigger? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

jmciver added a comment. The regression and test-suite pass using a bootstrap build. I'll provide performance data tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/D134410 __

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands updated this revision to Diff 462392. anderslanglands marked 7 inline comments as done. anderslanglands added a comment. Add testing, address style notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134416/new/ https://reviews.llvm

[PATCH] D134416: Allow getting template args for ClassTemplateSpecializations

anderslanglands added a comment. I ended up modifying c-index-test to print out the template arguments in the same way it does for FunctionDecl, which ends up working all cases in the existing test suite. The only other thing I added was a specific case in index-templates.cpp to check whether i

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

njames93 added a subscriber: kwk. njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/MatchersTest.cpp:2 +#include "utils/Matchers.h" +#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h" + @kwk I seem to recall you saying

<    1   2   3