[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae updated this revision to Diff 462039. python3kgae marked 4 inline comments as done. python3kgae added a comment. Add type check for dispatch thread id. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133983/new/ https://reviews.llvm.org/D

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

python3kgae added a comment. In D133983#3805761 , @aaron.ballman wrote: > There are no tests for applying this to a global variable, so those should be > added. The global variable in the Subjects is wrong. It should be Field. Support for semantic on f

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang added a comment. In D133959#3793283 , @hans wrote: > Could the new flag be marked as an Alias in the tablegen, so that we don't > need to do any code changes for it? It appears before _SLASH_Zl in the file so we'd have to move it out of place.

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

akhuang updated this revision to Diff 462042. akhuang marked an inline comment as done. akhuang added a comment. Change name of flag, and alias /Zl to this flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133959/new/ https://reviews.llvm.org/D13

[clang] 85d97aa - [analyzer] Support implicit parameter 'self' in path note

Author: Jan Korous Date: 2022-09-21T17:26:09-07:00 New Revision: 85d97aac80b8e7689a6d957441054aa817bbb192 URL: https://github.com/llvm/llvm-project/commit/85d97aac80b8e7689a6d957441054aa817bbb192 DIFF: https://github.com/llvm/llvm-project/commit/85d97aac80b8e7689a6d957441054aa817bbb192.diff LO

[PATCH] D133815: [analyzer] Support implicit parameters in path note

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85d97aac80b8: [analyzer] Support implicit parameter 'self' in path note (authored by jkorous). Herald added a project: clang. Herald added a subscrib

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

cfang accepted this revision. cfang added a comment. This revision is now accepted and ready to land. LGTM Should the module flag name be amdgpu_code_object_version or amdhsa_code_object_version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134355/new/ https://reviews.llvm.org/D13435

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:368 +def HasStdExtZcb : Predicate<"Subtarget->hasStdExtZcb()">, + AssemblerPredicate<(all_of FeatureExtZcb), + "'Zcb' (Shortened format for basic bit

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper added a comment. Need to add Zcd command lines to compress-rv32d.s Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoC.td:881 let Predicates = [HasStdExtC, HasStdExtD] in { def : CompressPat<(FLD FPR64:$rd, SP:$rs1, uimm9_lsb000:$imm), CompressPa

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:47 // CHECK-NOT: __riscv_zicbom // CHECK-NOT: __riscv_zicboz Need to update this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D134176: Add MC support of RISCV Zcf Extension

craig.topper added a comment. Need to add zcf command lines to compress-rv32f.s Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcf' (Compressed Single-Precision Floating-Point Instructions)">; +def HasStdExtZcf : Predicate<"Subtarget->hasStdExtZcf()">

[PATCH] D134177: Add MC support of RISCV Zcd Extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:366 + "'Zcd' (Compressed Double-Precision Floating-Point Instructions)">; +def HasStdExtZcd : Predicate<"Subtarget->hasStdExtZcf()">, + AssemblerPredica

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By draft of C23 (https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2912.pdf), the description for isless macro under 7.12.17.3 s

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. Tested with our internal workloads and things look fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D133807: Update Unicode to 15.0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc932cef32aa4: Update Unicode to 15.0 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 327141f - [C++] [Coroutines] Prefer aligned (de)allocation for coroutines -

Author: Chuanqi Xu Date: 2022-09-22T11:28:29+08:00 New Revision: 327141fb1d8ca35b323107a43d57886eb77e7384 URL: https://github.com/llvm/llvm-project/commit/327141fb1d8ca35b323107a43d57886eb77e7384 DIFF: https://github.com/llvm/llvm-project/commit/327141fb1d8ca35b323107a43d57886eb77e7384.diff LO

[PATCH] D133341: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - implement the option2 of P2014R0

This revision was automatically updated to reflect the committed changes. Closed by commit rG327141fb1d8c: [C++] [Coroutines] Prefer aligned (de)allocation for coroutines - (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133341

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:2226 +def fms_omit_default_lib : Joined<["-"], "fms-omit-default-lib">, + Group, Flags<[NoXarchOption, CoreOption]>; defm

[PATCH] D133959: Add clang flag equivalent to clang-cl /Zl flag

mstorsjo added inline comments. Comment at: clang/test/Driver/cl-runtime-flags.c:101 +// RUN: %clang -### --target=x86_64-windows-msvc -fms-runtime-lib=static \ +// RUN: -fms-omit-default-lib-name -- %s 2>&1 | FileCheck \ +// RUN: -check-prefix=CHECK-MTZl %s

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

wlei added a comment. Tested this and confirmed the issue I reported is gone, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 462084. python3kgae added a comment. Remove address space and manual align. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 Files: clang/lib/CodeGen/CGDecl.cpp

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae marked an inline comment as done. python3kgae added a comment. In D130131#3720552 , @beanz wrote: > Now that I'm seeing the code in D131370 , I > don't know that this is the right way to do things. > > I thin

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae updated this revision to Diff 462085. python3kgae added a comment. Remove nested HLSLBuffer and namespace inside HLSLBuffer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130131/new/ https://reviews.llvm.org/D130131 Files: clang/lib/

[PATCH] D134379: [clangd] IncludeCleaner: handle using namespace

ArcsinX added a comment. Anyway if this is the only concern, we can handle namespace declaration as a special case inside `ReferencedLocationCrawler::add()`. something like this: diff -for (const Decl *Redecl : D->redecls()) - Result.User.insert(Redecl->getLocation()); +if (

<    1   2   3