[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:538 + CallExpr::const_arg_range Args) { +for (const auto &[Param, Arg] : llvm::zip(FD->parameters(), Args)) { + if (!Param->getType()->isReference

[clang] e12f6c2 - [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

Author: Volodymyr Sapsai Date: 2022-09-20T17:55:37-07:00 New Revision: e12f6c26c394bd5b49e7c1e1c157bcee3a33d1de URL: https://github.com/llvm/llvm-project/commit/e12f6c26c394bd5b49e7c1e1c157bcee3a33d1de DIFF: https://github.com/llvm/llvm-project/commit/e12f6c26c394bd5b49e7c1e1c157bcee3a33d1de.di

[PATCH] D134249: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

This revision was automatically updated to reflect the committed changes. Closed by commit rGe12f6c26c394: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap… (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D134249?vs=461435&id=461770#toc Repos

[PATCH] D134249: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

vsapsai marked an inline comment as done. vsapsai added a comment. Thanks for the review! Comment at: clang/lib/Serialization/ModuleManager.cpp:284-286 for (ModuleIterator victim = First; victim != Last; ++victim) { Modules.erase(victim->File); } Chu

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PCH supported f

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. The build still fails. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added a comment. > The build still fails. I think it might be an infrastructure issue or something like that--I've tried restarting it a few times and each time it just ends with "HTTP 28" as the only message I see. Another review that was created a bit ago (https://reviews.llvm.or

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. In D130513#3804659 , @jpenix-quic wrote: >> The build still fails. > > I think it might be an infrastructure issue or something like that--I've > tried restarting it a few times and each time it just ends with "HTTP 28" as > the

[clang] 669e508 - [Driver] Fix -f[no-]unwind-tables -Wunused-command-line-argument after 4388b56d525c08ce3cf941cfbad2428b0e1695b0

Author: Fangrui Song Date: 2022-09-20T20:13:30-07:00 New Revision: 669e508772e5e00db6285d699ee82a428dc00f32 URL: https://github.com/llvm/llvm-project/commit/669e508772e5e00db6285d699ee82a428dc00f32 DIFF: https://github.com/llvm/llvm-project/commit/669e508772e5e00db6285d699ee82a428dc00f32.diff

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134271/new/ https://reviews.llvm.org/D134271 ___ cfe-commits mailing list cfe

[PATCH] D134269: [docs] Document the one-phase style compilation to c++ standard modules

ChuanqiXu updated this revision to Diff 461782. ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134269/new/ https://reviews.llvm.org/D134269 Files: clang/docs/StandardCPlusPlusModules.rst Index: c

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. When attempting to decide if in C++17 a type template for class template argument deduction and the code is ill-formed the condition to break is

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

zzyyyl added a comment. What if `concept c = (bool)(...)` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134325/new/ https://reviews.llvm.org/D134325 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 461790. to268 marked 2 inline comments as done. to268 added a comment. I've added more test cases, added a diagnostic when using `auto` in compound literals and advised fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3db2917e2706: [clang] [docs] Improve formatting & fix typo in config docs (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[clang] 3db2917 - [clang] [docs] Improve formatting & fix typo in config docs

Author: Michał Górny Date: 2022-09-21T07:26:56+02:00 New Revision: 3db2917e270673be281547ec80796dc6f254be82 URL: https://github.com/llvm/llvm-project/commit/3db2917e270673be281547ec80796dc6f254be82 DIFF: https://github.com/llvm/llvm-project/commit/3db2917e270673be281547ec80796dc6f254be82.diff

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 added a comment. Also i have found that we don't parse the compound literal with the `auto` keyword correctly in `ParseExpr.cpp` between line 939 to 973 which is the beginning of `Parser::ParseCastExpression(...)` int test_cl = (int){12}; // Compound literal is detected auto test

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

sepavloff added a comment. What about the case, when executable file has a target prefix (so implicit config file may be used) and the option `--config` is specified in command line? Now this case becomes possible and we should either reject it (because explicit config files have precedence) or

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16733 + while (auto *BaseCast = dyn_cast(BaseExpr)) +BaseExpr = BaseCast->getSubExpr(); +} There is `Expr::ignoreParenImpCasts()` or `Expr::ImpCasts()` that should do this

[PATCH] D134020: [clang][Interp] Handle enums

tbaeder added a comment. Anything still missing here? (CI failure is because one of the other patches is missing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134020/new/ https://reviews.llvm.org/D134020 _

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. In D134270#3804855 , @sepavloff wrote: > What about the case, when executable file has a target prefix (so implicit > config file may be used) and the option `--config` is specified in command > line? Now this case becomes possib

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

glandium added a comment. This didn't change the default for msvc targets, was that expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 ___ cfe-commits ma

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch updated this revision to Diff 461799. t-8ch added a comment. - [analyzer] Treat values passed as parameter as escaped - [analyzer][deadstores] Handle member operator calls Handle calls to member operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp:538 + CallExpr::const_arg_range Args) { +for (const auto &[Param, Arg] : llvm::zip(FD->parameters(), Args)) { + if (!Param->getType()->isReferen

<    1   2   3