[PATCH] D134297: [HLSL] add sqrt library function

bob80905 created this revision. bob80905 added a reviewer: bob80905. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the sqrt library function f

[PATCH] D131479: Handle explicitly defaulted consteval special members.

Mordante added a comment. In D131479#3755266 , @aaron.ballman wrote: > In D131479#3753586 , @Mordante > wrote: > >> So I think there's indeed a bug in libc++ which was hidden since Clang >> hadn't implemented s

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: LLVM. Herald added subscribers: abrachet, hiraditya. Herald added a project: All. leonardchan requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

jyu2 added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:351 +// CHECK: omp_offload.failed: +// CHECK-NEXT:call void @{{__omp_offloading_[0-9a-z]+_[0-9a-z]+}}_main_l145(i32* [[TMP2]]) #[[ATTR5:[0-9]+]] +// CHECK-NEXT:br label [[

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added a comment. @phosek feel free to add who you think is appropriate for reviewing this. This is a conservative comparison of dso_local_equivalents where two are the same only if they point to the same underlying function. It could be argued that a `dso_local_equivalent @func` cou

[clang] 6257832 - [clang-format] Wrap inserted braces only if preceded by comments

Author: owenca Date: 2022-09-20T12:09:39-07:00 New Revision: 6257832bf94fbd83836ee3616480d815a1fdfbf3 URL: https://github.com/llvm/llvm-project/commit/6257832bf94fbd83836ee3616480d815a1fdfbf3 DIFF: https://github.com/llvm/llvm-project/commit/6257832bf94fbd83836ee3616480d815a1fdfbf3.diff LOG: [

[PATCH] D134233: [clang-format] Wrap inserted braces only if preceded by comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG6257832bf94f: [clang-format] Wrap inserted braces only if preceded by comments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134233/ne

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

nikic added a comment. Please drop the clang test and use update_test_checks.py for LLVM tests. Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1 +;; Check the cases involving dso_local_equivalent where we do expect functions to be merged. +; RUN: opt

[PATCH] D133438: change SM target to 6.2, that's when fnative-half-type was introduced

bob80905 updated this revision to Diff 461654. bob80905 added a comment. - merge hlsl_intr.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133438/new/ https://reviews.llvm.org/D133438 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/

[PATCH] D134302: [pseudo] Don't misparse ... as an abstract declarator in template argument.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The motivation is to eliminate a false ambiguous parse of tempalte-arugment-l

[PATCH] D132711: [HLSL] add sqrt library function

bob80905 updated this revision to Diff 461656. bob80905 added a comment. Include previous commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/t

[PATCH] D132711: [HLSL] add sqrt library function

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 ___ c

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputBackend in CompilerInstance

dexonsmith abandoned this revision. dexonsmith added a comment. Herald added a project: All. This is superseded by https://reviews.llvm.org/D133509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95502/new/ https://reviews.llvm.org/D95502 ___

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo updated this revision to Diff 461661. abidmalikwaterloo marked 2 inline comments as done. abidmalikwaterloo added a comment. Updated the PrintStmt.cpp according to the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/n

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, urnathan. Herald added subscribers: kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Her

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

beanz created this revision. beanz added reviewers: pow2clk, python3kgae. Herald added a subscriber: Anastasia. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. HLSL uses a variety of named IR metadata and attributes to convey additional informat

[PATCH] D122255: Meta directive runtime support

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:19 #include "clang/Basic/LLVM.h" +#include "clang/AST/StmtOpenMP.h" // #include "clang/Basic/OpenMPKinds.h" Remove empty comment Comment at: clang/lib/AST/OpenMPClause.

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a comment. I just saw this touches the same code as @urnathan's D134283 , specifically `Sema::ActOnUsingEnumDeclaration`. I'm happy to wait for that to land and then merge, I think these will play nicely together. The changes to the actual Usin

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. One small nit, otherwise looks good. Comment at: clang/include/clang/Sema/HLSLExternalSemaSource.h:18 #include "clang/Sema/ExternalSemaSource.h" +#include "clang/Sema/Multiple

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:948-956 +if (getLangOpts().CPlusPlus) { + Diag(Tok, getLangOpts().CPlusPlus2b +? diag::warn_cxx20_compat_label_end_of_compound_statement +: diag::ext_cx

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

dblaikie added a comment. Which patch needs review, this one or D133875 ? Or are they both relevant? (their names are basically identical, so I'm not sure which is needed/how they're different) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat abandoned this revision. azat added a comment. > Which patch needs review, this one or D133875 > ? Or are they both relevant? Sorry, wrote in the wrong thread. The only patch that needs review is resubmitted version - https://reviews.llvm.org/D133875 > (t

[PATCH] D134268: [Clang][OpenMP] Codegen generation for has_device_addr claues.

abhinavgaba accepted this revision. abhinavgaba added a comment. This revision is now accepted and ready to land. Thanks, Jennifer. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134268/new/ https://reviews.llvm.org/D134268 __

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay added a comment. If the two patches are basically identical with just some fixes for the problem, the convention is to reuse the original Differential. You can click "Add Action - Open" (or Reopen?), then you can upload a new patch to update the Differential. This keeps all discussions i

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman marked 13 inline comments as done. aaron.ballman added a comment. In D134286#3803077 , @erichkeane wrote: > I'm on the fence about re-using the same nodes for `typeof` and > `typeof_unqual`. However, I have a preference to stop shuffling

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman updated this revision to Diff 461673. aaron.ballman marked 8 inline comments as done. aaron.ballman added a comment. Addressing review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132711: [HLSL] add sqrt library function

bob80905 updated this revision to Diff 461674. bob80905 added a comment. - add empty line to end of file sqrt.hlsl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/lib/Headers/hlsl/hlsl_intr

[clang-tools-extra] 8a13119 - [clangd] Remove second tracer (which breaks threading contract)

Author: Sam McCall Date: 2022-09-20T22:17:34+02:00 New Revision: 8a131190070152ffb0a27ab5dd14d98052467aa9 URL: https://github.com/llvm/llvm-project/commit/8a131190070152ffb0a27ab5dd14d98052467aa9 DIFF: https://github.com/llvm/llvm-project/commit/8a131190070152ffb0a27ab5dd14d98052467aa9.diff LO

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman updated this revision to Diff 461675. aaron.ballman added a comment. Really update, don't just kinda sorta update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134286/new/ https://reviews.llvm.org/D134286 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/AST

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

barcisz added a comment. @njames93 What would be the best way to write up those tests here? I feel like writing a custom check to test the matcher each time we want to test one would be quite wasteful, but at the same time what would be the best way to invoke clang's frontend without using `too

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12910-12916 +// FIXME:: is this assumption correct or do we need to do work here to find +// the common type sugar regarding the stripped qualifiers if only one side +// is unqual? +asse

[clang] 549231d - [RISCV] Support -mno-implicit-float.

Author: Craig Topper Date: 2022-09-20T13:32:40-07:00 New Revision: 549231d38e10de7371adb85f5452d42ad42f4201 URL: https://github.com/llvm/llvm-project/commit/549231d38e10de7371adb85f5452d42ad42f4201 DIFF: https://github.com/llvm/llvm-project/commit/549231d38e10de7371adb85f5452d42ad42f4201.diff

[PATCH] D134077: [RISCV] Support -mno-implicit-float.

This revision was automatically updated to reflect the committed changes. Closed by commit rG549231d38e10: [RISCV] Support -mno-implicit-float. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134077/new/ https://reviews.llv

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

python3kgae added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:12 +The goal of this document is to provide a reference for all the special purpose +IR metadata and attributes used by the HLSL code generation path. + Once we document a metadata

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

beanz added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:12 +The goal of this document is to provide a reference for all the special purpose +IR metadata and attributes used by the HLSL code generation path. + python3kgae wrote: > Once we docu

[PATCH] D134286: [C2x] implement typeof and typeof_unqual

erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:1902 AutoTypeBitfields AutoTypeBits; +TypeOfBitfields TypeOfBits; BuiltinTypeBitfields BuiltinTypeBits; So the downside to doing the bitfields is that EVERY 'Type' pays for

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan updated this revision to Diff 461686. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 Files: llvm/lib/Transforms/Utils/FunctionComparator.cpp llvm/test/Transforms/MergeFunc/dso_local_equival

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added inline comments. Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1 +;; Check the cases involving dso_local_equivalent where we do expect functions to be merged. +; RUN: opt -S -mergefunc < %s | FileCheck %s nikic wrote

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. In D131424#3803190 , @mwyman wrote: > Hi Akira, > > I'd reached out to John offline and he'd mentioned you might be able to help > on some of these objc_direct reviews; if so, that would be wonderful! > > -Michael I would also be

[clang] b95c574 - [HLSL] add sqrt library function

Author: Joshua Batista Date: 2022-09-20T15:42:08-05:00 New Revision: b95c57444a8ac3f81bc33a3d52d0f88b7a592a2f URL: https://github.com/llvm/llvm-project/commit/b95c57444a8ac3f81bc33a3d52d0f88b7a592a2f DIFF: https://github.com/llvm/llvm-project/commit/b95c57444a8ac3f81bc33a3d52d0f88b7a592a2f.diff

[PATCH] D132711: [HLSL] add sqrt library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb95c57444a8a: [HLSL] add sqrt library function (authored by bob80905, committed by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

python3kgae added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:20 + +The ``hlsl.uavs`` metadata is a list of all the global variables that represent +to UAV resources. Maybe only external global variables? Repository: rG LLVM Github Monor

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

msebor created this revision. msebor added a reviewer: aaron.ballman. Herald added a project: All. msebor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The discussion in PR #57687 turne

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

beanz added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:20 + +The ``hlsl.uavs`` metadata is a list of all the global variables that represent +to UAV resources. python3kgae wrote: > Maybe only external global variables? > Do they have to be

[PATCH] D134137: [clangd] Return earlier when snippet is empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG60528c690a4c: [clangd] Return earlier when snippet is empty (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang-tools-extra] 60528c6 - [clangd] Return earlier when snippet is empty

Author: Tom Praschan Date: 2022-09-21T00:45:26+02:00 New Revision: 60528c690a4c334d2a3a2c22eb97af9e67d7a91d URL: https://github.com/llvm/llvm-project/commit/60528c690a4c334d2a3a2c22eb97af9e67d7a91d DIFF: https://github.com/llvm/llvm-project/commit/60528c690a4c334d2a3a2c22eb97af9e67d7a91d.diff

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. > If the two patches are basically identical with just some fixes for the > problem, the convention is to reuse the original Differential. Ok, did not know that, will keep it in mind, thanks! > You can click "Add Action - Open" (or Reopen?), then you can upload a new > pa

[PATCH] D132711: [HLSL] add sqrt library function

python3kgae added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_intrinsics.h:18 +// abs builtins +__attribute__((clang_builtin_alias(__builtin_abs))) int abs(int In); +__attribute__((clang_builtin_alias(__builtin_labs))) int64_t abs(int64_t In); This s

[PATCH] D134137: [clangd] Return earlier when snippet is empty

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1017 +TEST(CompletionTests, EmptySnippetDoesNotCrash) { +// See https://github.com/clangd/clangd/issues/1216 nridge wrote: > tom-anders wrote: > > tom-and

[PATCH] D133834: [RISCV] Remove support for the unratified Zbt extension.

reames accepted this revision. reames added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133834/new/ https://reviews.llvm.org/D133834 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D134304: [Docs] [HLSL] Add IR reference for HLSL

python3kgae added inline comments. Comment at: clang/docs/HLSL/HLSLIRReference.rst:20 + +The ``hlsl.uavs`` metadata is a list of all the global variables that represent +to UAV resources. beanz wrote: > python3kgae wrote: > > Maybe only external global variables?

[PATCH] D133586: [clang] initialize type qualifiers for FunctionNoProtoType

rmaz updated this revision to Diff 461689. rmaz edited the summary of this revision. rmaz added a comment. Add unit test for type qualifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586 Files: clang/

[PATCH] D134312: [HLSL] remove unnecessary abs attributes

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. remove abs non-elementwise attribute s

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 461695. python3kgae marked 2 inline comments as done. python3kgae added a comment. Move #include "clang/Sema/MultiplexExternalSemaSource.h" into FrontendAction.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 461699. ayzhao added a comment. rebase + clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/i

[PATCH] D134312: [HLSL] remove unnecessary abs attributes

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Doh... I should have caught this before I pushed your last change. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134312/new/ https://revie

[PATCH] D134312: [HLSL] remove unnecessary abs attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd76c654d02b6: [HLSL] remove unnecessary abs attributes (authored by bob80905, committed by beanz). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] d76c654 - [HLSL] remove unnecessary abs attributes

Author: Joshua Batista Date: 2022-09-20T16:04:21-05:00 New Revision: d76c654d02b66d8ec695d531d82a482224f21c79 URL: https://github.com/llvm/llvm-project/commit/d76c654d02b66d8ec695d531d82a482224f21c79 DIFF: https://github.com/llvm/llvm-project/commit/d76c654d02b66d8ec695d531d82a482224f21c79.diff

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 ___

[PATCH] D134314: [HIP] stop forcing the lang std in the driver

scchan created this revision. scchan added a reviewer: yaxunl. Herald added a project: All. scchan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. D103221 changed HIP's default to C++14, removing

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

msebor added inline comments. Comment at: clang/test/Sema/unbounded-array-bounds.c:101 + char tail[1]; // addr16-note {{declared here}} addr32-note {{declared here}} +} fam1; + There's a difference between the sizes of `fam1` and `fam` that makes accesses to t

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:208 + // ctors/dtors added for entry. + Triple T(M.getTargetTriple()); + if (T.getEnvironment() != Triple::EnvironmentType::Library) { I question whether we should do this early or la

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

jloser created this revision. jloser added reviewers: RKSimon, nikic, fhahn. Herald added a project: All. jloser requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The docs mention that `__builtin_reduce_add` and `__builtin_reduce_mul` support

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:208 + // ctors/dtors added for entry. + Triple T(M.getTargetTriple()); + if (T.getEnvironment() != Triple::EnvironmentType::Library) { -

[PATCH] D134318: [clang][dataflow] Remove deprecated `transfer(const Stmt *, ...)` API.

wyt created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D134319: [HLSL] add ceil library function

bob80905 created this revision. bob80905 added a reviewer: beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the ceil library function for

[clang] 45c7da2 - [PS4] Always enable the .debug_aranges section when using LTO

Author: Matthew Voss Date: 2022-09-20T14:44:56-07:00 New Revision: 45c7da241f124d49abdc0598d381d96d15918834 URL: https://github.com/llvm/llvm-project/commit/45c7da241f124d49abdc0598d381d96d15918834 DIFF: https://github.com/llvm/llvm-project/commit/45c7da241f124d49abdc0598d381d96d15918834.diff

[PATCH] D134296: [SIE] Always enable the .debug_aranges section when using LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45c7da241f12: [PS4] Always enable the .debug_aranges section when using LTO (authored by ormris). Herald added a subscriber: cfe-commits. Repository

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:208 + // ctors/dtors added for entry. + Triple T(M.getTargetTriple()); + if (T.getEnvironment() != Triple::EnvironmentType::Library) { python3kgae wrote: > beanz wrote: > > I question

[PATCH] D134319: [HLSL] add ceil library function

beanz added a comment. For this builtin you should be able to use `__builtin_elementwise_ceil` for all the overload cases, and you should be able to add the vector cases too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://review

[PATCH] D133801: Extraction of a matcher for an unused value from an expression from the bugprone-unused-return-value check

barcisz updated this revision to Diff 461721. barcisz added a comment. Tests for the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133801/new/ https://reviews.llvm.org/D133801 Files: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueC

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae marked 4 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:208 + // ctors/dtors added for entry. + Triple T(M.getTargetTriple()); + if (T.getEnvironment() != Triple::EnvironmentType::Library) { -

[PATCH] D134249: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

bnbarham accepted this revision. bnbarham added a comment. LGTM. > When we try to load such outdated .pcm file, we shouldn't change any already > loaded and processed modules. Or to put another way - we can't remove these modules because they may already have references... anywhere. Reposito

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 461725. bob80905 added a comment. - add elementwise function tests. Remove integer tests, ceil will not take integer types as an arg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.l

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 461727. bob80905 added a comment. - remove int attribute links in hlsl_intrinsics.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/h

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG079a5ffb0a3f: [HLSL] Support PCH for cc1 mode (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/

[clang] 079a5ff - [HLSL] Support PCH for cc1 mode

Author: Xiang Li Date: 2022-09-20T15:13:43-07:00 New Revision: 079a5ffb0a3f862bee3076f785d5c71c03e14f00 URL: https://github.com/llvm/llvm-project/commit/079a5ffb0a3f862bee3076f785d5c71c03e14f00 DIFF: https://github.com/llvm/llvm-project/commit/079a5ffb0a3f862bee3076f785d5c71c03e14f00.diff LOG:

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 461729. ayzhao marked 2 inline comments as done. ayzhao added a comment. remove PrevLookupResult + put Declarator(...) and ~Declarator() definitions back in the header files to reduce the diff since we're no longer overloading the constructor. Repository:

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

mizvekov added a comment. In D133468#3803449 , @sammccall wrote: > The descriptions here are pretty general and opaque nad it's hard to follow > what this means in practice. > It sounds like the motivating cases are to do with template instantiation - >

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:1918 + /// Lookup result of declarator, if any. + std::unique_ptr PrevLookupResult; + shafik wrote: > Why do we need this one shot previous lookup result? I am struggling to see > th

[PATCH] D133108: [clang] Rework IsTailPaddedMemberArray into isFlexibleArrayMemberExpr

msebor added inline comments. Comment at: clang/test/Sema/unbounded-array-bounds.c:101 + char tail[1]; // addr16-note {{declared here}} addr32-note {{declared here}} +} fam1; + msebor wrote: > There's a difference between the sizes of `fam1` and `fam` that make

[clang] c493d49 - [clang] Fix missing template arguments in AST of access to member variable template

Author: Matheus Izvekov Date: 2022-09-21T00:46:18+02:00 New Revision: c493d49cefeefa87532a2987a776b5433265e49f URL: https://github.com/llvm/llvm-project/commit/c493d49cefeefa87532a2987a776b5433265e49f DIFF: https://github.com/llvm/llvm-project/commit/c493d49cefeefa87532a2987a776b5433265e49f.dif

[PATCH] D134295: [clang] Fix missing template arguments in AST of access to member variable template

This revision was automatically updated to reflect the committed changes. Closed by commit rGc493d49cefee: [clang] Fix missing template arguments in AST of access to member variable… (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D134319: [HLSL] add ceil library function

python3kgae added inline comments. Comment at: clang/lib/Headers/hlsl/hlsl_intrinsics.h:18 // abs builtins -__attribute__((clang_builtin_alias(__builtin_abs))) int abs(int In); -__attribute__((clang_builtin_alias(__builtin_labs))) int64_t abs(int64_t In); The ch

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 461739. bob80905 added a comment. Herald added subscribers: llvm-commits, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, mravishankar, teijeong, rdzhabarov, tatianashp, ThomasRaoux, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufeng

[PATCH] D134311: [clang] handle extended integer constant expressions in _Static_assert (PR #57687)

msebor updated this revision to Diff 461744. msebor added a comment. Update to the latest diff that didn't get picked up in the first submission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134311/new/ https://reviews.llvm.org/D134311 Files: c

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 461747. bob80905 added a comment. fix attempt 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h Index: clang/lib/

[PATCH] D134319: [HLSL] add ceil library function

bob80905 updated this revision to Diff 461749. bob80905 added a comment. fix attempt 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134319/new/ https://reviews.llvm.org/D134319 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/CodeGe

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 461751. python3kgae added a comment. Rebase for the PCH fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 Files: clang/include/clang/AST/Decl.h clang/inclu

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay, curdeius. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The comment handling the bool case says: "bool

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 461753. jpenix-quic added a comment. Address comments from @awarzynski, @rovka, and @peixin. Also fixed the file header comments for EnvironmentDefaults.h, environment-defaults.h, and environment-default-list.h to match others in their respective folders

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

haowei added a comment. I am a bit puzzled by the intent of cleaning up the constructors in Info object. I didn't see it as an issue to have multiple constructors, which is a common practice. After this clean up It doesn't make it easier to use these objects, in fact, in `Serialize.cpp`, you ha

[PATCH] D134326: [HLSL] Allow SV_GroupIndex for lib profile.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner, bob80905. Herald added subscribers: Anastasia, arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 461759. jpenix-quic marked an inline comment as done. jpenix-quic added a comment. Move comment, see if build will cooperate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 Files: clang/include/clan

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic marked 5 inline comments as done. jpenix-quic added inline comments. Comment at: flang/test/Driver/convert.f90:1 +! Ensure argument -fconvert= works as expected. + awarzynski wrote: > rovka wrote: > > Nit: Shouldn't you also check that valid values (e

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix braces and

[PATCH] D134296: [SIE] Always enable the .debug_aranges section when using LTO

chapuni added a comment. A warning can be seen in -Asserts. Comment at: clang/lib/Driver/ToolChains/PS4CPU.cpp:160 const bool IsPS5 = TC.getTriple().isPS5(); assert(IsPS4 || IsPS5); IsPS5 is used only here. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ added a comment. Hi, looks great! I found a couple of typos and the amount of changes in tests is suspiciously low. And I want to make sure that the promise to change "arg" -> "argument" isn't lost (but I'll be happy if it's addressed in a follow-up patch). Comment at: c

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM! Thanks again for your investigation. And patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030

[clang] 7a23920 - [clang] Fix an unused variable warning

Author: Kazu Hirata Date: 2022-09-20T17:41:58-07:00 New Revision: 7a239200e673c4e4c0c6d87cd35bce5bac2d44a7 URL: https://github.com/llvm/llvm-project/commit/7a239200e673c4e4c0c6d87cd35bce5bac2d44a7 DIFF: https://github.com/llvm/llvm-project/commit/7a239200e673c4e4c0c6d87cd35bce5bac2d44a7.diff L

<    1   2   3   >