[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

Ericson2314 updated this revision to Diff 459968. Ericson2314 added a comment. Rebase on top of D133828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: bolt/lib

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Ericson2314 updated this revision to Diff 459975. Ericson2314 added a comment. Require `LLVM_LIBDIR_SUFFIX` in the sed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: clang/cmake/modules/CMakeLis

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf712c0131f3b: [HLSL]Add -O and -Od option for dxc mode. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D128845?vs=459883&id=459977#toc Repository: rG LLVM Github Monorep

[clang] f712c01 - [HLSL]Add -O and -Od option for dxc mode.

Author: Xiang Li Date: 2022-09-13T21:26:18-07:00 New Revision: f712c0131f3b2d7b95ff4e21e8050943c01565d6 URL: https://github.com/llvm/llvm-project/commit/f712c0131f3b2d7b95ff4e21e8050943c01565d6 DIFF: https://github.com/llvm/llvm-project/commit/f712c0131f3b2d7b95ff4e21e8050943c01565d6.diff LOG:

[PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Ericson2314 added a comment. I think I fixed the issue: I was confusing `/lib` stemming from lib subdirs in the source and `/lib` stemming from building things in a lib directory that will later be installed also to a lib directory. It is just the latter case that uses the suffix, and so just t

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 459985. Ericson2314 marked 4 inline comments as done. Ericson2314 added a comment. Rebase, avoid sed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: bolt

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added inline comments. Comment at: cmake/Modules/GNUBinaryDirs.cmake:3 + get_filename_component(CMAKE_LIBDIR_BASENAME "${CMAKE_INSTALL_LIBDIR}" NAME) +endif() + compnerd wrote: > Should this perhaps be moved further down near the usage? Sure ==

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:4516 + bool HasTimeTrace = C.getArgs().hasArg(options::OPT_ftime_trace); + bool HasTimeTraceFile = C.getArgs().hasArg(options:

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Sorry, we should compare this approach with D133662 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 marked 6 inline comments as done. to268 added a comment. In D133289#3784042 , @aaron.ballman wrote: > auto auto k = 12; // 99% this is intended to be accepted; first `auto` is > the storage class specifier, second `auto` is a redundant storage c

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

MaskRay added a comment. At a glance the approach looks more elegant to me, but I haven't studied this carefully yet. Also thanks for checking how to handle offloading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133662/new/ https://reviews.llvm

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Compilation.h:134 + + llvm::SmallDenseMap TimeTraceFiles; + I don't think we should use a non-zero inline element for these members. They are, in 99.9% cases, empty. We should optimize for th

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4516 + bool HasTimeTrace = C.getArgs().hasArg(options::OPT_ftime_trace); + bool HasTimeTraceFile = C.getArgs().hasArg(options::OPT_ftime_trace_EQ); + // Whether `-ftime-trace` or `-ftime-trace=` are spec

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. Hm, by some reason on CI there is `lld`, any clue? (I've looked through other tests, and cannot find anything different that will show path to lld or require it explicitly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added a comment. > ~sort of. The process is described here: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Yep, already looked through it, thanks for the link. > But generally not every developer is immediately aware of who has/doesn't > have commit access - so if yo

<    1   2   3