[clang] 2f7da9d - [Driver] Remove cc1 Separate form -fvisibility

Author: Fangrui Song Date: 2022-09-02T12:40:00-07:00 New Revision: 2f7da9d317c9e390aee1f68cdcf4da48e180aec4 URL: https://github.com/llvm/llvm-project/commit/2f7da9d317c9e390aee1f68cdcf4da48e180aec4 DIFF: https://github.com/llvm/llvm-project/commit/2f7da9d317c9e390aee1f68cdcf4da48e180aec4.diff

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 457678. azat added a comment. v3: test only linux (to avoid failures on windows) v4: add a comment about SCE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: cla

[clang] 00ecacc - [HLSL] Generate buffer subscript operators

Author: Chris Bieneman Date: 2022-09-02T14:55:43-05:00 New Revision: 00ecacca7d90f96a1d54bc3fa38986fdd64e4c72 URL: https://github.com/llvm/llvm-project/commit/00ecacca7d90f96a1d54bc3fa38986fdd64e4c72 DIFF: https://github.com/llvm/llvm-project/commit/00ecacca7d90f96a1d54bc3fa38986fdd64e4c72.diff

[PATCH] D131268: [HLSL] Generate buffer subscript operators

This revision was automatically updated to reflect the committed changes. Closed by commit rG00ecacca7d90: [HLSL] Generate buffer subscript operators (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D131268?vs=456774&id=457681#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D133229: [driver] Prune module-map related flags, if they are not going to be needed

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is follow-up from https://reviews.llvm.org/D132801, but taking into account the conditions where the module-ma

[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

akyrtzi added a comment. In D132801#3761253 , @akyrtzi wrote: > In D132801#3760014 , @rsmith wrote: > >> This doesn't look right to me -- we still use module maps when modules are >> disabled to enforce layering

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

pmor13 added a comment. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 457684. python3kgae added a comment. Rebase to use MultiplexExternalSemaSource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/clang/Sema/

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae added inline comments. Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:78 + // ExternalAST path. + // PrevRecord->setHasExternalLexicalStorage(); + if (PrevRecord->isCompleteDefinition()) { If comment this line out. Th

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457685. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/Driver.cpp clang/test/Dr

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1687 +def fexperimental_sanitize_metadata_EQ : CommaJoined<["-"], "fexperimental-sanitize-metadata=">, + Group, + HelpText<"Specify the type of metadata to emit for

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

efriedma added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2457 +/*IsVectorCall=*/false, /*IsRegCall=*/false); + } + rjmccall wrote: > Hmm. Doesn't EC ABI lowering need to preserve this same state, or else > you'll get inc

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt added a comment. I was talking to @reames about this. The spec has changed since I posted these patches: there's now two instructions (wrs.nto and wrs.sto) and there's no longer a register to encode the timeout. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/

[PATCH] D133236: [Clang][Tools] Use utf-8 for JSON object load

kaitingwang created this revision. kaitingwang added reviewers: djasper, sammccall, ldrumm, vsk. kaitingwang added a project: clang-format. Herald added subscribers: Naghasan, Anastasia. Herald added a project: All. kaitingwang requested review of this revision. Herald added a project: clang. Heral

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

alexander-shaposhnikov added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133197/new/ https://reviews.llvm.org/D133197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] 3bbdf06 - [clang-format] Fix annotating when deleting array of pointers

Author: jackh Date: 2022-09-03T05:56:49+08:00 New Revision: 3bbdf06b28275a56ad36a844d271d84956d1d7e9 URL: https://github.com/llvm/llvm-project/commit/3bbdf06b28275a56ad36a844d271d84956d1d7e9 DIFF: https://github.com/llvm/llvm-project/commit/3bbdf06b28275a56ad36a844d271d84956d1d7e9.diff LOG: [c

[PATCH] D132911: [clang-format] Fix annotating when deleting array of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bbdf06b2827: [clang-format] Fix annotating when deleting array of pointers (authored by jackh ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang-tools-extra] 47dbacb - [clang-tidy] Restrict use-equals-default to c++11-or-later

Author: Alexander Shaposhnikov Date: 2022-09-02T22:19:11Z New Revision: 47dbacbc8ae2c13f970096814de8f677d80859af URL: https://github.com/llvm/llvm-project/commit/47dbacbc8ae2c13f970096814de8f677d80859af DIFF: https://github.com/llvm/llvm-project/commit/47dbacbc8ae2c13f970096814de8f677d80859af.d

[PATCH] D132998: [clang-tidy] Restrict use-equals-default to c++11-or-later

This revision was automatically updated to reflect the committed changes. Closed by commit rG47dbacbc8ae2: [clang-tidy] Restrict use-equals-default to c++11-or-later (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm.org/D132998?vs=456876&id=457715#toc Reposito

[clang] b514793 - [analyzer] Add more information to the Exploded Graph

Author: isuckatcs Date: 2022-09-03T00:21:05+02:00 New Revision: b5147937b2a9ffdc12110a5df5ba4d482f83d2a8 URL: https://github.com/llvm/llvm-project/commit/b5147937b2a9ffdc12110a5df5ba4d482f83d2a8 DIFF: https://github.com/llvm/llvm-project/commit/b5147937b2a9ffdc12110a5df5ba4d482f83d2a8.diff LOG

[PATCH] D131187: [analyzer] Add more information to the Exploded Graph

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5147937b2a9: [analyzer] Add more information to the Exploded Graph (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo C

Re: [PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

Arnd mentions on IRC: 1:38 AM ndesaulniers: I just looked at the patch and found that the list of supported targets still includes armv5 and armve (both without t), which never existed in hardware and were removed from gcc a while ago 1:38 AM might be good to take them out here as well 1:38 AM

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

ahatanak updated this revision to Diff 457720. ahatanak added a comment. Deactivate the cleanup that was pushed in `EmitParmDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131701/new/ https://reviews.llvm.org/D131701 Files: clang/lib/CodeGe

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 457723. vsapsai added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Serialization

[PATCH] D133006: [clang-tidy] Skip copy assignment operators with nonstandard return types

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7395b860bc2: [clang-tidy] Skip copy assignment operators with nonstandard return types (authored by alexander-shaposhnikov). Changed prior to commit: https://reviews.llvm.org/D133006?vs=456902&id=45772

[clang-tools-extra] a7395b8 - [clang-tidy] Skip copy assignment operators with nonstandard return types

Author: Alexander Shaposhnikov Date: 2022-09-02T22:43:39Z New Revision: a7395b860bc247c9e4e917bf5786c04d4cccf1d7 URL: https://github.com/llvm/llvm-project/commit/a7395b860bc247c9e4e917bf5786c04d4cccf1d7 DIFF: https://github.com/llvm/llvm-project/commit/a7395b860bc247c9e4e917bf5786c04d4cccf1d7.d

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao added a comment. In D53847#3745415 , @royjacobson wrote: > I looked at this a bit about a week ago and got it down to 3-4 tests failing, > but I'm not sure how much time I'll have to continue working on it. If one of > you wants to take over I'll

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3767146 , @aaron.ballman wrote: > In D133066#3765503 , @zhouyizhou > wrote: > >> In D133066#3764384 , >> @aaron.ballman wrote: >>

[clang] b484256 - Add driver test for -fmodule-name and -fmodule-map-file use without -fmodules.

Author: Richard Smith Date: 2022-09-02T16:08:30-07:00 New Revision: b484256f59850e702df4d4532c5f31f478879bb9 URL: https://github.com/llvm/llvm-project/commit/b484256f59850e702df4d4532c5f31f478879bb9 DIFF: https://github.com/llvm/llvm-project/commit/b484256f59850e702df4d4532c5f31f478879bb9.diff

[PATCH] D133229: [driver] Prune module-map related flags, if they are not going to be needed

rsmith added a comment. I've landed some tests for the specific functionality that intends to use modules info under `-fno-modules` in b484256f59850e702df4d4532c5f31f478879bb9 . I think the approach you're taking here is proba

[clang] 246c5a9 - [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

Author: Volodymyr Sapsai Date: 2022-09-02T16:20:05-07:00 New Revision: 246c5a994b753fb52b2d3b70687039afef7a106e URL: https://github.com/llvm/llvm-project/commit/246c5a994b753fb52b2d3b70687039afef7a106e DIFF: https://github.com/llvm/llvm-project/commit/246c5a994b753fb52b2d3b70687039afef7a106e.di

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG246c5a994b75: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into… (authored by vsapsai). Repository: rG LLVM Github Mo

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

var-const added a comment. Out of curiosity, would it be possible to do a benchmark to see how adding `_LIBCPP_NODEBUG` to `std::invoke` would compare to using builtins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llv

[PATCH] D133229: [driver] Prune module-map related flags, if they are not going to be needed

akyrtzi added a comment. In D133229#3768101 , @rsmith wrote: > I think the approach you're taking here is probably doomed -- too many things > in Clang depend on whether we've read module map files, and it seems unlikely > to me that you'll be able to c

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem updated this revision to Diff 457734. Navidem added a comment. Herald added subscribers: cfe-commits, ormris, MaskRay. Herald added a project: clang. Updated docs, lit test, and added clang option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 457735. python3kgae added a comment. Merge fix from Chris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/include/clang/Sema/HLSLExternalSemaSourc

[PATCH] D133177: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is not deleted before attempting to call DefineDefaultedFunction(...)

shafik updated this revision to Diff 457736. shafik added a comment. - Add Release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133177/new/ https://reviews.llvm.org/D133177 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/constant-expres

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:1055 + for (auto &BB: F) { +// blockaddress may not be used on function's entry block. +if (&BB == &F.getEntryBlock()) Navidem wrote: > kcc wrote: > > vi

[clang] a887d9e - [NFC][clang] LLVM_FALLTHROUGH => [[fallthrough]

Author: Sheng Date: 2022-09-03T08:58:31+08:00 New Revision: a887d9efd696da42dd8bf19a63a3db4140361c07 URL: https://github.com/llvm/llvm-project/commit/a887d9efd696da42dd8bf19a63a3db4140361c07 DIFF: https://github.com/llvm/llvm-project/commit/a887d9efd696da42dd8bf19a63a3db4140361c07.diff LOG: [N

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith updated this revision to Diff 457742. rsmith added a comment. Document the flag to undo the behavior, and mention that it's going away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132779/new/ https://reviews.llvm.org/D132779 Files: clan

[PATCH] D132779: Enforce module decl-use restrictions and private header restrictions in textual headers

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:126 + `_ are now + diagnosed even when the includer is a textual header. aaron.ballman wrote: > You should mention `-fno-modules-va

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem added inline comments. Comment at: llvm/test/Instrumentation/SanitizerCoverage/control-flow.ll:2 +; Test -sanitizer-coverage-control-flow +; RUN: opt < %s -passes='module(sancov-module)' -sanitizer-coverage-level=3 -sanitizer-coverage-control-flow -S | FileCheck %s + ---

[clang] 220c2cb - Attempt to make AIX bot happier.

Author: Richard Smith Date: 2022-09-02T18:43:27-07:00 New Revision: 220c2cb0a88f0f1cc97ea657018abbffb8697a73 URL: https://github.com/llvm/llvm-project/commit/220c2cb0a88f0f1cc97ea657018abbffb8697a73 DIFF: https://github.com/llvm/llvm-project/commit/220c2cb0a88f0f1cc97ea657018abbffb8697a73.diff

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

This revision was automatically updated to reflect the committed changes. Closed by commit rG38941da066a7: [Clang] change default storing path of `-ftime-trace` (authored by dongjunduo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ http

[clang] 38941da - [Clang] change default storing path of `-ftime-trace`

Author: Junduo Dong Date: 2022-09-02T18:49:11-07:00 New Revision: 38941da066a7b785ba4771710189172e94e37824 URL: https://github.com/llvm/llvm-project/commit/38941da066a7b785ba4771710189172e94e37824 DIFF: https://github.com/llvm/llvm-project/commit/38941da066a7b785ba4771710189172e94e37824.diff L

[clang] 9f6b319 - [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is not deleted before attempting to call DefineDefaultedFunction(...)

Author: Shafik Yaghmour Date: 2022-09-02T18:59:15-07:00 New Revision: 9f6b3199d33c146937f29feb62e123f34138f770 URL: https://github.com/llvm/llvm-project/commit/9f6b3199d33c146937f29feb62e123f34138f770 DIFF: https://github.com/llvm/llvm-project/commit/9f6b3199d33c146937f29feb62e123f34138f770.dif

[PATCH] D133177: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is not deleted before attempting to call DefineDefaultedFunction(...)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6b3199d33c: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the… (authored by shafik). Herald added a project: clang. Reposito

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. The test you added is failing on the PS4 linux bot because the PS4 platform requires an external linker that isn't present. Is linking necessary for your test? Or can -S or even -c work instead to accomplish what you are trying to test? Repository: rG LLVM Github Mono

[clang] 632e1e9 - Work around Windows buildbot failure.

Author: Richard Smith Date: 2022-09-02T19:09:15-07:00 New Revision: 632e1e9fd81d899ffa01300eb47fd417b76bbae5 URL: https://github.com/llvm/llvm-project/commit/632e1e9fd81d899ffa01300eb47fd417b76bbae5 DIFF: https://github.com/llvm/llvm-project/commit/632e1e9fd81d899ffa01300eb47fd417b76bbae5.diff

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. In D131469#3768260 , @dyung wrote: > The test you added is failing on the PS4 linux bot because the PS4 platform > requires an external linker that isn't present. Is linking necessary for your > test? Or can -S or even -c wor

[PATCH] D133157: Add -sanitizer-coverage-control-flow

Navidem updated this revision to Diff 457754. Navidem added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Added an initial run-time test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://revie

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768274 , @dongjunduo wrote: > In D131469#3768260 , @dyung wrote: > >> The test you added is failing on the PS4 linux bot because the PS4 platform >> requires an external linker

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. In D131469#3768282 , @dyung wrote: > In D131469#3768274 , @dongjunduo > wrote: > >> In D131469#3768260 , @dyung wrote: >> >>> The test you add

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768283 , @dongjunduo wrote: > In D131469#3768282 , @dyung wrote: > >> In D131469#3768274 , @dongjunduo >> wrote: >> >>> In D131469#376

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (const auto *T = TInfo->getType()->getContainedDeducedType()) +if (isa(T)) + Diag(D.getIdentifierLoc(), + diag::warn_cxx14_compat_template_nontype_parm_auto_type) +

[clang] 39221ad - [driver][clang] remove the check-time-trace test on the platform "PS4/PS5/Hexagon"

Author: Junduo Dong Date: 2022-09-02T20:27:35-07:00 New Revision: 39221ad55752c246bb8448a181847103432e12b2 URL: https://github.com/llvm/llvm-project/commit/39221ad55752c246bb8448a181847103432e12b2 DIFF: https://github.com/llvm/llvm-project/commit/39221ad55752c246bb8448a181847103432e12b2.diff L

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo added a comment. In D131469#3768288 , @dyung wrote: > In D131469#3768283 , @dongjunduo > wrote: > >> In D131469#3768282 , @dyung wrote: >> >>> In D131469#37682

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

steven_wu added a comment. In D131469#3768308 , @dongjunduo wrote: > In D131469#3768288 , @dyung wrote: > >> In D131469#3768283 , @dongjunduo >> wrote: >> >>> In D131469

[PATCH] D133157: Add -sanitizer-coverage-control-flow

vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:4 +// RUN: %clangxx -O0 -std=c++11 -fsanitize-coverage=control-flow %s -o %t +// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not Assertion{{.*}}fai

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

owenpan accepted this revision. owenpan added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D123450: [clang-format] Parse Verilog if statements

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:1550 + bool isBlockBegin(const FormatToken &Tok, const FormatStyle &Style) const { +return Tok.is(TT_MacroBlockBegin) || + (Style.isVerilog() ? isVerilogBegin(Tok) : Tok.is(tok::l_brace)); --

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

SuibianP created this revision. Herald added a subscriber: jdoerfert. Herald added a project: All. SuibianP requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The parser assumes that the lexer never emits coloncolon token for C code, but this

[PATCH] D123450: [clang-format] Parse Verilog if statements

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2592 - if (FormatTok->is(tok::l_brace)) { + if (Keywords.isBlockBegin(*FormatTok, Style)) { FormatTok->setFinalizedType(TT_ControlStatementLBrace); owenpan wrote: > This

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

inclyc added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5340 +if (!getLangOpts().CPlusPlus) + return false; if (NextToken().is(tok::kw_new) ||// ::new Maybe we can make a new `error` diagnostic definition and fire that here? ==

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

tschuett added a comment. Will there be eventually a way to build a fully optimised clang/lld with ThinLTO, PGO, and Bolt? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

jdoerfert added inline comments. Comment at: clang/CodeOwners.rst:226 +| Alexey Bataev +| a.bataev\@hotmail.com (email), ABataev (Phabricator), cilkplus (GitHub) + CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

thakis added a comment. This breaks tests on Mac and windows, see eg http://45.33.8.238/macm1/43791/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://rev

[PATCH] D133093: [clang-format] Fix a bug in merging blocks with a wrapped l_brace

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d8738c3844: [clang-format] Fix a bug in merging blocks with a wrapped l_brace (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133093/n

[clang] 92d8738 - [clang-format] Fix a bug in merging blocks with a wrapped l_brace

Author: owenca Date: 2022-09-02T21:38:36-07:00 New Revision: 92d8738c38448a478e0c5b097b24b450a224843f URL: https://github.com/llvm/llvm-project/commit/92d8738c38448a478e0c5b097b24b450a224843f DIFF: https://github.com/llvm/llvm-project/commit/92d8738c38448a478e0c5b097b24b450a224843f.diff LOG: [

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dyung added a comment. In D131469#3768352 , @steven_wu wrote: > In D131469#3768308 , @dongjunduo > wrote: > >> In D131469#3768288 , @dyung wrote: >> >>> In D131469#376828

<    1   2