[clang] 582ec4b - [test][msan] Don't ignore prefix of sanitizer_dtor_callback

Author: Vitaly Buka Date: 2022-08-29T18:26:04-07:00 New Revision: 582ec4b0aa55bff84490e1c89e55066bf6603212 URL: https://github.com/llvm/llvm-project/commit/582ec4b0aa55bff84490e1c89e55066bf6603212 DIFF: https://github.com/llvm/llvm-project/commit/582ec4b0aa55bff84490e1c89e55066bf6603212.diff L

[PATCH] D132905: [clang-format] Fix a bug in inserting braces at trailing comments

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the style w

[PATCH] D132906: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is a special member function before attempting to call DefineDefaultedFunction(...)

shafik created this revision. shafik added reviewers: erichkeane, aaron.ballman. Herald added a project: All. shafik requested review of this revision. In `Sema::CheckCompletedCXXClass(...)` It used a lambda `CheckForDefaultedFunction` the `CXXMethodDecl` passed to `CheckForDefaultedFunction` ma

[clang] 420209b - [test][msan] Add missing Debug Info check from dtor test

Author: Vitaly Buka Date: 2022-08-29T18:55:24-07:00 New Revision: 420209bb6d092bd4735c24726b934a1e4637f04d URL: https://github.com/llvm/llvm-project/commit/420209bb6d092bd4735c24726b934a1e4637f04d DIFF: https://github.com/llvm/llvm-project/commit/420209bb6d092bd4735c24726b934a1e4637f04d.diff L

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka created this revision. Herald added a subscriber: Enna1. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 updated this revision to Diff 456520. jhuber6 added a comment. Remove unused code gen option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130096/new/ https://reviews.llvm.org/D130096 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/l

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. In D128490#3689958 , @ChuanqiXu wrote: > LGTM then. Thanks for the review! Sorry for not answering earlier, I was on vacation. Now I'll rebase the change and will test it again before committing. Repository: rG LLVM Github M

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked an inline comment as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto &J : C.getJobs()) { Whitney wrote: > dongjunduo wrot

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Whitney added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto &J : C.getJobs()) { dongjunduo wrote: > Whitney wrote: > > dongjunduo wrote: > > > Whitney wrote: >

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo marked an inline comment as done. dongjunduo added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4702 + + // Add or replace -ftime-trace` to the correct one to all clang jobs + for (auto &J : C.getJobs()) { Whitney wrote: > dongjunduo wrot

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 456524. MaskRay marked 6 inline comments as done. MaskRay added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/ https://reviews.llvm.org/D131464 Files: clang/test/AST/as

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/exception-spec-decay.cpp:1 -// RUN: %clang_cc1 -fcxx-exceptions -fexceptions %s -triple=i686-unknown-linux -emit-llvm -o - | FileCheck %s +// RUN: %clang_cc1 %stdcxx_98- -fcxx-exceptions -fexceptions -Wno-dynamic-

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D132352#3755355 , @nikic wrote: > Okay, this is a bit tricky because we have three different things: > > 1. The noread_thread_id attribute, the lack of which was causing issues with

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. @njames93 Can we land this patch before it occurs conflicting with other changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132640/new/ https://reviews.llvm.org/D132640 ___

[PATCH] D129833: Use @llvm.threadlocal.address intrinsic to access TLS

ChuanqiXu added a comment. In D129833#3755135 , @nikic wrote: > In D129833#3727881 , @ChuanqiXu > wrote: > >> And I am working on adding Align properties. But I meet problems since the >> alignment of threadloca

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 456528. ychen added a comment. This revision is now accepted and ready to land. - handle constrained placeholder [pack] types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D12

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay marked 5 inline comments as done. MaskRay added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:570 +clang_std_values = ('98', '11', '14', '17', '20', '2b') +def add_stdcxx(s): +t = s[8:] aaron.ballman wrote: > I

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen requested review of this revision. ychen added a comment. @royjacobson: really appreciate it if you could take another look. @mizvekov: I saw you mentioned in the Discourse that you want to review template-related stuff and you have been actively working in that area, do you mind having a

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

vitalybuka created this revision. Herald added a subscriber: Enna1. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Depends on: D132907 Repos

[clang] d9d7e12 - [test][msan] Use -DAG to match Debug Info

Author: Vitaly Buka Date: 2022-08-29T20:32:41-07:00 New Revision: d9d7e1211b5b0bfaacd220650b8eec8d0efe69c1 URL: https://github.com/llvm/llvm-project/commit/d9d7e1211b5b0bfaacd220650b8eec8d0efe69c1 DIFF: https://github.com/llvm/llvm-project/commit/d9d7e1211b5b0bfaacd220650b8eec8d0efe69c1.diff L

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 456533. dongjunduo added a comment. Replace -ftime-trace with -ftime-trace= also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.c

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

dongjunduo updated this revision to Diff 456535. dongjunduo added a comment. Rewrite comments and commit log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 Files: clang/lib/Driver/Driver.cpp clang/te

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka updated this revision to Diff 456540. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132907/new/ https://reviews.llvm.org/D132907 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/sanitize-

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

vitalybuka updated this revision to Diff 456541. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132909/new/ https://reviews.llvm.org/D132909 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/sanitize-

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

VincentWu updated this revision to Diff 456542. VincentWu marked 6 inline comments as done. VincentWu added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/

[clang] 740a75c - Fix assumption that Clang version number is numeric.

Author: Richard Smith Date: 2022-08-29T21:42:11-07:00 New Revision: 740a75c9d6adf8a26ebd13fc1d3460c728550624 URL: https://github.com/llvm/llvm-project/commit/740a75c9d6adf8a26ebd13fc1d3460c728550624 DIFF: https://github.com/llvm/llvm-project/commit/740a75c9d6adf8a26ebd13fc1d3460c728550624.diff

[PATCH] D132831: [clang][Interp] Handle SubstNonTypeTemplateParmExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:273 +const SubstNonTypeTemplateParmExpr *E) { + return this->visit(E->getReplacement()); +} tahonermann wrote: > erichkeane wrote: > > tbaeder wrote: > > > erichkeane wrote:

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

njames93 added a comment. In D132640#3757277 , @corona10 wrote: > @njames93 Can we land this patch before it occurs conflicting with other > changes? Yes, sorry do you have commit access. If you don't what is your GitHub name and email that I should us

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

tonic added a comment. Moving to GitHub PRs is the path forward. Let's save ourselves some work and add them now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 _

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 456545. VincentWu marked an inline comment as done. VincentWu added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. clear patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D132640: [clang-tidy] Fix modernize-use-emplace to support alias cases

corona10 added a comment. In D132640#3757395 , @njames93 wrote: > In D132640#3757277 , @corona10 > wrote: > >> @njames93 Can we land this patch before it occurs conflicting with other >> changes? > > Yes, sorry

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. In D126864#3698798 , @sberg wrote: > I'm surprised that [...] > causes a warning? I would have expected it to be suppressed in this case, as > with the lax `-fstrict-flex-arrays=0` default, and only to hit with the > stricter `

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added a comment. Stackful coroutine bodies should be straightforward to support on top of the other work you've been doing, if anyone's actually interested in pursuing them. As far as the optimizer needs to know, a stackful coroutine function is just like a presplit stackless coroutin

[PATCH] D132911: Fix annotating when deleting array of pointers

jackhong12 created this revision. jackhong12 added reviewers: owenpan, MyDeveloperDay, curdeius, HazardyKnusperkeks. Herald added a project: All. jackhong12 edited the summary of this revision. jackhong12 published this revision for review. Herald added a project: clang. Fixes https://github.com/

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu added a comment. In D132352#3757415 , @rjmccall wrote: > Stackful coroutine bodies should be straightforward to support on top of the > other work you've been doing, if anyone's actually interested in pursuing > them. As far as the optimizer

[PATCH] D132853: [clang] Fix -Warray-bound interaction with -fstrict-flex-arrays=1

serge-sans-paille added a comment. Description updated, it's just a bug in the previous implementation (by myself!) I don't think it's worth an entry in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132853/new/ https://reviews.l

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

wlei added a comment. In D131714#3754399 , @ahatanak wrote: > Fixed in f051c1ded40970169cda84b0966331ae7ad424ed > . It > looks like gcc, unlike clang, doesn't allow passing `-Werror=fo

<    1   2   3