[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3744315 , @alexfh wrote: > The whole project seems like a great improvement in clang diagnostics, but I > don't yet see how template parameter pack substitution indices fit into the > whole picture. If different type

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz added inline comments. Comment at: clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -hlsl-entry main -verify %s + aaron.ballman wrote: > That's not needed, right?

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07e34763b027: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 07e3476 - [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

Author: Bing1 Yu Date: 2022-08-24T09:28:55+08:00 New Revision: 07e34763b02728857e1d6e8ccd2b82820eb3c0cc URL: https://github.com/llvm/llvm-project/commit/07e34763b02728857e1d6e8ccd2b82820eb3c0cc DIFF: https://github.com/llvm/llvm-project/commit/07e34763b02728857e1d6e8ccd2b82820eb3c0cc.diff LOG:

[clang] 0d8f952 - Revert "[X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit"

Author: Bing1 Yu Date: 2022-08-24T09:38:46+08:00 New Revision: 0d8f9520c5d8912e80b3f245d369c7b86fbd2d5d URL: https://github.com/llvm/llvm-project/commit/0d8f9520c5d8912e80b3f245d369c7b86fbd2d5d DIFF: https://github.com/llvm/llvm-project/commit/0d8f9520c5d8912e80b3f245d369c7b86fbd2d5d.diff LOG:

[PATCH] D132521: [AST] Reuse PrintingPolicy from ASTContext

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. No need to create a duplicate PrintingPolicy when we can reuse the PrintingPolicy from ASTContext. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:972 +} + } + auto result = Visit(const_cast(E)); The unary operator cases seem to have disappeared from this function. Comment at: clang/lib/CodeGen/CGExprCom

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

NoQ added a comment. Aha perfect, now the entire static analyzer knows how to work with these regions! I have one tiny remark and I think we can commit. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:1079 else { -if (LC) { +bool IsArcManagedBlock = BD->ge

[clang] 887bafb - [HLSL] Infer language from file extension

Author: Chris Bieneman Date: 2022-08-23T20:52:29-05:00 New Revision: 887bafb503c59c5ecef831c679a2b114ee6ef338 URL: https://github.com/llvm/llvm-project/commit/887bafb503c59c5ecef831c679a2b114ee6ef338 DIFF: https://github.com/llvm/llvm-project/commit/887bafb503c59c5ecef831c679a2b114ee6ef338.diff

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz added inline comments. Comment at: clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -hlsl-entry main -verify %s + beanz wrote: > aaron.ballman wrote: > > That's n

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu marked an inline comment as not done. zixuan-wu added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

yubing updated this revision to Diff 455041. yubing added a comment. address sign-conversion issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132141/new/ https://reviews.llvm.org/D132141 Files: clang/lib/Headers/immintrin.h clang/test/CodeG

[clang] 6d8ddf5 - [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

Author: Bing1 Yu Date: 2022-08-24T10:22:46+08:00 New Revision: 6d8ddf53cc8026748a27a8964e117da371f2ccf2 URL: https://github.com/llvm/llvm-project/commit/6d8ddf53cc8026748a27a8964e117da371f2ccf2 DIFF: https://github.com/llvm/llvm-project/commit/6d8ddf53cc8026748a27a8964e117da371f2ccf2.diff LOG:

[PATCH] D132141: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d8ddf53cc80: [X86] Emulate _rdrand64_step with two rdrand32 if it is 32bit (authored by yubing). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 455051. cjdb edited the summary of this revision. cjdb added a comment. changes RemoveReference to BuiltinRemoveReference Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > I'm not sure what optimization you mean. Because the ABI returns 16-bit and > 32-bit FP values differently, there really isn't a way that we can return a > value without going through a truncation/extension cycle. I explained it to Zahira offline. I forgot we have dif

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

shafik added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:39 + CompilerType coro_func_type = ast_ctx.CreateFunctionType( + /*result_type*/ void_type, /*args*/ &void_type, /*num_args*/ 1, + /*is_variadic*/ false, /*qualifiers*/ 0);

[PATCH] D132531: [AArch64] Reserve more physical registers

Carrot created this revision. Carrot added a reviewer: dmgreen. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. Carrot requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. Reserved phys

[PATCH] D121779: [RISCV] Add zihintntl compressed instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. alextsao1999 marked an inline comment as done. Closed by commit rG07a700f814bf: [RISCV] Add zihintntl compressed instructions (authored by alextsao1999). Repository:

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3744505 , @pengfei wrote: >> I'm not sure what optimization you mean. Because the ABI returns 16-bit and >> 32-bit FP values differently, there really isn't a way that we can return a >> value without going through a

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta updated this revision to Diff 455087. thieta added a comment. Updated the option to default to ON - meaning we keep the current behavior found in main. This rationel for this is explained in my post here: https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground

[PATCH] D132531: [AArch64] Reserve more physical registers

kristof.beyls added a comment. My understanding is that X8, X16, X17 and X19 cannot be reserved because the code generator in places will make use of them. For example, using X19 as a base register in some cases. X16 and X17 are defined by the ABI to potentially be clobbered on function calls &

<    1   2   3