[clang] d4e0fe6 - Simplify RAV isSameMethod with constexpr if

2022-08-18 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2022-08-19T04:00:21Z New Revision: d4e0fe62b1aa090527c0cc289cdf3eef0370f064 URL: https://github.com/llvm/llvm-project/commit/d4e0fe62b1aa090527c0cc289cdf3eef0370f064 DIFF: https://github.com/llvm/llvm-project/commit/d4e0fe62b1aa090527c0cc289cdf3eef0370f064.diff LOG:

[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

2022-08-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D132142#3733629 , @NoQ wrote: > Like I vaguely mentioned in the thread, I'm really curious whether it's > possible to canonicalize the *absence* of element regions instead, as it > allows modeling pointer casts as no-op and

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

2022-08-18 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

2022-08-18 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:41 + +constexpr const int* getIntPointer() { + return &m; shafik wrote: > What are these functions testing? Functions take a slightly different code path where actual bytecode is gene

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

2022-08-18 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:14938 + + if (E->getType().isNull()) +return false; shafik wrote: > Curious why these two checks don't go w/ the `::Evaluate(Result, Info, E)` > below. No real reason I think, it's ju

[clang] 3d2ab23 - [clang] Improve diagnostics for uninitialized constexpr variables

2022-08-18 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-08-19T08:06:12+02:00 New Revision: 3d2ab237f157908d595581cfbeeb0a9ff33bb249 URL: https://github.com/llvm/llvm-project/commit/3d2ab237f157908d595581cfbeeb0a9ff33bb249 DIFF: https://github.com/llvm/llvm-project/commit/3d2ab237f157908d595581cfbeeb0a9ff33bb249.diff LO

[PATCH] D131662: [clang] Try to improve diagnostics about uninitialized constexpr variables

2022-08-18 Thread Timm Bäder via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d2ab237f157: [clang] Improve diagnostics for uninitialized constexpr variables (authored by tbaeder). Changed prior to commit: https://reviews.ll

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

2022-08-18 Thread Tomasz Kamiński via Phabricator via cfe-commits
tomasz-kaminski-sonarsource added a comment. @NoQ Do you agree with my view on `handleConstructionContext`, if so is the issue ready to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030 _

[PATCH] D113859: [Sema] Fix consteval function calls with value-dependent args

2022-08-18 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 added a comment. Herald added a project: All. Update: The mentioned cases here are all now fixed at head (after D132031 ) // 1 consteval int f(int n) { return n; } template constexpr int broken() { return f(M); } static_assert(broke

[clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

2022-08-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2022-08-19T14:43:22+08:00 New Revision: acaf6b9dc07de3c12c8a1a55fd8674bca547a917 URL: https://github.com/llvm/llvm-project/commit/acaf6b9dc07de3c12c8a1a55fd8674bca547a917 DIFF: https://github.com/llvm/llvm-project/commit/acaf6b9dc07de3c12c8a1a55fd8674bca547a917.diff LO

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

2022-08-18 Thread Pavel Samolysov via Phabricator via cfe-commits
psamolysov added a comment. In D128830#3647168 , @aeubanks wrote: > ... but let me run some internal benchmarks on this patch @aeubanks Sorry for the late answer. Did you have a chance to run the benchmarks? If so, could you share the results? Reposit

[clang-tools-extra] b8655f7 - [clang-tidy] Improve modernize-use-emplace check

2022-08-18 Thread Nathan James via cfe-commits
Author: Joey Watts Date: 2022-08-19T07:57:42+01:00 New Revision: b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651 URL: https://github.com/llvm/llvm-project/commit/b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651 DIFF: https://github.com/llvm/llvm-project/commit/b8655f7ff286b9ebcd97cdd24b9c8eb5b89b9651.diff LO

[PATCH] D131623: [clang-tidy] Improve modernize-use-emplace check

2022-08-18 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb8655f7ff286: [clang-tidy] Improve modernize-use-emplace check (authored by joeywatts, committed by njames93). Changed prior to commit: https://reviews.llvm.org/D131623?vs=451960&id=453899#toc Reposito

<    1   2   3