[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

jansvoboda11 added a comment. Do you think it would make sense to introduce a command-line flag that would control this behavior? Also, I'd like to test this patch internally to see if it affects anything on our end. I should be able to do so next week. Repository: rG LLVM Github Monorepo

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth updated this revision to Diff 450359. JonasToth added a comment. - improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130793/new/ https://reviews.llvm.org/D130793 Files: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.c

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

fmayer added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->size--; fmayer wrote: > fmayer wrote: > > vitalybuka wrote: > > > maybe we should pop eve

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

iliya-diyachkov accepted this revision. iliya-diyachkov added a comment. This revision is now accepted and ready to land. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130768/new/ https://reviews.llvm.org/D130768 ___ cfe-com

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 450364. thieta added a comment. Fixed spelling error and added links to C++ standard libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CM

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

scanon added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) +LIBBUILTIN(round

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 450377. python3kgae marked 3 inline comments as done. python3kgae added a comment. Rebase and fix merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. In D126676#3703024 , @jansvoboda11 wrote: > Do you think it would make sense to introduce a command-line flag that would > control this behavior? Hmm - I don’t think it’d be necessary. If using the gcc style PCH directory, I

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

tra added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" Ideally we want to test that the output file actually survives the compilation. It's traky to do for in-tree tests as w

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I can confirm that this patch fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131278/new/ https://reviews.llvm.org/D131278 ___

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" tra wrote: > Ideally we want to test that the output file actually survives the > compilation. It's traky to do for

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450392. ckissane added a comment. - fix InputSection decompress issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516 Files: clang-tools-extra/clangd/index/Seriali

[PATCH] D130516: [llvm] compression classes

ckissane updated this revision to Diff 450401. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.compression-class-simple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130516/new/ https://reviews.llvm.org/D130516

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I don't have any concerns, this seems reasonable to me. Since Jan offered to test it, please wait to hear back before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Driver/Options.td:6921 HelpText<"Entry point name">; +def dxc_P : Option<["--", "/", "-"], "P", KIND_SEPARATE>, + Group, Flags<[DXCOption, NoXarchOption]>, This is the same option

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Asserted locally the test passes. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/ https://reviews.

[PATCH] D130858: [HLSL] emit-obj when set output.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130858/new/ https://reviews.llvm.org/D130858 ___ c

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 450407. abrahamcd added a comment. Checks for `clear()` in base classes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-ti

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw created this revision. brettw added a reviewer: phosek. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Struct/class data members did not have the comments associated with them. This a

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar, mgorny. Herald added a project: All. Trass3r edited the summary of this revision. Trass3r edited projects, added clang-tools-extra; removed All. Trass3r edited subscribers, added: sammccall; removed

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added a comment. I just searched again and found https://reviews.llvm.org/D91930. But seems like it never got updated with the latest code contained in here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/ https://reviews.llvm.org

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 450430. abrahamcd added a comment. Adds non-dependent base class test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 Files: clang-tools-extra/clang-tidy/bu

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp:14 #include "clang/ASTMatchers/ASTMatchers.h" +#include "llvm/Support/Casting.h" Typically don't need this include. Comment at: clang-to

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

tra added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" jhuber6 wrote: > tra wrote: > > Ideally we want to test that the output file actually survives the > > compilation. It'

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:148 +// RUN: | FileCheck -check-prefix=D_ONLY %s +// D_ONLY: "foo.o" tra wrote: > jhuber6 wrote: > > tra wrote: > > > Ideally we want to test that the output file actually survives the

[clang] 6635f48 - [Serialization] Remove `ORIGINAL_PCH_DIR` record

Author: Argyrios Kyrtzidis Date: 2022-08-05T15:40:33-07:00 New Revision: 6635f48e4aba499a7a31c6346cb1351437d36055 URL: https://github.com/llvm/llvm-project/commit/6635f48e4aba499a7a31c6346cb1351437d36055 DIFF: https://github.com/llvm/llvm-project/commit/6635f48e4aba499a7a31c6346cb1351437d36055.

[PATCH] D131124: [Serialization] Remove `ORIGINAL_PCH_DIR` record

This revision was automatically updated to reflect the committed changes. Closed by commit rG6635f48e4aba: [Serialization] Remove `ORIGINAL_PCH_DIR` record (authored by akyrtzi). Changed prior to commit: https://reviews.llvm.org/D131124?vs=449808&id=450439#toc Repository: rG LLVM Github Mono

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

w2yehia added inline comments. Herald added a project: All. Comment at: libcxx/trunk/include/istream:1222 { -this->setstate(ios_base::badbit); +__state |= ios_base::badbit; return -1; Hi @ldionne, you'

[clang] 3b52341 - [CUDA] Fix output name being replaced in device-only mode

Author: Joseph Huber Date: 2022-08-05T19:08:41-04:00 New Revision: 3b52341116b794e53dec2fd07e568884e5a0b8bb URL: https://github.com/llvm/llvm-project/commit/3b52341116b794e53dec2fd07e568884e5a0b8bb DIFF: https://github.com/llvm/llvm-project/commit/3b52341116b794e53dec2fd07e568884e5a0b8bb.diff

[PATCH] D131278: [CUDA] Fix output name being replaced in device-only mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b52341116b7: [CUDA] Fix output name being replaced in device-only mode (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131278/new/ htt

[clang] 549542b - [HLSL] emit-obj when set output.

Author: Xiang Li Date: 2022-08-05T16:27:17-07:00 New Revision: 549542b494f4c84bead744ed91ea81236e4aaa63 URL: https://github.com/llvm/llvm-project/commit/549542b494f4c84bead744ed91ea81236e4aaa63 DIFF: https://github.com/llvm/llvm-project/commit/549542b494f4c84bead744ed91ea81236e4aaa63.diff LOG:

[PATCH] D130858: [HLSL] emit-obj when set output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG549542b494f4: [HLSL] emit-obj when set output. (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D130858?vs=448890&id=4

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth created this revision. paulkirth added a reviewer: tejohnson. Herald added subscribers: ormris, okura, kuter, hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added projects:

[clang] 3fbbf28 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV=OFF after 6635f48e4aba

Author: Nico Weber Date: 2022-08-05T19:50:23-04:00 New Revision: 3fbbf28173406ed74c9791d172fff5c5b1aab823 URL: https://github.com/llvm/llvm-project/commit/3fbbf28173406ed74c9791d172fff5c5b1aab823 DIFF: https://github.com/llvm/llvm-project/commit/3fbbf28173406ed74c9791d172fff5c5b1aab823.diff LO

[PATCH] D130516: [llvm] compression classes

dblaikie added a comment. This is looking pretty close to what I've been picturing - the only thing remaining is that I think we could get rid of `CompressionKind` and access the `CompressionAlgorithm` directly - basically the contents of `CompressionKind::operator->` could be a free/public fun

[clang] 7b12e56 - [test/Modules/cxx20-export-import.cpp] Pre-clean the modules cache directory of the test, NFC

Author: Argyrios Kyrtzidis Date: 2022-08-05T17:27:43-07:00 New Revision: 7b12e561ac7aa9604022d56c8561bd472e78f2ed URL: https://github.com/llvm/llvm-project/commit/7b12e561ac7aa9604022d56c8561bd472e78f2ed DIFF: https://github.com/llvm/llvm-project/commit/7b12e561ac7aa9604022d56c8561bd472e78f2ed.

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, thakis, smeenai, tahonermann. Herald added a project: All. shafik requested review of this revision. In D130058 we diagnose the undefined behavior of setting the value outside the r

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:13532 -if (DestType->isEnumeralType()) { +if (Info.Ctx.getLangOpts().CPlusPlus && DestType->isEnumeralType()) { const EnumType *ET = dyn_cast(DestType.getCanonicalType()); C

[clang] 786b503 - [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

Author: Jun Zhang Date: 2022-08-06T11:36:02+08:00 New Revision: 786b503f66b1a35f79312203fcb533ad27511982 URL: https://github.com/llvm/llvm-project/commit/786b503f66b1a35f79312203fcb533ad27511982 DIFF: https://github.com/llvm/llvm-project/commit/786b503f66b1a35f79312203fcb533ad27511982.diff LOG

[PATCH] D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rG786b503f66b1: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior. (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 updated this revision to Diff 450469. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131272/new/ https://reviews.llvm.org/D131272 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp c

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:1070 void operator=(const OMPPrivateScope &) = delete; +bool MapRestored = false; tianshilei1992 wrote: > ABataev wro

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong updated this revision to Diff 450468. ShawnZhong added a comment. - Added CodeGen tests. - Fixed failed tests that assigned 1 to `int:1`. - Modified the Sema test to use `int:` instead of `signed char:1`. - Added release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131272: [Clang][OpenMP] Fix the issue that `llvm.lifetime.end` is emitted too early for variables captured in linear clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131272/new/ https://reviews.llvm.org/D131272 ___

[PATCH] D128372: [Clang-Tidy] Empty Check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:124 + return isa(ND) && + llvm::dyn_cast(ND)->getMinRequiredArguments() == + 0; `dyn_cast` isn't needed here a

<    1   2