[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu updated this revision to Diff 448246. ChuanqiXu added a comment. - Address comment. - Add Sema::CheckRedefinitionInModule CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130614/new/ https://reviews.llvm.org/D130614 Files: clang/include/clang/Basic/Module.h clang/include/cla

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sylvestre.ledru added a comment. Same, it broke apt.llvm.org It is installing some of the libs in debian/tmp/libgomp.so instead of debian/tmp/usr/lib/llvm-15/lib/libgomp.so I think it should be indeed revert (and in the branch 15 too) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1dc26b8 - [Driver][PowerPC] Support -mtune=

Author: Fangrui Song Date: 2022-07-28T00:34:04-07:00 New Revision: 1dc26b80b872a94c581549a21943756a8c3448a3 URL: https://github.com/llvm/llvm-project/commit/1dc26b80b872a94c581549a21943756a8c3448a3 DIFF: https://github.com/llvm/llvm-project/commit/1dc26b80b872a94c581549a21943756a8c3448a3.diff

[PATCH] D130526: [Driver][PowerPC] Support -mtune=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dc26b80b872: [Driver][PowerPC] Support -mtune= (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

nikic added a comment. I think my only concern with this change is that it will also allow some implicit ArrayRef constructors. For example, this will permit creating a SmallVector from `std::array`, `std::vector`, or just `T` -- but only if `ArrayRef` is in scope. This seems somewhat dangerous

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. In D130614#3681881 , @ilya-biryukov wrote: > Thanks! Mostly questions to better understand the spec and clang. Please > excuse me if they sound too basic. > I have read the modules s

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

ro marked 2 inline comments as done. ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:634 + // LLVM support for atomics on 32-bit SPARC V8+ is incomplete, so + // forcibly link with libatomic as a workaround. MaskRay wrote: >

[PATCH] D130600: [clang][dataflow] Handle return statements

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:114 + /// + /// `return` must not be assigned a storage location. + void setReturnStorageLocation(StorageLocation &Loc) { li.zhe.hua wrote: > sames

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

ro updated this revision to Diff 448253. ro marked 2 inline comments as done. ro added a comment. - Switch to `--push-state`/`--pop-state`. - Add testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130569/new/ https://reviews.llvm.org/D130569

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro created this revision. ro added reviewers: glaubitz, MaskRay, jrtc27. ro added a project: clang. Herald added subscribers: StephenFan, pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. This is the Debian/sparc64 equivalent of D86621

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta created this revision. thieta added reviewers: mehdi_amini, jyknight, jhenderson, hans, tstellar, cor3ntin, MaskRay. Herald added subscribers: ayermolo, StephenFan, mgorny. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a proj

[PATCH] D129446: [clang][driver] Find Apple default SDK path

thieta added a comment. Ping - any thoughts on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129446/new/ https://reviews.llvm.org/D129446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. Herald added a subscriber: JDevlieghere. Nice, LGTM, thanks for driving this! > Remember that if we want to adopt some new feature in a bigger way it should > be discussed and added to the CodingStandard document. What does it mean exactly? We can't use **anything**

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684330 , @mehdi_amini wrote: > What does it mean exactly? We can't use **anything** C++17 without writing it > in the coding standards? > I'm not sure it'll be manageable: how do you see this playing out? Probably po

[PATCH] D130689: [LLVM] Update C++ standard to 17

ChuanqiXu added a comment. In D130689#3684333 , @thieta wrote: > In D130689#3684330 , @mehdi_amini > wrote: > >> What does it mean exactly? We can't use **anything** C++17 without writing >> it in the coding sta

[PATCH] D130689: [LLVM] Update C++ standard to 17

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. In D130689#3684330 , @mehdi_amini wrote: > Nice, LGTM, thanks for driving this! > >> Remember that if we want to adopt some new feature in a b

[PATCH] D130689: [LLVM] Update C++ standard to 17

BertalanD added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:79-80 set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -std=c++0x") # Test for libstdc++ version of at least 4.8 by checking for _ZNKSt17bad_function_call4whatEv. # Note: W

[PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. In D130689#3684333 , @thieta wrote: > In D130689#3684330 , @mehdi_amini > wrote: > >> What does it mean exactly? We can't use **anything** C++17 without writing >> it in the coding s

[PATCH] D130081: Add foldings for multi-line comment.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:177 -// FIXME(kirillbobyrev): Collect comments, PP conditional regions, includes and -// other code regions (

[PATCH] D130689: [LLVM] Update C++ standard to 17

barannikov88 added a comment. There are a few places (primarily in ADT and Support) that check __cplusplus > 201402. Do they need to be cleaned up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448261. thieta added a comment. Address some old comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684360 , @barannikov88 wrote: > There are a few places (primarily in ADT and Support) that check __cplusplus > > 201402. Do they need to be cleaned up? Sounds good - but maybe that can be addressed in a separate diff

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684334 , @ChuanqiXu wrote: > So it is free that developers want to use some C++17 features in a small > amount of code, right? As soon as this land C++ 17 should be free to use everywhere yeah! Repository: rG LLVM

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448262. thieta added a comment. Fixed unintended indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.t

[PATCH] D130689: [LLVM] Update C++ standard to 17

cor3ntin accepted this revision. cor3ntin added a comment. Thanks a lot for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___ cfe-commits mai

[PATCH] D130689: [LLVM] Update C++ standard to 17

h-vetinari added a comment. It may be worth calling out that this is about C++17 core language and not the standard library? libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing various pieces even today (much less for Clang 5). Repository: rG LLVM Github Monorepo C

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein updated this revision to Diff 448265. hokein marked an inline comment as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130511/new/ https://reviews.llvm.org/D130511 Files: clang-tools-

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:168 +bool guardPreviousTokenNotIdentifier(const GuardParams &P) { + if (P.LookaheadIndex < 2) +return true; sammccall wrote: > Is LookaheadIndex from another patch? > I can't

[PATCH] D129799: [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake setting to avoid building when cross compiling

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/CMakeLists.txt:13 +elseif(LLVM_USE_HOST_TOOLS) build_native_tool(clang-tidy-confusable-chars-gen make_confusable_table) set(make_confusable_table_target "${make_

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. BTW, I've sent a NFC test to show the current behavior for functions, classes and variables are basically fine: https://github.com/llvm/llvm-project/commit/fe1887da36c63f64903de112f2a8e88f973318fa CHANGES SINCE LAST ACTION

[PATCH] D129798: [clang-tidy] Rename the make-confusable-table executable

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/CMakeLists.txt:10 else() - set(make_confusable_table $) - set(make_confusable_table_target make-confusable-table) + set(make_confusable_table $) + set(make_confusable_table_target clang-tidy-confu

[clang-tools-extra] 18b4a8b - [clang-tidy] Rename the make-confusable-table executable

Author: Martin Storsjö Date: 2022-07-28T12:00:20+03:00 New Revision: 18b4a8bcf3553174f770f09528c9bd01c8cebfe7 URL: https://github.com/llvm/llvm-project/commit/18b4a8bcf3553174f770f09528c9bd01c8cebfe7 DIFF: https://github.com/llvm/llvm-project/commit/18b4a8bcf3553174f770f09528c9bd01c8cebfe7.diff

[clang-tools-extra] dc95d0c - [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake cache variable to avoid building when cross compiling

Author: Martin Storsjö Date: 2022-07-28T12:00:21+03:00 New Revision: dc95d0c525636aed53a3b38258efa2dff4c83edf URL: https://github.com/llvm/llvm-project/commit/dc95d0c525636aed53a3b38258efa2dff4c83edf DIFF: https://github.com/llvm/llvm-project/commit/dc95d0c525636aed53a3b38258efa2dff4c83edf.diff

[PATCH] D129798: [clang-tidy] Rename the make-confusable-table executable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18b4a8bcf355: [clang-tidy] Rename the make-confusable-table executable (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] 6f6c40a - [pseudo] Eliminate the false `::` nested-name-specifier ambiguity

Author: Haojian Wu Date: 2022-07-28T11:01:15+02:00 New Revision: 6f6c40a875c84443f255f3a6b4efc0bc0f2fb67a URL: https://github.com/llvm/llvm-project/commit/6f6c40a875c84443f255f3a6b4efc0bc0f2fb67a DIFF: https://github.com/llvm/llvm-project/commit/6f6c40a875c84443f255f3a6b4efc0bc0f2fb67a.diff LO

[PATCH] D129799: [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake setting to avoid building when cross compiling

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc95d0c52563: [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake cache variable to avoid… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D130511: [pseudo] Eliminate the false `::` nested-name-specifier ambiguity

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f6c40a875c8: [pseudo] Eliminate the false `::` nested-name-specifier ambiguity (authored by hokein). Changed prior to commit: https://reviews.llv

[PATCH] D130690: [clangd][NFCI] Store TUPath inside ParsedAST

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. Lots of featu

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); dgoldman wrote: > dgoldman wrote: > > sammccall wrote: > > > kadircet wrote: >

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128697/new/ https://reviews.llvm.org/D128697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D130678: [clang-tools-extra] Refactor to reduce code duplication

avogelsgesang accepted this revision. avogelsgesang added a comment. This revision is now accepted and ready to land. LGTM (note that I am rather inexperienced with LLVM, though, so take my approval with a grain of salt) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D130690: [clangd][NFCI] Store TUPath inside ParsedAST

ilya-biryukov added a comment. I want to understand the trade-offs a bit better. - what are the actual differences between the file paths passed to TU and the canonical path in source manager? - what issues does having these differences result in? Having some tests that illustrate the differenc

[PATCH] D129798: [clang-tidy] Rename the make-confusable-table executable

mstorsjo added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/CMakeLists.txt:10 else() - set(make_confusable_table $) - set(make_confusable_table_target make-confusable-table) + set(make_confusable_table $) + set(make_confusable_table_target clang-tidy-confus

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

njames93 accepted this revision. njames93 added a comment. LGTM, You'd need to rebase before landing as the release notes have been reset for the 15 release branching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 __

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added a comment. @aaron.ballman @shafik I'm perfectly happy to add isInitCapture in `ValueDecl` if that allows us to make progress on this. Let me know what you think! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://revi

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

ro updated this revision to Diff 448290. ro marked 3 inline comments as done. ro edited the summary of this revision. ro added a comment. - Incorporate review comments. - Add testcases. - Reject `-march`, matching GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D130701: [clang-tidy] Rename a local cmake variables to match the new tool name. NFC.

mstorsjo created this revision. mstorsjo added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. This shouldn't have any externally visible effect.

[PATCH] D129798: [clang-tidy] Rename the make-confusable-table executable

thakis added inline comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/misc/ConfusableTable/BUILD.gn:1 -executable("make-confusable-table") { +executable("clang-tidy-confusable-chars-gen") { deps = [ "//llvm/lib/Support" ] Thanks for a

[PATCH] D130055: Clang extensions yolo, woot & kaboom

aaron.ballman added subscribers: aaronpuchert, delesley. aaron.ballman added a comment. In D130055#3683279 , @beanz wrote: > In D130055#3683173 , @aaron.ballman > wrote: > >> Are there circumstances where we cann

[PATCH] D130055: Clang extensions yolo, woot & kaboom

aaron.ballman added a comment. In D130055#3683822 , @jkorous wrote: > In D130055#3683173 , @aaron.ballman > wrote: > >> Are there circumstances where we cannot "simply" infer this from the >> constructor itself?

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

hans added a comment. Here's an example where I think this regressed a Clang diagnostic. Consider: template struct Template { Template(int x) {} }; struct S1 { struct Foo; typedef Template Typedef; }; struct S2 { struct Foo; typedef Template Typedef; }; typed

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. FWIW, precommit CI has some relevant failures for a change: TEST 'Clang :: CodeGen/attr-maybeundef-template.cpp' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w4\llvm-project\premerge-checks\build\bin\clang.exe -cc

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'll make some editorial corrections for grammar to the release note when I land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 0cc3c18 - Missing tautological compare warnings due to unary operators

Author: Muhammad Usman Shahid Date: 2022-07-28T07:45:28-04:00 New Revision: 0cc3c184c784d5f0d55de8ad0a9876acd149 URL: https://github.com/llvm/llvm-project/commit/0cc3c184c784d5f0d55de8ad0a9876acd149 DIFF: https://github.com/llvm/llvm-project/commit/0cc3c184c784d5f0d55de8ad0a9876acd1

[PATCH] D130510: Missing tautological compare warnings due to unary operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cc3c184c784: Missing tautological compare warnings due to unary operators (authored by Codesbyusman, committed by aaron.ballman). Changed prior to

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. In D130510#3684740 , @aaron.ballman wrote: > LGTM! I'll make some editorial corrections for grammar to the release note > when I land. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D129446: [clang][driver] Find Apple default SDK path

dexonsmith added a subscriber: arphaman. dexonsmith added a comment. I’m not at Apple anymore, but this is a long-standing platform decision that is intentional and seems unlikely to change. Note that `/usr/bin/clang` isn’t really clang, but a tool called `xcrun` which adds environment variables

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > The problem is that just based on `Template` it's not clear whether it's > `S1::Foo` or `S2::Foo` that's referred to. The logic in the diagnostic here ended up doing a silent single step desu

[clang] 72ea1a7 - [ORC] Fix weak hidden symbols failure on PPC with runtimedyld

Author: Sunho Kim Date: 2022-07-28T21:12:25+09:00 New Revision: 72ea1a721e005f29c6fea4a684807a68abd93c39 URL: https://github.com/llvm/llvm-project/commit/72ea1a721e005f29c6fea4a684807a68abd93c39 DIFF: https://github.com/llvm/llvm-project/commit/72ea1a721e005f29c6fea4a684807a68abd93c39.diff LOG

[PATCH] D129175: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72ea1a721e00: [ORC] Fix weak hidden symbols failure on PPC with runtimedyld (authored by sunho). Herald added a project: clang. Herald added a subscr

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) + set(LLVM_LIBRARY_OUTPUT_

[clang] 3cc3be8 - [clang-repl] Add host exception support check utility flag.

Author: Sunho Kim Date: 2022-07-28T21:14:58+09:00 New Revision: 3cc3be8fa471c69ac7cf9c071554a14020226158 URL: https://github.com/llvm/llvm-project/commit/3cc3be8fa471c69ac7cf9c071554a14020226158 DIFF: https://github.com/llvm/llvm-project/commit/3cc3be8fa471c69ac7cf9c071554a14020226158.diff LOG

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cc3be8fa471: [clang-repl] Add host exception support check utility flag. (authored by sunho). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > Here's an example where I think this regressed a Clang diagnostic. Consider: Consider this simple extension of this example, to show how this general problem already existed: https://godbolt.

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sebastian-ne added inline comments. Comment at: openmp/runtime/src/CMakeLists.txt:383 \"${alias}${LIBOMP_LIBRARY_SUFFIX}\" WORKING_DIRECTORY -\"\$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${OPENMP_INSTALL_LIBDIR}\")") +\"\$ENV{DESTDIR}\${outdir}\")") endf

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

mgorny added a comment. Thanks. The usual way of doing is to move the necessary bits to `llvm-config.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185 ___ cfe

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sebastian-ne added a comment. I pushed a potential fix (removing the backslash) in 50716ba2b337afe46ac256cc91673dc27356a776 . I don’t know which buildbots to look at though, it looks like the OpenMP ones all succeed. PS: I’ll

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

lei added inline comments. Comment at: llvm/test/CodeGen/PowerPC/kill-canary-intrinsic.ll:4 +; RUN: --ppc-asm-full-reg-names < %s | FileCheck %s -check-prefix=AIX +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux \ +; RUN: --ppc-asm-full-reg-names < %s | File

[clang] 3b09e53 - [ARM] Remove duplicate fp16 intrinsics

Author: David Green Date: 2022-07-28T14:26:17+01:00 New Revision: 3b09e532ee396bb07820ecadb29e1ed88f6e6c25 URL: https://github.com/llvm/llvm-project/commit/3b09e532ee396bb07820ecadb29e1ed88f6e6c25 DIFF: https://github.com/llvm/llvm-project/commit/3b09e532ee396bb07820ecadb29e1ed88f6e6c25.diff L

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:114 + /// + /// `return` must not be assigned a storage location. + void setReturnStorageLocation(StorageLocation &Loc) { sgatev wrote: > li.zhe.

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

yvvan added a comment. With this change we don't pass "LocInfo" directly and it seems to break the locations when calling "getCXXOperatorNameRange" for this DeclRefExpr later on. Please fix it. You can introduce another "Create" static method for DeclRefExpr that accepts LocInfo and passes it t

[PATCH] D130460: [pseudo] Add recovery for declarations

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:267 +Token::Index recoverNextDeclaration(const RecoveryParams &P) { + if (P.Begin == P.Tokens.tokens().size()) I think this excludes the parameter-declaration (from the grammar

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 448323. carlosgalvezp added a comment. Rebase onto latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 Files: clang-tools-extra/clang-tidy/cppcoregu

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. @njames93 Would you mind reviewing? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 ___ cfe-commits mailing list cfe-comm

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro added a comment. In D130566#3682923 , @dblaikie wrote: >> This is all extremely weird, but until the error shows up again, I'll put >> this patch on hold (not yet abandoning since there seems to be no way to >> unabandon if necessary). > > You can ab

[clang] bd08f41 - [clang-repl] Disable exception unittest on AIX.

Author: Sunho Kim Date: 2022-07-28T22:48:51+09:00 New Revision: bd08f413c089da5a56438cc8902f60df91a08a66 URL: https://github.com/llvm/llvm-project/commit/bd08f413c089da5a56438cc8902f60df91a08a66 DIFF: https://github.com/llvm/llvm-project/commit/bd08f413c089da5a56438cc8902f60df91a08a66.diff LOG

[clang] 6e56d0d - Start support for HLSL `RWBuffer`

Author: Chris Bieneman Date: 2022-07-28T08:49:50-05:00 New Revision: 6e56d0dbe3c89d3cd5730a57b9049b74e0bf605f URL: https://github.com/llvm/llvm-project/commit/6e56d0dbe3c89d3cd5730a57b9049b74e0bf605f DIFF: https://github.com/llvm/llvm-project/commit/6e56d0dbe3c89d3cd5730a57b9049b74e0bf605f.diff

[PATCH] D128569: Start support for HLSL `RWBuffer`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e56d0dbe3c8: Start support for HLSL `RWBuffer` (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D128569?vs=442690&id=448326

[PATCH] D130523: [pseudo] Perform unconstrained recovery prior to completion.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:109 +// tok::unknown is a sentinel value used in recovery: can follow anything. +if (t

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 updated this revision to Diff 448330. skc7 marked an inline comment as not done. skc7 added a comment. Fix tests failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[PATCH] D130523: [pseudo] Perform unconstrained recovery prior to completion.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:621 // Consume the token. glrShift(Heads, Terminals[I], Params, Lang, NextHeads); hokein wrote: > I think we can move the Line634 `Heads.resize(HeadsPartition)` before the

[PATCH] D130690: [clangd][NFCI] Store TUPath inside ParsedAST

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM and a few nits. Could you please add a summary of our offline discussion here. Comment at: clang-tools-extra/clangd/ParsedAST.cpp:763 -ParsedAST::Parsed

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe13002bb37c: [HLSL] Add __builtin_hlsl_create_handle (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] fe13002 - [HLSL] Add __builtin_hlsl_create_handle

Author: Chris Bieneman Date: 2022-07-28T09:16:11-05:00 New Revision: fe13002bb37caf7425dfdb56b8f891c3f33b54b6 URL: https://github.com/llvm/llvm-project/commit/fe13002bb37caf7425dfdb56b8f891c3f33b54b6 DIFF: https://github.com/llvm/llvm-project/commit/fe13002bb37caf7425dfdb56b8f891c3f33b54b6.diff

[PATCH] D130709: MSVC compatibility mode: fix error on unqualified templated base class initialization in case of partial specialization

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: rnk. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I introduced a patch to handle

[PATCH] D130710: [ASTWriter] Provide capability to output a PCM/PCH file that does not write out information about its output path

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful to enable sharing of the same PCH file even when it's intended for a different output path. The only inform

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:103 if (Value *MergedVal = MergedEnv.createValue(Type)) if (Model.merge(Type, *Val1, Env1, *Val2, Env2, *MergedVal, MergedEnv)) return

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/Sparc.cpp:139 + if (Triple.getArch() == llvm::Triple::sparc && + (Triple.isOSSolaris() || Distro(D.getVFS(), Triple).IsDebian())) return "v9"; Can we do it "IsLinux()" instead

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" compnerd wrote: > Does this not potentially break downstre

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ilya-biryukov added a comment. Thanks for the thorough explanation and testing. LGTM. Comment at: clang/lib/Sema/SemaDecl.cpp:1738 +// Return true if the redefinition is not allowed. Return false otherwise. +bool Sema::CheckRedefinitionInModule(const NamedDecl *New, +

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp:103-104 +struct WithAlias { + ConstType c; + // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: member 'c' is const qualified + RefType lr; -

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:62-63 class Token; class VarDecl; +class ValueDecl; We usually keep these alphabetical. Comment at: clang/lib/AST/ExprCXX.cpp:1214-1216 + return (C->capturesVa

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/attr-maybeundef-template.cpp:3 + +// CHECK-LABEL: @_Z5test4IfEvT_( +// CHECK-NEXT: entry: This mangling works for Itanium targets, but doesn't match MSVC targets, which is why the test is faili

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

erichkeane added inline comments. Comment at: clang/lib/AST/ExprCXX.cpp:1214-1216 + return (C->capturesVariable() && isa(C->getCapturedVar()) && + cast(C->getCapturedVar())->isInitCapture() && (getCallOperator() == C->getCapturedVar()->getDeclContext())); ---

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added a comment. I still think we shouldn't bother making all the noise containing the original name. Just mangle it and treat it like every other declare target variable without introducing any extra complexity. These symbols never should've been emitted in the first place so I'm not c

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. In D129752#3682977 , @aaron.ballman wrote: > Do you think this warrants a release note (or did it close any open issues in > the tracker)? It's probably too technical/minor to

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:555 if (BuiltPreamble) { -vlog("Built preamble of size {0} for file {1} version {2} in {3} seconds", +log

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2091-2097 + if (auto *CE = dyn_cast(E)) +if (CE->getCastKind() == CK_NoOp) + E = CE->getSubExpr()->IgnoreParens(); + if (auto *CE = dyn_cast(E)) +if (CE->getCastKind() == CK_Constr

  1   2   >