[PATCH] D130414: [pseudo] Reorganize CXX.h enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG6bdb15fe844c: [pseudo] Reorganize CXX.h enums (authored by sammccall). Herald added a subscriber: mgorny.

[clang-tools-extra] 6bdb15f - [pseudo] Reorganize CXX.h enums

Author: Sam McCall Date: 2022-07-27T09:03:29+02:00 New Revision: 6bdb15fe844c428f1bf477c73a36901c84e5b5fa URL: https://github.com/llvm/llvm-project/commit/6bdb15fe844c428f1bf477c73a36901c84e5b5fa DIFF: https://github.com/llvm/llvm-project/commit/6bdb15fe844c428f1bf477c73a36901c84e5b5fa.diff LO

[clang-tools-extra] 89f284b - [pseudo] Remove dead header

Author: Sam McCall Date: 2022-07-27T09:05:59+02:00 New Revision: 89f284bc238b4091482cbc4fa38bc5f7246b81e4 URL: https://github.com/llvm/llvm-project/commit/89f284bc238b4091482cbc4fa38bc5f7246b81e4 DIFF: https://github.com/llvm/llvm-project/commit/89f284bc238b4091482cbc4fa38bc5f7246b81e4.diff LO

[clang-tools-extra] afc4958 - [pseudo] Add dangling-else guard to missing if-statement variants

Author: Sam McCall Date: 2022-07-27T09:08:34+02:00 New Revision: afc4958f5ad004309bb982c24147bc3d562add74 URL: https://github.com/llvm/llvm-project/commit/afc4958f5ad004309bb982c24147bc3d562add74 DIFF: https://github.com/llvm/llvm-project/commit/afc4958f5ad004309bb982c24147bc3d562add74.diff LO

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

dyung added a comment. Hi @sammccall, your change seems to be causing a build failure on the PS4 linux bot, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/25678 FAILED: tools/clang/tools/extra/pseudo/gen/CMakeFiles/clang-pseudo-gen.dir/Main.cpp.o CCACHE_CPP2=yes

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo added a comment. In D129799#3681524 , @sammccall wrote: > I'd be tempted by `clang-tidy-confusable-chars-gen` or so but I'm really just > painting the bikeshed at this point - up to you. That sounds like a clearer name to me, thanks! I’ll updat

[clang] bfe191d - Disable stack-sizes section by default for PS4.

Author: Ying Yi Date: 2022-07-27T09:37:20+01:00 New Revision: bfe191dfa79bbccb57506055db9c89bfb891f65c URL: https://github.com/llvm/llvm-project/commit/bfe191dfa79bbccb57506055db9c89bfb891f65c DIFF: https://github.com/llvm/llvm-project/commit/bfe191dfa79bbccb57506055db9c89bfb891f65c.diff LOG:

[PATCH] D130493: Disable stack-sizes section by default for PS4.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe191dfa79b: Disable stack-sizes section by default for PS4. (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. Currently, I cannot test the option `-fconvert=big-endian` with open statement with convert argument using the following code since lowering is not supported. I am not sure if it can be tested in runtime. $ cat fconvert_option_openfile.f90 module fconvert_option_ope

[clang-tools-extra] 7b70c2e - [pseudo] Fix initializer of string table

Author: Sam McCall Date: 2022-07-27T11:04:12+02:00 New Revision: 7b70c2e75cd6b21cf9c2ea2f2ce5f7b9c4202549 URL: https://github.com/llvm/llvm-project/commit/7b70c2e75cd6b21cf9c2ea2f2ce5f7b9c4202549 DIFF: https://github.com/llvm/llvm-project/commit/7b70c2e75cd6b21cf9c2ea2f2ce5f7b9c4202549.diff LO

Re: [PATCH] D130414: [pseudo] Reorganize CXX.h enums

Sorry Doug! 7b70c2e75cd6b21cf9c2ea2f2ce5f7b9c4202549 should fix, not sure why my local clang accepts it. On Wed, Jul 27, 2022 at 9:57 AM Douglas Yung via Phabricator < revi...@reviews.llvm.org> wrote: > dyung added a comment. > > Hi @sammccall, your change seems to be causing a build failure on t

[PATCH] D130526: [Driver][PowerPC] Support -mtune=

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Thanks. We'll eventually start doing something with the option in the back end. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130526/n

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f3cd6bfc67: [clang] Implement ElaboratedType sugaring for types

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 447962. daiyousei-qz added a comment. remove dedicated MacroExpansion variable (reuse Definition) added empty MACRO test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

sebastian-ne accepted this revision. sebastian-ne added a comment. This revision is now accepted and ready to land. Looks good to me, I left three questions inline. Comment at: clang/CMakeLists.txt:81 # path is removed. -set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") +

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 updated this revision to Diff 447967. njames93 added a comment. Fix typo in check list documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130181/new/ https://reviews.llvm.org/D130181 Files: clang-tools-extra/clang-tidy/readabi

[clang-tools-extra] 61c422f - [clang-tidy] Add execute perms back to add_new_check script

Author: Nathan James Date: 2022-07-27T10:41:34+01:00 New Revision: 61c422f274a07bcf2af9ebbb24f9fde879a8cc30 URL: https://github.com/llvm/llvm-project/commit/61c422f274a07bcf2af9ebbb24f9fde879a8cc30 DIFF: https://github.com/llvm/llvm-project/commit/61c422f274a07bcf2af9ebbb24f9fde879a8cc30.diff

[PATCH] D130620: Fix lack of cc1 flag in llvmcmd sections when assertions are enabled

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when assertions are enabled, the cc1 flag is not inserted into the llvmcmd section of object files wit

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 447973. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang-tools-extra/clangd/unittests/ASTTests.cpp clang-tools-extra/clangd/unittests/HoverTests.cpp

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 447974. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[clang] 7f0387d - [clang][ExtractAPI] Add a space between type and name in property declaration fragments

Author: Daniel Grumberg Date: 2022-07-27T11:02:21+01:00 New Revision: 7f0387de4c600af185b2db8d748f530444fe03cd URL: https://github.com/llvm/llvm-project/commit/7f0387de4c600af185b2db8d748f530444fe03cd DIFF: https://github.com/llvm/llvm-project/commit/7f0387de4c600af185b2db8d748f530444fe03cd.dif

[PATCH] D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f0387de4c60: [clang][ExtractAPI] Add a space between type and name in property declaration… (authored by dang). Repository: rG LLVM Github Monore

[clang] d3fc779 - [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

Author: Daniel Grumberg Date: 2022-07-27T11:03:34+01:00 New Revision: d3fc779e4295b0bf726008580ddd99c8e86c2c0c URL: https://github.com/llvm/llvm-project/commit/d3fc779e4295b0bf726008580ddd99c8e86c2c0c DIFF: https://github.com/llvm/llvm-project/commit/d3fc779e4295b0bf726008580ddd99c8e86c2c0c.dif

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3fc779e4295: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property" (authored by dang). Repository: rG LLVM Github Monor

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ilya-biryukov updated this revision to Diff 447978. ilya-biryukov added a comment. - set canonical decl as primary merged, add tests for the relevant failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130585/new/ https://reviews.llvm.org/D130585

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ilya-biryukov added a comment. In D130585#3681397 , @ChuanqiXu wrote: > In D130585#3680189 , @ilya-biryukov > wrote: > >> I wonder whether the right fix for this should generalize to `Mergeable`. >> The fact that

[clang] 42f87bb - [Sema] Return primary merged decl as canonical for concepts

Author: Ilya Biryukov Date: 2022-07-27T12:31:20+02:00 New Revision: 42f87bb62d0719848842da60d2a8180b9e4d7c52 URL: https://github.com/llvm/llvm-project/commit/42f87bb62d0719848842da60d2a8180b9e4d7c52 DIFF: https://github.com/llvm/llvm-project/commit/42f87bb62d0719848842da60d2a8180b9e4d7c52.diff

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42f87bb62d07: [Sema] Return primary merged decl as canonical for concepts (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 447988. mizvekov marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/

[clang] cef232f - [clang][ExtractAPI] Fix objc_property.m reference output

Author: Daniel Grumberg Date: 2022-07-27T11:34:17+01:00 New Revision: cef232ff3320ad1c85d403837d0b8c8b5ae7153f URL: https://github.com/llvm/llvm-project/commit/cef232ff3320ad1c85d403837d0b8c8b5ae7153f DIFF: https://github.com/llvm/llvm-project/commit/cef232ff3320ad1c85d403837d0b8c8b5ae7153f.dif

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro added a comment. In D130566#3681129 , @dblaikie wrote: >> During a build on Debian 11/sparc64, several binaries fail to link with >> >> /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: >> 0x23 > > What's the linker doing parsi

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov updated this revision to Diff 447995. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/include/clang/Sema/Sema.h clang/include/clang/Sema/SemaInternal.h clang/lib/Sema/SemaTemplat

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ilya-biryukov added a comment. Thanks! Mostly questions to better understand the spec and clang. Please excuse me if they sound too basic. I have read the modules section of the standard, but I couldn't find where it specifies whether these redefinition errors should be present or not. Any guid

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 updated this revision to Diff 447993. skc7 added a comment. Changes for code review comments from @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDo

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

Michael137 added a comment. In D123319#3680169 , @aprantl wrote: > Sorry for the silence — I was out on vacation. > > @Michael137 has recently started looking into improving support for C++ > lambdas in LLDB. > Michael, would you be interested in taking

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2050-2066 +static bool IsArgumentMayBeUndef(const Decl *TargetDecl, unsigned ArgNo) { + if (!TargetDecl) +return false; + + bool ArgHasMayBeUndefAttr = false; + if (TargetDecl) { +if (const FunctionDe

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 447997. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Fil

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

animeshk-amd updated this revision to Diff 447998. animeshk-amd edited the summary of this revision. animeshk-amd added a comment. Herald added subscribers: openmp-commits, steakhal, arphaman. Herald added a project: OpenMP. [OpenMP] Update more LIT tests to support OpenMP version upgrade Some mo

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2050-2066 +static bool IsArgumentMayBeUndef(const Decl *TargetDecl, unsigned ArgNo) { + if (!TargetDecl) +return false; + + bool ArgHasMayBeUndefAttr = false; + if (TargetDecl) { +if (const F

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added a comment. @sebastian-ne I didn't quote it because it is a list, but this might be shell script habit sneaking through. I am not sure what is best for CMake. Checking now, https://stackoverflow.com/questions/35847655/when-should-i-quote-cmake-variables says "If your variable

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

ymandel added a comment. In D130306#3681291 , @samestep wrote: > In D130306#3680942 , @chapuni wrote: > >> A few variables cause warinings in -Asserts. > > Thanks for pointing this out! How should I address this?

[PATCH] D130626: [pseudo] experiment

hokein created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999, ilya-biryukov. Herald added a project: clang-tools-extra. This is not the direction we will persu

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) + set(LLVM_LIBRARY_OUTPUT_

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. A

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 4 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:3144 +for (const OMPTraitSelector &Selector : Set.Selectors) { + if (Selector.Kind == llvm::omp::TraitSelector::user_con

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 448016. quinnp marked 5 inline comments as done. quinnp added a comment. Addressing review comments: fixing test cases and improving test case clarity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ h

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

balazske added a comment. A related question: Is it better to have a more generic function like this: void CStringChecker::evalMemmove(CheckerContext &C, const CallExpr *CE, bool IsRestricted, bool IsMempcpy, bool IsWide) const { // void *memmove(void *ds

[clang] 3e874bc - ClangLinkerWrapper: explicitly #include

Author: Nicolai Hähnle Date: 2022-07-27T14:57:34+02:00 New Revision: 3e874bcf064283a5f00e2bef3a086057265563cb URL: https://github.com/llvm/llvm-project/commit/3e874bcf064283a5f00e2bef3a086057265563cb DIFF: https://github.com/llvm/llvm-project/commit/3e874bcf064283a5f00e2bef3a086057265563cb.diff

[clang] 5a78ac2 - clang: include ManagedStatic.h for llvm_shutdown

Author: Nicolai Hähnle Date: 2022-07-27T14:57:34+02:00 New Revision: 5a78ac21569abe2e419b201ca196b21fc3bb00aa URL: https://github.com/llvm/llvm-project/commit/5a78ac21569abe2e419b201ca196b21fc3bb00aa DIFF: https://github.com/llvm/llvm-project/commit/5a78ac21569abe2e419b201ca196b21fc3bb00aa.diff

[PATCH] D130574: ClangLinkerWrapper: explicitly #include

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e874bcf0642: ClangLinkerWrapper: explicitly #include (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 7132bcd - ManagedStatic: remove from ASTMatchersInternal.h

Author: Nicolai Hähnle Date: 2022-07-27T14:57:34+02:00 New Revision: 7132bcdc428d79258901af0156ace240952b6745 URL: https://github.com/llvm/llvm-project/commit/7132bcdc428d79258901af0156ace240952b6745 DIFF: https://github.com/llvm/llvm-project/commit/7132bcdc428d79258901af0156ace240952b6745.diff

[PATCH] D130575: clang: include ManagedStatic.h for llvm_shutdown

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a78ac21569a: clang: include ManagedStatic.h for llvm_shutdown (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130576: ManagedStatic: remove from ASTMatchersInternal.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7132bcdc428d: ManagedStatic: remove from ASTMatchersInternal.h (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:338-339 +if (Loc == nullptr) { + // The outermost context does not set a storage location for `return`, so + // in that case we just ignore `return` statements. + return;

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep updated this revision to Diff 448026. samestep added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130270/new/ https://reviews.llvm.org/D130270 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep added a comment. @gribozavr2 I rebased again, should work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130270/new/ https://reviews.llvm.org/D130270 ___ cfe-commits mailing list cfe-commits

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with some minor nits. Also, please be sure to add a release note. @erichkeane -- should we update the cxx_dr_status.html page for this? We currently claim Clang 12 for this

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. Mostly Ok with this. The diagnostic seems a little subtle with the mathematical notation... just looking at the diagnostics I was like, "wait, why is 8 NOT included in the range -8, 8 oh wait". This will be a little shocking to others perhaps? Also, misisng an

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D130058#3682192 , @aaron.ballman wrote: > LGTM, with some minor nits. Also, please be sure to add a release note. > > @erichkeane -- should we update the cxx_dr_status.html page for this? We > currently claim Clang 12 for

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf565444b486d: [libLTO] Set data-sections by default in libLTO. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] f565444 - [libLTO] Set data-sections by default in libLTO.

Author: Quinn Pham Date: 2022-07-27T08:34:40-05:00 New Revision: f565444b486d49f84297c3a279ca24d785961ea8 URL: https://github.com/llvm/llvm-project/commit/f565444b486d49f84297c3a279ca24d785961ea8 DIFF: https://github.com/llvm/llvm-project/commit/f565444b486d49f84297c3a279ca24d785961ea8.diff LO

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of v

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of valu

[clang] cd62604 - Revert "ManagedStatic: remove from ASTMatchersInternal.h"

Author: Nicolai Hähnle Date: 2022-07-27T15:46:21+02:00 New Revision: cd62604d19aea56d79a919e799d899b0636bd6b4 URL: https://github.com/llvm/llvm-project/commit/cd62604d19aea56d79a919e799d899b0636bd6b4 DIFF: https://github.com/llvm/llvm-project/commit/cd62604d19aea56d79a919e799d899b0636bd6b4.diff

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of v

[clang] 70ec8cd - Revert "[libLTO] Set data-sections by default in libLTO."

Author: Quinn Pham Date: 2022-07-27T08:47:00-05:00 New Revision: 70ec8cd024f3313962878bf68e89a0687c79ad05 URL: https://github.com/llvm/llvm-project/commit/70ec8cd024f3313962878bf68e89a0687c79ad05 DIFF: https://github.com/llvm/llvm-project/commit/70ec8cd024f3313962878bf68e89a0687c79ad05.diff LO

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/nested-ifs.rst:58 + } + Excessive newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https:/

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane accepted this revision. erichkeane added a comment. Still want a test for E3, a release note, and updating the cxx_status.html. But those don't need review IMO. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); /

[PATCH] D129635: [OpenMP] Update the default version of OpenMP to 5.1

saiislam accepted this revision. saiislam added a comment. Thanks, LGTM! In the multi-company OpenMP meeting, it was decided to defer this update. So, please don't land this patch yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129635/new/ http

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. In D130470#3682131 , @balazske wrote: > A related question: > Is it better to have a more generic function like

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1334 + bool IsWide) const { // void *memmove(void *dst, const void *src, size_t n); // The return value is the address of the destination buffer.

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 448036. quinnp added a comment. Adding lit config to mark tests as unsupported for non PPC targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129401/new/ https://reviews.llvm.org/D129401 Files: clang/lib/

[PATCH] D130636: [clangd] Upgrade vlog() to log() for preamble build stats

adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is v

[clang] b6cc5dd - [libLTO] Set data-sections by default in libLTO.

Author: Quinn Pham Date: 2022-07-27T09:39:39-05:00 New Revision: b6cc5ddc94780074e2a027e5c217a254a1b61b05 URL: https://github.com/llvm/llvm-project/commit/b6cc5ddc94780074e2a027e5c217a254a1b61b05 DIFF: https://github.com/llvm/llvm-project/commit/b6cc5ddc94780074e2a027e5c217a254a1b61b05.diff LO

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6cc5ddc9478: [libLTO] Set data-sections by default in libLTO. (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 added a comment. Thanks so much @sebastian-ne for the thorough review! Unlike the other patches rather than being cleaned up code that needs more testing, this is closer to the original patch we've been using for a while (tested but not cleaned up); sorry there were so many things t

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 448044. samestep added a comment. Set a storage location for the outermost context too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files: clang/include/clang/A

[PATCH] D130020: [OpenMP] Deprecate the old driver for OpenMP offloading

ye-luo added a comment. I noticed that in one of my applications, offload to x86 is not fully working with static libraries but directly linking all object files resolves the issue. So the new driver doesn't cause regression compared to the old driver which doesn't work with static libraries an

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

tahonermann added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of val

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a subscriber: cjdb. aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer

[PATCH] D88299: [clang-format] Add MacroUnexpander.

HazardyKnusperkeks added a comment. A bit surprising such a big change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 ___ cfe-commits mailing list cfe-commits

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of valu

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

royjacobson added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of val

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

Jake-Egan added a comment. Hi, this new test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/2544/steps/6/logs/FAIL__Clang__objc_property_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130581/new

[PATCH] D130018: [HLSL] Add HLSLResource attribute

beanz added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6473-6475 +The HLSL ``resource`` attribute is not valid to manually specify in +HLSL. It is applied by the compiler to HLSL resource type objects enabling them +to be handled appropriately in CodeGen.

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448053. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Fix review comments. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D1305

[PATCH] D130639: [clang-tidy] Fix readability-redundant-string-c-str fix for overloaded operator->

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D130372: [analyzer] Add a new factory function RangeSet::Factory::invert

martong added a comment. > The motivation is to extend the set of operations that can be performed on > range sets. Specifically, this function is needed for the next patch in the > stack. Would be great to see the motivation clearly and early. What will be the next patch about? ===

[PATCH] D130055: Clang extensions yolo, woot & kaboom

beanz added a comment. In D130055#3677743 , @dblaikie wrote: > Any chance this could be a generalization of > https://clang.llvm.org/doxygen/Consumed_8cpp_source.html ? I'm not really familiar with that code, but at glance there seems to be some simila

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 448058. Ericson2314 added a comment. Add deprecation notice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: bolt/runtime/CMakeLists.txt clang/CMakeList

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 marked 6 inline comments as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake:65 set(output_dir "${LLVM_LIBRARY_OUTPUT_INTDIR}") - set(install_dir "${CMAKE_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFIX}") +

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 448060. Codesbyusman added a comment. updating the code suggestions and test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/lib/Analysis/C

[PATCH] D130641: [clang-tidy] Extend redundant-string-c-str to also flag constructing a string_view.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer &CB) { + const unsigned CBufferAddressSpace = 4; I don't think I understand the intent of this function along with `CGHL

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

njames93 updated this revision to Diff 448064. njames93 marked an inline comment as done. njames93 added a comment. Remove Excessive Newline. Hopefully fix the windows test failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://

[PATCH] D130018: [HLSL] Add HLSLResource attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6473-6475 +The HLSL ``resource`` attribute is not valid to manually specify in +HLSL. It is applied by the compiler to HLSL resource type objects enabling them +to be handled appropriately in C

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

cjdb added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:2420 + constexpr E1 x2 = static_cast(8); // expected-error {{must be initialized by a constant expression}} + // expected-note@-1 {{integer value 8 is outside the valid range of values [-

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 448086. abidmalikwaterloo added a comment. Added assembly format changed the type of mape_type_modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255 File

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir added a comment. In D129884#3677435 , @jansvoboda11 wrote: > Would it make sense for this to replace the existing strict context hash > implementation? It's not clear to me whether this would be a good tradeoff or not: the explicit build c

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. I just updated the patch. Something went wrong. I used arc `diff --update ` for uploading. However, it seems it is not comparing the last submitted patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new

  1   2   >