[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

hubert.reinterpretcast added a comment. Tests require fixing. Comment at: llvm/test/LTO/PowerPC/data-sections-aix.ll:18-19 + +; CHECK-NOT: (csect: .data) +; CHECK: g O .data {{.*}} var + Unfortunately (without the change)

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

hubert.reinterpretcast added a comment. With respect to the compiler changes: they look good. I checked, and the injected options being passed to the linker are added before user-specified ones (and that is good). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 447882. vsapsai added a comment. - Who could have suspected that some lambdas were double-indented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 Files: clang/inc

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

MaskRay added inline comments. Comment at: llvm/test/LTO/PowerPC/data-sections-aix.ll:18-19 + +; CHECK-NOT: (csect: .data) +; CHECK: g O .data {{.*}} var + hubert.reinterpretcast wrote: > Unfortunately (without the change) t

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 447890. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 447892. vsapsai added a comment. - Replicate some creative old indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

lamb-j updated this revision to Diff 447894. lamb-j added a comment. Updating driver cmake to correctly build shared library Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129873/new/ https://reviews.llvm.org/D129873 Files: clang/include/clang/Dr

[PATCH] D121997: [clang][driver] Fix compilation database dump with multiple architectures

jansvoboda11 added a comment. In D121997#3676972 , @alanphipps wrote: > Should there be an aarch64 guard on the test? There exist downstream Arm > compilers that don't support Arm64 and fail. I know other tests explicitly > state "REQUIRES: aarch64-re

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai updated this revision to Diff 447899. vsapsai added a comment. - Revert indentation for the second and subsequent lines in lambda-now-method calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. OK. Now I've reverted mostly to the old indentation, preserving some of the quirks. Hope it is easier to review now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128490/new/ https://reviews.llvm.org/D128490 _

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 updated this revision to Diff 447901. ssquare08 added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Adding a test and fixing This adds a new runtime test and also address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep added a comment. In D130306#3680942 , @chapuni wrote: > A few variables cause warinings in -Asserts. Thanks for pointing this out! How should I address this? Should I just inline the definitions of those variables into the `assert`s themselves?

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added inline comments. Comment at: clang/test/OpenMP/declare_target_only_one_side_compilation.cpp:61 // DEVICE-DAG: @G1 = {{.*}}global i32 0, align 4 -// DEVICE-DAG: @_ZL2G2 = internal {{.*}}global i32 0, align 4 +// DEVICE-DAG: @_ZL2G2 = {{.*}}global i32 0, align 4 /

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

ssquare08 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10797 +Out< ssquare08 wrote: > > jhuber6 wrote: > > > `CGM.printPostfixForExternalizedDecl` should ideally give the same output > > > on the host and device, but it's somewhat limited sinc

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep updated this revision to Diff 447906. samestep added a comment. Address Dmitri's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130600/new/ https://reviews.llvm.org/D130600 Files: clang/include/clang/Analysis/FlowSensitive/Dataflo

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:110 + /// Assigns `Loc` as the storage location of `return`. + /// gribozavr2 wrote: > Done. Comment at: clang/include/clang

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep added a comment. In D130593#3681126 , @xazax.hun wrote: > While separate call strings are properly isolated from each other, repeated > analysis of the same call is not:| > > while (...) > { > foo(...); > } > > In the above code snippe

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

vsapsai added a comment. In D128695#3675112 , @ChuanqiXu wrote: > I see. It looks like the tricks in `.git-blame-ignore-revs` doesn't work for > this kind of move. I admit I don't look these changes in details. But as long > as it is helpful for future

[clang] 1cbaf68 - [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

Author: Kai Luo Date: 2022-07-27T01:56:25Z New Revision: 1cbaf681b0f1e7257e7e2a63d290a20216668f17 URL: https://github.com/llvm/llvm-project/commit/1cbaf681b0f1e7257e7e2a63d290a20216668f17 DIFF: https://github.com/llvm/llvm-project/commit/1cbaf681b0f1e7257e7e2a63d290a20216668f17.diff LOG: [clan

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cbaf681b0f1: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX (authored by lkail). Repository: rG LLVM Github Monorepo C

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

zixuan-wu added inline comments. Herald added subscribers: pcwang-thead, luke957, StephenFan, MaskRay, arichardson. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +r

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ChuanqiXu added a comment. In D130585#3680189 , @ilya-biryukov wrote: > I wonder whether the right fix for this should generalize to `Mergeable`. > The fact that `Mergeable::getFirstDecl` checks if the decl is coming from the > AST file before looking u

[clang] 1f8ae9d - Inline function calls.

Author: Weverything Date: 2022-07-26T21:12:28-07:00 New Revision: 1f8ae9d7e7e4afcc4e76728b28e64941660ca3eb URL: https://github.com/llvm/llvm-project/commit/1f8ae9d7e7e4afcc4e76728b28e64941660ca3eb DIFF: https://github.com/llvm/llvm-project/commit/1f8ae9d7e7e4afcc4e76728b28e64941660ca3eb.diff L

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447926. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-to

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:232 +while (T != Tokens.end() && T->Kind == tok::comment && + LastComment->Line == T->Line + 1) { + LastComment = T; hokein wrote: > this seems incorrec

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447928. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clangd/Protocol.cpp clang

[PATCH] D130600: [clang][dataflow] Handle return statements

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:338-339 +if (Loc == nullptr) { + // The outermost context does not set a storage location for `return`, so + // in that case we just ignore `return` statements. + return; --

[PATCH] D129311: [clang-format] Update return code

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks for the explanations! LGTM. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M', ol

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

mstorsjo added a comment. Ping @serge-sans-paille @sammccall - does this seem reasonable, and would you like to tweak the name of the tool before cementing it into a public cmake option (that at least I would be setting while cross compiling)? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D130614: [C++20] [Modules] Merge same concept decls in global module fragment

ChuanqiXu created this revision. ChuanqiXu added a reviewer: ilya-biryukov. ChuanqiXu added a project: clang. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I found this one when I try to add a C++20 Modules example for D130585

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. I've added a C++20 Named Modules tests for this (and some trivial change) in D130614 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5588985 - [NFC] Convert a dyn_cast<> to an isa<>

Author: Chuanqi Xu Date: 2022-07-27T13:56:38+08:00 New Revision: 55889852127245b830bc3231f172eed53dcb355e URL: https://github.com/llvm/llvm-project/commit/55889852127245b830bc3231f172eed53dcb355e DIFF: https://github.com/llvm/llvm-project/commit/55889852127245b830bc3231f172eed53dcb355e.diff LO

[clang] e8e46cd - [NFC] [C++20] [Modules] Use Sema::isCurrentModulePurview() to simplify the codes

Author: Chuanqi Xu Date: 2022-07-27T14:15:32+08:00 New Revision: e8e46cdce3ed3fbd1a0a632a7f69abb97be33cf4 URL: https://github.com/llvm/llvm-project/commit/e8e46cdce3ed3fbd1a0a632a7f69abb97be33cf4 DIFF: https://github.com/llvm/llvm-project/commit/e8e46cdce3ed3fbd1a0a632a7f69abb97be33cf4.diff LO

[clang] e818ce0 - [clang] Make parts of index test optional

Author: Danny Mösch Date: 2022-07-27T08:25:52+02:00 New Revision: e818ce0e060901be98eb1b043ca581c746171085 URL: https://github.com/llvm/llvm-project/commit/e818ce0e060901be98eb1b043ca581c746171085 DIFF: https://github.com/llvm/llvm-project/commit/e818ce0e060901be98eb1b043ca581c746171085.diff L

[clang] 8d91b1d - [NFC] [C++20] [Modules] Use Sema::isModuleUnitOfCurrentTU to simplify the code

Author: Chuanqi Xu Date: 2022-07-27T14:33:28+08:00 New Revision: 8d91b1da576b1643175fbac0fb4b3a95bed07bf0 URL: https://github.com/llvm/llvm-project/commit/8d91b1da576b1643175fbac0fb4b3a95bed07bf0 DIFF: https://github.com/llvm/llvm-project/commit/8d91b1da576b1643175fbac0fb4b3a95bed07bf0.diff LO

[PATCH] D129799: [clang-tidy] Add CLANG_MAKE_CONFUSABLE_TABLE cmake cache variable to avoid building when cross compiling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Mechanics definitely seem reasonable. I don't have a strong opinion about the name. I don't find it very clear, the missing info being that it's part of clang-**tidy** and it relates to

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

sammccall added a comment. This check is enabled by default in LLVM (`Checks: misc-*` in `llvm-project/.clang-tidy`) The warning on mutable non-ref local variables is pretty noisy: a *lot* of existing code does not do this, for defensible reasons (some of us think that the ratio of extra safet

<    1   2   3