[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 added inline comments. Comment at: clang/CMakeLists.txt:81 # path is removed. -set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") +set(INCLUDE_DIRS ${LLVM_INCLUDE_DIRS}) set(LLVM_OBJ_DIR "${LLVM_BINARY_DIR}") sebastian-ne wrote: > Do we nee

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm okay with this approach, but please be sure to add a release note explaining the behavior and update AttrDocs.td as well, so that users have some notice as to what's broken.

[clang] 2eade1d - [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

Author: Arthur Eubanks Date: 2022-07-26T08:01:08-07:00 New Revision: 2eade1dba4a8d6e1c6867e9127bcd88cf4e55976 URL: https://github.com/llvm/llvm-project/commit/2eade1dba4a8d6e1c6867e9127bcd88cf4e55976 DIFF: https://github.com/llvm/llvm-project/commit/2eade1dba4a8d6e1c6867e9127bcd88cf4e55976.diff

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2eade1dba4a8: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible… (authored by aeubanks). Repository: rG LLVM Github M

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

tahonermann added a comment. I guess this is probably ok as a short term fix for the Clang 15 release. It still makes me nervous though. Comment at: clang/lib/Serialization/ASTWriter.cpp:4353 + // https://github.com/llvm/llvm-project/issues/56490 for example. + if (!A || (is

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

tejohnson added a comment. @tmsriram can you take a look? I can review from a code standpoint but you are more familiar with PIC/PIE details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 _

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

tahonermann accepted this revision. tahonermann added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:4353 + // https://github.com/llvm/llvm-project/issues/56490 for example. + if (!A || (isa(A) && Writer->isWritingNamedModules())) return Record.push_bac

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. In D130224#3677261 , @arsenm wrote: > In D130224#3677224 , @aaron.ballman > wrote: > >> However, what I think I'm hearing from this thread is that there are >> alternative approach

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Generated symbol graphs should distinguish betwee

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz added a comment. Pre-merge checks passed on Windows. Debian failures are unrelated. Locally on Ubuntu and macOS all tests pass. Getting ready to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128190/new/ https://reviews.llvm.or

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:4353 + // https://github.com/llvm/llvm-project/issues/56490 for example. + if (!A || (isa(A) && Writer->isWritingNamedModules())) return Record.push_back(0); tahonermann wro

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:64 TypeErasedDataflowAnalysis(bool ApplyBuiltinTransfer) - : Options({ApplyBuiltinTransfer}) {} + : Options({ApplyBuilt

[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

aeubanks added a comment. polly and clang-fuzzer both call `populateModulePassManager` just to optimize IR, they should be easily migrated to use the new PM bugpoint is still an issue, I just haven't found time to work on it yet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1e30820 - [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls in the course of IR transforms

Author: Stefan Gränitz Date: 2022-07-26T17:52:43+02:00 New Revision: 1e308204838b5edc5ffbd775896a004edb08c60a URL: https://github.com/llvm/llvm-project/commit/1e308204838b5edc5ffbd775896a004edb08c60a DIFF: https://github.com/llvm/llvm-project/commit/1e308204838b5edc5ffbd775896a004edb08c60a.diff

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e308204838b: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to… (authored by sgraenitz). Repository: rG LLVM Github Mono

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Abandon this since we're prefer D130331 , thanks for every one here! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129748/new/ https://reviews.llvm.org/D129748 _

[clang] a2772fc - [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

Author: Chuanqi Xu Date: 2022-07-26T23:58:07+08:00 New Revision: a2772fc806af7db5d58c7e3d604270a92fff79de URL: https://github.com/llvm/llvm-project/commit/a2772fc806af7db5d58c7e3d604270a92fff79de DIFF: https://github.com/llvm/llvm-project/commit/a2772fc806af7db5d58c7e3d604270a92fff79de.diff LO

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2772fc806af: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface (authored by ChuanqiXu). Changed prior to commit: htt

[clang-tools-extra] 88a2ac6 - [clangd] Improve XRefs support for ObjCMethodDecl

Author: David Goldman Date: 2022-07-26T12:11:26-04:00 New Revision: 88a2ac6ad623cd7519070f6b0bf2de2793bb90dd URL: https://github.com/llvm/llvm-project/commit/88a2ac6ad623cd7519070f6b0bf2de2793bb90dd DIFF: https://github.com/llvm/llvm-project/commit/88a2ac6ad623cd7519070f6b0bf2de2793bb90dd.diff

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG88a2ac6ad623: [clangd] Improve XRefs support for ObjCMethodDecl (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D130095?vs=445951&id=447739#toc Repository: rG LLVM Github Mo

[PATCH] D130575: clang: include ManagedStatic.h for llvm_shutdown

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130575/new/ https://reviews.llvm.org/D130575 ___

[PATCH] D130574: ClangLinkerWrapper: explicitly #include

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM You don't really need pre-commit review for a patch that just adds an include, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

fhahn added a comment. In D128955#3679418 , @tejohnson wrote: > lgtm > > In D128955#3676478 , @aeubanks > wrote: > >> In D128955#3676198 , @tejohnson >> wrote: >> >>> In

[PATCH] D130576: ManagedStatic: remove from ASTMatchersInternal.h

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130576/new/ https://reviews.llvm.org/D130576 ___

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

Ericson2314 added a comment. Hmm I am getting failed builds from this one but not quite sure what the problem is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130545/new/ https://reviews.llvm.org/D130545 _

[PATCH] D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://re

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

MaskRay accepted this revision. MaskRay added a comment. Consider creating a minimum reproduce and filing a bug on https://sourceware.org/bugzilla/buglist.cgi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/ https://reviews.llvm.org/D1305

[PATCH] D130018: [HLSL] Add HLSLResource attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a documentation question. Comment at: clang/include/clang/Basic/AttrDocs.td:6473-6475 +The HLSL ``resource`` attribute is not valid to manually

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde1b5c91453f: [AArch64] Simplify BTI/PAC-RET module flags (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D130145?vs=4473

[PATCH] D130019: [HLSL] CodeGen HLSL Resource annotations

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:59 +return; + auto *RD = Ty->getAsCXXRecordDecl(); + if (!RD) Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:62-66 + if (!RD->hasAttr()) +return;

[clang] 8348c40 - [clang-offload-bundler] Library-ize ClangOffloadBundler

Author: Jacob Lambert Date: 2022-07-26T10:05:22-07:00 New Revision: 8348c4095600ec2c0beee293267832799d2ebee3 URL: https://github.com/llvm/llvm-project/commit/8348c4095600ec2c0beee293267832799d2ebee3 DIFF: https://github.com/llvm/llvm-project/commit/8348c4095600ec2c0beee293267832799d2ebee3.diff

[PATCH] D129873: [clang-offload-bundler] Library-ize ClangOffloadBundler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8348c4095600: [clang-offload-bundler] Library-ize ClangOffloadBundler (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ilya-biryukov created this revision. ilya-biryukov added a reviewer: ChuanqiXu. Herald added a project: All. ilya-biryukov requested review of this revision. Herald added a project: clang. Otherwise we get invalid results for ODR checks. See changed test for an example: despite the fact that we me

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a subscriber: Michael137. aprantl added a comment. Sorry for the silence — I was out on vacation. @Michael137 has recently started looking into improving support for C++ lambdas in LLDB. Michael, would you be interested in taking a fresh look at this and figure out what the requir

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 447750. samestep added a comment. Be explicit when constructing TransferOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis

[PATCH] D130374: [Passes] add a tail-call-elim pass near the end of the opt pipeline

hiraditya added a comment. Thanks for clarifying! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130374/new/ https://reviews.llvm.org/D130374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D130585: [Sema] Return primary merged decl as canonical for concepts

ilya-biryukov added a comment. I wonder whether the right fix for this should generalize to `Mergeable`. The fact that `Mergeable::getFirstDecl` checks if the decl is coming from the AST file before looking up its primary merged decl is probably a performance optimization, not a deliberate seman

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, compnerd, phosek. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, J

[clang] fa2b83d - [clang][dataflow] Analyze calls to in-TU functions

Author: Sam Estep Date: 2022-07-26T17:27:19Z New Revision: fa2b83d07ecab3b24b4c5ee2e7dc4b6bbc895317 URL: https://github.com/llvm/llvm-project/commit/fa2b83d07ecab3b24b4c5ee2e7dc4b6bbc895317 DIFF: https://github.com/llvm/llvm-project/commit/fa2b83d07ecab3b24b4c5ee2e7dc4b6bbc895317.diff LOG: [cl

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa2b83d07eca: [clang][dataflow] Analyze calls to in-TU functions (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] cc9aa15 - Revert "[clang][dataflow] Analyze calls to in-TU functions"

Author: Sam Estep Date: 2022-07-26T17:30:09Z New Revision: cc9aa157a83a4da52f9749807429205583d815da URL: https://github.com/llvm/llvm-project/commit/cc9aa157a83a4da52f9749807429205583d815da DIFF: https://github.com/llvm/llvm-project/commit/cc9aa157a83a4da52f9749807429205583d815da.diff LOG: Rev

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 447757. Ericson2314 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere, ormris. Forgot to define `CLANG_INSTALL_LIBDIR_BASENAME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D130493: Disable stack-sizes section by default for PS4.

MaggieYi updated this revision to Diff 447756. MaggieYi added a comment. Use `Args.addOptInFlag` instead of `Args.hasFlag`, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130493/new/ https://reviews.llvm.org/D130493 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Dri

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep updated this revision to Diff 447758. samestep added a comment. Use different name for TransferOptions field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130306/new/ https://reviews.llvm.org/D130306 Files: clang/include/clang/Analysis/

[clang] 300fbf5 - [clang][dataflow] Analyze calls to in-TU functions

Author: Sam Estep Date: 2022-07-26T17:54:27Z New Revision: 300fbf56f89aebbe2ef9ed490066bab23e5356d1 URL: https://github.com/llvm/llvm-project/commit/300fbf56f89aebbe2ef9ed490066bab23e5356d1 DIFF: https://github.com/llvm/llvm-project/commit/300fbf56f89aebbe2ef9ed490066bab23e5356d1.diff LOG: [cl

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG300fbf56f89a: [clang][dataflow] Analyze calls to in-TU functions (authored by samestep). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think this patch is in a good state. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54 +namespace rules { +namespace dummy { +enum Rule { -

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman marked an inline comment as done. Codesbyusman added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:970-980 +if (LHSExpr->EvaluateAsInt(IntExprResult, *Context)) { + // Evaluating value. + BoolExpr = RHSExpr; +} +else if (RHSExpr->Eval

[PATCH] D130591: [pseudo] Use the TokenIndex for the lookahead in GuardParams

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo h

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 447771. dgoldman marked 5 inline comments as done. dgoldman added a comment. Minor fixes for review (some still pending based on discussion) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://re

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); sammccall wrote: > kadircet wrote: > > let's just pass the TUPath from ClangdS

[clang] 4638d7a - Revert "[clang-offload-bundler] Library-ize ClangOffloadBundler"

Author: Lambert, Jacob Date: 2022-07-26T11:22:31-07:00 New Revision: 4638d7a28f62d2869a7394b009439a72c04c5b72 URL: https://github.com/llvm/llvm-project/commit/4638d7a28f62d2869a7394b009439a72c04c5b72 DIFF: https://github.com/llvm/llvm-project/commit/4638d7a28f62d2869a7394b009439a72c04c5b72.diff

[PATCH] D130394: [clang][CodeGen] Factor out Swift ABI hooks (NFCI)

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130394/new/ https://reviews.llvm.org/D130394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D130581: [clang][ExtractAPI] Ensure that class properties have a kind of "Type Property"

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM. Thanks Daniel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130581/new/ https://reviews.llvm.org/D130581 _

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[PATCH] D130583: [clang][ExtractAPI] Add a space between type and name in property declaration fragments

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. Awesome! Thanks Daniel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130583/new/ https://reviews.llvm.org/D130583 __

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 447785. shafik marked 3 inline comments as done. shafik added a comment. - Added documentation for `getValueRange(...)` - Added new tests to cover fix introduced by D130301 CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D129855: [clang][PowerPC] Set lld as clang's default linker for PowerPC Linux

nemanjai added a comment. In D129855#3667191 , @MaskRay wrote: > In D129855#3662457 , @quinnp wrote: > >> In D129855#3657006 , @MaskRay >> wrote: >> >>> This is not right

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 3 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:201 if opts.diff: -print_diff(old_tree, new_tree) - elif opts.diffstat: -print_diffstat(old_tree, new_tree) - else: -c

[clang-tools-extra] 4e94f66 - [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

Author: Danny Mösch Date: 2022-07-26T21:22:18+02:00 New Revision: 4e94f6653150511de434fa7e29b684ae7f0e52b6 URL: https://github.com/llvm/llvm-project/commit/4e94f6653150511de434fa7e29b684ae7f0e52b6 DIFF: https://github.com/llvm/llvm-project/commit/4e94f6653150511de434fa7e29b684ae7f0e52b6.diff L

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e94f6653150: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads (authored by SimplyDanny). Changed prior to commit: https://rev

[PATCH] D129211: [Clang][Doc] Update the release note for clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129211/new/ https://reviews.llvm.org/D129211 ___

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:370 +def note_constexpr_unscoped_enum_out_of_range : Note< + "store of value outside of the range of unscoped enum, valid values %0 to %1">; def err_experimental_clang_interp_faile

[clang] 114df24 - [Clang][Doc] Update the release note for clang

Author: Shilei Tian Date: 2022-07-26T15:39:21-04:00 New Revision: 114df244ec50ce0145702974335965c3aa2c3dcc URL: https://github.com/llvm/llvm-project/commit/114df244ec50ce0145702974335965c3aa2c3dcc DIFF: https://github.com/llvm/llvm-project/commit/114df244ec50ce0145702974335965c3aa2c3dcc.diff L

[PATCH] D129211: [Clang][Doc] Update the release note for clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG114df244ec50: [Clang][Doc] Update the release note for clang (authored by tianshilei1992). Changed prior to commit: https://reviews.llvm.org/D1292

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

royjacobson added a comment. In D128750#3663161 , @ychen wrote: > In D128750#3662898 , @royjacobson > wrote: > >> but in your example with T/U/V we have 3 template parameters that we could >> reorder in 6 differ

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

SimplyDanny added a comment. alexfh, aaron.ballman, njames93, LegalizeAdulthood Could anyone give some feedback, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ https://reviews.llvm.org/D129596 __

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 447803. vsapsai added a comment. Use `diagnoseSubMismatchMethodParameters` both for Obj-C and C++ methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130325/new/ https://reviews.llvm.org/D130325 Files: cl

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:634 + // LLVM support for atomics on 32-bit SPARC V8+ is incomplete, so + // forcibly link with libatomic as a workaround. `// TODO ...` and attach a bug link ===

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ https://reviews.llvm.org/D129596

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

MaskRay added a comment. This needs a test. For now you can use `linux-ld.c` which has some sparc tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130569/new/ https://reviews.llvm.org/D130569 ___ cfe

[PATCH] D130593: [clang][dataflow] Separate context by frame

samestep updated this revision to Diff 447808. samestep added a comment. Use operator[] instead of try_emplace for C++14 compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/ https://reviews.llvm.org/D130593 Files: clang/includ

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

stella.stamenova added a comment. This change broke the `LLVMConfig` generation and now when including `llvm` through `LLVM_DIR` in another project such as `onnx-mlir`, various tools no longer have the correct paths. For example, before this change: set(LLVM_TOOLS_BINARY_DIR "${LLVM_INSTALL_P

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

stella.stamenova added a comment. In D117977#3680655 , @stella.stamenova wrote: > This change broke the `LLVMConfig` generation and now when including `llvm` > through `LLVM_DIR` in another project such as `onnx-mlir`, various tools no > longer have th

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 447813. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clan

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

HazardyKnusperkeks added a comment. In D126845#3675721 , @sstwcw wrote: > Are there any problems with this revision? The ones that depend on it are > approved. Sorry, last time you updated I had no time, and then I forgot. Repository: rG LLVM Githu

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein updated this revision to Diff 447815. hokein added a comment. refine the patch: guard the "::" nested-name-specifier rule instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130511/new/ https://reviews.llvm.org/D130511 Files: clang-too

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

hokein added a comment. In D130511#3679161 , @sammccall wrote: > TL;DR: I suspect this is valid but guarding `nested-name-specifier := :: > [guard=PrevNotIdentifier]` may be equivalent and clearer. Yeah, that's better! Repository: rG LLVM Github Mon

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Thanks @stella.stamenova for looking into this. I agree the `extend_path` should go back so it properly becomes the install dir. I can't think why I removed it in the first place! The point was to not export the other var, and indeed having that one properly alterna

[PATCH] D129596: [clang-tidy] Avoid extra parentheses around MemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG0734c02b34e4: [clang-tidy] Avoid extra parentheses around MemberExpr (authored by SimplyDanny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129596/new/ ht

[clang-tools-extra] 0734c02 - [clang-tidy] Avoid extra parentheses around MemberExpr

Author: Danny Mösch Date: 2022-07-26T22:36:00+02:00 New Revision: 0734c02b34e49568d278dce7ca4b818fc465853d URL: https://github.com/llvm/llvm-project/commit/0734c02b34e49568d278dce7ca4b818fc465853d DIFF: https://github.com/llvm/llvm-project/commit/0734c02b34e49568d278dce7ca4b818fc465853d.diff L

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. In D128490#3670543 , @ChuanqiXu wrote: > For these indentation changes, maybe it is a good idea to edit the > `.git-blame-ignore-revs` files in the root path. That is a good idea. I'm thinking about a different option: I make my

[clang] 8dfaecc - [CGDebugInfo] Access the current working directory from the `VFS`

Author: Argyrios Kyrtzidis Date: 2022-07-26T13:48:39-07:00 New Revision: 8dfaecc4c24494337933aff9d9166486ca0949f1 URL: https://github.com/llvm/llvm-project/commit/8dfaecc4c24494337933aff9d9166486ca0949f1 DIFF: https://github.com/llvm/llvm-project/commit/8dfaecc4c24494337933aff9d9166486ca0949f1.

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dfaecc4c244: [CGDebugInfo] Access the current working directory from the `VFS` (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

thakis added a comment. Looks like this doesn't build: http://45.33.8.238/linux/82380/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130443/new/ https://reviews.llvm.org/D130443 ___ cfe-commits

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 447825. shafik marked an inline comment as done. shafik added a comment. - Changed wording for diagnostic and updated the places where it was used and checked in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130058/new/ https://reviews.llvm.or

[PATCH] D130443: [CGDebugInfo] Access the current working directory from the `VFS`

akyrtzi added a comment. In D130443#3680753 , @thakis wrote: > Looks like this doesn't build: http://45.33.8.238/linux/82380/step_4.txt Sorry about that, fixed here: https://github.com/llvm/llvm-project/commit/c5ddacb3b6afe2fd507b5f4a10c32ec00ffb245e

[PATCH] D130516: [Support] compression classes

ckissane added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004 // consumers will not want its contents. + llvm::compression::CompressionAlgorithm CompressionScheme = + llvm::compression::ZlibCompressionAlgorithm(); + dblaikie

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1528 } - + auto MainFilePath = + getCanonicalPath(SM.getFileEntryForID(SM.getMainFileID()), SM); dgoldman wrote: > sammccall wrote: > > kadircet wrote: > > > let's just pass t

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

jrbyrnes added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128158/new/ https://reviews.llvm.org/D128158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D130600: [clang][dataflow] Handle return statements

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D130593

[PATCH] D130600: [clang][dataflow] Handle return statements

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:110 + /// Assigns `Loc` as the storage location of `return`. + /// Comment at: clang/include/clang/Analysis/FlowSensitive/

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic updated this revision to Diff 447838. jpenix-quic added a comment. Added changes to address feedback about missing braces and where I am adding options::OPT_fconvert_EQ (and removing the extra formatting change). Also removes an unnecessary include I had mistakenly added. CHANGES S

[PATCH] D130511: [pseudo][wip] Eliminate simple-type-specifier ambiguities.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:168 +bool guardPreviousTokenNotIdentifier(const GuardParams &P) { + if (P.LookaheadIndex < 2) +return tr

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic marked 2 inline comments as done. jpenix-quic added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:52 +options::OPT_fno_automatic, +options::OPT_fconvert_EQ}); } awarzynski w

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

chapuni added a comment. A few variables cause warinings in -Asserts. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:216 + assert(FuncDecl != nullptr); + const auto *Body = FuncDecl->getBody(); + assert(Body != nullptr); It is used only

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

ziqingluo-90 updated this revision to Diff 447854. ziqingluo-90 added a comment. The `callee` ASTMatcher overloading patch has landed in LLVM repo. I update this patch to use `callee` for matching objective-C message callee methods. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/

[PATCH] D130593: [clang][dataflow] Separate context by frame

xazax.hun added a comment. While separate call strings are properly isolated from each other, repeated analysis of the same call is not:| while (...) { foo(...); } In the above code snippet, we will end up analyzing foo with leftover state from the previous iteration. The analysis ca

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

dblaikie added a comment. > During a build on Debian 11/sparc64, several binaries fail to link with > > /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x23 What's the linker doing parsing DWARF? Any idea what feature this is? And why is it SPARC-specific? Or is it true

<    1   2   3   >