[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Herald added subscribers: jsji, StephenFan. Herald added a project: All. The module flags metadata usage "Override" was wrong. I fixed it by using "Min". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116070/new/ https://rev

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

2022-07-22 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. This broke building of Clang, when it's set up by symlinking `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake configure errors out like this: -- Configuring done CMake Error in tools/clang/tools/clang-fuzzer/handle-cxx/CMakeLists.txt: T

[clang] d959324 - Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator"

2022-07-22 Thread Med Ismail Bennani via cfe-commits
Author: Med Ismail Bennani Date: 2022-07-22T15:24:40-07:00 New Revision: d959324e1efec12c3924c17b7d90db0b37eb84c3 URL: https://github.com/llvm/llvm-project/commit/d959324e1efec12c3924c17b7d90db0b37eb84c3 DIFF: https://github.com/llvm/llvm-project/commit/d959324e1efec12c3924c17b7d90db0b37eb84c3.

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4415-4430 -// Upgrade branch protection and return address signing module flags. The -// module flag behavior for these fields were Error and now they are Min.

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

2022-07-22 Thread Med Ismail Bennani via Phabricator via cfe-commits
mib added a comment. In D129377#3673204 , @mstorsjo wrote: > This broke building of Clang, when it's set up by symlinking > `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake > configure errors out like this: > > -- Configuring d

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

2022-07-22 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 446997. shafik marked 4 inline comments as done. shafik added a comment. - Addressed style comments - Changed to use initializer_list version of std::max - Added test to cover enum with -1 as sole enumerator value CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

2022-07-22 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Misc/enum.cpp:10 +enum class EBool : bool { a = 1 } e3; +enum EEmpty {}; erichkeane wrote: > can you do a test on: > > `enum ENeg { a = -1 }` > ? > > That should ALSO have only a singl

[PATCH] D119296: KCFI sanitizer

2022-07-22 Thread Sami Tolvanen via Phabricator via cfe-commits
samitolvanen planned changes to this revision. samitolvanen added a comment. Based on the recent LKML discussions about X86 retbleed mitigations (https://lore.kernel.org/lkml/20220716230344.239749...@linutronix.de/), we're going to need some changes to the code generated for X86. Repository:

[PATCH] D130078: [flang][nfc] Rename `AddOtherOptions` as `ForwardOptions`

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D130078#3669072 , @awarzynski wrote: > In D130078#3667188 , @MaskRay wrote: > >> `forwardOptions` will be better if you are renaming it anyway. > > I'd rather create a separate patch a

[PATCH] D119296: KCFI sanitizer

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. (Will read new updates.) Note that release/15.x is branching soon (https://discourse.llvm.org/t/llvm-15-0-0-release-schedule/63495): 2022-07-26. It seems that we can miss the branch to have more time mature the feature and have it for 16.0. Repository: rG LLVM Githu

[clang] 589ddd7 - [clang][dataflow] ArrayRef'ize debugString()

2022-07-22 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2022-07-23T01:16:31+02:00 New Revision: 589ddd7fe8e4dcf3323dd0b8f6af3ae953ed6037 URL: https://github.com/llvm/llvm-project/commit/589ddd7fe8e4dcf3323dd0b8f6af3ae953ed6037 DIFF: https://github.com/llvm/llvm-project/commit/589ddd7fe8e4dcf3323dd0b8f6af3ae953ed6037.dif

[PATCH] D130400: [clang][dataflow] ArrayRef'ize debugString()

2022-07-22 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ddd7fe8e4: [clang][dataflow] ArrayRef'ize debugString() (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ee6aba8 - [clang][dataflow] Expose stringification functions for SAT solver enums

2022-07-22 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2022-07-23T01:21:20+02:00 New Revision: ee6aba85aa48d03a931ba989ea2c1584b468588a URL: https://github.com/llvm/llvm-project/commit/ee6aba85aa48d03a931ba989ea2c1584b468588a DIFF: https://github.com/llvm/llvm-project/commit/ee6aba85aa48d03a931ba989ea2c1584b468588a.dif

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

2022-07-22 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee6aba85aa48: [clang][dataflow] Expose stringification functions for SAT solver enums (authored by gribozavr). Changed prior to commit: https://re

[clang] 1e4478b - Move "clang/Basic/TokenKinds.h" into a separate top-level module.

2022-07-22 Thread Volodymyr Sapsai via cfe-commits
Author: Volodymyr Sapsai Date: 2022-07-22T16:26:27-07:00 New Revision: 1e4478bbea727dbbffb1023eedfc24eae7185782 URL: https://github.com/llvm/llvm-project/commit/1e4478bbea727dbbffb1023eedfc24eae7185782 DIFF: https://github.com/llvm/llvm-project/commit/1e4478bbea727dbbffb1023eedfc24eae7185782.di

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

2022-07-22 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e4478bbea72: Move "clang/Basic/TokenKinds.h" into a separate top-level module. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D130377: Move "clang/Basic/TokenKinds.h" into a separate top-level module.

2022-07-22 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130377/new/ https://reviews.llvm.org/D130377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] b5414b5 - [clang][dataflow] Add DataflowEnvironment::dump()

2022-07-22 Thread Dmitri Gribenko via cfe-commits
Author: Dmitri Gribenko Date: 2022-07-23T01:31:53+02:00 New Revision: b5414b566a5aedd90e41f01dd2b7b632afc5d5b7 URL: https://github.com/llvm/llvm-project/commit/b5414b566a5aedd90e41f01dd2b7b632afc5d5b7 DIFF: https://github.com/llvm/llvm-project/commit/b5414b566a5aedd90e41f01dd2b7b632afc5d5b7.dif

[PATCH] D130398: [clang][dataflow] Add DataflowEnvironment::dump()

2022-07-22 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5414b566a5a: [clang][dataflow] Add DataflowEnvironment::dump() (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D130398

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

2022-07-22 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 447009. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaTemplateDeduc

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

2022-07-22 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov marked 3 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12670 + return QualType(); +// FIXME: The modified types can be different as well. +// FIXME: It's inneficient to have to unify the modified types. ---

[clang] 80a4e6f - [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

2022-07-22 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2022-07-22T17:16:41-07:00 New Revision: 80a4e6fd31a06143b83947785ea3bd5c04344ea6 URL: https://github.com/llvm/llvm-project/commit/80a4e6fd31a06143b83947785ea3bd5c04344ea6 DIFF: https://github.com/llvm/llvm-project/commit/80a4e6fd31a06143b83947785ea3bd5c04344ea6.diff

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80a4e6fd31a0: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation (authored by MaskRay). Changed prior to commit: https://reviews.llvm.

[PATCH] D130403: Use the range-based overload of llvm::sort where possible

2022-07-22 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added subscribers: carlosgalvezp, cishida, cmtice, usaxena95, kadircet, arphaman, mgrang. Herald added a reviewer: jhenderson. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added a project: All. gribozavr requested review

[PATCH] D130063: [Driver] Enable sanitizers on FreeBSD AArch64

2022-07-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Herald added a subscriber: StephenFan. > [Driver] Enable sanitizers on FreeBSD AArch64 Be specific what sanitizers are enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130063/new/ http

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

2022-07-22 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov accepted this revision as: mizvekov. mizvekov added a comment. This revision is now accepted and ready to land. Thanks! The patch itself LGTM. Please update / fix up the commit message before merging. It still mentions `note` and has some minor English spelling issues. CHANGES SINCE L

[PATCH] D130406: Use llvm::sort instead of std::sort where possible

2022-07-22 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added subscribers: bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, usaxe

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

2022-07-22 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. In D130299#3672486 , @denis-fatkulin wrote: >> Could you please add full git context? > > I updated the patch with p

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

2022-07-22 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:899 + // triviality properties of the class until selecting a destructor and + // computing the eligibility of SMFs. This is because those member + // functions may have constraints that we need to

[clang] 1a3a2ee - [NFC] Move function definition to cpp file

2022-07-22 Thread Jun Zhang via cfe-commits
Author: Jun Zhang Date: 2022-07-23T13:43:42+08:00 New Revision: 1a3a2eec717b6067e29d8a07318257d2d96da238 URL: https://github.com/llvm/llvm-project/commit/1a3a2eec717b6067e29d8a07318257d2d96da238 DIFF: https://github.com/llvm/llvm-project/commit/1a3a2eec717b6067e29d8a07318257d2d96da238.diff LOG

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

2022-07-22 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[PATCH] D130411: [clang-format] Fix a hang when formatting C# $@ string literals

2022-07-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

<    1   2   3