[PATCH] D130326: [ODRHash] Hash `ObjCPropertyDecl` and diagnose discovered mismatches.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130326 Files: clang

[PATCH] D130327: [ODRHash] Detect duplicate `ObjCProtocolDecl` ODR mismatches during parsing.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When during parsing we encountered a duplicate `ObjCProtocolDecl`, we were always emitt

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

vsapsai added a comment. In D128695#3670552 , @ChuanqiXu wrote: > It looks like we lack a patch to use it in parser, right? Kinda. Things get a little bit more complicated before we can do that. But to see the bigger picture, I've published all planned

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

shchenz added a comment. Can we use the feature bit `FeatureQuadwordAtomic` to decide whether QuadAtomic is supported or not on AIX? Like what we do for Linux. The reason we need this option is: we may need to compile a lock free libatomic on a Power7 or below target? If so, do we have similar

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu added a comment. @iains I'm going to land this in next Monday if all the dependent patch landed. Do you feel good with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129138/new/ https://reviews.llvm.org/D129138 ___ cfe-commits

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

shafik updated this revision to Diff 446702. shafik added a comment. Herald added a subscriber: Enna1. -Modified UBSan test to cover the empty enum case. I also refactored the test which was pretty clever but hard to work with as is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130301/

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

amyk added a comment. Hi! It appears that this patch is causing a build failure on a couple PPC bots that build with shared libraries: https://lab.llvm.org/buildbot/#/builders/57/builds/20179 https://lab.llvm.org/buildbot/#/builders/121/builds/21678 The specific error that occurs looks like thi

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 446705. SixWeining marked 9 inline comments as done. SixWeining added a comment. Address @MaskRay's comments. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D13025

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:26 + // TODO: To be implemented in future. + return ArrayRef(); +} MaskRay wrote: > `return {}` Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, tahonermann, aaron.ballman. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is an

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

ChuanqiXu added a comment. In D129748#3668446 , @erichkeane wrote: > In D129748#3667932 , @ChuanqiXu > wrote: > >> @erichkeane @aaron.ballman @tahonermann I get another idea. We could tell >> the user honestly

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. > Can we use the feature bit FeatureQuadwordAtomic to decide whether QuadAtomic > is supported or not on AIX? Like what we do for Linux. `FeatureQuadwordAtomic` is for cpu level control, while `-mabi=quadword-atomics` is for ABI level. AIX running on pwr8+ also features

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:4353 + // https://github.com/llvm/llvm-project/issues/56490 for example. + if (!A || (isa(A) && Writer->isWritingNamedModules())) return Record.push_back(0); The `Writer->is

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added inline comments. Comment at: clang/include/clang/Driver/Options.td:3611 HelpText<"Enable the default Altivec ABI on AIX (AIX only). Uses only volatile vector registers.">; +def maix_quadword_atomics : Flag<["-"], "maix64-quadword-atomics">, + Group, Flags<[CC1Opt

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446718. SimplyDanny added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 Files: clang-tools-extra/test/clang-tidy/checkers/misc/un

[clang-tools-extra] d26ee28 - [pseudo] Fix link error after 3132e9cd7c9fda63

Author: Sam McCall Date: 2022-07-22T08:43:56+02:00 New Revision: d26ee284ded30aff46a00986b5c966238e2279be URL: https://github.com/llvm/llvm-project/commit/d26ee284ded30aff46a00986b5c966238e2279be DIFF: https://github.com/llvm/llvm-project/commit/d26ee284ded30aff46a00986b5c966238e2279be.diff LO

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/constrained-special-member-functions.cpp:103 +// FIXME: DR1734. +static_assert(__is_trivially_copyable(CopyAssignmentChecker<1>)); +static_assert(!__is_trivially_copyable(CopyAssignmentChecker<2>)); H

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall added a comment. In D130066#3670745 , @amyk wrote: > Hi! > > It appears that this patch is causing a build failure on a couple PPC bots > that build with shared libraries: > https://lab.llvm.org/buildbot/#/builders/57/builds/20179 > https://lab

[PATCH] D130279: [clang-doc] Add check for pointer validity

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130279/new/ https://reviews.llvm.org/D130279 ___

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 446726. pmatos added a comment. Update the patch as there were some missing calls from SemaChecking. Thanks to @asb for spotting it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

sammccall added a comment. In D126731#3670265 , @vsapsai wrote: > Looks like this breaks a modular build. I.e., > > My understanding is that the module 'Clang_Basic' needs .inc headers and this > module is pulled in by `#include "clang/Basic/TokenKinds.h

[clang-tools-extra] 18cee95 - [pseudo] Tweak the cli option messages, NFC.

Author: Haojian Wu Date: 2022-07-22T08:53:24+02:00 New Revision: 18cee95919c8a9bf1a2d1c23fbbc7dc63077ee86 URL: https://github.com/llvm/llvm-project/commit/18cee95919c8a9bf1a2d1c23fbbc7dc63077ee86 DIFF: https://github.com/llvm/llvm-project/commit/18cee95919c8a9bf1a2d1c23fbbc7dc63077ee86.diff LO

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 updated this revision to Diff 446727. skc7 edited the summary of this revision. skc7 added a comment. Rebase. Remove skipping noundef attribute based on maybe_undef. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm.org/D130224 Files: clang/include/c

<    1   2   3