[PATCH] D129488: [Sema] Fix evaluation context of immediate functions in default arguments

ilya-biryukov added a comment. TODO: add example from cpprefence to the tests: consteval int f() { return 42; } consteval auto g() { return &f; } consteval int h(int (*p)() = g()) { return p(); } constexpr int r = h(); // OK constexpr auto e = g(); // ill-formed: a pointer to an immedi

[clang] 119d223 - [clang] Add -fdiagnostics-format=sarif option for future SARIF output

Author: Abraham Corea Diaz Date: 2022-07-21T16:51:15Z New Revision: 119d22310bd622d4b39e9760667b6fa58d15a8c5 URL: https://github.com/llvm/llvm-project/commit/119d22310bd622d4b39e9760667b6fa58d15a8c5 DIFF: https://github.com/llvm/llvm-project/commit/119d22310bd622d4b39e9760667b6fa58d15a8c5.diff

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG119d22310bd6: [clang] Add -fdiagnostics-format=sarif option for future SARIF output (authored by abrahamcd, committed by cjdb). Repository: rG LLV

[PATCH] D129488: [Sema] Fix evaluation context of immediate functions in default arguments

ilya-biryukov added a comment. another example that actually breaks: constexpr int foo(int i) { if (i == 1) return i/0; } consteval int bar(int i) { if (i == 1) return i/0; return i; } void baz(int i = foo(1), int j = bar(1)) { } void xxx() { baz();

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

zequanwu updated this revision to Diff 446551. zequanwu marked 2 inline comments as done. zequanwu added a comment. - Address comment. - Move test to `clang/test/CXX/conv/conv.prom/p4.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130210/new/

[PATCH] D130210: [SemaCXX] Set promotion type for enum bool to integer type.

zequanwu added a comment. > I am curious that this does not change the test results of > `clang/test/CXX/conv/conv.prom/p4.cpp` The crash only happens when the enum is bool and has no definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13021

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added a comment. I am not sure what to do with this patch. I really prefer to avoid it to minimize the risk of regressions. We probably considered/prototyped to insert starts like in this solution then in 2016. But at the time of the solution was a comment by @rsmith https://reviews

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation) MaskRay wrote:

[clang] 080022d - [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

Author: Joseph Huber Date: 2022-07-21T13:20:01-04:00 New Revision: 080022d8ed6c1bd9ba5ece33cfea248f9473e775 URL: https://github.com/llvm/llvm-project/commit/080022d8ed6c1bd9ba5ece33cfea248f9473e775 DIFF: https://github.com/llvm/llvm-project/commit/080022d8ed6c1bd9ba5ece33cfea248f9473e775.diff

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG080022d8ed6c: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 446566. aeubanks marked an inline comment as done. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D128955 Files: clang/lib/CodeGen/CGClas

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added a comment. In D128955#3666995 , @tejohnson wrote: > In D128955#3666830 , @aeubanks > wrote: > >> the assert that there are no public.type.tests in LTT fails on >> `CodeGenCXX/thinlto-distributed-t

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation) compnerd wrote:

[clang] 48d6f52 - [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

Author: Johannes Doerfert Date: 2022-07-21T12:36:54-05:00 New Revision: 48d6f5240187573881f96cc9574ea09592f50723 URL: https://github.com/llvm/llvm-project/commit/48d6f5240187573881f96cc9574ea09592f50723 DIFF: https://github.com/llvm/llvm-project/commit/48d6f5240187573881f96cc9574ea09592f50723.d

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG48d6f5240187: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D130210: [SemaCXX] Set promotion type for enum if its type is promotable to integer type even if it has no definition.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though you should add a release note to clang/docs/ReleaseNotes.rst for the bug fix. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 446581. sridhar_gopinath added a comment. Removed '--' in the git-diff commands as it only applies to files and not commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311/new/ https://reviews.ll

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Those pre-commit failure seem to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130254/new/ https://reviews.llvm.org/D13

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 2 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:579 with temporary_index_file(old_tree): - subprocess.check_call(['git', 'checkout', '--patch', new_tree]) + subprocess.

[clang] d870a57 - [SemaCXX] Set promotion type for enum if its type is promotable to integer type even if it has no definition.

Author: Zequan Wu Date: 2022-07-21T11:23:21-07:00 New Revision: d870a575631d2cedab2ff237af8edd17916edc64 URL: https://github.com/llvm/llvm-project/commit/d870a575631d2cedab2ff237af8edd17916edc64 DIFF: https://github.com/llvm/llvm-project/commit/d870a575631d2cedab2ff237af8edd17916edc64.diff LOG

[PATCH] D130210: [SemaCXX] Set promotion type for enum if its type is promotable to integer type even if it has no definition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd870a575631d: [SemaCXX] Set promotion type for enum if its type is promotable to integer type… (authored by zequanwu). Changed prior to commit: ht

[PATCH] D130210: [SemaCXX] Set promotion type for enum if its type is promotable to integer type even if it has no definition.

zequanwu added a comment. In D130210#3669464 , @aaron.ballman wrote: > LGTM, though you should add a release note to clang/docs/ReleaseNotes.rst for > the bug fix. Thank you! Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

Ericson2314 added a comment. LGMT. Also thanks I saw the same failures and was worried they were not spurious on my own patch. Glad to know they are! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130254/new/ https://reviews.llvm.org/D130254 _

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a comment. https://reviews.llvm.org/D130254 oh yay I learned from this the openmp failure is in fact spurious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 __

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. https://reviews.llvm.org/D130254 oh yay I learned from this the openmp failure is in fact spurious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 __

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3669069 , @Mordante wrote: > In D129048#3668905 , @aaron.ballman > wrote: > >> In D129048#3668846 , @ldionne >> wrote: >> >>> I

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

nikic accepted this revision. nikic added a comment. Still LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo marked 4 inline comments as done. abidmalikwaterloo added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10852 +def err_omp_misplaced_default_clause : Error< + "misplaced default clause! Only one default clause is allowed in" + "

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446592. SimplyDanny added a comment. Herald added a subscriber: arphaman. Added a test for the AST dump and updated some test references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://re

[clang] 07b7498 - [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Author: John Ericson Date: 2022-07-21T19:04:00Z New Revision: 07b749800c5cd4105d49ab46be5f0a2079dd709a URL: https://github.com/llvm/llvm-project/commit/07b749800c5cd4105d49ab46be5f0a2079dd709a DIFF: https://github.com/llvm/llvm-project/commit/07b749800c5cd4105d49ab46be5f0a2079dd709a.diff LOG:

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b749800c5c: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang/test/Index/annotate-operator-call-expr.cpp:21 +// CHECK1: Punctuation: "(" [7:6 - 7:7] CallExpr=operator():3:7 +// CHECK1: Punctuation: ")" [7:7 - 7:8] CallExpr=operator():3:7 // C

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

quinnp updated this revision to Diff 446597. quinnp marked 3 inline comments as done. quinnp added a comment. Adressed review comments. - Modified how `llvm-lto` test-cases check the `llvm-objdump -t` output. - Renamed `gold-lto-sections.c` to `forwarding-sections-liblto.c` and modified the test

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang/test/AST/ast-dump-overloaded-operators.cpp:65 +// CHECK-NEXT: |-ImplicitCastExpr {{.*}} 'void (*)(E, E)' +// CHECK-NEXT: | `-DeclRefExpr {{.*}} 'void (E, E)' lvalue

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

mizvekov added a comment. In D129222#3668158 , @sammccall wrote: > I think what's going on here: outer cmake invokes this opaque external > command (which just _happens_ to be cmake --build) to produce an exe. The > outer cmake has no special knowledge

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Thanks @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 updated this revision to Diff 446609. Ericson2314 added a comment. - Rebase - Some `set` -> `extend_path` - Fix spelling / comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 Files: c

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a subscriber: nikic. Ericson2314 added a comment. @nikic if you are still around, might you want to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 _

[PATCH] D129048: Rewording the "static_assert" to static assertion

Mordante added a comment. In D129048#3669568 , @aaron.ballman wrote: > In D129048#3669069 , @Mordante > wrote: > >> In D129048#3668905 , >> @aaron.ballman wrote: >> >>>

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

denis-fatkulin created this revision. denis-fatkulin added a reviewer: rsmith. denis-fatkulin added a project: clang-format. Herald added a project: All. denis-fatkulin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lambdas with trailing r

[clang] b17baa1 - [ASTMatchers] Adding a new matcher for callee declarations of Obj-C

Author: Ziqing Luo Date: 2022-07-21T13:35:31-07:00 New Revision: b17baa1db613a2ce777aa122feb87488750a64d0 URL: https://github.com/llvm/llvm-project/commit/b17baa1db613a2ce777aa122feb87488750a64d0 DIFF: https://github.com/llvm/llvm-project/commit/b17baa1db613a2ce777aa122feb87488750a64d0.diff LO

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGb17baa1db613: [ASTMatchers] Adding a new matcher for callee declarations of Obj-C (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D130301: [Clang] Fix how we set the NumPositiveBits on an E numDecl to cover the case of single enumerator with value zero or an empty enum

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, tahonermann. Herald added a project: All. shafik requested review of this revision. Currently in `Sema::ActOnEnumBody(...)` when calculating `NumPositiveBits` we miss the case where there is only a single enumerator

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

This revision was automatically updated to reflect the committed changes. sammccall marked 6 inline comments as done. Closed by commit rG3132e9cd7c9f: [pseudo] Key guards by RuleID, add guards to literals (and 0). (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D13006

[clang-tools-extra] 3132e9c - [pseudo] Key guards by RuleID, add guards to literals (and 0).

Author: Sam McCall Date: 2022-07-21T22:42:31+02:00 New Revision: 3132e9cd7c9fda63f7c0babf8bd5f6d755ce9027 URL: https://github.com/llvm/llvm-project/commit/3132e9cd7c9fda63f7c0babf8bd5f6d755ce9027 DIFF: https://github.com/llvm/llvm-project/commit/3132e9cd7c9fda63f7c0babf8bd5f6d755ce9027.diff LO

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:102 llvm::StringRef Name = G.table().AttributeValues[EID]; - assert(!Name.empty()); Out.os() << llvm::formatv("EXTENSION({0}, {1})\n", Name, EID); hokein wrote:

[clang] ccc12a2 - [OpenMP][NFC] Claim iterators in 'map' clause and motion clauses

Author: Chi Chun Chen Date: 2022-07-21T15:50:22-05:00 New Revision: ccc12a2376105d28b6acce59b4319df2051a0833 URL: https://github.com/llvm/llvm-project/commit/ccc12a2376105d28b6acce59b4319df2051a0833 DIFF: https://github.com/llvm/llvm-project/commit/ccc12a2376105d28b6acce59b4319df2051a0833.diff

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny updated this revision to Diff 446629. SimplyDanny added a comment. Rebased commit onto current main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/D129973 Files: clang-tools-extra/test/clan

[PATCH] D130231: [WIP][clang-doc] Improve the Markdown output

paulkirth added a comment. Overall I like the direction of the patch, I know this is WIP, but I've left some small question inline regarding scope and work tracking. Comment at: clang-tools-extra/clang-doc/MDGenerator.cpp:23-52 +static std::string genEscaped(StringRef Name) {

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker created this revision. collinbaker added a reviewer: rnk. Herald added a subscriber: arphaman. Herald added a project: All. collinbaker requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In a class template, a bit field's width may

[PATCH] D130304: [clang][dataflow] Move NoopAnalysis from unittests to include

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[PATCH] D130305: [clang][dataflow] Refactor ApplyBuiltinTransfer field out into DataflowAnalysisOptions struct

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D130304

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends On D130305

[PATCH] D130299: [clang-format] FIX: Misformatting lambdas with trailing return type 'auto' in braced lists

curdeius added a comment. Could you please add full git context? Was the problem due to misannotation of `auto`? If so, could you add an annotator test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130299/new/ https://reviews.llvm.org/D130299 __

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov created this revision. Herald added projects: clang, All. Herald added a subscriber: cfe-commits. mizvekov requested review of this revision. Depends on D128095 Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov updated this revision to Diff 446644. mizvekov planned changes to this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTCon

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper created this revision. craig.topper added reviewers: reames, asb, luismarques, arcbbb, frasercrmck, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper added inline comments. Comment at: clang/test/CodeGen/builtin_float_strictfp.c:3 // RUN: %clang_cc1 -no-opaque-pointers -emit-llvm -triple ppc64-be -ffp-exception-behavior=maytrap -o - %s | FileCheck %s --check-prefixes=CHECK,NOFP16 +// RUN: %clang_cc1 -no-opaque-

[PATCH] D130311: [RISCV] Enable strict FP in clang as long as Zve* or V are not enabled.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:933 + if (!Subtarget.hasVInstructions()) +IsStrictFPEnabled = true; + Setting this to true disables some code in SelectionDAGISel.cpp that make ISD::STRICT_* nodes c

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12654 + return QualType(); +// FIXME: It's inneficient to have to unify the original types. +return Ctx.getAdjustedType(Ctx.getCommonSugaredType(OX, OY), Underlying); Typo "ineffi

[PATCH] D130308: WIP: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:12670 + return QualType(); +// FIXME: The modified types can be different as well. +// FIXME: It's inneficient to have to unify the modified types. rsmith wrote: > Should we bai

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

rnk added a comment. Dmitri, do you know a good libclang point of contact for the new API? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 ___ cfe-commits maili

[PATCH] D130305: [clang][dataflow] Refactor ApplyBuiltinTransfer field out into DataflowAnalysisOptions struct

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.h:38 + // analysis). + bool ApplyBuiltinTransfer; +}; I think it might be better to have a default value. Repository: rG LLVM Github Monorepo

[PATCH] D129048: Rewording the "static_assert" to static assertion

ldionne added a comment. The libc++ CI runs pre-commit only, and it runs on all commits that touch something under `libcxx/`, `libcxxabi/`, `runtimes/` and `libunwind/`. In particular, it won't trigger if you make changes to `clang/` only -- that would create too much traffic and concretely it

[PATCH] D130305: [clang][dataflow] Refactor ApplyBuiltinTransfer field out into DataflowAnalysisOptions struct

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:66 explicit DataflowAnalysis(ASTContext &Context) : Context(Context) {} explicit D

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

xazax.hun added a comment. There are many ways to introduce context sensitivity into the framework, this patch seems to take the "inline substitution" approach, the same approach the Clang Static Analyzer is taking. While this approach is relatively easy to implement and has great precision, it

[PATCH] D126731: [pseudo] Eliminate dependencies from clang-pseudo-gen. NFC

vsapsai added a comment. Looks like this breaks a modular build. I.e., cmake -GNinja ~/Projects/llvm/llvm-project/llvm \ -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" \ -DLLVM_ENABLE_ASSERTIONS=ON \ -DCMAKE_BUILD_TYPE=RelWithDebInfo \ -DLLVM_ENABLE_MODULES=ON ninja clangPse

[PATCH] D128927: [libc++] Always build c++experimental.a

ldionne added a comment. In D128927#3665748 , @hans wrote: > In D128927#3662659 , @ldionne wrote: > >> The weird part here is that you're configuring libc++, but you are building >> neither the static nor the sha

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. There are some nits for tests. I'll step away and just LGTM. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:579 + else if (Args.hasArg(options::OPT_fno_data_sectio

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:4 +// basic +while(1) {}; // expected-error {{while loop outside of a function}} + What I meant is something like this, we test that the error caret would be placed on th

[clang] 408a263 - [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386

Author: Ryan Prichard Date: 2022-07-21T17:23:29-07:00 New Revision: 408a2638fda63b381f8750e16c78bc3c845cfdfd URL: https://github.com/llvm/llvm-project/commit/408a2638fda63b381f8750e16c78bc3c845cfdfd DIFF: https://github.com/llvm/llvm-project/commit/408a2638fda63b381f8750e16c78bc3c845cfdfd.diff

[clang] 02a2527 - [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

Author: Ryan Prichard Date: 2022-07-21T17:23:29-07:00 New Revision: 02a25279aedcd959d060bba585adc0fe1cec3782 URL: https://github.com/llvm/llvm-project/commit/02a25279aedcd959d060bba585adc0fe1cec3782 DIFF: https://github.com/llvm/llvm-project/commit/02a25279aedcd959d060bba585adc0fe1cec3782.diff

[PATCH] D127465: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG408a2638fda6: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386 (authored by rprichard). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG02a25279aedc: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin (authored by rprichard). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130138/new/ https://reviews.llvm.org/D130138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 381fcaa - [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

Author: Volodymyr Sapsai Date: 2022-07-21T17:42:04-07:00 New Revision: 381fcaa1365b4fd8f9682a6a1e09f5b3fd4bbfc2 URL: https://github.com/llvm/llvm-project/commit/381fcaa1365b4fd8f9682a6a1e09f5b3fd4bbfc2 DIFF: https://github.com/llvm/llvm-project/commit/381fcaa1365b4fd8f9682a6a1e09f5b3fd4bbfc2.di

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG381fcaa1365b: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

vsapsai added a comment. Sorry for the huge amount of changes in ASTReader.cpp but most of them are indentation changes, so I hope it's not too bad. I've tried to minimize the changes unrelated to introducing `ODRDiagsEmitter` but if anybody has other ideas/requests, I'm totally willing to redu

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

vsapsai added a comment. If anybody knows how to demonstrate the code was moved without modification in process, I'll be happy to do that. Unfortunately, the only thing I've found is that it should be auto-detected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required

barannikov88 created this revision. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130322 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCall.h:26 -// FIXME: Restructure so we don't have to expose so much stuff. -#include "ABIInfo.h" - This is the main change. The included file was not used here at all. Repository: rG LLVM Git

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:49 public: - TargetCodeGenInfo(std::unique_ptr Info) : Info(std::move(Info)) {} + TargetCodeGenInfo(std::unique_ptr Info); virtual ~TargetCodeGenInfo(); Had to do this due to "in

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. To reviewers: if you are OK with the patch, could you please merge it? I don't have permission yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 _

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 updated this revision to Diff 446685. barannikov88 added a comment. Removed forward declaration of non-existent class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 Files: clang/lib/CodeG

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ABIInfo.h:39 -namespace swiftcall { - class SwiftAggLowering; -} Not used in this file. (This class does not seem to be used anywhere.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.

ChuanqiXu added a comment. In D128490#3670441 , @vsapsai wrote: > Sorry for the huge amount of changes in ASTReader.cpp but most of them are > indentation changes, so I hope it's not too bad. I've tried to minimize the > changes unrelated to introducing

[PATCH] D128695: [ODRHash diagnostics] Move `ODRDiagsEmitter` to libAST in separate files. NFC.

ChuanqiXu added a comment. It looks like we lack a patch to use it in parser, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128695/new/ https://reviews.llvm.org/D128695 ___ cfe-commits mailing lis

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 446688. SixWeining marked 3 inline comments as done. SixWeining added a comment. Address @rengolin's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 File

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added a comment. In D130255#3668436 , @rengolin wrote: > This looks great, thanks! > > Exciting that we can finally go all the way from C source to LoongArch binary. > > The changes look good to me, other than a few nits. But please wait for a

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc updated this revision to Diff 446690. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129573/new/ https://reviews.llvm.org/D129573 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Parse/ParseDecl.cpp clang/test/Parser/while-loop-outside-function.c clang/tes

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:26 + // TODO: To be implemented in future. + return ArrayRef(); +} `return {}` Comment at: clang/test/Driver/frame-pointer.c:60 +// RUN: %clang -target loongar

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

reames added a comment. This was very briefly discussed at today's sync up call. We were running short on time, so we didn't get a chance to talk through it, but there did seem to be a consensus that discussion on the interface implications was needed. This should hopefully be on the agenda w

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:480 +LibDir = std::string(getOSLibDir(Triple, Args)); +StringRef ABIName = tools::loongarch::getLoongArchABI(Args, Triple); +Loader = ("ld-linux-loongarch-" + ABIName + ".so.1").str(); --

[PATCH] D129573: [clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc marked 2 inline comments as not done. inclyc added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:3 + +while // expected-error {{while loop outside of a function}} +(1) {}; Thanks a lot for your suggestion, I replaced this sta

[clang] 2191528 - [Driver][test] Remove unused "-o %t.s" from frame-pointer*.c

Author: Fangrui Song Date: 2022-07-21T19:41:25-07:00 New Revision: 219152837375283bde1f1586b6d709b51941a90f URL: https://github.com/llvm/llvm-project/commit/219152837375283bde1f1586b6d709b51941a90f DIFF: https://github.com/llvm/llvm-project/commit/219152837375283bde1f1586b6d709b51941a90f.diff

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130324 Files: clang

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

MaskRay added a comment. I notice that in gcc, -march/-mtune/-mcpu are handled in gcc/config/* and every port may have somewhat different behaviors. E.g. x86 and aarch64 are different (and I suspect x86 has the weird behavior). Have you checked that whether this matches GCC? We need some clang/

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130325 Files: clang

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2225 +StringRef Name = A->getValue(); + +std::string TuneCPU; delete blank line after a variable declaration Comment at: clang/lib/Driver/ToolChains/Clang.

<    1   2   3   >